[INFO] crate unicode-bom 1.1.3 is already in cache [INFO] extracting crate unicode-bom 1.1.3 into work/ex/clippy-test-run/sources/stable/reg/unicode-bom/1.1.3 [INFO] extracting crate unicode-bom 1.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unicode-bom/1.1.3 [INFO] validating manifest of unicode-bom-1.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unicode-bom-1.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unicode-bom-1.1.3 [INFO] finished frobbing unicode-bom-1.1.3 [INFO] frobbed toml for unicode-bom-1.1.3 written to work/ex/clippy-test-run/sources/stable/reg/unicode-bom/1.1.3/Cargo.toml [INFO] started frobbing unicode-bom-1.1.3 [INFO] finished frobbing unicode-bom-1.1.3 [INFO] frobbed toml for unicode-bom-1.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unicode-bom/1.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unicode-bom-1.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unicode-bom/1.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 352ca35902264d67eeb49b1ced859613e26bdab323d5653ecb435d71898dc35c [INFO] running `"docker" "start" "-a" "352ca35902264d67eeb49b1ced859613e26bdab323d5653ecb435d71898dc35c"` [INFO] [stderr] Checking unicode-bom v1.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: item `Bom` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / impl Bom { [INFO] [stderr] 92 | | /// Returns the size in bytes of the BOM. [INFO] [stderr] 93 | | pub fn len(&self) -> usize { [INFO] [stderr] 94 | | match *self { [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 64 [INFO] [stderr] --> src/test.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | / fn from_slice() { [INFO] [stderr] 67 | | assert_bom!([], Null); [INFO] [stderr] 68 | | [INFO] [stderr] 69 | | assert_bom!([0, 0, 0xfe], Null); [INFO] [stderr] ... | [INFO] [stderr] 142 | | assert_bom!([0xff, 0xfe, 0, 1, 42], Utf16Le); [INFO] [stderr] 143 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: item `Bom` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | / impl Bom { [INFO] [stderr] 92 | | /// Returns the size in bytes of the BOM. [INFO] [stderr] 93 | | pub fn len(&self) -> usize { [INFO] [stderr] 94 | | match *self { [INFO] [stderr] ... | [INFO] [stderr] 108 | | } [INFO] [stderr] 109 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn len(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.46s [INFO] running `"docker" "inspect" "352ca35902264d67eeb49b1ced859613e26bdab323d5653ecb435d71898dc35c"` [INFO] running `"docker" "rm" "-f" "352ca35902264d67eeb49b1ced859613e26bdab323d5653ecb435d71898dc35c"` [INFO] [stdout] 352ca35902264d67eeb49b1ced859613e26bdab323d5653ecb435d71898dc35c