[INFO] crate unicase 2.2.0 is already in cache [INFO] extracting crate unicase 2.2.0 into work/ex/clippy-test-run/sources/stable/reg/unicase/2.2.0 [INFO] extracting crate unicase 2.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unicase/2.2.0 [INFO] validating manifest of unicase-2.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unicase-2.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unicase-2.2.0 [INFO] finished frobbing unicase-2.2.0 [INFO] frobbed toml for unicase-2.2.0 written to work/ex/clippy-test-run/sources/stable/reg/unicase/2.2.0/Cargo.toml [INFO] started frobbing unicase-2.2.0 [INFO] finished frobbing unicase-2.2.0 [INFO] frobbed toml for unicase-2.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unicase/2.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unicase-2.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unicase/2.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e6677cefb926d71ae63ba488bcf2a39114c4a3319e1daf21deb8d87b27446db [INFO] running `"docker" "start" "-a" "0e6677cefb926d71ae63ba488bcf2a39114c4a3319e1daf21deb8d87b27446db"` [INFO] [stderr] Compiling unicase v2.2.0 (/opt/crater/workdir) [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ascii.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / fn deref<'a>(&'a self) -> &'a S { [INFO] [stderr] 23 | | &self.0 [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_lifetimes)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ascii.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stderr] 30 | | &mut self.0 [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: redundant closure found [INFO] [stderr] --> src/unicode/mod.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | for c in self.0.as_ref().chars().flat_map(|c| lookup(c)) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `lookup` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_closure)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / fn deref<'a>(&'a self) -> &'a S { [INFO] [stderr] 133 | | inner!(self.0) [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match &$e { [INFO] [stderr] 103 | | &Encoding::Ascii(ref s) => &s.0, [INFO] [stderr] 104 | | &Encoding::Unicode(ref s) => &s.0, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 133 | inner!(self.0) [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::match_ref_pats)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stderr] 140 | | inner!(mut self.0) [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match &mut $e { [INFO] [stderr] 97 | | &mut Encoding::Ascii(ref mut s) => &mut s.0, [INFO] [stderr] 98 | | &mut Encoding::Unicode(ref mut s) => &mut s.0, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 140 | inner!(mut self.0) [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] error: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match &$e { [INFO] [stderr] 103 | | &Encoding::Ascii(ref s) => &s.0, [INFO] [stderr] 104 | | &Encoding::Unicode(ref s) => &s.0, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 147 | inner!(self.0).as_ref() [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] error: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match &$e { [INFO] [stderr] 103 | | &Encoding::Ascii(ref s) => &s.0, [INFO] [stderr] 104 | | &Encoding::Unicode(ref s) => &s.0, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 155 | fmt::Debug::fmt(inner!(self.0), fmt) [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] error: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match &$e { [INFO] [stderr] 103 | | &Encoding::Ascii(ref s) => &s.0, [INFO] [stderr] 104 | | &Encoding::Unicode(ref s) => &s.0, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 162 | fmt::Display::fmt(inner!(self.0), fmt) [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `unicase`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ascii.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / fn deref<'a>(&'a self) -> &'a S { [INFO] [stderr] 23 | | &self.0 [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ascii.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stderr] 30 | | &mut self.0 [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/unicode/mod.rs:44:51 [INFO] [stderr] | [INFO] [stderr] 44 | for c in self.0.as_ref().chars().flat_map(|c| lookup(c)) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `lookup` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / fn deref<'a>(&'a self) -> &'a S { [INFO] [stderr] 133 | | inner!(self.0) [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match &$e { [INFO] [stderr] 103 | | &Encoding::Ascii(ref s) => &s.0, [INFO] [stderr] 104 | | &Encoding::Unicode(ref s) => &s.0, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 133 | inner!(self.0) [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | / fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stderr] 140 | | inner!(mut self.0) [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match &mut $e { [INFO] [stderr] 97 | | &mut Encoding::Ascii(ref mut s) => &mut s.0, [INFO] [stderr] 98 | | &mut Encoding::Unicode(ref mut s) => &mut s.0, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 140 | inner!(mut self.0) [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match &$e { [INFO] [stderr] 103 | | &Encoding::Ascii(ref s) => &s.0, [INFO] [stderr] 104 | | &Encoding::Unicode(ref s) => &s.0, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 147 | inner!(self.0).as_ref() [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match &$e { [INFO] [stderr] 103 | | &Encoding::Ascii(ref s) => &s.0, [INFO] [stderr] 104 | | &Encoding::Unicode(ref s) => &s.0, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 155 | fmt::Debug::fmt(inner!(self.0), fmt) [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | / match &$e { [INFO] [stderr] 103 | | &Encoding::Ascii(ref s) => &s.0, [INFO] [stderr] 104 | | &Encoding::Unicode(ref s) => &s.0, [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 162 | fmt::Display::fmt(inner!(self.0), fmt) [INFO] [stderr] | -------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0e6677cefb926d71ae63ba488bcf2a39114c4a3319e1daf21deb8d87b27446db"` [INFO] running `"docker" "rm" "-f" "0e6677cefb926d71ae63ba488bcf2a39114c4a3319e1daf21deb8d87b27446db"` [INFO] [stdout] 0e6677cefb926d71ae63ba488bcf2a39114c4a3319e1daf21deb8d87b27446db