[INFO] crate unic-ucd-bidi 0.7.0 is already in cache [INFO] extracting crate unic-ucd-bidi 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/unic-ucd-bidi/0.7.0 [INFO] extracting crate unic-ucd-bidi 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-ucd-bidi/0.7.0 [INFO] validating manifest of unic-ucd-bidi-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unic-ucd-bidi-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unic-ucd-bidi-0.7.0 [INFO] finished frobbing unic-ucd-bidi-0.7.0 [INFO] frobbed toml for unic-ucd-bidi-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/unic-ucd-bidi/0.7.0/Cargo.toml [INFO] started frobbing unic-ucd-bidi-0.7.0 [INFO] finished frobbing unic-ucd-bidi-0.7.0 [INFO] frobbed toml for unic-ucd-bidi-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-ucd-bidi/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unic-ucd-bidi-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unic-ucd-bidi/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3cc9dca996063fefff3aa15d2fd1085a32f6bbe56e502644f0d9333f4f3e527c [INFO] running `"docker" "start" "-a" "3cc9dca996063fefff3aa15d2fd1085a32f6bbe56e502644f0d9333f4f3e527c"` [INFO] [stderr] Checking unic-ucd-bidi v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bidi_class.rs:239:21 [INFO] [stderr] | [INFO] [stderr] 239 | pub fn category(&self) -> BidiClassCategory { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bidi_class.rs:272:19 [INFO] [stderr] | [INFO] [stderr] 272 | pub fn is_ltr(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bidi_class.rs:284:19 [INFO] [stderr] | [INFO] [stderr] 284 | pub fn is_rtl(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bidi_class.rs:239:21 [INFO] [stderr] | [INFO] [stderr] 239 | pub fn category(&self) -> BidiClassCategory { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bidi_class.rs:272:19 [INFO] [stderr] | [INFO] [stderr] 272 | pub fn is_ltr(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bidi_class.rs:284:19 [INFO] [stderr] | [INFO] [stderr] 284 | pub fn is_rtl(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/bidi_class.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / fn test_bmp() { [INFO] [stderr] 391 | | // Hebrew [INFO] [stderr] 392 | | assert_eq!(BidiClass::of('\u{0590}'), R); [INFO] [stderr] 393 | | assert_eq!(BidiClass::of('\u{05D0}'), R); [INFO] [stderr] ... | [INFO] [stderr] 433 | | assert_eq!(BidiClass::of('\u{FFFF}'), L); [INFO] [stderr] 434 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 51 [INFO] [stderr] --> src/bidi_control.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / fn test_values() { [INFO] [stderr] 36 | | use super::is_bidi_control; [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | // ASCII [INFO] [stderr] ... | [INFO] [stderr] 101 | | assert_eq!(is_bidi_control('\u{10ffff}'), false); [INFO] [stderr] 102 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> src/bidi_mirrored.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / fn test_values() { [INFO] [stderr] 37 | | use super::is_bidi_mirrored; [INFO] [stderr] 38 | | [INFO] [stderr] 39 | | // ASCII [INFO] [stderr] ... | [INFO] [stderr] 108 | | assert_eq!(is_bidi_mirrored('\u{10ffff}'), false); [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.17s [INFO] running `"docker" "inspect" "3cc9dca996063fefff3aa15d2fd1085a32f6bbe56e502644f0d9333f4f3e527c"` [INFO] running `"docker" "rm" "-f" "3cc9dca996063fefff3aa15d2fd1085a32f6bbe56e502644f0d9333f4f3e527c"` [INFO] [stdout] 3cc9dca996063fefff3aa15d2fd1085a32f6bbe56e502644f0d9333f4f3e527c