[INFO] crate unic-ucd-age 0.7.0 is already in cache [INFO] extracting crate unic-ucd-age 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/unic-ucd-age/0.7.0 [INFO] extracting crate unic-ucd-age 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-ucd-age/0.7.0 [INFO] validating manifest of unic-ucd-age-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unic-ucd-age-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unic-ucd-age-0.7.0 [INFO] finished frobbing unic-ucd-age-0.7.0 [INFO] frobbed toml for unic-ucd-age-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/unic-ucd-age/0.7.0/Cargo.toml [INFO] started frobbing unic-ucd-age-0.7.0 [INFO] finished frobbing unic-ucd-age-0.7.0 [INFO] frobbed toml for unic-ucd-age-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-ucd-age/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unic-ucd-age-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unic-ucd-age/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8e48262c546d322ee51c4f0f5faec8331b3e9a678107034253b745015ed72db [INFO] running `"docker" "start" "-a" "b8e48262c546d322ee51c4f0f5faec8331b3e9a678107034253b745015ed72db"` [INFO] [stderr] Checking unic-ucd-age v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/age.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn actual(&self) -> UnicodeVersion { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/age.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn actual(&self) -> UnicodeVersion { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/age.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / fn test_values() { [INFO] [stderr] 116 | | // ASCII [INFO] [stderr] 117 | | assert_eq!( [INFO] [stderr] 118 | | Age::of('\u{0000}'), [INFO] [stderr] ... | [INFO] [stderr] 421 | | ); [INFO] [stderr] 422 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/age.rs:425:5 [INFO] [stderr] | [INFO] [stderr] 425 | / fn test_cmp() { [INFO] [stderr] 426 | | assert!(Age::of('A') == Age::of('a')); [INFO] [stderr] 427 | | assert!(Age::of('A') > Age::of('Ɐ')); [INFO] [stderr] 428 | | assert!(Age::of('A') > Age::of('\u{10000}')); [INFO] [stderr] ... | [INFO] [stderr] 666 | | ); [INFO] [stderr] 667 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.78s [INFO] running `"docker" "inspect" "b8e48262c546d322ee51c4f0f5faec8331b3e9a678107034253b745015ed72db"` [INFO] running `"docker" "rm" "-f" "b8e48262c546d322ee51c4f0f5faec8331b3e9a678107034253b745015ed72db"` [INFO] [stdout] b8e48262c546d322ee51c4f0f5faec8331b3e9a678107034253b745015ed72db