[INFO] crate unic-idna 0.7.0 is already in cache [INFO] extracting crate unic-idna 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/unic-idna/0.7.0 [INFO] extracting crate unic-idna 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-idna/0.7.0 [INFO] validating manifest of unic-idna-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unic-idna-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unic-idna-0.7.0 [INFO] finished frobbing unic-idna-0.7.0 [INFO] frobbed toml for unic-idna-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/unic-idna/0.7.0/Cargo.toml [INFO] started frobbing unic-idna-0.7.0 [INFO] finished frobbing unic-idna-0.7.0 [INFO] frobbed toml for unic-idna-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-idna/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unic-idna-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unic-idna/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d6597b0055d7eae7277ae3f5dce6db314be12fc5ef1a369e5148810004759715 [INFO] running `"docker" "start" "-a" "d6597b0055d7eae7277ae3f5dce6db314be12fc5ef1a369e5148810004759715"` [INFO] [stderr] Checking unic-idna-punycode v0.7.0 [INFO] [stderr] Checking unic-ucd-normal v0.7.0 [INFO] [stderr] Checking unic-ucd-bidi v0.7.0 [INFO] [stderr] Checking unic-idna-mapping v0.7.0 [INFO] [stderr] Checking unic-normal v0.7.0 [INFO] [stderr] Checking unic-idna v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/process.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | PunycodeError, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/process.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/process.rs:298:5 [INFO] [stderr] | [INFO] [stderr] 298 | PunycodeError, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/process.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/process.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/process.rs:181:60 [INFO] [stderr] | [INFO] [stderr] 181 | else if label.starts_with('-') || label.ends_with('-') { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 182 | | errors.push(Error::ValidityCriteria); [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/process.rs:169:43 [INFO] [stderr] | [INFO] [stderr] 169 | else if label.nfc().ne(label.chars()) { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 170 | | errors.push(Error::ValidityCriteria); [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/process.rs:343:12 [INFO] [stderr] | [INFO] [stderr] 343 | if domain.len() < 1 || domain.split('.').any(|label| label.len() < 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `domain.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/process.rs:343:62 [INFO] [stderr] | [INFO] [stderr] 343 | if domain.len() < 1 || domain.split('.').any(|label| label.len() < 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `label.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `unic-idna`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/process.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | while let Some(c) = chars.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for c in chars { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/process.rs:181:60 [INFO] [stderr] | [INFO] [stderr] 181 | else if label.starts_with('-') || label.ends_with('-') { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 182 | | errors.push(Error::ValidityCriteria); [INFO] [stderr] 183 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/process.rs:169:43 [INFO] [stderr] | [INFO] [stderr] 169 | else if label.nfc().ne(label.chars()) { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 170 | | errors.push(Error::ValidityCriteria); [INFO] [stderr] 171 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/process.rs:343:12 [INFO] [stderr] | [INFO] [stderr] 343 | if domain.len() < 1 || domain.split('.').any(|label| label.len() < 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `domain.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/process.rs:343:62 [INFO] [stderr] | [INFO] [stderr] 343 | if domain.len() < 1 || domain.split('.').any(|label| label.len() < 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `label.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `unic-idna`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d6597b0055d7eae7277ae3f5dce6db314be12fc5ef1a369e5148810004759715"` [INFO] running `"docker" "rm" "-f" "d6597b0055d7eae7277ae3f5dce6db314be12fc5ef1a369e5148810004759715"` [INFO] [stdout] d6597b0055d7eae7277ae3f5dce6db314be12fc5ef1a369e5148810004759715