[INFO] crate unic-cli 0.7.0 is already in cache [INFO] extracting crate unic-cli 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/unic-cli/0.7.0 [INFO] extracting crate unic-cli 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-cli/0.7.0 [INFO] validating manifest of unic-cli-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unic-cli-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unic-cli-0.7.0 [INFO] finished frobbing unic-cli-0.7.0 [INFO] frobbed toml for unic-cli-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/unic-cli/0.7.0/Cargo.toml [INFO] started frobbing unic-cli-0.7.0 [INFO] finished frobbing unic-cli-0.7.0 [INFO] frobbed toml for unic-cli-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unic-cli/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unic-cli-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unic-cli/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5dc44e15cc14e76dc18d810e5bd50d38a05ad16ecbc7030878f8f2a66a436288 [INFO] running `"docker" "start" "-a" "5dc44e15cc14e76dc18d810e5bd50d38a05ad16ecbc7030878f8f2a66a436288"` [INFO] [stderr] Compiling rustc-demangle v0.1.13 [INFO] [stderr] Checking unic-char-range v0.7.0 [INFO] [stderr] Compiling pulldown-cmark v0.2.0 [INFO] [stderr] Compiling bytecount v0.4.0 [INFO] [stderr] Checking unic-idna-punycode v0.7.0 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Checking unic-char-property v0.7.0 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking unic-ucd-category v0.7.0 [INFO] [stderr] Checking unic-ucd-bidi v0.7.0 [INFO] [stderr] Checking unic-ucd-common v0.7.0 [INFO] [stderr] Checking unic-ucd-name v0.7.0 [INFO] [stderr] Checking unic-idna-mapping v0.7.0 [INFO] [stderr] Checking unic-ucd-age v0.7.0 [INFO] [stderr] Checking unic-ucd-case v0.7.0 [INFO] [stderr] Checking unic-emoji-char v0.7.0 [INFO] [stderr] Checking unic-ucd-ident v0.7.0 [INFO] [stderr] Checking unic-ucd-segment v0.7.0 [INFO] [stderr] Checking unic-char v0.7.0 [INFO] [stderr] Compiling error-chain v0.12.0 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Checking unic-bidi v0.7.0 [INFO] [stderr] Checking unic-ucd-normal v0.7.0 [INFO] [stderr] Checking unic-emoji v0.7.0 [INFO] [stderr] Checking unic-segment v0.7.0 [INFO] [stderr] Compiling cargo_metadata v0.6.4 [INFO] [stderr] Checking unic-normal v0.7.0 [INFO] [stderr] Checking unic-idna v0.7.0 [INFO] [stderr] Compiling skeptic v0.13.4 [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] Checking unic-ucd v0.7.0 [INFO] [stderr] Checking unic v0.7.0 [INFO] [stderr] Checking unic-cli v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/writers.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | ($write_fn)($output, v)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 43 | / write_join_with_space!(output, utf8.iter(), |output: &mut W, b8| -> Result<()> { [INFO] [stderr] 44 | | write!(output, "0x{:02X}", b8) [INFO] [stderr] 45 | | }) [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/writers.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | ($write_fn)($output, v)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 51 | / write_join_with_space!(output, utf16.iter(), |output: &mut W, b16| -> Result<()> { [INFO] [stderr] 52 | | write!(output, "0x{:04X}", b16) [INFO] [stderr] 53 | | }) [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parsers.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | .expect(&format!("Cannot parse token as hex number: {}", token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot parse token as hex number: {}", token))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parsers.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | .expect(&format!("Invalid Unicode Scalar Value code-point: {}", codepoint)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Invalid Unicode Scalar Value code-point: {}", codepoint))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parsers.rs:53:14 [INFO] [stderr] | [INFO] [stderr] 53 | .expect(&format!("Cannot parse token as hex byte value: {}", token)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot parse token as hex byte value: {}", token))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parsers.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | .expect(&format!("Cannot parse token as hex byte value: {}", token)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot parse token as hex byte value: {}", token))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/writers.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | ($write_fn)($output, v)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 43 | / write_join_with_space!(output, utf8.iter(), |output: &mut W, b8| -> Result<()> { [INFO] [stderr] 44 | | write!(output, "0x{:02X}", b8) [INFO] [stderr] 45 | | }) [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/writers.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | ($write_fn)($output, v)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 51 | / write_join_with_space!(output, utf16.iter(), |output: &mut W, b16| -> Result<()> { [INFO] [stderr] 52 | | write!(output, "0x{:04X}", b16) [INFO] [stderr] 53 | | }) [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parsers.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | .expect(&format!("Cannot parse token as hex number: {}", token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot parse token as hex number: {}", token))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parsers.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | .expect(&format!("Invalid Unicode Scalar Value code-point: {}", codepoint)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Invalid Unicode Scalar Value code-point: {}", codepoint))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parsers.rs:53:14 [INFO] [stderr] | [INFO] [stderr] 53 | .expect(&format!("Cannot parse token as hex byte value: {}", token)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot parse token as hex byte value: {}", token))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parsers.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | .expect(&format!("Cannot parse token as hex byte value: {}", token)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot parse token as hex byte value: {}", token))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/bin/unic-echo.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / unic_arg_enum!{ [INFO] [stderr] 24 | | #[derive(Debug)] [INFO] [stderr] 25 | | enum InputFormat { [INFO] [stderr] 26 | | Plain, [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/bin/unic-echo.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / unic_arg_enum!{ [INFO] [stderr] 47 | | #[derive(Debug)] [INFO] [stderr] 48 | | enum OutputFormat { [INFO] [stderr] 49 | | Plain, [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/bin/unic-echo.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / unic_arg_enum!{ [INFO] [stderr] 24 | | #[derive(Debug)] [INFO] [stderr] 25 | | enum InputFormat { [INFO] [stderr] 26 | | Plain, [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/bin/unic-echo.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | / unic_arg_enum!{ [INFO] [stderr] 47 | | #[derive(Debug)] [INFO] [stderr] 48 | | enum OutputFormat { [INFO] [stderr] 49 | | Plain, [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/unic-inspector.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | .unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/unic-inspector.rs:69:14 [INFO] [stderr] | [INFO] [stderr] 69 | .unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 54.70s [INFO] running `"docker" "inspect" "5dc44e15cc14e76dc18d810e5bd50d38a05ad16ecbc7030878f8f2a66a436288"` [INFO] running `"docker" "rm" "-f" "5dc44e15cc14e76dc18d810e5bd50d38a05ad16ecbc7030878f8f2a66a436288"` [INFO] [stdout] 5dc44e15cc14e76dc18d810e5bd50d38a05ad16ecbc7030878f8f2a66a436288