[INFO] crate uni-gl 0.1.0 is already in cache [INFO] extracting crate uni-gl 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/uni-gl/0.1.0 [INFO] extracting crate uni-gl 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uni-gl/0.1.0 [INFO] validating manifest of uni-gl-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of uni-gl-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing uni-gl-0.1.0 [INFO] finished frobbing uni-gl-0.1.0 [INFO] frobbed toml for uni-gl-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/uni-gl/0.1.0/Cargo.toml [INFO] started frobbing uni-gl-0.1.0 [INFO] finished frobbing uni-gl-0.1.0 [INFO] frobbed toml for uni-gl-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uni-gl/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting uni-gl-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/uni-gl/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7f6e4fd8e4aa00d60c94adf402cff47e0dbdde54cbb5474e82de0abaef3c6680 [INFO] running `"docker" "start" "-a" "7f6e4fd8e4aa00d60c94adf402cff47e0dbdde54cbb5474e82de0abaef3c6680"` [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking wayland-sys v0.20.12 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking wayland-commons v0.20.12 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking wayland-client v0.20.12 [INFO] [stderr] Checking wayland-protocols v0.20.12 [INFO] [stderr] Checking smithay-client-toolkit v0.2.6 [INFO] [stderr] Checking uni-gl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webgl_native.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / return unsafe { [INFO] [stderr] 56 | | let data = CStr::from_ptr(gl::GetString(param) as *const _) [INFO] [stderr] 57 | | .to_bytes() [INFO] [stderr] 58 | | .to_vec(); [INFO] [stderr] 59 | | String::from_utf8(data).unwrap() [INFO] [stderr] 60 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 55 | unsafe { [INFO] [stderr] 56 | let data = CStr::from_ptr(gl::GetString(param) as *const _) [INFO] [stderr] 57 | .to_bytes() [INFO] [stderr] 58 | .to_vec(); [INFO] [stderr] 59 | String::from_utf8(data).unwrap() [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webgl_native.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | return shader; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `shader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webgl_native.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | return Some(location as _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(location as _)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webgl_native.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | / return Some(WebGLUniformLocation { [INFO] [stderr] 297 | | reference: location as _, [INFO] [stderr] 298 | | name: name.into(), [INFO] [stderr] 299 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 296 | Some(WebGLUniformLocation { [INFO] [stderr] 297 | reference: location as _, [INFO] [stderr] 298 | name: name.into(), [INFO] [stderr] 299 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/glenum.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | Depth = 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/glenum.rs:127:15 [INFO] [stderr] | [INFO] [stderr] 127 | Stencil = 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/glenum.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | Color = 0x00004000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/webgl_native.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn new<'p>(mut loadfn: WebGLContext<'p>) -> WebGLRenderingContext { [INFO] [stderr] 75 | | gl::load_with(move |name| loadfn(name)); [INFO] [stderr] 76 | | [INFO] [stderr] 77 | | WebGLRenderingContext { [INFO] [stderr] 78 | | common: GLContext::new(), [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `webgl::GLContext` [INFO] [stderr] --> src/webgl_native.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn new() -> GLContext { [INFO] [stderr] 85 | | // unsafe { gl::Enable(gl::DEPTH_TEST) }; [INFO] [stderr] 86 | | println!("opengl {}", get_string(gl::VERSION)); [INFO] [stderr] 87 | | println!( [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:182:30 [INFO] [stderr] | [INFO] [stderr] 182 | let mut status = gl::FALSE as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:186:26 [INFO] [stderr] | [INFO] [stderr] 186 | if status != (gl::TRUE as gl::types::GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/webgl_native.rs:200:21 [INFO] [stderr] | [INFO] [stderr] 200 | Err(_) => panic!("Compile shader fail, reason unknown"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:220:30 [INFO] [stderr] | [INFO] [stderr] 220 | let mut status = gl::FALSE as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:224:26 [INFO] [stderr] | [INFO] [stderr] 224 | if status != (gl::TRUE as gl::types::GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/webgl_native.rs:238:21 [INFO] [stderr] | [INFO] [stderr] 238 | Err(_) => panic!("Link program fail, reason unknown"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:394:28 [INFO] [stderr] | [INFO] [stderr] 394 | gl::ClearDepth(value as _); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/webgl_native.rs:432:5 [INFO] [stderr] | [INFO] [stderr] 432 | / pub fn read_pixels( [INFO] [stderr] 433 | | &self, [INFO] [stderr] 434 | | x: u32, [INFO] [stderr] 435 | | y: u32, [INFO] [stderr] ... | [INFO] [stderr] 453 | | } [INFO] [stderr] 454 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/webgl_native.rs:465:5 [INFO] [stderr] | [INFO] [stderr] 465 | / pub fn tex_image2d( [INFO] [stderr] 466 | | &self, [INFO] [stderr] 467 | | target: TextureBindPoint, [INFO] [stderr] 468 | | level: u8, [INFO] [stderr] ... | [INFO] [stderr] 497 | | check_gl_error("tex_image2d"); [INFO] [stderr] 498 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/webgl_native.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | / let p: *const c_void; [INFO] [stderr] 476 | | [INFO] [stderr] 477 | | if pixels.len() > 0 { [INFO] [stderr] 478 | | p = pixels.as_ptr() as _; [INFO] [stderr] 479 | | } else { [INFO] [stderr] 480 | | p = 0 as _; [INFO] [stderr] 481 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let p = if pixels.len() > 0 { pixels.as_ptr() as _ } else { 0 as _ };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/webgl_native.rs:477:12 [INFO] [stderr] | [INFO] [stderr] 477 | if pixels.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pixels.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:486:17 [INFO] [stderr] | [INFO] [stderr] 486 | level as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:488:17 [INFO] [stderr] | [INFO] [stderr] 488 | width as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:489:17 [INFO] [stderr] | [INFO] [stderr] 489 | height as _, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/webgl_native.rs:501:5 [INFO] [stderr] | [INFO] [stderr] 501 | / pub fn tex_sub_image2d( [INFO] [stderr] 502 | | &self, [INFO] [stderr] 503 | | target: TextureBindPoint, [INFO] [stderr] 504 | | level: u8, [INFO] [stderr] ... | [INFO] [stderr] 527 | | check_gl_error("tex_sub_image2d"); [INFO] [stderr] 528 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:516:17 [INFO] [stderr] | [INFO] [stderr] 516 | level as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:517:17 [INFO] [stderr] | [INFO] [stderr] 517 | xoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:518:17 [INFO] [stderr] | [INFO] [stderr] 518 | yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:519:17 [INFO] [stderr] | [INFO] [stderr] 519 | width as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:520:17 [INFO] [stderr] | [INFO] [stderr] 520 | height as _, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:543:17 [INFO] [stderr] | [INFO] [stderr] 543 | level as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:545:17 [INFO] [stderr] | [INFO] [stderr] 545 | width as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:546:17 [INFO] [stderr] | [INFO] [stderr] 546 | height as _, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Checking glutin v0.17.0 [INFO] [stderr] Checking uni-app v0.1.0 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webgl_native.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / return unsafe { [INFO] [stderr] 56 | | let data = CStr::from_ptr(gl::GetString(param) as *const _) [INFO] [stderr] 57 | | .to_bytes() [INFO] [stderr] 58 | | .to_vec(); [INFO] [stderr] 59 | | String::from_utf8(data).unwrap() [INFO] [stderr] 60 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 55 | unsafe { [INFO] [stderr] 56 | let data = CStr::from_ptr(gl::GetString(param) as *const _) [INFO] [stderr] 57 | .to_bytes() [INFO] [stderr] 58 | .to_vec(); [INFO] [stderr] 59 | String::from_utf8(data).unwrap() [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webgl_native.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | return shader; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `shader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webgl_native.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | return Some(location as _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(location as _)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webgl_native.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | / return Some(WebGLUniformLocation { [INFO] [stderr] 297 | | reference: location as _, [INFO] [stderr] 298 | | name: name.into(), [INFO] [stderr] 299 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 296 | Some(WebGLUniformLocation { [INFO] [stderr] 297 | reference: location as _, [INFO] [stderr] 298 | name: name.into(), [INFO] [stderr] 299 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/glenum.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | Depth = 0x00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0100` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/glenum.rs:127:15 [INFO] [stderr] | [INFO] [stderr] 127 | Stencil = 0x00000400, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/glenum.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | Color = 0x00004000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_4000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/webgl_native.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | / pub fn new<'p>(mut loadfn: WebGLContext<'p>) -> WebGLRenderingContext { [INFO] [stderr] 75 | | gl::load_with(move |name| loadfn(name)); [INFO] [stderr] 76 | | [INFO] [stderr] 77 | | WebGLRenderingContext { [INFO] [stderr] 78 | | common: GLContext::new(), [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `webgl::GLContext` [INFO] [stderr] --> src/webgl_native.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | / pub fn new() -> GLContext { [INFO] [stderr] 85 | | // unsafe { gl::Enable(gl::DEPTH_TEST) }; [INFO] [stderr] 86 | | println!("opengl {}", get_string(gl::VERSION)); [INFO] [stderr] 87 | | println!( [INFO] [stderr] ... | [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:182:30 [INFO] [stderr] | [INFO] [stderr] 182 | let mut status = gl::FALSE as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:186:26 [INFO] [stderr] | [INFO] [stderr] 186 | if status != (gl::TRUE as gl::types::GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/webgl_native.rs:200:21 [INFO] [stderr] | [INFO] [stderr] 200 | Err(_) => panic!("Compile shader fail, reason unknown"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:220:30 [INFO] [stderr] | [INFO] [stderr] 220 | let mut status = gl::FALSE as gl::types::GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:224:26 [INFO] [stderr] | [INFO] [stderr] 224 | if status != (gl::TRUE as gl::types::GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/webgl_native.rs:238:21 [INFO] [stderr] | [INFO] [stderr] 238 | Err(_) => panic!("Link program fail, reason unknown"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:394:28 [INFO] [stderr] | [INFO] [stderr] 394 | gl::ClearDepth(value as _); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/webgl_native.rs:432:5 [INFO] [stderr] | [INFO] [stderr] 432 | / pub fn read_pixels( [INFO] [stderr] 433 | | &self, [INFO] [stderr] 434 | | x: u32, [INFO] [stderr] 435 | | y: u32, [INFO] [stderr] ... | [INFO] [stderr] 453 | | } [INFO] [stderr] 454 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/webgl_native.rs:465:5 [INFO] [stderr] | [INFO] [stderr] 465 | / pub fn tex_image2d( [INFO] [stderr] 466 | | &self, [INFO] [stderr] 467 | | target: TextureBindPoint, [INFO] [stderr] 468 | | level: u8, [INFO] [stderr] ... | [INFO] [stderr] 497 | | check_gl_error("tex_image2d"); [INFO] [stderr] 498 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/webgl_native.rs:475:9 [INFO] [stderr] | [INFO] [stderr] 475 | / let p: *const c_void; [INFO] [stderr] 476 | | [INFO] [stderr] 477 | | if pixels.len() > 0 { [INFO] [stderr] 478 | | p = pixels.as_ptr() as _; [INFO] [stderr] 479 | | } else { [INFO] [stderr] 480 | | p = 0 as _; [INFO] [stderr] 481 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let p = if pixels.len() > 0 { pixels.as_ptr() as _ } else { 0 as _ };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/webgl_native.rs:477:12 [INFO] [stderr] | [INFO] [stderr] 477 | if pixels.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pixels.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:486:17 [INFO] [stderr] | [INFO] [stderr] 486 | level as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:488:17 [INFO] [stderr] | [INFO] [stderr] 488 | width as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:489:17 [INFO] [stderr] | [INFO] [stderr] 489 | height as _, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/webgl_native.rs:501:5 [INFO] [stderr] | [INFO] [stderr] 501 | / pub fn tex_sub_image2d( [INFO] [stderr] 502 | | &self, [INFO] [stderr] 503 | | target: TextureBindPoint, [INFO] [stderr] 504 | | level: u8, [INFO] [stderr] ... | [INFO] [stderr] 527 | | check_gl_error("tex_sub_image2d"); [INFO] [stderr] 528 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:516:17 [INFO] [stderr] | [INFO] [stderr] 516 | level as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:517:17 [INFO] [stderr] | [INFO] [stderr] 517 | xoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(xoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:518:17 [INFO] [stderr] | [INFO] [stderr] 518 | yoffset as _, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(yoffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:519:17 [INFO] [stderr] | [INFO] [stderr] 519 | width as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:520:17 [INFO] [stderr] | [INFO] [stderr] 520 | height as _, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:543:17 [INFO] [stderr] | [INFO] [stderr] 543 | level as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(level)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:545:17 [INFO] [stderr] | [INFO] [stderr] 545 | width as _, [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/webgl_native.rs:546:17 [INFO] [stderr] | [INFO] [stderr] 546 | height as _, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.10s [INFO] running `"docker" "inspect" "7f6e4fd8e4aa00d60c94adf402cff47e0dbdde54cbb5474e82de0abaef3c6680"` [INFO] running `"docker" "rm" "-f" "7f6e4fd8e4aa00d60c94adf402cff47e0dbdde54cbb5474e82de0abaef3c6680"` [INFO] [stdout] 7f6e4fd8e4aa00d60c94adf402cff47e0dbdde54cbb5474e82de0abaef3c6680