[INFO] crate unhtml_derive 0.2.2 is already in cache [INFO] extracting crate unhtml_derive 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/unhtml_derive/0.2.2 [INFO] extracting crate unhtml_derive 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unhtml_derive/0.2.2 [INFO] validating manifest of unhtml_derive-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of unhtml_derive-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing unhtml_derive-0.2.2 [INFO] finished frobbing unhtml_derive-0.2.2 [INFO] frobbed toml for unhtml_derive-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/unhtml_derive/0.2.2/Cargo.toml [INFO] started frobbing unhtml_derive-0.2.2 [INFO] finished frobbing unhtml_derive-0.2.2 [INFO] frobbed toml for unhtml_derive-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/unhtml_derive/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting unhtml_derive-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/unhtml_derive/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2ff67f938e607e4a6541d2e40681f6ad3b201deb30b029d2372aaf631029a86 [INFO] running `"docker" "start" "-a" "d2ff67f938e607e4a6541d2e40681f6ad3b201deb30b029d2372aaf631029a86"` [INFO] [stderr] Compiling itoa v0.4.3 [INFO] [stderr] Compiling mac v0.1.1 [INFO] [stderr] Compiling utf-8 v0.7.5 [INFO] [stderr] Compiling nodrop v0.1.13 [INFO] [stderr] Compiling thin-slice v0.1.1 [INFO] [stderr] Compiling ego-tree v0.5.1 [INFO] [stderr] Compiling dtoa-short v0.3.2 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Compiling smallvec v0.6.8 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling futf v0.1.4 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking tendril v0.4.1 [INFO] [stderr] Compiling fxhash v0.2.1 [INFO] [stderr] Compiling string_cache_codegen v0.4.2 [INFO] [stderr] Compiling selectors v0.20.0 [INFO] [stderr] Compiling string_cache v0.7.3 [INFO] [stderr] Compiling serde_json v1.0.37 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Compiling html5ever v0.22.5 [INFO] [stderr] Compiling cssparser-macros v0.3.5 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling cssparser v0.24.1 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Compiling failure v0.1.5 [INFO] [stderr] Compiling markup5ever v0.7.5 [INFO] [stderr] Checking scraper v0.8.2 [INFO] [stderr] Checking unhtml v0.1.2 [INFO] [stderr] Checking unhtml_derive v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/implement.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | if &attr_value == ATTR_INNER_TEXT { [INFO] [stderr] | -----------^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `attr_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/implement.rs:130:28 [INFO] [stderr] | [INFO] [stderr] 130 | if &attr_value == ATTR_INNER_TEXT { [INFO] [stderr] | -----------^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `attr_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/implement.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / if let &syn::PathArguments::AngleBracketed(ref angle_bracket) = type_arguments { [INFO] [stderr] 153 | | if type_ident == TYPE_VEC && !type_arguments.is_empty() { [INFO] [stderr] 154 | | if let syn::GenericArgument::Type(ty) = angle_bracket.args.first()?.value() { [INFO] [stderr] 155 | | return Some(ty); [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 152 | if let syn::PathArguments::AngleBracketed(ref angle_bracket) = *type_arguments { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/implement.rs:169:26 [INFO] [stderr] | [INFO] [stderr] 169 | fn get_macro_attr(attrs: &Vec) -> MacroAttr { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/implement.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | for ref pair in list.nested.pairs() { [INFO] [stderr] | ^^^^^^^^ ------------------- help: try: `let pair = &list.nested.pairs();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/implement.rs:176:25 [INFO] [stderr] | [INFO] [stderr] 176 | / if let &&syn::NestedMeta::Meta(syn::Meta::NameValue(ref name_value)) = pair.value() { [INFO] [stderr] 177 | | if name_value.ident == SELECTOR_IDENT { [INFO] [stderr] 178 | | macro_attr.selector = Some(name_value.lit.to_owned()); [INFO] [stderr] 179 | | } else if name_value.ident == ATTR_IDENT { [INFO] [stderr] ... | [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 176 | if let &syn::NestedMeta::Meta(syn::Meta::NameValue(ref name_value)) = *pair.value() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/implement.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | / if let &Lit::Str(ref str_lit) = lit { [INFO] [stderr] 195 | | Selector::parse(&str_lit.value()).unwrap(); [INFO] [stderr] 196 | | } else { [INFO] [stderr] 197 | | panic!("selector must be string") [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | if let Lit::Str(ref str_lit) = *lit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/implement.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | / if let &Lit::Str(ref str_lit) = lit { [INFO] [stderr] 203 | | str_lit.value() [INFO] [stderr] 204 | | } else { [INFO] [stderr] 205 | | panic!("selector must be string") [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 202 | if let Lit::Str(ref str_lit) = *lit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/implement.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | if &attr_value == ATTR_INNER_TEXT { [INFO] [stderr] | -----------^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `attr_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/implement.rs:130:28 [INFO] [stderr] | [INFO] [stderr] 130 | if &attr_value == ATTR_INNER_TEXT { [INFO] [stderr] | -----------^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `attr_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/implement.rs:152:5 [INFO] [stderr] | [INFO] [stderr] 152 | / if let &syn::PathArguments::AngleBracketed(ref angle_bracket) = type_arguments { [INFO] [stderr] 153 | | if type_ident == TYPE_VEC && !type_arguments.is_empty() { [INFO] [stderr] 154 | | if let syn::GenericArgument::Type(ty) = angle_bracket.args.first()?.value() { [INFO] [stderr] 155 | | return Some(ty); [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 152 | if let syn::PathArguments::AngleBracketed(ref angle_bracket) = *type_arguments { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/implement.rs:169:26 [INFO] [stderr] | [INFO] [stderr] 169 | fn get_macro_attr(attrs: &Vec) -> MacroAttr { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/implement.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | for ref pair in list.nested.pairs() { [INFO] [stderr] | ^^^^^^^^ ------------------- help: try: `let pair = &list.nested.pairs();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/implement.rs:176:25 [INFO] [stderr] | [INFO] [stderr] 176 | / if let &&syn::NestedMeta::Meta(syn::Meta::NameValue(ref name_value)) = pair.value() { [INFO] [stderr] 177 | | if name_value.ident == SELECTOR_IDENT { [INFO] [stderr] 178 | | macro_attr.selector = Some(name_value.lit.to_owned()); [INFO] [stderr] 179 | | } else if name_value.ident == ATTR_IDENT { [INFO] [stderr] ... | [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 176 | if let &syn::NestedMeta::Meta(syn::Meta::NameValue(ref name_value)) = *pair.value() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/implement.rs:194:5 [INFO] [stderr] | [INFO] [stderr] 194 | / if let &Lit::Str(ref str_lit) = lit { [INFO] [stderr] 195 | | Selector::parse(&str_lit.value()).unwrap(); [INFO] [stderr] 196 | | } else { [INFO] [stderr] 197 | | panic!("selector must be string") [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | if let Lit::Str(ref str_lit) = *lit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/implement.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | / if let &Lit::Str(ref str_lit) = lit { [INFO] [stderr] 203 | | str_lit.value() [INFO] [stderr] 204 | | } else { [INFO] [stderr] 205 | | panic!("selector must be string") [INFO] [stderr] 206 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 202 | if let Lit::Str(ref str_lit) = *lit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 39s [INFO] running `"docker" "inspect" "d2ff67f938e607e4a6541d2e40681f6ad3b201deb30b029d2372aaf631029a86"` [INFO] running `"docker" "rm" "-f" "d2ff67f938e607e4a6541d2e40681f6ad3b201deb30b029d2372aaf631029a86"` [INFO] [stdout] d2ff67f938e607e4a6541d2e40681f6ad3b201deb30b029d2372aaf631029a86