[INFO] crate umio 0.3.0 is already in cache [INFO] extracting crate umio 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/umio/0.3.0 [INFO] extracting crate umio 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/umio/0.3.0 [INFO] validating manifest of umio-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of umio-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing umio-0.3.0 [INFO] removed 0 missing tests [INFO] finished frobbing umio-0.3.0 [INFO] frobbed toml for umio-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/umio/0.3.0/Cargo.toml [INFO] started frobbing umio-0.3.0 [INFO] removed 0 missing tests [INFO] finished frobbing umio-0.3.0 [INFO] frobbed toml for umio-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/umio/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting umio-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/umio/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b1be041d8a6fe9db8ba3b87c0a969db0ddef1f2be0f1d6a51a593f10dc1bc7b4 [INFO] running `"docker" "start" "-a" "b1be041d8a6fe9db8ba3b87c0a969db0ddef1f2be0f1d6a51a593f10dc1bc7b4"` [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking umio v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | BufferPool{ buffers: buffers, buffer_size: buffer_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buffers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | BufferPool{ buffers: buffers, buffer_size: buffer_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatcher.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | DispatchHandler{ dispatch: dispatch, out_queue: out_queue, udp_socket: udp_socket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatcher.rs:48:46 [INFO] [stderr] | [INFO] [stderr] 48 | DispatchHandler{ dispatch: dispatch, out_queue: out_queue, udp_socket: udp_socket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatcher.rs:48:68 [INFO] [stderr] | [INFO] [stderr] 48 | DispatchHandler{ dispatch: dispatch, out_queue: out_queue, udp_socket: udp_socket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `udp_socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatcher.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | buffer_pool: buffer_pool, current_set: EventSet::readable() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eloop.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | event_loop: event_loop }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/provider.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | Provider{ buffer_pool: buffer_pool, out_queue: out_queue, event_loop: event_loop } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/provider.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | Provider{ buffer_pool: buffer_pool, out_queue: out_queue, event_loop: event_loop } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/provider.rs:18:63 [INFO] [stderr] | [INFO] [stderr] 18 | Provider{ buffer_pool: buffer_pool, out_queue: out_queue, event_loop: event_loop } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | BufferPool{ buffers: buffers, buffer_size: buffer_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buffers` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:11:39 [INFO] [stderr] | [INFO] [stderr] 11 | BufferPool{ buffers: buffers, buffer_size: buffer_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatcher.rs:48:26 [INFO] [stderr] | [INFO] [stderr] 48 | DispatchHandler{ dispatch: dispatch, out_queue: out_queue, udp_socket: udp_socket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dispatch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatcher.rs:48:46 [INFO] [stderr] | [INFO] [stderr] 48 | DispatchHandler{ dispatch: dispatch, out_queue: out_queue, udp_socket: udp_socket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatcher.rs:48:68 [INFO] [stderr] | [INFO] [stderr] 48 | DispatchHandler{ dispatch: dispatch, out_queue: out_queue, udp_socket: udp_socket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `udp_socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dispatcher.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | buffer_pool: buffer_pool, current_set: EventSet::readable() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eloop.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | event_loop: event_loop }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/provider.rs:18:15 [INFO] [stderr] | [INFO] [stderr] 18 | Provider{ buffer_pool: buffer_pool, out_queue: out_queue, event_loop: event_loop } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buffer_pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/provider.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | Provider{ buffer_pool: buffer_pool, out_queue: out_queue, event_loop: event_loop } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/provider.rs:18:63 [INFO] [stderr] | [INFO] [stderr] 18 | Provider{ buffer_pool: buffer_pool, out_queue: out_queue, event_loop: event_loop } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/buffer.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | self.buffers.pop().unwrap_or(Buffer::new(self.buffer_size)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Buffer::new(self.buffer_size))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dispatcher.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match self.out_queue.pop_front() { [INFO] [stderr] 54 | | Some((buffer, addr)) => { [INFO] [stderr] 55 | | self.udp_socket.send_to(buffer.as_ref(), &addr).unwrap(); [INFO] [stderr] 56 | | [INFO] [stderr] ... | [INFO] [stderr] 59 | | None => () [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | if let Some((buffer, addr)) = self.out_queue.pop_front() { [INFO] [stderr] 54 | self.udp_socket.send_to(buffer.as_ref(), &addr).unwrap(); [INFO] [stderr] 55 | [INFO] [stderr] 56 | self.buffer_pool.push(buffer); [INFO] [stderr] 57 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `eloop::ELoopBuilder` [INFO] [stderr] --> src/eloop.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> ELoopBuilder { [INFO] [stderr] 24 | | let default_addr = SocketAddr::V4(SocketAddrV4::new(Ipv4Addr::new(0, 0, 0, 0), 0)); [INFO] [stderr] 25 | | [INFO] [stderr] 26 | | ELoopBuilder{ channel_capacity: DEFAULT_CHANNEL_CAPACITY, timer_capacity: DEFAULT_TIMER_CAPACITY, [INFO] [stderr] 27 | | buffer_size: DEFAULT_BUFFER_SIZE, bind_address: default_addr } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for eloop::ELoopBuilder { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> test/mod.rs:35:26 [INFO] [stderr] | [INFO] [stderr] 35 | (MockDispatcher{ send: send }, recv) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `send` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/buffer.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | self.buffers.pop().unwrap_or(Buffer::new(self.buffer_size)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Buffer::new(self.buffer_size))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dispatcher.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / match self.out_queue.pop_front() { [INFO] [stderr] 54 | | Some((buffer, addr)) => { [INFO] [stderr] 55 | | self.udp_socket.send_to(buffer.as_ref(), &addr).unwrap(); [INFO] [stderr] 56 | | [INFO] [stderr] ... | [INFO] [stderr] 59 | | None => () [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | if let Some((buffer, addr)) = self.out_queue.pop_front() { [INFO] [stderr] 54 | self.udp_socket.send_to(buffer.as_ref(), &addr).unwrap(); [INFO] [stderr] 55 | [INFO] [stderr] 56 | self.buffer_pool.push(buffer); [INFO] [stderr] 57 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `eloop::ELoopBuilder` [INFO] [stderr] --> src/eloop.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> ELoopBuilder { [INFO] [stderr] 24 | | let default_addr = SocketAddr::V4(SocketAddrV4::new(Ipv4Addr::new(0, 0, 0, 0), 0)); [INFO] [stderr] 25 | | [INFO] [stderr] 26 | | ELoopBuilder{ channel_capacity: DEFAULT_CHANNEL_CAPACITY, timer_capacity: DEFAULT_TIMER_CAPACITY, [INFO] [stderr] 27 | | buffer_size: DEFAULT_BUFFER_SIZE, bind_address: default_addr } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | impl Default for eloop::ELoopBuilder { [INFO] [stderr] 22 | fn default() -> Self { [INFO] [stderr] 23 | Self::new() [INFO] [stderr] 24 | } [INFO] [stderr] 25 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_mut` does nothing [INFO] [stderr] --> test/mod.rs:53:58 [INFO] [stderr] | [INFO] [stderr] 53 | for (src, dst) in message.iter().zip(buffer.as_mut().iter_mut()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try this: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.44s [INFO] running `"docker" "inspect" "b1be041d8a6fe9db8ba3b87c0a969db0ddef1f2be0f1d6a51a593f10dc1bc7b4"` [INFO] running `"docker" "rm" "-f" "b1be041d8a6fe9db8ba3b87c0a969db0ddef1f2be0f1d6a51a593f10dc1bc7b4"` [INFO] [stdout] b1be041d8a6fe9db8ba3b87c0a969db0ddef1f2be0f1d6a51a593f10dc1bc7b4