[INFO] crate ultrastar-txt 0.1.2 is already in cache [INFO] extracting crate ultrastar-txt 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/ultrastar-txt/0.1.2 [INFO] extracting crate ultrastar-txt 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ultrastar-txt/0.1.2 [INFO] validating manifest of ultrastar-txt-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ultrastar-txt-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ultrastar-txt-0.1.2 [INFO] finished frobbing ultrastar-txt-0.1.2 [INFO] frobbed toml for ultrastar-txt-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/ultrastar-txt/0.1.2/Cargo.toml [INFO] started frobbing ultrastar-txt-0.1.2 [INFO] finished frobbing ultrastar-txt-0.1.2 [INFO] frobbed toml for ultrastar-txt-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ultrastar-txt/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ultrastar-txt-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ultrastar-txt/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69371205840b155f264626758d9a51d88a7203e75ff41fbb298841e5577be58e [INFO] running `"docker" "start" "-a" "69371205840b155f264626758d9a51d88a7203e75ff41fbb298841e5577be58e"` [INFO] [stderr] Checking backtrace-sys v0.1.28 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking backtrace v0.3.13 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking ultrastar-txt v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | artist: artist, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `artist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | bpm: bpm, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bpm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | artist: artist, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `artist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | bpm: bpm, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bpm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the variable `line_count` is used as a loop counter. Consider using `for (line_count, item) in txt_str.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/parser.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | for line in txt_str.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `line_count` is used as a loop counter. Consider using `for (line_count, item) in txt_str.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/parser.rs:73:17 [INFO] [stderr] | [INFO] [stderr] 73 | for line in txt_str.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `line_count` is used as a loop counter. Consider using `for (line_count, item) in txt_str.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/parser.rs:290:17 [INFO] [stderr] | [INFO] [stderr] 290 | for line in txt_str.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `line_count` is used as a loop counter. Consider using `for (line_count, item) in txt_str.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/parser.rs:290:17 [INFO] [stderr] | [INFO] [stderr] 290 | for line in txt_str.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/structs.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | / match self { [INFO] [stderr] 148 | | &Note::Regular { ref text, .. } [INFO] [stderr] 149 | | | &Note::Golden { ref text, .. } [INFO] [stderr] 150 | | | &Note::Freestyle { ref text, .. } => Some(text), [INFO] [stderr] 151 | | &Note::PlayerChange { .. } => None, [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | match *self { [INFO] [stderr] 148 | Note::Regular { ref text, .. } [INFO] [stderr] 149 | | Note::Golden { ref text, .. } [INFO] [stderr] 150 | | Note::Freestyle { ref text, .. } => Some(text), [INFO] [stderr] 151 | Note::PlayerChange { .. } => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/structs.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match self { [INFO] [stderr] 158 | | &Note::PlayerChange { player, .. } => Some(player), [INFO] [stderr] 159 | | &Note::Regular { .. } [INFO] [stderr] 160 | | | &Note::Golden { .. } [INFO] [stderr] 161 | | | &Note::Freestyle { .. } => None, [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 157 | match *self { [INFO] [stderr] 158 | Note::PlayerChange { player, .. } => Some(player), [INFO] [stderr] 159 | Note::Regular { .. } [INFO] [stderr] 160 | | Note::Golden { .. } [INFO] [stderr] 161 | | Note::Freestyle { .. } => None, [INFO] [stderr] | [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/structs.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | / match self { [INFO] [stderr] 148 | | &Note::Regular { ref text, .. } [INFO] [stderr] 149 | | | &Note::Golden { ref text, .. } [INFO] [stderr] 150 | | | &Note::Freestyle { ref text, .. } => Some(text), [INFO] [stderr] 151 | | &Note::PlayerChange { .. } => None, [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | match *self { [INFO] [stderr] 148 | Note::Regular { ref text, .. } [INFO] [stderr] 149 | | Note::Golden { ref text, .. } [INFO] [stderr] 150 | | Note::Freestyle { ref text, .. } => Some(text), [INFO] [stderr] 151 | Note::PlayerChange { .. } => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/structs.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match self { [INFO] [stderr] 158 | | &Note::PlayerChange { player, .. } => Some(player), [INFO] [stderr] 159 | | &Note::Regular { .. } [INFO] [stderr] 160 | | | &Note::Golden { .. } [INFO] [stderr] 161 | | | &Note::Freestyle { .. } => None, [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 157 | match *self { [INFO] [stderr] 158 | Note::PlayerChange { player, .. } => Some(player), [INFO] [stderr] 159 | Note::Regular { .. } [INFO] [stderr] 160 | | Note::Golden { .. } [INFO] [stderr] 161 | | Note::Freestyle { .. } => None, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:19:50 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn generate_song_txt(header: &Header, lines: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Line]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/generator.rs:19:50 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn generate_song_txt(header: &Header, lines: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Line]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generator.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | let mut song_txt_str = String::from(format!( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 26 | | "#TITLE:{}\n#ARTIST:{}\n#MP3:{}\n#BPM:{}\n", [INFO] [stderr] 27 | | header.title, header.artist, mp3_str, header.bpm [INFO] [stderr] 28 | | )); [INFO] [stderr] | |______^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 25 | let mut song_txt_str = format!( [INFO] [stderr] 26 | "#TITLE:{}\n#ARTIST:{}\n#MP3:{}\n#BPM:{}\n", [INFO] [stderr] 27 | header.title, header.artist, mp3_str, header.bpm [INFO] [stderr] 28 | ); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/generator.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / match note { [INFO] [stderr] 92 | | &Note::Regular { [INFO] [stderr] 93 | | start, [INFO] [stderr] 94 | | duration, [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | match *note { [INFO] [stderr] 92 | Note::Regular { [INFO] [stderr] 93 | start, [INFO] [stderr] 94 | duration, [INFO] [stderr] 95 | pitch, [INFO] [stderr] 96 | ref text, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/generator.rs:25:28 [INFO] [stderr] | [INFO] [stderr] 25 | let mut song_txt_str = String::from(format!( [INFO] [stderr] | ____________________________^ [INFO] [stderr] 26 | | "#TITLE:{}\n#ARTIST:{}\n#MP3:{}\n#BPM:{}\n", [INFO] [stderr] 27 | | header.title, header.artist, mp3_str, header.bpm [INFO] [stderr] 28 | | )); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `String::from()` [INFO] [stderr] | [INFO] [stderr] 25 | let mut song_txt_str = format!( [INFO] [stderr] 26 | "#TITLE:{}\n#ARTIST:{}\n#MP3:{}\n#BPM:{}\n", [INFO] [stderr] 27 | header.title, header.artist, mp3_str, header.bpm [INFO] [stderr] 28 | ); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/generator.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / match note { [INFO] [stderr] 92 | | &Note::Regular { [INFO] [stderr] 93 | | start, [INFO] [stderr] 94 | | duration, [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 91 | match *note { [INFO] [stderr] 92 | Note::Regular { [INFO] [stderr] 93 | start, [INFO] [stderr] 94 | duration, [INFO] [stderr] 95 | pitch, [INFO] [stderr] 96 | ref text, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/txt.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `ultrastar-txt`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "69371205840b155f264626758d9a51d88a7203e75ff41fbb298841e5577be58e"` [INFO] running `"docker" "rm" "-f" "69371205840b155f264626758d9a51d88a7203e75ff41fbb298841e5577be58e"` [INFO] [stdout] 69371205840b155f264626758d9a51d88a7203e75ff41fbb298841e5577be58e