[INFO] crate ulid 0.2.3 is already in cache [INFO] extracting crate ulid 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/ulid/0.2.3 [INFO] extracting crate ulid 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ulid/0.2.3 [INFO] validating manifest of ulid-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ulid-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ulid-0.2.3 [INFO] finished frobbing ulid-0.2.3 [INFO] frobbed toml for ulid-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/ulid/0.2.3/Cargo.toml [INFO] started frobbing ulid-0.2.3 [INFO] finished frobbing ulid-0.2.3 [INFO] frobbed toml for ulid-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ulid/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ulid-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ulid/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ffa85866a0507a4b7c61b4cf4a5d94d1034525aed9e6d5349928f5d5f9c4287f [INFO] running `"docker" "start" "-a" "ffa85866a0507a4b7c61b4cf4a5d94d1034525aed9e6d5349928f5d5f9c4287f"` [INFO] [stderr] Checking bencher v0.1.5 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking ulid v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/base32.rs:3:18 [INFO] [stderr] | [INFO] [stderr] 3 | const ALPHABET: &'static [u8; 32] = b"0123456789ABCDEFGHJKMNPQRSTVWXYZ"; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/base32.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | return String::from_utf8(buffer.to_vec()) [INFO] [stderr] | _____^ [INFO] [stderr] 55 | | .expect("unexpected failure in base32 encode for ulid"); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | String::from_utf8(buffer.to_vec()) [INFO] [stderr] 55 | .expect("unexpected failure in base32 encode for ulid") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/base32.rs:91:2 [INFO] [stderr] | [INFO] [stderr] 91 | return Ok((msb, lsb)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((msb, lsb))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:75:3 [INFO] [stderr] | [INFO] [stderr] 75 | return Ulid( [INFO] [stderr] | _________^ [INFO] [stderr] 76 | | timebits << 16 | source.gen::() as u64, [INFO] [stderr] 77 | | source.gen::() [INFO] [stderr] 78 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 75 | Ulid( [INFO] [stderr] 76 | timebits << 16 | source.gen::() as u64, [INFO] [stderr] 77 | source.gen::() [INFO] [stderr] 78 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:86:3 [INFO] [stderr] | [INFO] [stderr] 86 | return base32::decode(encoded) [INFO] [stderr] | _________^ [INFO] [stderr] 87 | | .map(|(msb, lsb)| Ulid(msb, lsb)); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 86 | base32::decode(encoded) [INFO] [stderr] 87 | .map(|(msb, lsb)| Ulid(msb, lsb)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return UTC.timestamp(secs as i64, (millis*1000000) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UTC.timestamp(secs as i64, (millis*1000000) as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:95:45 [INFO] [stderr] | [INFO] [stderr] 95 | return UTC.timestamp(secs as i64, (millis*1000000) as u32); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:100:3 [INFO] [stderr] | [INFO] [stderr] 100 | return self.0 >> 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.0 >> 16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:105:3 [INFO] [stderr] | [INFO] [stderr] 105 | return base32::encode(self.0, self.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `base32::encode(self.0, self.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/base32.rs:3:18 [INFO] [stderr] | [INFO] [stderr] 3 | const ALPHABET: &'static [u8; 32] = b"0123456789ABCDEFGHJKMNPQRSTVWXYZ"; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u8; 32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/base32.rs:54:2 [INFO] [stderr] | [INFO] [stderr] 54 | return String::from_utf8(buffer.to_vec()) [INFO] [stderr] | _____^ [INFO] [stderr] 55 | | .expect("unexpected failure in base32 encode for ulid"); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 54 | String::from_utf8(buffer.to_vec()) [INFO] [stderr] 55 | .expect("unexpected failure in base32 encode for ulid") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/base32.rs:91:2 [INFO] [stderr] | [INFO] [stderr] 91 | return Ok((msb, lsb)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((msb, lsb))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:100:14 [INFO] [stderr] | [INFO] [stderr] 100 | let val = (0x4141414141414141, 0x4141414141414141); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4141_4141_4141_4141` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:100:34 [INFO] [stderr] | [INFO] [stderr] 100 | let val = (0x4141414141414141, 0x4141414141414141); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4141_4141_4141_4141` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:104:14 [INFO] [stderr] | [INFO] [stderr] 104 | let val = (0x4d4e385051444a59, 0x454234335a413756); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4d4e_3850_5144_4a59` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:104:34 [INFO] [stderr] | [INFO] [stderr] 104 | let val = (0x4d4e385051444a59, 0x454234335a413756); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4542_3433_5a41_3756` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | assert_eq!(encode(0xffffffffffffffff, 0xffffffffffffffff).len(), 26); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:114:41 [INFO] [stderr] | [INFO] [stderr] 114 | assert_eq!(encode(0xffffffffffffffff, 0xffffffffffffffff).len(), 26); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:115:21 [INFO] [stderr] | [INFO] [stderr] 115 | assert_eq!(encode(0x0f0f0f0f0f0f0f0f, 0x0f0f0f0f0f0f0f0f).len(), 26); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0f0f_0f0f_0f0f_0f0f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:115:41 [INFO] [stderr] | [INFO] [stderr] 115 | assert_eq!(encode(0x0f0f0f0f0f0f0f0f, 0x0f0f0f0f0f0f0f0f).len(), 26); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0f0f_0f0f_0f0f_0f0f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:116:21 [INFO] [stderr] | [INFO] [stderr] 116 | assert_eq!(encode(0x0000000000000000, 0x0000000000000000).len(), 26); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:116:41 [INFO] [stderr] | [INFO] [stderr] 116 | assert_eq!(encode(0x0000000000000000, 0x0000000000000000).len(), 26); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:125:23 [INFO] [stderr] | [INFO] [stderr] 125 | for ref c in encode(0xffffffffffffffff, 0xffffffffffffffff).bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:125:43 [INFO] [stderr] | [INFO] [stderr] 125 | for ref c in encode(0xffffffffffffffff, 0xffffffffffffffff).bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:128:23 [INFO] [stderr] | [INFO] [stderr] 128 | for ref c in encode(0x0f0f0f0f0f0f0f0f, 0x0f0f0f0f0f0f0f0f).bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0f0f_0f0f_0f0f_0f0f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:128:43 [INFO] [stderr] | [INFO] [stderr] 128 | for ref c in encode(0x0f0f0f0f0f0f0f0f, 0x0f0f0f0f0f0f0f0f).bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0f0f_0f0f_0f0f_0f0f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | for ref c in encode(0x0000000000000000, 0x0000000000000000).bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/base32.rs:131:43 [INFO] [stderr] | [INFO] [stderr] 131 | for ref c in encode(0x0000000000000000, 0x0000000000000000).bytes() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:75:3 [INFO] [stderr] | [INFO] [stderr] 75 | return Ulid( [INFO] [stderr] | _________^ [INFO] [stderr] 76 | | timebits << 16 | source.gen::() as u64, [INFO] [stderr] 77 | | source.gen::() [INFO] [stderr] 78 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 75 | Ulid( [INFO] [stderr] 76 | timebits << 16 | source.gen::() as u64, [INFO] [stderr] 77 | source.gen::() [INFO] [stderr] 78 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:86:3 [INFO] [stderr] | [INFO] [stderr] 86 | return base32::decode(encoded) [INFO] [stderr] | _________^ [INFO] [stderr] 87 | | .map(|(msb, lsb)| Ulid(msb, lsb)); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 86 | base32::decode(encoded) [INFO] [stderr] 87 | .map(|(msb, lsb)| Ulid(msb, lsb)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return UTC.timestamp(secs as i64, (millis*1000000) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UTC.timestamp(secs as i64, (millis*1000000) as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:95:45 [INFO] [stderr] | [INFO] [stderr] 95 | return UTC.timestamp(secs as i64, (millis*1000000) as u32); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:100:3 [INFO] [stderr] | [INFO] [stderr] 100 | return self.0 >> 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.0 >> 16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:105:3 [INFO] [stderr] | [INFO] [stderr] 105 | return base32::encode(self.0, self.1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `base32::encode(self.0, self.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | let s = Ulid(0x4141414141414141, 0x4141414141414141).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4141_4141_4141_4141` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:156:36 [INFO] [stderr] | [INFO] [stderr] 156 | let s = Ulid(0x4141414141414141, 0x4141414141414141).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4141_4141_4141_4141` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:159:19 [INFO] [stderr] | [INFO] [stderr] 159 | assert_eq!(u.0, 0x4141414141414141); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4141_4141_4141_4141` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | assert_eq!(u.1, 0x4141414141414141); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4141_4141_4141_4141` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/base32.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | msb = (msb << 5) | val as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/base32.rs:77:22 [INFO] [stderr] | [INFO] [stderr] 77 | msb = (msb << 1) | ((val >> 4) & 0x1) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((val >> 4) & 0x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/base32.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | lsb = (val & 0xf) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(val & 0xf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/base32.rs:85:23 [INFO] [stderr] | [INFO] [stderr] 85 | lsb = (lsb << 5) | val as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Ulid` [INFO] [stderr] --> src/lib.rs:51:2 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn new() -> Ulid { [INFO] [stderr] | _____^ [INFO] [stderr] 52 | | Ulid::from_datetime(UTC::now()) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:71:6 [INFO] [stderr] | [INFO] [stderr] 71 | + (datetime.timestamp_subsec_millis() as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(datetime.timestamp_subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | timebits << 16 | source.gen::() as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(source.gen::())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/base32.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | msb = (msb << 5) | val as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/base32.rs:77:22 [INFO] [stderr] | [INFO] [stderr] 77 | msb = (msb << 1) | ((val >> 4) & 0x1) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((val >> 4) & 0x1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/base32.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | lsb = (val & 0xf) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(val & 0xf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/base32.rs:85:23 [INFO] [stderr] | [INFO] [stderr] 85 | lsb = (lsb << 5) | val as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/base32.rs:125:7 [INFO] [stderr] | [INFO] [stderr] 125 | for ref c in encode(0xffffffffffffffff, 0xffffffffffffffff).bytes() { [INFO] [stderr] | ^^^^^ ------------------------------------------------------ help: try: `let c = &encode(0xffffffffffffffff, 0xffffffffffffffff).bytes();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/base32.rs:128:7 [INFO] [stderr] | [INFO] [stderr] 128 | for ref c in encode(0x0f0f0f0f0f0f0f0f, 0x0f0f0f0f0f0f0f0f).bytes() { [INFO] [stderr] | ^^^^^ ------------------------------------------------------ help: try: `let c = &encode(0x0f0f0f0f0f0f0f0f, 0x0f0f0f0f0f0f0f0f).bytes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/base32.rs:131:7 [INFO] [stderr] | [INFO] [stderr] 131 | for ref c in encode(0x0000000000000000, 0x0000000000000000).bytes() { [INFO] [stderr] | ^^^^^ ------------------------------------------------------ help: try: `let c = &encode(0x0000000000000000, 0x0000000000000000).bytes();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Ulid` [INFO] [stderr] --> src/lib.rs:51:2 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn new() -> Ulid { [INFO] [stderr] | _____^ [INFO] [stderr] 52 | | Ulid::from_datetime(UTC::now()) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 46 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:71:6 [INFO] [stderr] | [INFO] [stderr] 71 | + (datetime.timestamp_subsec_millis() as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(datetime.timestamp_subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | timebits << 16 | source.gen::() as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(source.gen::())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:199:43 [INFO] [stderr] | [INFO] [stderr] 199 | let ts = dt.timestamp() as u64 * 1000 + dt.timestamp_subsec_millis() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dt.timestamp_subsec_millis())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> benches/bench.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | b.iter(|| Ulid::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `Ulid::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.92s [INFO] running `"docker" "inspect" "ffa85866a0507a4b7c61b4cf4a5d94d1034525aed9e6d5349928f5d5f9c4287f"` [INFO] running `"docker" "rm" "-f" "ffa85866a0507a4b7c61b4cf4a5d94d1034525aed9e6d5349928f5d5f9c4287f"` [INFO] [stdout] ffa85866a0507a4b7c61b4cf4a5d94d1034525aed9e6d5349928f5d5f9c4287f