[INFO] crate ufire_ec 0.9.2 is already in cache [INFO] extracting crate ufire_ec 0.9.2 into work/ex/clippy-test-run/sources/stable/reg/ufire_ec/0.9.2 [INFO] extracting crate ufire_ec 0.9.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ufire_ec/0.9.2 [INFO] validating manifest of ufire_ec-0.9.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ufire_ec-0.9.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ufire_ec-0.9.2 [INFO] finished frobbing ufire_ec-0.9.2 [INFO] frobbed toml for ufire_ec-0.9.2 written to work/ex/clippy-test-run/sources/stable/reg/ufire_ec/0.9.2/Cargo.toml [INFO] started frobbing ufire_ec-0.9.2 [INFO] finished frobbing ufire_ec-0.9.2 [INFO] frobbed toml for ufire_ec-0.9.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ufire_ec/0.9.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ufire_ec-0.9.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ufire_ec/0.9.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36fb880210410d02436dfa04d534d49f834384352d7e5ae98f0ca3b831d9daa8 [INFO] running `"docker" "start" "-a" "36fb880210410d02436dfa04d534d49f834384352d7e5ae98f0ca3b831d9daa8"` [INFO] [stderr] Compiling pulldown-cmark v0.2.0 [INFO] [stderr] Compiling bytecount v0.4.0 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Compiling error-chain v0.12.0 [INFO] [stderr] Compiling cargo_metadata v0.6.4 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Compiling skeptic v0.13.4 [INFO] [stderr] Compiling i2cdev v0.3.2 [INFO] [stderr] Checking ufire_ec v0.9.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | const PSU_TO_PPT_CONVERSION: f32 = 1.004715; [INFO] [stderr] | ^^^^^^^^ help: consider: `1.004_715` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PSU_TO_PPT_CONVERSION` [INFO] [stderr] --> src/lib.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | const PSU_TO_PPT_CONVERSION: f32 = 1.004715; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | const PSU_TO_PPT_CONVERSION: f32 = 1.004715; [INFO] [stderr] | ^^^^^^^^ help: consider: `1.004_715` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:447:52 [INFO] [stderr] | [INFO] [stderr] 447 | self._write_register(EC_SOLUTION_REGISTER, i2c_address as f32)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(i2c_address)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `register` [INFO] [stderr] --> src/lib.rs:457:44 [INFO] [stderr] | [INFO] [stderr] 457 | self.dev.smbus_write_byte_data(register + 0, buf[0])?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PSU_TO_PPT_CONVERSION` [INFO] [stderr] --> src/lib.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | const PSU_TO_PPT_CONVERSION: f32 = 1.004715; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:447:52 [INFO] [stderr] | [INFO] [stderr] 447 | self._write_register(EC_SOLUTION_REGISTER, i2c_address as f32)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from(i2c_address)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `register` [INFO] [stderr] --> src/lib.rs:457:44 [INFO] [stderr] | [INFO] [stderr] 457 | self.dev.smbus_write_byte_data(register + 0, buf[0])?; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.49s [INFO] running `"docker" "inspect" "36fb880210410d02436dfa04d534d49f834384352d7e5ae98f0ca3b831d9daa8"` [INFO] running `"docker" "rm" "-f" "36fb880210410d02436dfa04d534d49f834384352d7e5ae98f0ca3b831d9daa8"` [INFO] [stdout] 36fb880210410d02436dfa04d534d49f834384352d7e5ae98f0ca3b831d9daa8