[INFO] crate udpproxy 0.1.0 is already in cache [INFO] extracting crate udpproxy 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/udpproxy/0.1.0 [INFO] extracting crate udpproxy 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/udpproxy/0.1.0 [INFO] validating manifest of udpproxy-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of udpproxy-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing udpproxy-0.1.0 [INFO] finished frobbing udpproxy-0.1.0 [INFO] frobbed toml for udpproxy-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/udpproxy/0.1.0/Cargo.toml [INFO] started frobbing udpproxy-0.1.0 [INFO] finished frobbing udpproxy-0.1.0 [INFO] frobbed toml for udpproxy-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/udpproxy/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting udpproxy-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/udpproxy/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a31aed64c5e71343026b8bbaebbee5b8440fec62077404215232ac5ea22d8ee [INFO] running `"docker" "start" "-a" "0a31aed64c5e71343026b8bbaebbee5b8440fec62077404215232ac5ea22d8ee"` [INFO] [stderr] Checking udpproxy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:81:46 [INFO] [stderr] | [INFO] [stderr] 81 | let local = UdpSocket::bind(&local_addr).expect(&format!("Unable to bind to {}", &local_addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to bind to {}", &local_addr))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | .expect(&format!("Failed to clone primary listening address socket {}", [INFO] [stderr] | __________^ [INFO] [stderr] 89 | | local.local_addr().unwrap())); [INFO] [stderr] | |_____________________________________________________^ help: try this: `unwrap_or_else(|_| panic!("Failed to clone primary listening address socket {}", local.local_addr().unwrap()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:92:15 [INFO] [stderr] | [INFO] [stderr] 92 | debug(format!("Started new thread to deal out responses to clients")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Started new thread to deal out responses to clients".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | .expect(&format!("Failed to forward response from upstream server to client {}", [INFO] [stderr] | __________________^ [INFO] [stderr] 99 | | dest)); [INFO] [stderr] | |______________________________________^ help: try this: `unwrap_or_else(|_| panic!("Failed to forward response from upstream server to client {}", dest))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:117:23 [INFO] [stderr] | [INFO] [stderr] 117 | debug(format!("Removing existing forwarder from map.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Removing existing forwarder from map.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | .expect(&format!("Failed to bind to transient address {}", &temp_outgoing_addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to bind to transient address {}", &temp_outgoing_addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:167:38 [INFO] [stderr] | [INFO] [stderr] 167 | .expect(&format!("Failed to forward packet from client {} to upstream server!", src_addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to forward packet from client {} to upstream server!", src_addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:81:46 [INFO] [stderr] | [INFO] [stderr] 81 | let local = UdpSocket::bind(&local_addr).expect(&format!("Unable to bind to {}", &local_addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to bind to {}", &local_addr))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:88:10 [INFO] [stderr] | [INFO] [stderr] 88 | .expect(&format!("Failed to clone primary listening address socket {}", [INFO] [stderr] | __________^ [INFO] [stderr] 89 | | local.local_addr().unwrap())); [INFO] [stderr] | |_____________________________________________________^ help: try this: `unwrap_or_else(|_| panic!("Failed to clone primary listening address socket {}", local.local_addr().unwrap()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:92:15 [INFO] [stderr] | [INFO] [stderr] 92 | debug(format!("Started new thread to deal out responses to clients")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Started new thread to deal out responses to clients".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | .expect(&format!("Failed to forward response from upstream server to client {}", [INFO] [stderr] | __________________^ [INFO] [stderr] 99 | | dest)); [INFO] [stderr] | |______________________________________^ help: try this: `unwrap_or_else(|_| panic!("Failed to forward response from upstream server to client {}", dest))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:117:23 [INFO] [stderr] | [INFO] [stderr] 117 | debug(format!("Removing existing forwarder from map.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Removing existing forwarder from map.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:135:26 [INFO] [stderr] | [INFO] [stderr] 135 | .expect(&format!("Failed to bind to transient address {}", &temp_outgoing_addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to bind to transient address {}", &temp_outgoing_addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:167:38 [INFO] [stderr] | [INFO] [stderr] 167 | .expect(&format!("Failed to forward packet from client {} to upstream server!", src_addr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to forward packet from client {} to upstream server!", src_addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.95s [INFO] running `"docker" "inspect" "0a31aed64c5e71343026b8bbaebbee5b8440fec62077404215232ac5ea22d8ee"` [INFO] running `"docker" "rm" "-f" "0a31aed64c5e71343026b8bbaebbee5b8440fec62077404215232ac5ea22d8ee"` [INFO] [stdout] 0a31aed64c5e71343026b8bbaebbee5b8440fec62077404215232ac5ea22d8ee