[INFO] crate udev 0.2.0 is already in cache [INFO] extracting crate udev 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/udev/0.2.0 [INFO] extracting crate udev 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/udev/0.2.0 [INFO] validating manifest of udev-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of udev-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing udev-0.2.0 [INFO] finished frobbing udev-0.2.0 [INFO] frobbed toml for udev-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/udev/0.2.0/Cargo.toml [INFO] started frobbing udev-0.2.0 [INFO] finished frobbing udev-0.2.0 [INFO] frobbed toml for udev-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/udev/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting udev-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/udev/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ee0cfb77553e520abafaf07e670ce36cd4a3116e39635fbcefcb3bd798e86738 [INFO] running `"docker" "start" "-a" "ee0cfb77553e520abafaf07e670ce36cd4a3116e39635fbcefcb3bd798e86738"` [INFO] [stderr] Checking libudev-sys v0.1.4 [INFO] [stderr] Checking udev v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:291:17 [INFO] [stderr] | [INFO] [stderr] 291 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:292:17 [INFO] [stderr] | [INFO] [stderr] 292 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | name: name [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/monitor.rs:159:26 [INFO] [stderr] | [INFO] [stderr] 159 | Some(Event { device: device }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:291:17 [INFO] [stderr] | [INFO] [stderr] 291 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:292:17 [INFO] [stderr] | [INFO] [stderr] 292 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:338:17 [INFO] [stderr] | [INFO] [stderr] 338 | name: name [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/monitor.rs:159:26 [INFO] [stderr] | [INFO] [stderr] 159 | Some(Event { device: device }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | Err(_) => return Err(::error::from_errno(::libc::EINVAL)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(::error::from_errno(::libc::EINVAL))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | Err(_) => return Err(::error::from_errno(::libc::EINVAL)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(::error::from_errno(::libc::EINVAL))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/device.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | BlockDevice = 'b' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'b' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/device.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | CharacterDevice = 'c' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'c' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/device.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | BlockDevice = 'b' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'b' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/device.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | CharacterDevice = 'c' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'c' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/device.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | / pub fn properties<'a>(&'a self) -> Properties<'a> { [INFO] [stderr] 242 | | Properties { [INFO] [stderr] 243 | | entry: unsafe { ::ffi::udev_device_get_properties_list_entry(self.device) }, [INFO] [stderr] 244 | | _device: self, [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/device.rs:262:5 [INFO] [stderr] | [INFO] [stderr] 262 | / pub fn attributes<'a>(&'a self) -> Attributes<'a> { [INFO] [stderr] 263 | | Attributes { [INFO] [stderr] 264 | | entry: unsafe { ::ffi::udev_device_get_sysattr_list_entry(self.device) }, [INFO] [stderr] 265 | | device: self, [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/device.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | / pub fn properties<'a>(&'a self) -> Properties<'a> { [INFO] [stderr] 242 | | Properties { [INFO] [stderr] 243 | | entry: unsafe { ::ffi::udev_device_get_properties_list_entry(self.device) }, [INFO] [stderr] 244 | | _device: self, [INFO] [stderr] 245 | | } [INFO] [stderr] 246 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/device.rs:262:5 [INFO] [stderr] | [INFO] [stderr] 262 | / pub fn attributes<'a>(&'a self) -> Attributes<'a> { [INFO] [stderr] 263 | | Attributes { [INFO] [stderr] 264 | | entry: unsafe { ::ffi::udev_device_get_sysattr_list_entry(self.device) }, [INFO] [stderr] 265 | | device: self, [INFO] [stderr] 266 | | } [INFO] [stderr] 267 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/monitor.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | f.write_str(match self { [INFO] [stderr] | _____________________^ [INFO] [stderr] 189 | | &EventType::Add => "add", [INFO] [stderr] 190 | | &EventType::Change => "change", [INFO] [stderr] 191 | | &EventType::Remove => "remove", [INFO] [stderr] 192 | | &EventType::Unknown => "unknown", [INFO] [stderr] 193 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | f.write_str(match *self { [INFO] [stderr] 189 | EventType::Add => "add", [INFO] [stderr] 190 | EventType::Change => "change", [INFO] [stderr] 191 | EventType::Remove => "remove", [INFO] [stderr] 192 | EventType::Unknown => "unknown", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/monitor.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | f.write_str(match self { [INFO] [stderr] | _____________________^ [INFO] [stderr] 189 | | &EventType::Add => "add", [INFO] [stderr] 190 | | &EventType::Change => "change", [INFO] [stderr] 191 | | &EventType::Remove => "remove", [INFO] [stderr] 192 | | &EventType::Unknown => "unknown", [INFO] [stderr] 193 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | f.write_str(match *self { [INFO] [stderr] 189 | EventType::Add => "add", [INFO] [stderr] 190 | EventType::Change => "change", [INFO] [stderr] 191 | EventType::Remove => "remove", [INFO] [stderr] 192 | EventType::Unknown => "unknown", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/list_devices.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.52s [INFO] running `"docker" "inspect" "ee0cfb77553e520abafaf07e670ce36cd4a3116e39635fbcefcb3bd798e86738"` [INFO] running `"docker" "rm" "-f" "ee0cfb77553e520abafaf07e670ce36cd4a3116e39635fbcefcb3bd798e86738"` [INFO] [stdout] ee0cfb77553e520abafaf07e670ce36cd4a3116e39635fbcefcb3bd798e86738