[INFO] crate uavcan-core 0.0.1 is already in cache [INFO] extracting crate uavcan-core 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/uavcan-core/0.0.1 [INFO] extracting crate uavcan-core 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uavcan-core/0.0.1 [INFO] validating manifest of uavcan-core-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of uavcan-core-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing uavcan-core-0.0.1 [INFO] finished frobbing uavcan-core-0.0.1 [INFO] frobbed toml for uavcan-core-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/uavcan-core/0.0.1/Cargo.toml [INFO] started frobbing uavcan-core-0.0.1 [INFO] finished frobbing uavcan-core-0.0.1 [INFO] frobbed toml for uavcan-core-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uavcan-core/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting uavcan-core-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/uavcan-core/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fcc178fdb9f3e15d7f3e0651920ea60693c2a5fadebf84baf2573afe2735e84a [INFO] running `"docker" "start" "-a" "fcc178fdb9f3e15d7f3e0651920ea60693c2a5fadebf84baf2573afe2735e84a"` [INFO] [stderr] Checking bit_field v0.8.0 [INFO] [stderr] Compiling syn v0.10.8 [INFO] [stderr] Compiling uavcan-derive v0.0.1 [INFO] [stderr] Checking uavcan-core v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serializer.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | structure: structure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structure` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_generator.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | transfer_id: transfer_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transfer_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serializer.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | structure: structure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structure` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_generator.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | transfer_id: transfer_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transfer_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `core::mem::transmute` [INFO] [stderr] --> src/types.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use core::mem::transmute; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:307:93 [INFO] [stderr] | [INFO] [stderr] 307 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:315:93 [INFO] [stderr] | [INFO] [stderr] 315 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:323:93 [INFO] [stderr] | [INFO] [stderr] 323 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:331:93 [INFO] [stderr] | [INFO] [stderr] 331 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:339:93 [INFO] [stderr] | [INFO] [stderr] 339 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:347:93 [INFO] [stderr] | [INFO] [stderr] 347 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u16); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:355:93 [INFO] [stderr] | [INFO] [stderr] 355 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u32); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:363:102 [INFO] [stderr] | [INFO] [stderr] 363 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.bitfield.set_bits((range.start as u8..range.end as u8), value as u16); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/headers.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return id; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/headers.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return id; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/headers.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return id; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crc.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return crc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `crc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crc.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return crc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `crc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crc.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return crc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `crc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/crc.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | crc = add_byte(crc, &( (data_type_signature >> 8*i) as u8) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `data_type_signature >> (8*i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return bits; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 102 | | if self.buffer.bit_length() >= 8 { [INFO] [stderr] 103 | | return Err(ParseError::StructureExhausted); [INFO] [stderr] 104 | | } else { [INFO] [stderr] 105 | | return Ok(self); [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | } else if self.buffer.bit_length() >= 8 { [INFO] [stderr] 102 | return Err(ParseError::StructureExhausted); [INFO] [stderr] 103 | } else { [INFO] [stderr] 104 | return Ok(self); [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `crc::calc` [INFO] [stderr] --> src/message_builder.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use crc::calc; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message_builder.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return Ok(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serializer.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | return SerializationResult::BufferFull; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SerializationResult::BufferFull` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serializer.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | return SerializationResult::Finished(buffer_next_bit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SerializationResult::Finished(buffer_next_bit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame_generator.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return Some(transport_frame); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(transport_frame)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/frame_generator.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 52 | | if let SerializationResult::Finished(i) = self.serializer.serialize(&mut transport_frame.data_as_mut()[0..max_data_length-1]){ [INFO] [stderr] 53 | | let frame_length = (i+7)/8 + 1; [INFO] [stderr] 54 | | transport_frame.set_data_length(frame_length); [INFO] [stderr] 55 | | transport_frame.data_as_mut()[frame_length-1] = TailByte{start_of_transfer: !self.started, end_of_transfer: true, toggle: self.toggle, transfer_id: self.transfer_id}.into(); [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | } else if let SerializationResult::Finished(i) = self.serializer.serialize(&mut transport_frame.data_as_mut()[0..max_data_length-1]){ [INFO] [stderr] 52 | let frame_length = (i+7)/8 + 1; [INFO] [stderr] 53 | transport_frame.set_data_length(frame_length); [INFO] [stderr] 54 | transport_frame.data_as_mut()[frame_length-1] = TailByte{start_of_transfer: !self.started, end_of_transfer: true, toggle: self.toggle, transfer_id: self.transfer_id}.into(); [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_bitmap` [INFO] [stderr] --> src/types.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn from_bitmap(bm: u16) -> f16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `add_byte` [INFO] [stderr] --> src/crc.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | fn add_byte(mut crc: u16, data: &u8) -> u16{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `add` [INFO] [stderr] --> src/crc.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn add(mut crc: u16, data: &[u8]) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `calc` [INFO] [stderr] --> src/crc.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn calc(data: &[u8], data_type_signature: u64) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `crc_calculated` [INFO] [stderr] --> src/message_builder.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | crc_calculated: u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/can_frame.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | CanID::Normal(x) => x as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:305:64 [INFO] [stderr] | [INFO] [stderr] 305 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:313:64 [INFO] [stderr] | [INFO] [stderr] 313 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:321:64 [INFO] [stderr] | [INFO] [stderr] 321 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:329:64 [INFO] [stderr] | [INFO] [stderr] 329 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:337:64 [INFO] [stderr] | [INFO] [stderr] 337 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:345:64 [INFO] [stderr] | [INFO] [stderr] 345 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:353:64 [INFO] [stderr] | [INFO] [stderr] 353 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:361:64 [INFO] [stderr] | [INFO] [stderr] 361 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.bitfield.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.bitfield.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:33:27 [INFO] [stderr] | [INFO] [stderr] 33 | id.set_bits(0..7, self.source_node as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.source_node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | id.set_bits(8..24, self.type_id as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.type_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | id.set_bits(24..29, self.priority as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.priority)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | id.set_bits(8..10, self.type_id as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.type_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | id.set_bits(10..24, self.discriminator as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.discriminator)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | id.set_bits(24..29, self.priority as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.priority)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:82:27 [INFO] [stderr] | [INFO] [stderr] 82 | id.set_bits(0..7, self.source_node as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.source_node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | id.set_bits(8..15, self.destination_node as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.destination_node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | id.set_bits(16..24, self.type_id as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.type_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | id.set_bits(24..29, self.priority as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.priority)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/crc.rs:1:33 [INFO] [stderr] | [INFO] [stderr] 1 | fn add_byte(mut crc: u16, data: &u8) -> u16{ [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/crc.rs:2:12 [INFO] [stderr] | [INFO] [stderr] 2 | crc ^= (*data as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(*data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this range is empty so this for loop will never run [INFO] [stderr] --> src/crc.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | for _bit in 8..1 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::reverse_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reverse_range_loop [INFO] [stderr] help: consider using the following if you are attempting to iterate over this range in reverse [INFO] [stderr] | [INFO] [stderr] 4 | for _bit in (1..8).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/crc.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | crc = crc << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `crc <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:40:73 [INFO] [stderr] | [INFO] [stderr] 40 | bits.set_bits(current_bit as u8..current_bit as u8 + 8, self.buffer.get_bits(current_bit..current_bit+8) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.buffer.get_bits(current_bit..current_bit+8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/parser.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | current_bit = current_bit + 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_bit += 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:43:68 [INFO] [stderr] | [INFO] [stderr] 43 | bits.set_bits(current_bit as u8..bit_length as u8, self.buffer.get_bits(current_bit..bit_length) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.buffer.get_bits(current_bit..bit_length))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/parser.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | current_bit = current_bit + 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_bit += 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn to_structure(self) -> T { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message_builder::MessageBuilder` [INFO] [stderr] --> src/message_builder.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Self { [INFO] [stderr] 39 | | MessageBuilder{ [INFO] [stderr] 40 | | parser: Parser::new(), [INFO] [stderr] 41 | | started: false, [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | impl Default for message_builder::MessageBuilder { [INFO] [stderr] 38 | fn default() -> Self { [INFO] [stderr] 39 | Self::new() [INFO] [stderr] 40 | } [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message_builder.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | self.crc.set_bits(0..8, frame.data()[0] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(frame.data()[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message_builder.rs:60:34 [INFO] [stderr] | [INFO] [stderr] 60 | .set_bits(8..16, frame.data()[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(frame.data()[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `uavcan-core`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `core::mem::transmute` [INFO] [stderr] --> src/types.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use core::mem::transmute; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:307:93 [INFO] [stderr] | [INFO] [stderr] 307 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:315:93 [INFO] [stderr] | [INFO] [stderr] 315 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:323:93 [INFO] [stderr] | [INFO] [stderr] 323 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:331:93 [INFO] [stderr] | [INFO] [stderr] 331 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:339:93 [INFO] [stderr] | [INFO] [stderr] 339 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:347:93 [INFO] [stderr] | [INFO] [stderr] 347 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u16); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:355:93 [INFO] [stderr] | [INFO] [stderr] 355 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.set_bits((range.start as u8..range.end as u8), value as u32); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/types.rs:363:102 [INFO] [stderr] | [INFO] [stderr] 363 | #[inline] fn set_bits(&mut self, range: Range, value: u64) { self.value.bitfield.set_bits((range.start as u8..range.end as u8), value as u16); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/headers.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return id; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/headers.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return id; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/headers.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return id; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crc.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return crc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `crc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crc.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return crc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `crc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/crc.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return crc; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `crc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/crc.rs:26:33 [INFO] [stderr] | [INFO] [stderr] 26 | crc = add_byte(crc, &( (data_type_signature >> 8*i) as u8) ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `data_type_signature >> (8*i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return bits; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 102 | | if self.buffer.bit_length() >= 8 { [INFO] [stderr] 103 | | return Err(ParseError::StructureExhausted); [INFO] [stderr] 104 | | } else { [INFO] [stderr] 105 | | return Ok(self); [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 101 | } else if self.buffer.bit_length() >= 8 { [INFO] [stderr] 102 | return Err(ParseError::StructureExhausted); [INFO] [stderr] 103 | } else { [INFO] [stderr] 104 | return Ok(self); [INFO] [stderr] 105 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/parser.rs:184:45 [INFO] [stderr] | [INFO] [stderr] 184 | parser = parser.parse(&[1, 0, 0, 0, 0b10001110, 5, 0]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1110` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `crc::calc` [INFO] [stderr] --> src/message_builder.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use crc::calc; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/message_builder.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | return Ok(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/message_builder.rs:138:125 [INFO] [stderr] | [INFO] [stderr] 138 | let can_frame = CanFrame{id: CanID::Extended(MessageFrameHeader::from_id(0xaa).to_id()), dlc: 8, data: [1, 0, 0, 0, 0b10001110, 5, 0, TailByte{start_of_transfer: true, end_of_transfer: true, toggle: false, transfer_id: 0}.into()]}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serializer.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | return SerializationResult::BufferFull; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SerializationResult::BufferFull` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/serializer.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | return SerializationResult::Finished(buffer_next_bit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SerializationResult::Finished(buffer_next_bit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:211:40 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(array, [1, 0, 0, 0, 0b10001110, 5, 0]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/frame_generator.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return Some(transport_frame); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(transport_frame)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/frame_generator.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 52 | | if let SerializationResult::Finished(i) = self.serializer.serialize(&mut transport_frame.data_as_mut()[0..max_data_length-1]){ [INFO] [stderr] 53 | | let frame_length = (i+7)/8 + 1; [INFO] [stderr] 54 | | transport_frame.set_data_length(frame_length); [INFO] [stderr] 55 | | transport_frame.data_as_mut()[frame_length-1] = TailByte{start_of_transfer: !self.started, end_of_transfer: true, toggle: self.toggle, transfer_id: self.transfer_id}.into(); [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 51 | } else if let SerializationResult::Finished(i) = self.serializer.serialize(&mut transport_frame.data_as_mut()[0..max_data_length-1]){ [INFO] [stderr] 52 | let frame_length = (i+7)/8 + 1; [INFO] [stderr] 53 | transport_frame.set_data_length(frame_length); [INFO] [stderr] 54 | transport_frame.data_as_mut()[frame_length-1] = TailByte{start_of_transfer: !self.started, end_of_transfer: true, toggle: self.toggle, transfer_id: self.transfer_id}.into(); [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_generator.rs:119:125 [INFO] [stderr] | [INFO] [stderr] 119 | let can_frame = CanFrame{id: CanID::Extended(MessageFrameHeader::from_id(0xaa).to_id()), dlc: 8, data: [1, 0, 0, 0, 0b10001110, 5, 0, TailByte{start_of_transfer: true, end_of_transfer: true, toggle: false, transfer_id: 0}.into()]}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_bitmap` [INFO] [stderr] --> src/types.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn from_bitmap(bm: u16) -> f16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `add_byte` [INFO] [stderr] --> src/crc.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | fn add_byte(mut crc: u16, data: &u8) -> u16{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `add` [INFO] [stderr] --> src/crc.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn add(mut crc: u16, data: &[u8]) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `calc` [INFO] [stderr] --> src/crc.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn calc(data: &[u8], data_type_signature: u64) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `crc_calculated` [INFO] [stderr] --> src/message_builder.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | crc_calculated: u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/can_frame.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | CanID::Normal(x) => x as u32, [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:305:64 [INFO] [stderr] | [INFO] [stderr] 305 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:313:64 [INFO] [stderr] | [INFO] [stderr] 313 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:321:64 [INFO] [stderr] | [INFO] [stderr] 321 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:329:64 [INFO] [stderr] | [INFO] [stderr] 329 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:337:64 [INFO] [stderr] | [INFO] [stderr] 337 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:345:64 [INFO] [stderr] | [INFO] [stderr] 345 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:353:64 [INFO] [stderr] | [INFO] [stderr] 353 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:361:64 [INFO] [stderr] | [INFO] [stderr] 361 | #[inline] fn get_bits(&self, range: Range) -> u64 { self.value.bitfield.get_bits(range.start as u8..range.end as u8) as u64} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.value.bitfield.get_bits(range.start as u8..range.end as u8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:33:27 [INFO] [stderr] | [INFO] [stderr] 33 | id.set_bits(0..7, self.source_node as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.source_node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | id.set_bits(8..24, self.type_id as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.type_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | id.set_bits(24..29, self.priority as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.priority)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | id.set_bits(8..10, self.type_id as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.type_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | id.set_bits(10..24, self.discriminator as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.discriminator)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | id.set_bits(24..29, self.priority as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.priority)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:82:27 [INFO] [stderr] | [INFO] [stderr] 82 | id.set_bits(0..7, self.source_node as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.source_node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:84:28 [INFO] [stderr] | [INFO] [stderr] 84 | id.set_bits(8..15, self.destination_node as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.destination_node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:86:29 [INFO] [stderr] | [INFO] [stderr] 86 | id.set_bits(16..24, self.type_id as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.type_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/headers.rs:87:29 [INFO] [stderr] | [INFO] [stderr] 87 | id.set_bits(24..29, self.priority as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.priority)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/crc.rs:1:33 [INFO] [stderr] | [INFO] [stderr] 1 | fn add_byte(mut crc: u16, data: &u8) -> u16{ [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/crc.rs:2:12 [INFO] [stderr] | [INFO] [stderr] 2 | crc ^= (*data as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(*data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this range is empty so this for loop will never run [INFO] [stderr] --> src/crc.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | for _bit in 8..1 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::reverse_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reverse_range_loop [INFO] [stderr] help: consider using the following if you are attempting to iterate over this range in reverse [INFO] [stderr] | [INFO] [stderr] 4 | for _bit in (1..8).rev() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/crc.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | crc = crc << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `crc <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:40:73 [INFO] [stderr] | [INFO] [stderr] 40 | bits.set_bits(current_bit as u8..current_bit as u8 + 8, self.buffer.get_bits(current_bit..current_bit+8) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.buffer.get_bits(current_bit..current_bit+8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/parser.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | current_bit = current_bit + 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_bit += 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:43:68 [INFO] [stderr] | [INFO] [stderr] 43 | bits.set_bits(current_bit as u8..bit_length as u8, self.buffer.get_bits(current_bit..bit_length) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.buffer.get_bits(current_bit..bit_length))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/parser.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | current_bit = current_bit + 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_bit += 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:115:25 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn to_structure(self) -> T { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `message_builder::MessageBuilder` [INFO] [stderr] --> src/message_builder.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> Self { [INFO] [stderr] 39 | | MessageBuilder{ [INFO] [stderr] 40 | | parser: Parser::new(), [INFO] [stderr] 41 | | started: false, [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | impl Default for message_builder::MessageBuilder { [INFO] [stderr] 38 | fn default() -> Self { [INFO] [stderr] 39 | Self::new() [INFO] [stderr] 40 | } [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message_builder.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | self.crc.set_bits(0..8, frame.data()[0] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(frame.data()[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/message_builder.rs:60:34 [INFO] [stderr] | [INFO] [stderr] 60 | .set_bits(8..16, frame.data()[1] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(frame.data()[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `uavcan-core`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fcc178fdb9f3e15d7f3e0651920ea60693c2a5fadebf84baf2573afe2735e84a"` [INFO] running `"docker" "rm" "-f" "fcc178fdb9f3e15d7f3e0651920ea60693c2a5fadebf84baf2573afe2735e84a"` [INFO] [stdout] fcc178fdb9f3e15d7f3e0651920ea60693c2a5fadebf84baf2573afe2735e84a