[INFO] crate uavcan 0.1.0-preview0 is already in cache [INFO] extracting crate uavcan 0.1.0-preview0 into work/ex/clippy-test-run/sources/stable/reg/uavcan/0.1.0-preview0 [INFO] extracting crate uavcan 0.1.0-preview0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uavcan/0.1.0-preview0 [INFO] validating manifest of uavcan-0.1.0-preview0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of uavcan-0.1.0-preview0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing uavcan-0.1.0-preview0 [INFO] finished frobbing uavcan-0.1.0-preview0 [INFO] frobbed toml for uavcan-0.1.0-preview0 written to work/ex/clippy-test-run/sources/stable/reg/uavcan/0.1.0-preview0/Cargo.toml [INFO] started frobbing uavcan-0.1.0-preview0 [INFO] finished frobbing uavcan-0.1.0-preview0 [INFO] frobbed toml for uavcan-0.1.0-preview0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uavcan/0.1.0-preview0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting uavcan-0.1.0-preview0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/uavcan/0.1.0-preview0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e38bad226348e3ede72fd14ef951f56245777114f03d56c3ebd2df0d53c94302 [INFO] running `"docker" "start" "-a" "e38bad226348e3ede72fd14ef951f56245777114f03d56c3ebd2df0d53c94302"` [INFO] [stderr] Checking embedded_types v0.3.2 [INFO] [stderr] Checking bit_field v0.8.0 [INFO] [stderr] Checking ux v0.0.1 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling memchr v2.1.3 [INFO] [stderr] Compiling aho-corasick v0.6.9 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Compiling uavcan-derive v0.1.0-preview0 [INFO] [stderr] Checking uavcan v0.1.0-preview0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transfer.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | mask: mask, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mask` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transfer.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/deserializer.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | Deserializer{structure: structure, field_index: 0, bit_index: 0} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serializer.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | structure: structure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_disassembler.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_disassembler.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | transfer_id: transfer_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transfer_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | interface: interface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | storage: storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `storage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:299:15 [INFO] [stderr] | [INFO] [stderr] 299 | Frame{id: id, body: body} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:299:23 [INFO] [stderr] | [INFO] [stderr] 299 | Frame{id: id, body: body} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:330:22 [INFO] [stderr] | [INFO] [stderr] 330 | CanFrame{id: id, dlc: 0, data: [0; 8]} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transfer.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | mask: mask, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mask` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transfer.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/deserializer.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | Deserializer{structure: structure, field_index: 0, bit_index: 0} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serializer.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | structure: structure, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `structure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_disassembler.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/frame_disassembler.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | transfer_id: transfer_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transfer_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | interface: interface, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interface` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:202:13 [INFO] [stderr] | [INFO] [stderr] 202 | storage: storage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `storage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:299:15 [INFO] [stderr] | [INFO] [stderr] 299 | Frame{id: id, body: body} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:299:23 [INFO] [stderr] | [INFO] [stderr] 299 | Frame{id: id, body: body} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:330:22 [INFO] [stderr] | [INFO] [stderr] 330 | CanFrame{id: id, dlc: 0, data: [0; 8]} [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/crc.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | crc.add_byte(&((data_type_signature >> 8*i) as u8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `data_type_signature >> (8*i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/crc.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | crc.add_byte(&((data_type_signature >> 8*i) as u8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `data_type_signature >> (8*i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/crc.rs:71:47 [INFO] [stderr] | [INFO] [stderr] 71 | let crc = TransferCRC::from_signature(0xd654a48e0c049d75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd654_a48e_0c04_9d75` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/deserializer.rs:95:52 [INFO] [stderr] | [INFO] [stderr] 95 | deserializer.deserialize(&mut [1, 0, 0, 0, 0b10011100, 5, 0]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_assembler.rs:156:90 [INFO] [stderr] | [INFO] [stderr] 156 | let can_frame = CanFrame{id: TransferFrameID::new(0), dlc: 8, data: [1, 0, 0, 0, 0b10011100, 5, 0, TailByte::new(true, true, false, TransferID::new(0)).into()]}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_assembler.rs:204:38 [INFO] [stderr] | [INFO] [stderr] 204 | id: TransferFrameID::new(4194080), [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_assembler.rs:210:38 [INFO] [stderr] | [INFO] [stderr] 210 | id: TransferFrameID::new(4194080), [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_assembler.rs:216:38 [INFO] [stderr] | [INFO] [stderr] 216 | id: TransferFrameID::new(4194080), [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_assembler.rs:222:38 [INFO] [stderr] | [INFO] [stderr] 222 | id: TransferFrameID::new(4194080), [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:236:30 [INFO] [stderr] | [INFO] [stderr] 236 | buffer.push_bits(15, 0b100000000000001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0b100_0000_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:239:41 [INFO] [stderr] | [INFO] [stderr] 239 | assert_eq!(buffer.pop_bits(15), 0b100000000000001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0b100_0000_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:249:42 [INFO] [stderr] | [INFO] [stderr] 249 | let float16: f16 = f16::from_f32(3.141592); [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:251:28 [INFO] [stderr] | [INFO] [stderr] 251 | let float64: f64 = 2.718281828459045235360; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `2.718_281_828_459_045_235_360` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:258:34 [INFO] [stderr] | [INFO] [stderr] 258 | assert_eq!(buffer.data, [0b01000000, 0, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:271:40 [INFO] [stderr] | [INFO] [stderr] 271 | assert_eq!(buffer.data, [1, 1, 0b01000000, 0]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:274:40 [INFO] [stderr] | [INFO] [stderr] 274 | assert_eq!(buffer.data, [1, 1, 0b01000000, 0b10000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:274:52 [INFO] [stderr] | [INFO] [stderr] 274 | assert_eq!(buffer.data, [1, 1, 0b01000000, 0b10000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:287:54 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(buffer.data[0..2], [f16::from_f32(3.141592).as_bits() as u8, (f16::from_f32(3.141592).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:287:96 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(buffer.data[0..2], [f16::from_f32(3.141592).as_bits() as u8, (f16::from_f32(3.141592).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^^ help: consider: `3.141_592` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:313:34 [INFO] [stderr] | [INFO] [stderr] 313 | assert_eq!(buffer.data, [0b10001001, 0, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:317:34 [INFO] [stderr] | [INFO] [stderr] 317 | assert_eq!(buffer.data, [0b11001001, 0b00001000, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:317:46 [INFO] [stderr] | [INFO] [stderr] 317 | assert_eq!(buffer.data, [0b11001001, 0b00001000, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:321:34 [INFO] [stderr] | [INFO] [stderr] 321 | assert_eq!(buffer.data, [0b10000001, 0b00000010, 0b00000100, 0b00010000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:321:46 [INFO] [stderr] | [INFO] [stderr] 321 | assert_eq!(buffer.data, [0b10000001, 0b00000010, 0b00000100, 0b00010000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:321:58 [INFO] [stderr] | [INFO] [stderr] 321 | assert_eq!(buffer.data, [0b10000001, 0b00000010, 0b00000100, 0b00010000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:321:70 [INFO] [stderr] | [INFO] [stderr] 321 | assert_eq!(buffer.data, [0b10000001, 0b00000010, 0b00000100, 0b00010000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:336:34 [INFO] [stderr] | [INFO] [stderr] 336 | assert_eq!(buffer.data, [0b00000011]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:340:34 [INFO] [stderr] | [INFO] [stderr] 340 | assert_eq!(buffer.data, [0b00000001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:344:34 [INFO] [stderr] | [INFO] [stderr] 344 | assert_eq!(buffer.data, [0b00000001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:348:83 [INFO] [stderr] | [INFO] [stderr] 348 | assert_eq!(buffer.data[0].get_bits((8 - buffer.stop_bit_index as u8)..8), 0b00000000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serializer.rs:434:46 [INFO] [stderr] | [INFO] [stderr] 434 | assert_eq!(buffer.data, [1, 0, 0, 0, 0b10011100, 5, 0]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_disassembler.rs:121:117 [INFO] [stderr] | [INFO] [stderr] 121 | let can_frame = CanFrame{id: TransferFrameID::from(TransferFrameID::new(87328)), dlc: 8, data: [1, 0, 0, 0, 0b10011100, 5, 0, TailByte::new(true, true, false, TransferID::new(0)).into()]}; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_disassembler.rs:166:50 [INFO] [stderr] | [INFO] [stderr] 166 | let crc = frame_generator.serializer.crc(0xd654a48e0c049d75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd654_a48e_0c04_9d75` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_disassembler.rs:172:42 [INFO] [stderr] | [INFO] [stderr] 172 | id: TransferFrameID::new(4194080), [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_disassembler.rs:181:42 [INFO] [stderr] | [INFO] [stderr] 181 | id: TransferFrameID::new(4194080), [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_disassembler.rs:190:42 [INFO] [stderr] | [INFO] [stderr] 190 | id: TransferFrameID::new(4194080), [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/frame_disassembler.rs:199:42 [INFO] [stderr] | [INFO] [stderr] 199 | id: TransferFrameID::new(4194080), [INFO] [stderr] | ^^^^^^^ help: consider: `4_194_080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/types.rs:697:19 [INFO] [stderr] | [INFO] [stderr] 697 | u64::from(f16::as_bits(self)) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/types.rs:697:19 [INFO] [stderr] | [INFO] [stderr] 697 | u64::from(f16::as_bits(self)) [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/deserializer.rs:215:65 [INFO] [stderr] | [INFO] [stderr] 215 | deserializer.deserialize(&mut [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/deserializer.rs:215:102 [INFO] [stderr] | [INFO] [stderr] 215 | deserializer.deserialize(&mut [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/deserializer.rs:215:151 [INFO] [stderr] | [INFO] [stderr] 215 | deserializer.deserialize(&mut [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/deserializer.rs:215:189 [INFO] [stderr] | [INFO] [stderr] 215 | deserializer.deserialize(&mut [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/deserializer.rs:249:65 [INFO] [stderr] | [INFO] [stderr] 249 | deserializer.deserialize(&mut [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/deserializer.rs:249:102 [INFO] [stderr] | [INFO] [stderr] 249 | deserializer.deserialize(&mut [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/deserializer.rs:249:151 [INFO] [stderr] | [INFO] [stderr] 249 | deserializer.deserialize(&mut [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/deserializer.rs:249:189 [INFO] [stderr] | [INFO] [stderr] 249 | deserializer.deserialize(&mut [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/serializer.rs:287:64 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(buffer.data[0..2], [f16::from_f32(3.141592).as_bits() as u8, (f16::from_f32(3.141592).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/serializer.rs:287:106 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(buffer.data[0..2], [f16::from_f32(3.141592).as_bits() as u8, (f16::from_f32(3.141592).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/serializer.rs:540:59 [INFO] [stderr] | [INFO] [stderr] 540 | assert_eq!(buffer.data, [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/serializer.rs:540:96 [INFO] [stderr] | [INFO] [stderr] 540 | assert_eq!(buffer.data, [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/serializer.rs:540:145 [INFO] [stderr] | [INFO] [stderr] 540 | assert_eq!(buffer.data, [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/serializer.rs:540:183 [INFO] [stderr] | [INFO] [stderr] 540 | assert_eq!(buffer.data, [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/serializer.rs:576:59 [INFO] [stderr] | [INFO] [stderr] 576 | assert_eq!(buffer.data, [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/serializer.rs:576:96 [INFO] [stderr] | [INFO] [stderr] 576 | assert_eq!(buffer.data, [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/serializer.rs:576:145 [INFO] [stderr] | [INFO] [stderr] 576 | assert_eq!(buffer.data, [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'half::f16::as_bits': renamed to to_bits [INFO] [stderr] --> src/serializer.rs:576:183 [INFO] [stderr] | [INFO] [stderr] 576 | assert_eq!(buffer.data, [0, 3, f16::from_f32(1.0).as_bits() as u8, (f16::from_f32(1.0).as_bits() >> 8) as u8, 1, 3, (f16::from_f32(1.0).as_bits() as u8), (f16::from_f32(1.0).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transfer.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn is_match(&self, value: TransferFrameID) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transfer.rs:355:30 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn start_of_transfer(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transfer.rs:361:28 [INFO] [stderr] | [INFO] [stderr] 361 | pub fn end_of_transfer(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transfer.rs:367:19 [INFO] [stderr] | [INFO] [stderr] 367 | pub fn toggle(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transfer.rs:373:24 [INFO] [stderr] | [INFO] [stderr] 373 | pub fn transfer_id(&self) -> TransferID { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transfer.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn is_match(&self, value: TransferFrameID) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transfer.rs:355:30 [INFO] [stderr] | [INFO] [stderr] 355 | pub fn start_of_transfer(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transfer.rs:361:28 [INFO] [stderr] | [INFO] [stderr] 361 | pub fn end_of_transfer(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transfer.rs:367:19 [INFO] [stderr] | [INFO] [stderr] 367 | pub fn toggle(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/transfer.rs:373:24 [INFO] [stderr] | [INFO] [stderr] 373 | pub fn transfer_id(&self) -> TransferID { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/types.rs:712:18 [INFO] [stderr] | [INFO] [stderr] 712 | unsafe { lib::core::mem::transmute::(v32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(v32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:715:9 [INFO] [stderr] | [INFO] [stderr] 715 | (unsafe { lib::core::mem::transmute::(self) }) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((unsafe { lib::core::mem::transmute::(self) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/types.rs:731:18 [INFO] [stderr] | [INFO] [stderr] 731 | unsafe { lib::core::mem::transmute(v) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/crc.rs:13:34 [INFO] [stderr] | [INFO] [stderr] 13 | fn add_byte(&mut self, data: &u8) { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/crc.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match self { [INFO] [stderr] 15 | | &mut TransferCRC(ref mut value) => { [INFO] [stderr] 16 | | [INFO] [stderr] 17 | | *value ^= (*data as u16) << 8; [INFO] [stderr] ... | [INFO] [stderr] 26 | | }, [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *self { [INFO] [stderr] 15 | TransferCRC(ref mut value) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/crc.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | *value ^= (*data as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(*data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame_assembler.rs:80:60 [INFO] [stderr] | [INFO] [stderr] 80 | self.crc_received = Some(TransferCRC::from((frame.data()[0] as u16) | (frame.data()[1] as u16) << 8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(frame.data()[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame_assembler.rs:80:87 [INFO] [stderr] | [INFO] [stderr] 80 | self.crc_received = Some(TransferCRC::from((frame.data()[0] as u16) | (frame.data()[1] as u16) << 8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(frame.data()[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serializer.rs:51:51 [INFO] [stderr] | [INFO] [stderr] 51 | bits.set_bits(0..(8-bit_start as u8), self.data[byte_start].get_bits(0..(8-bit_start as u8)) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data[byte_start].get_bits(0..(8-bit_start as u8)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serializer.rs:55:54 [INFO] [stderr] | [INFO] [stderr] 55 | bits.set_bits(0..(remaining_bits as u8), self.data[byte_start].get_bits(((8 - bit_start - remaining_bits) as u8)..(8 - bit_start as u8)) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data[byte_start].get_bits(((8 - bit_start - remaining_bits) as u8)..(8 - bit_start as u8)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serializer.rs:64:61 [INFO] [stderr] | [INFO] [stderr] 64 | bits.set_bits((bit as u8)..(bit as u8 + 8), self.data[self.start_bit_index/8] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data[self.start_bit_index/8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serializer.rs:68:64 [INFO] [stderr] | [INFO] [stderr] 68 | bits.set_bits((bit as u8)..(bit_length as u8), self.data[self.start_bit_index/8].get_bits((8 - remaining_bits as u8)..8) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data[self.start_bit_index/8].get_bits((8 - remaining_bits as u8)..8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/node.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | Err(_) => panic!("Unexpected error from FrameAssembler"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/node.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | Err(_) => panic!("Unexpected error from FrameAssembler"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/storage/mod.rs:52:34 [INFO] [stderr] | [INFO] [stderr] 52 | fn remove(&self, identifier: &TransferFrameID) -> Option; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TransferFrameID` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/types.rs:712:18 [INFO] [stderr] | [INFO] [stderr] 712 | unsafe { lib::core::mem::transmute::(v32) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(v32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/types.rs:715:9 [INFO] [stderr] | [INFO] [stderr] 715 | (unsafe { lib::core::mem::transmute::(self) }) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((unsafe { lib::core::mem::transmute::(self) }))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/types.rs:731:18 [INFO] [stderr] | [INFO] [stderr] 731 | unsafe { lib::core::mem::transmute(v) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/crc.rs:13:34 [INFO] [stderr] | [INFO] [stderr] 13 | fn add_byte(&mut self, data: &u8) { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/crc.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match self { [INFO] [stderr] 15 | | &mut TransferCRC(ref mut value) => { [INFO] [stderr] 16 | | [INFO] [stderr] 17 | | *value ^= (*data as u16) << 8; [INFO] [stderr] ... | [INFO] [stderr] 26 | | }, [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *self { [INFO] [stderr] 15 | TransferCRC(ref mut value) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/crc.rs:17:27 [INFO] [stderr] | [INFO] [stderr] 17 | *value ^= (*data as u16) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(*data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/deserializer.rs:127:61 [INFO] [stderr] | [INFO] [stderr] 127 | text1: Dynamic::<[u8; 7]>::with_data("test".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/deserializer.rs:128:61 [INFO] [stderr] | [INFO] [stderr] 128 | text2: Dynamic::<[u8; 8]>::with_data("lol".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"lol"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame_assembler.rs:80:60 [INFO] [stderr] | [INFO] [stderr] 80 | self.crc_received = Some(TransferCRC::from((frame.data()[0] as u16) | (frame.data()[1] as u16) << 8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(frame.data()[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/frame_assembler.rs:80:87 [INFO] [stderr] | [INFO] [stderr] 80 | self.crc_received = Some(TransferCRC::from((frame.data()[0] as u16) | (frame.data()[1] as u16) << 8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(frame.data()[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/frame_assembler.rs:196:52 [INFO] [stderr] | [INFO] [stderr] 196 | source: Dynamic::<[u8; 31]>::with_data("test source".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test source"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/frame_assembler.rs:197:50 [INFO] [stderr] | [INFO] [stderr] 197 | text: Dynamic::<[u8; 90]>::with_data("test text".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test text"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serializer.rs:51:51 [INFO] [stderr] | [INFO] [stderr] 51 | bits.set_bits(0..(8-bit_start as u8), self.data[byte_start].get_bits(0..(8-bit_start as u8)) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data[byte_start].get_bits(0..(8-bit_start as u8)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serializer.rs:55:54 [INFO] [stderr] | [INFO] [stderr] 55 | bits.set_bits(0..(remaining_bits as u8), self.data[byte_start].get_bits(((8 - bit_start - remaining_bits) as u8)..(8 - bit_start as u8)) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data[byte_start].get_bits(((8 - bit_start - remaining_bits) as u8)..(8 - bit_start as u8)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serializer.rs:64:61 [INFO] [stderr] | [INFO] [stderr] 64 | bits.set_bits((bit as u8)..(bit as u8 + 8), self.data[self.start_bit_index/8] as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data[self.start_bit_index/8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/serializer.rs:68:64 [INFO] [stderr] | [INFO] [stderr] 68 | bits.set_bits((bit as u8)..(bit_length as u8), self.data[self.start_bit_index/8].get_bits((8 - remaining_bits as u8)..8) as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data[self.start_bit_index/8].get_bits((8 - remaining_bits as u8)..8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/serializer.rs:249:42 [INFO] [stderr] | [INFO] [stderr] 249 | let float16: f16 = f16::from_f32(3.141592); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/serializer.rs:251:28 [INFO] [stderr] | [INFO] [stderr] 251 | let float64: f64 = 2.718281828459045235360; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.718_281_828_459_045` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/serializer.rs:287:54 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(buffer.data[0..2], [f16::from_f32(3.141592).as_bits() as u8, (f16::from_f32(3.141592).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/serializer.rs:287:96 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(buffer.data[0..2], [f16::from_f32(3.141592).as_bits() as u8, (f16::from_f32(3.141592).as_bits() >> 8) as u8]); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/frame_disassembler.rs:121:38 [INFO] [stderr] | [INFO] [stderr] 121 | let can_frame = CanFrame{id: TransferFrameID::from(TransferFrameID::new(87328)), dlc: 8, data: [1, 0, 0, 0, 0b10011100, 5, 0, TailByte::new(true, true, false, TransferID::new(0)).into()]}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `TransferFrameID::from()`: `TransferFrameID::new(87328)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/frame_disassembler.rs:160:52 [INFO] [stderr] | [INFO] [stderr] 160 | source: Dynamic::<[u8; 31]>::with_data("test source".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test source"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/frame_disassembler.rs:161:50 [INFO] [stderr] | [INFO] [stderr] 161 | text: Dynamic::<[u8; 90]>::with_data("test text".as_bytes()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test text"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/node.rs:133:21 [INFO] [stderr] | [INFO] [stderr] 133 | Err(_) => panic!("Unexpected error from FrameAssembler"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/node.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | Err(_) => panic!("Unexpected error from FrameAssembler"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/storage/mod.rs:52:34 [INFO] [stderr] | [INFO] [stderr] 52 | fn remove(&self, identifier: &TransferFrameID) -> Option; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `TransferFrameID` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `uavcan`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e38bad226348e3ede72fd14ef951f56245777114f03d56c3ebd2df0d53c94302"` [INFO] running `"docker" "rm" "-f" "e38bad226348e3ede72fd14ef951f56245777114f03d56c3ebd2df0d53c94302"` [INFO] [stdout] e38bad226348e3ede72fd14ef951f56245777114f03d56c3ebd2df0d53c94302