[INFO] crate uap-rust 0.0.4 is already in cache [INFO] extracting crate uap-rust 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/uap-rust/0.0.4 [INFO] extracting crate uap-rust 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uap-rust/0.0.4 [INFO] validating manifest of uap-rust-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of uap-rust-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing uap-rust-0.0.4 [INFO] finished frobbing uap-rust-0.0.4 [INFO] frobbed toml for uap-rust-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/uap-rust/0.0.4/Cargo.toml [INFO] started frobbing uap-rust-0.0.4 [INFO] finished frobbing uap-rust-0.0.4 [INFO] frobbed toml for uap-rust-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/uap-rust/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting uap-rust-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/uap-rust/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8f3ac5235eed5b21c31a316fed513db0185c75da9efc1aac0ae1fdec00f157f [INFO] running `"docker" "start" "-a" "d8f3ac5235eed5b21c31a316fed513db0185c75da9efc1aac0ae1fdec00f157f"` [INFO] [stderr] Checking uap-rust v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ua.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ua.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ua.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ua.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | patch_minor: patch_minor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `patch_minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | brand: brand, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `brand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ua.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ua.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ua.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ua.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | major: major, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `major` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | minor: minor, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | patch: patch, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `patch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/os.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | patch_minor: patch_minor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `patch_minor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | family: family, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `family` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | brand: brand, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `brand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/device.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/device.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | captures.iter().zip((0..captures.len())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/device.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | captures.iter().zip((0..captures.len())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/device.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | captures.iter().zip((0..captures.len())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/device.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | captures.iter().zip((0..captures.len())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 38 | | //Parse the yaml. [INFO] [stderr] 39 | | let docs = try!(YamlLoader::load_from_str(&s)); [INFO] [stderr] 40 | | let p = Parser { [INFO] [stderr] ... | [INFO] [stderr] 48 | | Ok(p) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ua.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | .unwrap_or(c.at(1).unwrap_or("Other").to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| c.at(1).unwrap_or("Other").to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/ua.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | .or(c.at(2).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(2).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/ua.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | .or(c.at(3).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(3).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/ua.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | .or(c.at(4).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(4).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/os.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | .unwrap_or(c.at(1).unwrap_or("Other").to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| c.at(1).unwrap_or("Other").to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/os.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | .or(c.at(2).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(2).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/os.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | .or(c.at(3).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(3).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/os.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | .or(c.at(4).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(4).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/os.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | .or(c.at(5).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(5).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: It is more idiomatic to use captures.iter().enumerate() [INFO] [stderr] --> src/device.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | captures.iter().zip((0..captures.len())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_zip_with_len)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_zip_with_len [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/device.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | .unwrap_or(c.at(1).unwrap_or("Other").to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| c.at(1).unwrap_or("Other").to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/device.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | .or(c.at(1).map(|s| s.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(1).map(|s| s.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/device.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | .or(c.at(1).map(|s| s.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(1).map(|s| s.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/result.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | Error::new(format!("{}", err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/yaml.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | arr.as_vec().map(|a| a.iter().filter_map(f).collect()).unwrap_or(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `arr.as_vec().map(|a| a.iter().filter_map(f).collect()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn from_str(s: &str) -> Result { [INFO] [stderr] 38 | | //Parse the yaml. [INFO] [stderr] 39 | | let docs = try!(YamlLoader::load_from_str(&s)); [INFO] [stderr] 40 | | let p = Parser { [INFO] [stderr] ... | [INFO] [stderr] 48 | | Ok(p) [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ua.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | .unwrap_or(c.at(1).unwrap_or("Other").to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| c.at(1).unwrap_or("Other").to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/ua.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | .or(c.at(2).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(2).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/ua.rs:50:18 [INFO] [stderr] | [INFO] [stderr] 50 | .or(c.at(3).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(3).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/ua.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | .or(c.at(4).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(4).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/os.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | .unwrap_or(c.at(1).unwrap_or("Other").to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| c.at(1).unwrap_or("Other").to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/os.rs:49:18 [INFO] [stderr] | [INFO] [stderr] 49 | .or(c.at(2).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(2).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/os.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | .or(c.at(3).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(3).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/os.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | .or(c.at(4).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(4).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/os.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | .or(c.at(5).map(String::from)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(5).map(String::from))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: It is more idiomatic to use captures.iter().enumerate() [INFO] [stderr] --> src/device.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | captures.iter().zip((0..captures.len())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_zip_with_len)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_zip_with_len [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/device.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | .unwrap_or(c.at(1).unwrap_or("Other").to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| c.at(1).unwrap_or("Other").to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/device.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | .or(c.at(1).map(|s| s.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(1).map(|s| s.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/device.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | .or(c.at(1).map(|s| s.to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| c.at(1).map(|s| s.to_string()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/result.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | Error::new(format!("{}", err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/yaml.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | arr.as_vec().map(|a| a.iter().filter_map(f).collect()).unwrap_or(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `arr.as_vec().map(|a| a.iter().filter_map(f).collect()).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | assert!(p.devices_regex.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!p.devices_regex.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | assert!(p.devices_regex.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!p.devices_regex.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | assert!(p.devices_regex.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!p.devices_regex.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/lib.rs:203:26 [INFO] [stderr] | [INFO] [stderr] 203 | let parsed = actual.clone().unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `actual.clone().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.58s [INFO] running `"docker" "inspect" "d8f3ac5235eed5b21c31a316fed513db0185c75da9efc1aac0ae1fdec00f157f"` [INFO] running `"docker" "rm" "-f" "d8f3ac5235eed5b21c31a316fed513db0185c75da9efc1aac0ae1fdec00f157f"` [INFO] [stdout] d8f3ac5235eed5b21c31a316fed513db0185c75da9efc1aac0ae1fdec00f157f