[INFO] crate tztail 1.2.0 is already in cache [INFO] extracting crate tztail 1.2.0 into work/ex/clippy-test-run/sources/stable/reg/tztail/1.2.0 [INFO] extracting crate tztail 1.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tztail/1.2.0 [INFO] validating manifest of tztail-1.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tztail-1.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tztail-1.2.0 [INFO] finished frobbing tztail-1.2.0 [INFO] frobbed toml for tztail-1.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tztail/1.2.0/Cargo.toml [INFO] started frobbing tztail-1.2.0 [INFO] finished frobbing tztail-1.2.0 [INFO] frobbed toml for tztail-1.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tztail/1.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tztail-1.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tztail/1.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1c13a72adcabb9ca4fe229da40a5d4341d788737dc98c32fa55e79845b02bd5 [INFO] running `"docker" "start" "-a" "a1c13a72adcabb9ca4fe229da40a5d4341d788737dc98c32fa55e79845b02bd5"` [INFO] [stderr] Compiling escargot v0.3.1 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking serde v1.0.85 [INFO] [stderr] Compiling parse-zoneinfo v0.2.0 [INFO] [stderr] Checking predicates v1.0.0 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Compiling chrono-tz v0.5.0 [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking assert_cmd v0.10.2 [INFO] [stderr] Checking tztail v1.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/converter.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | formats: formats, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `formats` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/converter.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | timezone: timezone, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `timezone` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | re: re, [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | first_line: first_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | first_line: first_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/converter.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | formats: formats, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `formats` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/converter.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | timezone: timezone, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `timezone` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | re: re, [INFO] [stderr] | ^^^^^^ help: replace it with: `re` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | first_line: first_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | first_line: first_line, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `first_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/args.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | / return if atty::is(Stream::Stdout) { [INFO] [stderr] 54 | | OutputFormatter::colored() [INFO] [stderr] 55 | | } else { [INFO] [stderr] 56 | | OutputFormatter::plain() [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | if atty::is(Stream::Stdout) { [INFO] [stderr] 54 | OutputFormatter::colored() [INFO] [stderr] 55 | } else { [INFO] [stderr] 56 | OutputFormatter::plain() [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/converter.rs:45:19 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(tz) => return Some(tz), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(tz)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/converter.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/converter.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / return TimedLog { [INFO] [stderr] 162 | | converted: false, [INFO] [stderr] 163 | | log: input, [INFO] [stderr] 164 | | original_time: None, [INFO] [stderr] 165 | | target_time: None, [INFO] [stderr] 166 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 161 | TimedLog { [INFO] [stderr] 162 | converted: false, [INFO] [stderr] 163 | log: input, [INFO] [stderr] 164 | original_time: None, [INFO] [stderr] 165 | target_time: None, [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/converter.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / return dt [INFO] [stderr] 182 | | .with_timezone(&tz) [INFO] [stderr] 183 | | .format("%Y-%m-%d %H:%M:%S %z") [INFO] [stderr] 184 | | .to_string(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 181 | dt [INFO] [stderr] 182 | .with_timezone(&tz) [INFO] [stderr] 183 | .format("%Y-%m-%d %H:%M:%S %z") [INFO] [stderr] 184 | .to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return self.re.find(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.re.find(input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | return self.timezone_aware; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.timezone_aware` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return &self.fmt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.fmt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / return Format { [INFO] [stderr] 32 | | fmt: String::from(fmt), [INFO] [stderr] 33 | | re: re, [INFO] [stderr] 34 | | timezone_aware: format_has_timezone(fmt), [INFO] [stderr] 35 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 31 | Format { [INFO] [stderr] 32 | fmt: String::from(fmt), [INFO] [stderr] 33 | re: re, [INFO] [stderr] 34 | timezone_aware: format_has_timezone(fmt), [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return Regex::new(®ex_str).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Regex::new(®ex_str).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format.rs:59:27 [INFO] [stderr] | [INFO] [stderr] 59 | const FORMAT_TO_REGEX: [(&'static str, &'static str); 51] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | const FORMAT_TO_REGEX: [(&'static str, &'static str); 51] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | return Err(format!("Exited while reading lines: {}", err)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Exited while reading lines: {}", err))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/args.rs:53:17 [INFO] [stderr] | [INFO] [stderr] 53 | / return if atty::is(Stream::Stdout) { [INFO] [stderr] 54 | | OutputFormatter::colored() [INFO] [stderr] 55 | | } else { [INFO] [stderr] 56 | | OutputFormatter::plain() [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | if atty::is(Stream::Stdout) { [INFO] [stderr] 54 | OutputFormatter::colored() [INFO] [stderr] 55 | } else { [INFO] [stderr] 56 | OutputFormatter::plain() [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/converter.rs:45:19 [INFO] [stderr] | [INFO] [stderr] 45 | Ok(tz) => return Some(tz), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(tz)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/converter.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/converter.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / return TimedLog { [INFO] [stderr] 162 | | converted: false, [INFO] [stderr] 163 | | log: input, [INFO] [stderr] 164 | | original_time: None, [INFO] [stderr] 165 | | target_time: None, [INFO] [stderr] 166 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 161 | TimedLog { [INFO] [stderr] 162 | converted: false, [INFO] [stderr] 163 | log: input, [INFO] [stderr] 164 | original_time: None, [INFO] [stderr] 165 | target_time: None, [INFO] [stderr] 166 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/converter.rs:181:5 [INFO] [stderr] | [INFO] [stderr] 181 | / return dt [INFO] [stderr] 182 | | .with_timezone(&tz) [INFO] [stderr] 183 | | .format("%Y-%m-%d %H:%M:%S %z") [INFO] [stderr] 184 | | .to_string(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 181 | dt [INFO] [stderr] 182 | .with_timezone(&tz) [INFO] [stderr] 183 | .format("%Y-%m-%d %H:%M:%S %z") [INFO] [stderr] 184 | .to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/converter.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | / return super::Utc [INFO] [stderr] 231 | | .datetime_from_str(input, format) [INFO] [stderr] 232 | | .unwrap() [INFO] [stderr] 233 | | .with_timezone(&local_timezone) [INFO] [stderr] 234 | | .format(format) [INFO] [stderr] 235 | | .to_string(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 230 | super::Utc [INFO] [stderr] 231 | .datetime_from_str(input, format) [INFO] [stderr] 232 | .unwrap() [INFO] [stderr] 233 | .with_timezone(&local_timezone) [INFO] [stderr] 234 | .format(format) [INFO] [stderr] 235 | .to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/converter.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | / return DateTime::parse_from_str(input, format) [INFO] [stderr] 241 | | .unwrap() [INFO] [stderr] 242 | | .with_timezone(&local_timezone) [INFO] [stderr] 243 | | .format(format) [INFO] [stderr] 244 | | .to_string(); [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 240 | DateTime::parse_from_str(input, format) [INFO] [stderr] 241 | .unwrap() [INFO] [stderr] 242 | .with_timezone(&local_timezone) [INFO] [stderr] 243 | .format(format) [INFO] [stderr] 244 | .to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return self.re.find(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.re.find(input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | return self.timezone_aware; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.timezone_aware` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return &self.fmt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.fmt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / return Format { [INFO] [stderr] 32 | | fmt: String::from(fmt), [INFO] [stderr] 33 | | re: re, [INFO] [stderr] 34 | | timezone_aware: format_has_timezone(fmt), [INFO] [stderr] 35 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 31 | Format { [INFO] [stderr] 32 | fmt: String::from(fmt), [INFO] [stderr] 33 | re: re, [INFO] [stderr] 34 | timezone_aware: format_has_timezone(fmt), [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return Regex::new(®ex_str).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Regex::new(®ex_str).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/format.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format.rs:59:27 [INFO] [stderr] | [INFO] [stderr] 59 | const FORMAT_TO_REGEX: [(&'static str, &'static str); 51] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/format.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | const FORMAT_TO_REGEX: [(&'static str, &'static str); 51] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | return Err(format!("Exited while reading lines: {}", err)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Exited while reading lines: {}", err))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/integration_tests.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / return DateTime::parse_from_str(input, format) [INFO] [stderr] 30 | | .unwrap() [INFO] [stderr] 31 | | .with_timezone(&local_timezone) [INFO] [stderr] 32 | | .format(format) [INFO] [stderr] 33 | | .to_string(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | DateTime::parse_from_str(input, format) [INFO] [stderr] 30 | .unwrap() [INFO] [stderr] 31 | .with_timezone(&local_timezone) [INFO] [stderr] 32 | .format(format) [INFO] [stderr] 33 | .to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/converter.rs:390:43 [INFO] [stderr] | [INFO] [stderr] 390 | target_time: Some(String::from(local_timezone_case_1)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `local_timezone_case_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/converter.rs:396:43 [INFO] [stderr] | [INFO] [stderr] 396 | target_time: Some(String::from(local_timezone_case_2)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `local_timezone_case_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.24s [INFO] running `"docker" "inspect" "a1c13a72adcabb9ca4fe229da40a5d4341d788737dc98c32fa55e79845b02bd5"` [INFO] running `"docker" "rm" "-f" "a1c13a72adcabb9ca4fe229da40a5d4341d788737dc98c32fa55e79845b02bd5"` [INFO] [stdout] a1c13a72adcabb9ca4fe229da40a5d4341d788737dc98c32fa55e79845b02bd5