[INFO] crate tzdata 0.4.1 is already in cache [INFO] extracting crate tzdata 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/tzdata/0.4.1 [INFO] extracting crate tzdata 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tzdata/0.4.1 [INFO] validating manifest of tzdata-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tzdata-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tzdata-0.4.1 [INFO] finished frobbing tzdata-0.4.1 [INFO] frobbed toml for tzdata-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/tzdata/0.4.1/Cargo.toml [INFO] started frobbing tzdata-0.4.1 [INFO] finished frobbing tzdata-0.4.1 [INFO] frobbed toml for tzdata-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tzdata/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tzdata-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tzdata/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9dfe2f25f08e697801f41e724f8aafcc10646d7739a7222864a49589805c5b8b [INFO] running `"docker" "start" "-a" "9dfe2f25f08e697801f41e724f8aafcc10646d7739a7222864a49589805c5b8b"` [INFO] [stderr] Checking tzdata v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:71:45 [INFO] [stderr] | [INFO] [stderr] 71 | off: off, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:71:45 [INFO] [stderr] | [INFO] [stderr] 71 | off: off, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | is_dst: is_dst, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `is_dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | trule: trule, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:72:45 [INFO] [stderr] | [INFO] [stderr] 72 | is_dst: is_dst, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `is_dst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | trule: trule, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trule` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | stamp: stamp, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | tz: tz, [INFO] [stderr] | ^^^^^^ help: replace it with: `tz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | stamp: stamp, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | tz: tz, [INFO] [stderr] | ^^^^^^ help: replace it with: `tz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1065:55 [INFO] [stderr] | [INFO] [stderr] 1065 | fn s(y: i32, mo: i32, d: i32, h: i32, m: i32, s: i32) -> i64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:1065:55 [INFO] [stderr] | [INFO] [stderr] 1065 | fn s(y: i32, mo: i32, d: i32, h: i32, m: i32, s: i32) -> i64 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:262:28 [INFO] [stderr] | [INFO] [stderr] 262 | const DAYS_MONTH: &'static [i32] = &[0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:792:26 [INFO] [stderr] | [INFO] [stderr] 792 | const NTP_TO_UNIX: i64 = 2208988800; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_208_988_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:793:22 [INFO] [stderr] | [INFO] [stderr] 793 | const LEAP_SECONDS: &'static [i64] = &[2272060800 - NTP_TO_UNIX, [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:793:40 [INFO] [stderr] | [INFO] [stderr] 793 | const LEAP_SECONDS: &'static [i64] = &[2272060800 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_272_060_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:794:40 [INFO] [stderr] | [INFO] [stderr] 794 | 2287785600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_287_785_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:795:40 [INFO] [stderr] | [INFO] [stderr] 795 | 2303683200 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_303_683_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:796:40 [INFO] [stderr] | [INFO] [stderr] 796 | 2335219200 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_335_219_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:797:40 [INFO] [stderr] | [INFO] [stderr] 797 | 2366755200 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_366_755_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:798:40 [INFO] [stderr] | [INFO] [stderr] 798 | 2398291200 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_398_291_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:799:40 [INFO] [stderr] | [INFO] [stderr] 799 | 2429913600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_429_913_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:800:40 [INFO] [stderr] | [INFO] [stderr] 800 | 2461449600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_461_449_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:801:40 [INFO] [stderr] | [INFO] [stderr] 801 | 2492985600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_492_985_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:802:40 [INFO] [stderr] | [INFO] [stderr] 802 | 2524521600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_524_521_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:803:40 [INFO] [stderr] | [INFO] [stderr] 803 | 2571782400 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_571_782_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:804:40 [INFO] [stderr] | [INFO] [stderr] 804 | 2603318400 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_603_318_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:805:40 [INFO] [stderr] | [INFO] [stderr] 805 | 2634854400 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_634_854_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:806:40 [INFO] [stderr] | [INFO] [stderr] 806 | 2698012800 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_698_012_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:807:40 [INFO] [stderr] | [INFO] [stderr] 807 | 2776982400 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_776_982_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:808:40 [INFO] [stderr] | [INFO] [stderr] 808 | 2840140800 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_840_140_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:809:40 [INFO] [stderr] | [INFO] [stderr] 809 | 2871676800 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_871_676_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:810:40 [INFO] [stderr] | [INFO] [stderr] 810 | 2918937600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_918_937_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:811:40 [INFO] [stderr] | [INFO] [stderr] 811 | 2950473600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_950_473_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:812:40 [INFO] [stderr] | [INFO] [stderr] 812 | 2982009600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_982_009_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:813:40 [INFO] [stderr] | [INFO] [stderr] 813 | 3029443200 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_029_443_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:814:40 [INFO] [stderr] | [INFO] [stderr] 814 | 3076704000 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_076_704_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:815:40 [INFO] [stderr] | [INFO] [stderr] 815 | 3124137600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_124_137_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:816:40 [INFO] [stderr] | [INFO] [stderr] 816 | 3345062400 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_345_062_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:817:40 [INFO] [stderr] | [INFO] [stderr] 817 | 3439756800 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_439_756_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:818:40 [INFO] [stderr] | [INFO] [stderr] 818 | 3550089600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_550_089_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:819:40 [INFO] [stderr] | [INFO] [stderr] 819 | 3644697600 - NTP_TO_UNIX]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_644_697_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/parse.rs:7:21 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::{self, Read, BufReader, Seek, SeekFrom}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Seek` [INFO] [stderr] --> src/parse.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::{self, Read, BufReader, Seek, SeekFrom}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:262:28 [INFO] [stderr] | [INFO] [stderr] 262 | const DAYS_MONTH: &'static [i32] = &[0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]; [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:792:26 [INFO] [stderr] | [INFO] [stderr] 792 | const NTP_TO_UNIX: i64 = 2208988800; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_208_988_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:793:22 [INFO] [stderr] | [INFO] [stderr] 793 | const LEAP_SECONDS: &'static [i64] = &[2272060800 - NTP_TO_UNIX, [INFO] [stderr] | -^^^^^^^------ help: consider removing `'static`: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:793:40 [INFO] [stderr] | [INFO] [stderr] 793 | const LEAP_SECONDS: &'static [i64] = &[2272060800 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_272_060_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:794:40 [INFO] [stderr] | [INFO] [stderr] 794 | 2287785600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_287_785_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:795:40 [INFO] [stderr] | [INFO] [stderr] 795 | 2303683200 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_303_683_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:796:40 [INFO] [stderr] | [INFO] [stderr] 796 | 2335219200 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_335_219_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:797:40 [INFO] [stderr] | [INFO] [stderr] 797 | 2366755200 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_366_755_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:798:40 [INFO] [stderr] | [INFO] [stderr] 798 | 2398291200 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_398_291_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:799:40 [INFO] [stderr] | [INFO] [stderr] 799 | 2429913600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_429_913_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:800:40 [INFO] [stderr] | [INFO] [stderr] 800 | 2461449600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_461_449_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:801:40 [INFO] [stderr] | [INFO] [stderr] 801 | 2492985600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_492_985_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:802:40 [INFO] [stderr] | [INFO] [stderr] 802 | 2524521600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_524_521_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:803:40 [INFO] [stderr] | [INFO] [stderr] 803 | 2571782400 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_571_782_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:804:40 [INFO] [stderr] | [INFO] [stderr] 804 | 2603318400 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_603_318_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:805:40 [INFO] [stderr] | [INFO] [stderr] 805 | 2634854400 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_634_854_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:806:40 [INFO] [stderr] | [INFO] [stderr] 806 | 2698012800 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_698_012_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:807:40 [INFO] [stderr] | [INFO] [stderr] 807 | 2776982400 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_776_982_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:808:40 [INFO] [stderr] | [INFO] [stderr] 808 | 2840140800 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_840_140_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:809:40 [INFO] [stderr] | [INFO] [stderr] 809 | 2871676800 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_871_676_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:810:40 [INFO] [stderr] | [INFO] [stderr] 810 | 2918937600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_918_937_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:811:40 [INFO] [stderr] | [INFO] [stderr] 811 | 2950473600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_950_473_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:812:40 [INFO] [stderr] | [INFO] [stderr] 812 | 2982009600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_982_009_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:813:40 [INFO] [stderr] | [INFO] [stderr] 813 | 3029443200 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_029_443_200` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:814:40 [INFO] [stderr] | [INFO] [stderr] 814 | 3076704000 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_076_704_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:815:40 [INFO] [stderr] | [INFO] [stderr] 815 | 3124137600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_124_137_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:816:40 [INFO] [stderr] | [INFO] [stderr] 816 | 3345062400 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_345_062_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:817:40 [INFO] [stderr] | [INFO] [stderr] 817 | 3439756800 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_439_756_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:818:40 [INFO] [stderr] | [INFO] [stderr] 818 | 3550089600 - NTP_TO_UNIX, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_550_089_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:819:40 [INFO] [stderr] | [INFO] [stderr] 819 | 3644697600 - NTP_TO_UNIX]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_644_697_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:908:78 [INFO] [stderr] | [INFO] [stderr] 908 | ((2016, 1, 1, 0, 0, 0, 0), 1451606400)] { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_451_606_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:930:35 [INFO] [stderr] | [INFO] [stderr] 930 | assert_eq!(t_leap.unix(), 1435708800); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_435_708_800` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1280:40 [INFO] [stderr] | [INFO] [stderr] 1280 | let t = t + Deltatime::seconds(126230402); // 4 years, 2 leaps [INFO] [stderr] | ^^^^^^^^^ help: consider: `126_230_402` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1285:41 [INFO] [stderr] | [INFO] [stderr] 1285 | let t = t + Deltatime::seconds(-126230402); [INFO] [stderr] | ^^^^^^^^^ help: consider: `126_230_402` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1296:40 [INFO] [stderr] | [INFO] [stderr] 1296 | let t = t + Deltatime::seconds(94608001); [INFO] [stderr] | ^^^^^^^^ help: consider: `94_608_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1301:41 [INFO] [stderr] | [INFO] [stderr] 1301 | let t = t + Deltatime::seconds(-94608001); [INFO] [stderr] | ^^^^^^^^ help: consider: `94_608_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `hdr.abbr_size` [INFO] [stderr] --> src/parse.rs:44:65 [INFO] [stderr] | [INFO] [stderr] 44 | let to_skip = hdr.transitions * 5 + hdr.types * 6 + hdr.abbr_size * 1 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `hdr.stdwalls` [INFO] [stderr] --> src/parse.rs:45:43 [INFO] [stderr] | [INFO] [stderr] 45 | hdr.leaps * 4 + hdr.stdwalls * 1 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `hdr.utclocals` [INFO] [stderr] --> src/parse.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | hdr.utclocals * 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `hdr.stdwalls` [INFO] [stderr] --> src/parse.rs:60:43 [INFO] [stderr] | [INFO] [stderr] 60 | let to_skip = hdr.leaps * 8 + hdr.stdwalls * 1 + hdr.utclocals * 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `hdr.utclocals` [INFO] [stderr] --> src/parse.rs:60:62 [INFO] [stderr] | [INFO] [stderr] 60 | let to_skip = hdr.leaps * 8 + hdr.stdwalls * 1 + hdr.utclocals * 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parse.rs:141:20 [INFO] [stderr] | [INFO] [stderr] 141 | trans.push(t as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parse.rs:297:35 [INFO] [stderr] | [INFO] [stderr] 297 | try!(r.seek(SeekFrom::Current(len as i64))); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | / pub fn datetime(&self, [INFO] [stderr] 185 | | year: i32, [INFO] [stderr] 186 | | month: i32, [INFO] [stderr] 187 | | day: i32, [INFO] [stderr] ... | [INFO] [stderr] 256 | | } [INFO] [stderr] 257 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:230:22 [INFO] [stderr] | [INFO] [stderr] 230 | stamp.sec -= utc_offset as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(utc_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:233:20 [INFO] [stderr] | [INFO] [stderr] 233 | if let Err(_) = LEAP_SECONDS.binary_search(&(stamp.sec + 1)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 234 | | panic!("not a valid leap second"); [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____________- help: try this: `if LEAP_SECONDS.binary_search(&(stamp.sec + 1)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:350:76 [INFO] [stderr] | [INFO] [stderr] 350 | let mut std_t = time::at_utc(time::Timespec { sec: stamp + std.off as i64, nsec: 0 }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(std.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:356:76 [INFO] [stderr] | [INFO] [stderr] 356 | let mut dst_t = time::at_utc(time::Timespec { sec: stamp + dst.off as i64, nsec: 0 }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(dst.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:435:35 [INFO] [stderr] | [INFO] [stderr] 435 | sec: self.stamp.sec + offset as i64 + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:639:24 [INFO] [stderr] | [INFO] [stderr] 639 | if self.stamp.nsec as i64 >= nano { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.stamp.nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:644:37 [INFO] [stderr] | [INFO] [stderr] 644 | let nano = nano - self.stamp.nsec as i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:644:39 [INFO] [stderr] | [INFO] [stderr] 644 | let nano = nano - self.stamp.nsec as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.stamp.nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:651:39 [INFO] [stderr] | [INFO] [stderr] 651 | let nano = nano + self.stamp.nsec as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.stamp.nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:661:36 [INFO] [stderr] | [INFO] [stderr] 661 | let sec = nano / 1_000_000_000; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:680:63 [INFO] [stderr] | [INFO] [stderr] 680 | let prev_leap = LEAP_SECONDS[s-1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:681:71 [INFO] [stderr] | [INFO] [stderr] 681 | let prev_leap_in_sec = self.stamp.sec - prev_leap; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:695:64 [INFO] [stderr] | [INFO] [stderr] 695 | self.stamp.sec = prev_leap - 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:724:66 [INFO] [stderr] | [INFO] [stderr] 724 | let next_leap_in_sec = next_leap - self.stamp.sec; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:765:39 [INFO] [stderr] | [INFO] [stderr] 765 | self.stamp.sec += day * 86400; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tzdata`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/parse.rs:7:21 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::{self, Read, BufReader, Seek, SeekFrom}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Seek` [INFO] [stderr] --> src/parse.rs:7:38 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::{self, Read, BufReader, Seek, SeekFrom}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `hdr.abbr_size` [INFO] [stderr] --> src/parse.rs:44:65 [INFO] [stderr] | [INFO] [stderr] 44 | let to_skip = hdr.transitions * 5 + hdr.types * 6 + hdr.abbr_size * 1 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `hdr.stdwalls` [INFO] [stderr] --> src/parse.rs:45:43 [INFO] [stderr] | [INFO] [stderr] 45 | hdr.leaps * 4 + hdr.stdwalls * 1 + [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `hdr.utclocals` [INFO] [stderr] --> src/parse.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | hdr.utclocals * 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `hdr.stdwalls` [INFO] [stderr] --> src/parse.rs:60:43 [INFO] [stderr] | [INFO] [stderr] 60 | let to_skip = hdr.leaps * 8 + hdr.stdwalls * 1 + hdr.utclocals * 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `hdr.utclocals` [INFO] [stderr] --> src/parse.rs:60:62 [INFO] [stderr] | [INFO] [stderr] 60 | let to_skip = hdr.leaps * 8 + hdr.stdwalls * 1 + hdr.utclocals * 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parse.rs:141:20 [INFO] [stderr] | [INFO] [stderr] 141 | trans.push(t as i64); [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parse.rs:297:35 [INFO] [stderr] | [INFO] [stderr] 297 | try!(r.seek(SeekFrom::Current(len as i64))); [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | / pub fn datetime(&self, [INFO] [stderr] 185 | | year: i32, [INFO] [stderr] 186 | | month: i32, [INFO] [stderr] 187 | | day: i32, [INFO] [stderr] ... | [INFO] [stderr] 256 | | } [INFO] [stderr] 257 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:230:22 [INFO] [stderr] | [INFO] [stderr] 230 | stamp.sec -= utc_offset as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(utc_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/lib.rs:233:20 [INFO] [stderr] | [INFO] [stderr] 233 | if let Err(_) = LEAP_SECONDS.binary_search(&(stamp.sec + 1)) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 234 | | panic!("not a valid leap second"); [INFO] [stderr] 235 | | } [INFO] [stderr] | |_____________- help: try this: `if LEAP_SECONDS.binary_search(&(stamp.sec + 1)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:350:76 [INFO] [stderr] | [INFO] [stderr] 350 | let mut std_t = time::at_utc(time::Timespec { sec: stamp + std.off as i64, nsec: 0 }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(std.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:356:76 [INFO] [stderr] | [INFO] [stderr] 356 | let mut dst_t = time::at_utc(time::Timespec { sec: stamp + dst.off as i64, nsec: 0 }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i64::from(dst.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:435:35 [INFO] [stderr] | [INFO] [stderr] 435 | sec: self.stamp.sec + offset as i64 + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:639:24 [INFO] [stderr] | [INFO] [stderr] 639 | if self.stamp.nsec as i64 >= nano { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.stamp.nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:644:37 [INFO] [stderr] | [INFO] [stderr] 644 | let nano = nano - self.stamp.nsec as i64; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:644:39 [INFO] [stderr] | [INFO] [stderr] 644 | let nano = nano - self.stamp.nsec as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.stamp.nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:651:39 [INFO] [stderr] | [INFO] [stderr] 651 | let nano = nano + self.stamp.nsec as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.stamp.nsec)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:661:36 [INFO] [stderr] | [INFO] [stderr] 661 | let sec = nano / 1_000_000_000; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:680:63 [INFO] [stderr] | [INFO] [stderr] 680 | let prev_leap = LEAP_SECONDS[s-1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:681:71 [INFO] [stderr] | [INFO] [stderr] 681 | let prev_leap_in_sec = self.stamp.sec - prev_leap; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:695:64 [INFO] [stderr] | [INFO] [stderr] 695 | self.stamp.sec = prev_leap - 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:724:66 [INFO] [stderr] | [INFO] [stderr] 724 | let next_leap_in_sec = next_leap - self.stamp.sec; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/lib.rs:765:39 [INFO] [stderr] | [INFO] [stderr] 765 | self.stamp.sec += day * 86400; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `3600` [INFO] [stderr] --> src/lib.rs:1096:18 [INFO] [stderr] | [INFO] [stderr] 1096 | off: 1 * 3600, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/lib.rs:1202:5 [INFO] [stderr] | [INFO] [stderr] 1202 | / fn test_add_deltatime() { [INFO] [stderr] 1203 | | let utc = Timezone::utc(); [INFO] [stderr] 1204 | | [INFO] [stderr] 1205 | | // nano [INFO] [stderr] ... | [INFO] [stderr] 1329 | | assert_eq!(t.time(), (0, 0, 0, 0)); [INFO] [stderr] 1330 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to 7 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tzdata`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9dfe2f25f08e697801f41e724f8aafcc10646d7739a7222864a49589805c5b8b"` [INFO] running `"docker" "rm" "-f" "9dfe2f25f08e697801f41e724f8aafcc10646d7739a7222864a49589805c5b8b"` [INFO] [stdout] 9dfe2f25f08e697801f41e724f8aafcc10646d7739a7222864a49589805c5b8b