[INFO] crate twoway 0.2.0 is already in cache [INFO] extracting crate twoway 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/twoway/0.2.0 [INFO] extracting crate twoway 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/twoway/0.2.0 [INFO] validating manifest of twoway-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of twoway-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing twoway-0.2.0 [INFO] finished frobbing twoway-0.2.0 [INFO] frobbed toml for twoway-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/twoway/0.2.0/Cargo.toml [INFO] started frobbing twoway-0.2.0 [INFO] finished frobbing twoway-0.2.0 [INFO] frobbed toml for twoway-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/twoway/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting twoway-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/twoway/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3b3c78e14524f7b43da2a40e48945ed59a125d11c71e149cc94b100494db0a45 [INFO] running `"docker" "start" "-a" "3b3c78e14524f7b43da2a40e48945ed59a125d11c71e149cc94b100494db0a45"` [INFO] [stderr] Checking macro-attr v0.2.0 [INFO] [stderr] Compiling newtype_derive v0.1.6 [INFO] [stderr] Checking odds v0.3.1 [INFO] [stderr] Checking twoway v0.2.0 (/opt/crater/workdir) [INFO] [stderr] Checking quickcheck v0.7.2 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:36:17 [INFO] [stderr] | [INFO] [stderr] 36 | let mut k = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | let mut p = 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | let r = (i - s) % p; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let mut k = 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | let mut p = 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let a = x[j + k]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | let (j, q) = maximal_suffix(x, true); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | let (l, p) = crit_period(x); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | let mut s = 0; // `s` is the memory [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | let mut i = max(l, s) + 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:155:25 [INFO] [stderr] | [INFO] [stderr] 155 | let mut j = l; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | let q = max(l, n - l) + 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | let mut i = l + 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:179:25 [INFO] [stderr] | [INFO] [stderr] 179 | let mut j = l; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | let (l, p) = crit_period(x); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | let mut s = 0; // `s` is the memory [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:211:21 [INFO] [stderr] | [INFO] [stderr] 211 | let mut i = max(l, s) + 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:219:25 [INFO] [stderr] | [INFO] [stderr] 219 | let mut j = l; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | let q = max(l, n - l) + 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:235:21 [INFO] [stderr] | [INFO] [stderr] 235 | let mut i = l + 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/tw.rs:242:25 [INFO] [stderr] | [INFO] [stderr] 242 | let mut j = l; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:179:17 [INFO] [stderr] | [INFO] [stderr] 179 | haystack: haystack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `haystack` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | needle: needle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `needle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:190:17 [INFO] [stderr] | [INFO] [stderr] 190 | haystack: haystack, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `haystack` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | needle: needle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `needle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:475:17 [INFO] [stderr] | [INFO] [stderr] 475 | crit_pos: crit_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `crit_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:476:17 [INFO] [stderr] | [INFO] [stderr] 476 | crit_pos_back: crit_pos_back, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crit_pos_back` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:477:17 [INFO] [stderr] | [INFO] [stderr] 477 | period: period, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:481:17 [INFO] [stderr] | [INFO] [stderr] 481 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:494:17 [INFO] [stderr] | [INFO] [stderr] 494 | crit_pos: crit_pos, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `crit_pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:500:17 [INFO] [stderr] | [INFO] [stderr] 500 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pcmp.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | return Some(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pcmp.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pcmp.rs:295:9 [INFO] [stderr] | [INFO] [stderr] 295 | return memchr::memchr(pattern[0], text); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `memchr::memchr(pattern[0], text)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pcmp.rs:508:5 [INFO] [stderr] | [INFO] [stderr] 508 | return data; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/pcmp.rs:49:26 [INFO] [stderr] | [INFO] [stderr] 49 | let text = mask_load(text.offset(offset as _) as *const _, text_len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `text.add(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::arch::x86_64::__m128i`) [INFO] [stderr] --> src/pcmp.rs:67:32 [INFO] [stderr] | [INFO] [stderr] 67 | let text = _mm_loadu_si128(text.offset(offset as _) as *const _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/pcmp.rs:67:32 [INFO] [stderr] | [INFO] [stderr] 67 | let text = _mm_loadu_si128(text.offset(offset as _) as *const _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `text.add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::arch::x86_64::__m128i`) [INFO] [stderr] --> src/pcmp.rs:85:34 [INFO] [stderr] | [INFO] [stderr] 85 | let needle = _mm_loadu_si128(needle.offset(noffset as _) as *const _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/pcmp.rs:85:34 [INFO] [stderr] | [INFO] [stderr] 85 | let needle = _mm_loadu_si128(needle.offset(noffset as _) as *const _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `needle.add(noffset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const std::arch::x86_64::__m128i`) [INFO] [stderr] --> src/pcmp.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | let text = _mm_loadu_si128(text.offset(offset as _) as *const _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/pcmp.rs:86:32 [INFO] [stderr] | [INFO] [stderr] 86 | let text = _mm_loadu_si128(text.offset(offset as _) as *const _); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `text.add(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/pcmp.rs:314:8 [INFO] [stderr] | [INFO] [stderr] 314 | if &pat[..crit_pos] == &pat[period.. period + crit_pos] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 314 | if pat[..crit_pos] == pat[period.. period + crit_pos] { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/pcmp.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | assert!(right.len() != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!right.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/pcmp.rs:410:40 [INFO] [stderr] | [INFO] [stderr] 410 | if memory <= left.len() && &left[memory..] != &text[pos + memory..pos + left.len()] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 410 | if memory <= left.len() && left[memory..] != text[pos + memory..pos + left.len()] { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:460:12 [INFO] [stderr] | [INFO] [stderr] 460 | if &needle[..crit_pos] == &needle[period.. period + crit_pos] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 460 | if needle[..crit_pos] == needle[period.. period + crit_pos] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `twoway`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "3b3c78e14524f7b43da2a40e48945ed59a125d11c71e149cc94b100494db0a45"` [INFO] running `"docker" "rm" "-f" "3b3c78e14524f7b43da2a40e48945ed59a125d11c71e149cc94b100494db0a45"` [INFO] [stdout] 3b3c78e14524f7b43da2a40e48945ed59a125d11c71e149cc94b100494db0a45