[INFO] crate twitter-stream 0.9.0 is already in cache [INFO] extracting crate twitter-stream 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/twitter-stream/0.9.0 [INFO] extracting crate twitter-stream 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/twitter-stream/0.9.0 [INFO] validating manifest of twitter-stream-0.9.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of twitter-stream-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing twitter-stream-0.9.0 [INFO] removed 1 missing examples [INFO] finished frobbing twitter-stream-0.9.0 [INFO] frobbed toml for twitter-stream-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/twitter-stream/0.9.0/Cargo.toml [INFO] started frobbing twitter-stream-0.9.0 [INFO] removed 1 missing examples [INFO] finished frobbing twitter-stream-0.9.0 [INFO] frobbed toml for twitter-stream-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/twitter-stream/0.9.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting twitter-stream-0.9.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/twitter-stream/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aaac79523c0686fcbad92dbcf0c3f147822bcb033741884a8f64e06cb55b1120 [INFO] running `"docker" "start" "-a" "aaac79523c0686fcbad92dbcf0c3f147822bcb033741884a8f64e06cb55b1120"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/echo_bot.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling nom v1.2.4 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Checking opaque-debug v0.2.2 [INFO] [stderr] Checking static_assertions v0.3.1 [INFO] [stderr] Checking crossbeam-utils v0.6.5 [INFO] [stderr] Checking openssl v0.10.16 [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Compiling oauth1-request-derive v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] Checking block-padding v0.1.3 [INFO] [stderr] Checking oauthcli v1.0.4 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking crossbeam-channel v0.3.7 [INFO] [stderr] Checking tokio-executor v0.1.6 [INFO] [stderr] Checking block-buffer v0.7.2 [INFO] [stderr] Compiling tweetust v0.9.0 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking tokio-timer v0.2.9 [INFO] [stderr] Checking tokio-current-thread v0.1.4 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking native-tls v0.2.2 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking oauth1-request v0.2.1 [INFO] [stderr] Checking multipart v0.12.0 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking version-sync v0.6.0 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking twitter-stream-message v0.3.0 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking twitter-stream v0.9.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:378:52 [INFO] [stderr] | [INFO] [stderr] 378 | #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:330:15 [INFO] [stderr] | [INFO] [stderr] 330 | pub fn not(p: &bool) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | #[derive(OAuth1Authorize)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 284 | / def_stream! { [INFO] [stderr] 285 | | /// A builder for `TwitterStream`. [INFO] [stderr] 286 | | /// [INFO] [stderr] 287 | | /// ## Example [INFO] [stderr] ... | [INFO] [stderr] 421 | | pub fn sample(GET, "https://stream.twitter.com/1.1/statuses/sample.json"); [INFO] [stderr] 422 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | #[derive(OAuth1Authorize)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 284 | / def_stream! { [INFO] [stderr] 285 | | /// A builder for `TwitterStream`. [INFO] [stderr] 286 | | /// [INFO] [stderr] 287 | | /// ## Example [INFO] [stderr] ... | [INFO] [stderr] 421 | | pub fn sample(GET, "https://stream.twitter.com/1.1/statuses/sample.json"); [INFO] [stderr] 422 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:378:52 [INFO] [stderr] | [INFO] [stderr] 378 | #[cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:330:15 [INFO] [stderr] | [INFO] [stderr] 330 | pub fn not(p: &bool) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/util.rs:386:18 [INFO] [stderr] | [INFO] [stderr] 386 | for _ in 0..(lines.len() + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=lines.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | #[derive(OAuth1Authorize)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 284 | / def_stream! { [INFO] [stderr] 285 | | /// A builder for `TwitterStream`. [INFO] [stderr] 286 | | /// [INFO] [stderr] 287 | | /// ## Example [INFO] [stderr] ... | [INFO] [stderr] 421 | | pub fn sample(GET, "https://stream.twitter.com/1.1/statuses/sample.json"); [INFO] [stderr] 422 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:137:22 [INFO] [stderr] | [INFO] [stderr] 137 | #[derive(OAuth1Authorize)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 284 | / def_stream! { [INFO] [stderr] 285 | | /// A builder for `TwitterStream`. [INFO] [stderr] 286 | | /// [INFO] [stderr] 287 | | /// ## Example [INFO] [stderr] ... | [INFO] [stderr] 421 | | pub fn sample(GET, "https://stream.twitter.com/1.1/statuses/sample.json"); [INFO] [stderr] 422 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `"docker" "inspect" "aaac79523c0686fcbad92dbcf0c3f147822bcb033741884a8f64e06cb55b1120"` [INFO] running `"docker" "rm" "-f" "aaac79523c0686fcbad92dbcf0c3f147822bcb033741884a8f64e06cb55b1120"` [INFO] [stdout] aaac79523c0686fcbad92dbcf0c3f147822bcb033741884a8f64e06cb55b1120