[INFO] crate twiggy-parser 0.3.0 is already in cache
[INFO] extracting crate twiggy-parser 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/twiggy-parser/0.3.0
[INFO] extracting crate twiggy-parser 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/twiggy-parser/0.3.0
[INFO] validating manifest of twiggy-parser-0.3.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of twiggy-parser-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing twiggy-parser-0.3.0
[INFO] finished frobbing twiggy-parser-0.3.0
[INFO] frobbed toml for twiggy-parser-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/twiggy-parser/0.3.0/Cargo.toml
[INFO] started frobbing twiggy-parser-0.3.0
[INFO] finished frobbing twiggy-parser-0.3.0
[INFO] frobbed toml for twiggy-parser-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/twiggy-parser/0.3.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting twiggy-parser-0.3.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/twiggy-parser/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a84d4800cfa51300eafdf91f977a10838e6f8f326de028461e9f3a96cf44fd24
[INFO] running `"docker" "start" "-a" "a84d4800cfa51300eafdf91f977a10838e6f8f326de028461e9f3a96cf44fd24"`
[INFO] [stderr]    Compiling byteorder v1.3.1
[INFO] [stderr]     Checking frozen v1.0.0
[INFO] [stderr]     Checking fallible-iterator v0.1.6
[INFO] [stderr]    Compiling cpp_demangle v0.2.12
[INFO] [stderr]     Checking uuid v0.6.5
[INFO] [stderr]     Checking flate2 v1.0.6
[INFO] [stderr]    Compiling scroll_derive v0.9.5
[INFO] [stderr]     Checking parity-wasm v0.31.3
[INFO] [stderr]     Checking gimli v0.16.1
[INFO] [stderr]     Checking parity-wasm v0.32.0
[INFO] [stderr]     Checking scroll v0.9.2
[INFO] [stderr]     Checking goblin v0.0.17
[INFO] [stderr]     Checking twiggy-ir v0.3.0
[INFO] [stderr]     Checking twiggy-traits v0.3.0
[INFO] [stderr]     Checking object v0.10.0
[INFO] [stderr]     Checking twiggy-parser v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> object_parse/die_parse/mod.rs:62:26
[INFO] [stderr]    |
[INFO] [stderr] 62 |                         .unwrap_or(format!("Subroutine[{}][{}]", unit_id, entry_id));
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("Subroutine[{}][{}]", unit_id, entry_id))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> wasm_parse/mod.rs:291:40
[INFO] [stderr]     |
[INFO] [stderr] 291 |             let size = serialized_size(func.clone())?;
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: try dereferencing it: `*func`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> wasm_parse/mod.rs:341:40
[INFO] [stderr]     |
[INFO] [stderr] 341 |             let size = serialized_size(entry.clone())?;
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^ help: try dereferencing it: `*entry`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> wasm_parse/mod.rs:362:40
[INFO] [stderr]     |
[INFO] [stderr] 362 |             let size = serialized_size(mem.clone())?;
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: try dereferencing it: `*mem`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> wasm_parse/mod.rs:509:13
[INFO] [stderr]     |
[INFO] [stderr] 509 | /             match *s {
[INFO] [stderr] 510 | |                 Section::Function(_) => func_section = Some(sect_idx),
[INFO] [stderr] 511 | |                 _ => {}
[INFO] [stderr] 512 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Section::Function(_) = *s { func_section = Some(sect_idx) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> wasm_parse/mod.rs:760:40
[INFO] [stderr]     |
[INFO] [stderr] 760 |             let size = serialized_size(rel.clone())?;
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: try dereferencing it: `*rel`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> object_parse/die_parse/mod.rs:62:26
[INFO] [stderr]    |
[INFO] [stderr] 62 |                         .unwrap_or(format!("Subroutine[{}][{}]", unit_id, entry_id));
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("Subroutine[{}][{}]", unit_id, entry_id))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> wasm_parse/mod.rs:291:40
[INFO] [stderr]     |
[INFO] [stderr] 291 |             let size = serialized_size(func.clone())?;
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: try dereferencing it: `*func`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> wasm_parse/mod.rs:341:40
[INFO] [stderr]     |
[INFO] [stderr] 341 |             let size = serialized_size(entry.clone())?;
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^ help: try dereferencing it: `*entry`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> wasm_parse/mod.rs:362:40
[INFO] [stderr]     |
[INFO] [stderr] 362 |             let size = serialized_size(mem.clone())?;
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: try dereferencing it: `*mem`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> wasm_parse/mod.rs:509:13
[INFO] [stderr]     |
[INFO] [stderr] 509 | /             match *s {
[INFO] [stderr] 510 | |                 Section::Function(_) => func_section = Some(sect_idx),
[INFO] [stderr] 511 | |                 _ => {}
[INFO] [stderr] 512 | |             }
[INFO] [stderr]     | |_____________^ help: try this: `if let Section::Function(_) = *s { func_section = Some(sect_idx) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> wasm_parse/mod.rs:760:40
[INFO] [stderr]     |
[INFO] [stderr] 760 |             let size = serialized_size(rel.clone())?;
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: try dereferencing it: `*rel`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 33.43s
[INFO] running `"docker" "inspect" "a84d4800cfa51300eafdf91f977a10838e6f8f326de028461e9f3a96cf44fd24"`
[INFO] running `"docker" "rm" "-f" "a84d4800cfa51300eafdf91f977a10838e6f8f326de028461e9f3a96cf44fd24"`
[INFO] [stdout] a84d4800cfa51300eafdf91f977a10838e6f8f326de028461e9f3a96cf44fd24