[INFO] crate twiggy-ir 0.3.0 is already in cache [INFO] extracting crate twiggy-ir 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/twiggy-ir/0.3.0 [INFO] extracting crate twiggy-ir 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/twiggy-ir/0.3.0 [INFO] validating manifest of twiggy-ir-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of twiggy-ir-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing twiggy-ir-0.3.0 [INFO] finished frobbing twiggy-ir-0.3.0 [INFO] frobbed toml for twiggy-ir-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/twiggy-ir/0.3.0/Cargo.toml [INFO] started frobbing twiggy-ir-0.3.0 [INFO] finished frobbing twiggy-ir-0.3.0 [INFO] frobbed toml for twiggy-ir-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/twiggy-ir/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting twiggy-ir-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/twiggy-ir/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35e84423f3846eb24552d7f8013d00c78aaf2dd90037ad80f705426c0a070b37 [INFO] running `"docker" "start" "-a" "35e84423f3846eb24552d7f8013d00c78aaf2dd90037ad80f705426c0a070b37"` [INFO] [stderr] Checking frozen v1.0.0 [INFO] [stderr] Compiling cpp_demangle v0.2.12 [INFO] [stderr] Checking twiggy-ir v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> ir.rs:77:32 [INFO] [stderr] | [INFO] [stderr] 77 | self.edges.entry(from).or_insert(BTreeSet::new()).insert(to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> ir.rs:208:37 [INFO] [stderr] | [INFO] [stderr] 208 | .or_insert_with(|| BTreeSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BTreeSet::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> ir.rs:77:32 [INFO] [stderr] | [INFO] [stderr] 77 | self.edges.entry(from).or_insert(BTreeSet::new()).insert(to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> ir.rs:258:22 [INFO] [stderr] | [INFO] [stderr] 258 | .or_insert(BTreeSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> ir.rs:208:37 [INFO] [stderr] | [INFO] [stderr] 208 | .or_insert_with(|| BTreeSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BTreeSet::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> ir.rs:258:22 [INFO] [stderr] | [INFO] [stderr] 258 | .or_insert(BTreeSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> ir.rs:423:25 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn serializable(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> ir.rs:424:19 [INFO] [stderr] | [INFO] [stderr] 424 | let top = (self.0 as u64) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(self.0)` [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> ir.rs:423:25 [INFO] [stderr] | [INFO] [stderr] 423 | pub fn serializable(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> ir.rs:424:19 [INFO] [stderr] | [INFO] [stderr] 424 | let top = (self.0 as u64) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> ir.rs:425:15 [INFO] [stderr] | [INFO] [stderr] 425 | top | (self.1 as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(self.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> ir.rs:425:15 [INFO] [stderr] | [INFO] [stderr] 425 | top | (self.1 as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(self.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DebugInfo` [INFO] [stderr] --> ir.rs:654:5 [INFO] [stderr] | [INFO] [stderr] 654 | / pub fn new() -> DebugInfo { [INFO] [stderr] 655 | | DebugInfo [INFO] [stderr] 656 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 650 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Misc` [INFO] [stderr] --> ir.rs:665:5 [INFO] [stderr] | [INFO] [stderr] 665 | / pub fn new() -> Misc { [INFO] [stderr] 666 | | Misc [INFO] [stderr] 667 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 661 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `DebugInfo` [INFO] [stderr] --> ir.rs:654:5 [INFO] [stderr] | [INFO] [stderr] 654 | / pub fn new() -> DebugInfo { [INFO] [stderr] 655 | | DebugInfo [INFO] [stderr] 656 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 650 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Misc` [INFO] [stderr] --> ir.rs:665:5 [INFO] [stderr] | [INFO] [stderr] 665 | / pub fn new() -> Misc { [INFO] [stderr] 666 | | Misc [INFO] [stderr] 667 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 661 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.23s [INFO] running `"docker" "inspect" "35e84423f3846eb24552d7f8013d00c78aaf2dd90037ad80f705426c0a070b37"` [INFO] running `"docker" "rm" "-f" "35e84423f3846eb24552d7f8013d00c78aaf2dd90037ad80f705426c0a070b37"` [INFO] [stdout] 35e84423f3846eb24552d7f8013d00c78aaf2dd90037ad80f705426c0a070b37