[INFO] crate tweetust 0.9.0 is already in cache
[INFO] extracting crate tweetust 0.9.0 into work/ex/clippy-test-run/sources/stable/reg/tweetust/0.9.0
[INFO] extracting crate tweetust 0.9.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tweetust/0.9.0
[INFO] validating manifest of tweetust-0.9.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tweetust-0.9.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tweetust-0.9.0
[INFO] finished frobbing tweetust-0.9.0
[INFO] frobbed toml for tweetust-0.9.0 written to work/ex/clippy-test-run/sources/stable/reg/tweetust/0.9.0/Cargo.toml
[INFO] started frobbing tweetust-0.9.0
[INFO] finished frobbing tweetust-0.9.0
[INFO] frobbed toml for tweetust-0.9.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tweetust/0.9.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tweetust-0.9.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tweetust/0.9.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5efe680d3def66eef6b5401a671bd3b841e56dcd8f331fa7257cfda65f3f4c5b
[INFO] running `"docker" "start" "-a" "5efe680d3def66eef6b5401a671bd3b841e56dcd8f331fa7257cfda65f3f4c5b"`
[INFO] [stderr]    Compiling nom v1.2.4
[INFO] [stderr]    Compiling Inflector v0.11.4
[INFO] [stderr]     Checking oauthcli v1.0.4
[INFO] [stderr]     Checking multipart v0.12.0
[INFO] [stderr]    Compiling tweetust v0.9.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> build.rs:5:1
[INFO] [stderr]   |
[INFO] [stderr] 5 | #[macro_use] extern crate nom;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Unsupported return type `Dictionary<Status>`: Statuses.LookupMap
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/conn/mod.rs:95:22
[INFO] [stderr]    |
[INFO] [stderr] 95 |         Ok(Request { method: method, url: request_url, content: content })
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^ help: replace it with: `method`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/conn/mod.rs:95:56
[INFO] [stderr]    |
[INFO] [stderr] 95 |         Ok(Request { method: method, url: request_url, content: content })
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^ help: replace it with: `content`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/conn/mod.rs:124:13
[INFO] [stderr]     |
[INFO] [stderr] 124 |             connector: connector,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/conn/mod.rs:255:13
[INFO] [stderr]     |
[INFO] [stderr] 255 |             rate_limit: rate_limit,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rate_limit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/conn/mod.rs:263:17
[INFO] [stderr]     |
[INFO] [stderr] 263 |                 errors: errors,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `errors`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/conn/mod.rs:265:17
[INFO] [stderr]     |
[INFO] [stderr] 265 |                 rate_limit: rate_limit,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rate_limit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/oauth.rs:98:25
[INFO] [stderr]    |
[INFO] [stderr] 98 |                         oauth_token: oauth_token,
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oauth_token`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/oauth.rs:99:25
[INFO] [stderr]    |
[INFO] [stderr] 99 |                         oauth_token_secret: oauth_token_secret,
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oauth_token_secret`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/oauth.rs:200:25
[INFO] [stderr]     |
[INFO] [stderr] 200 |                         oauth_token: oauth_token,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oauth_token`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/oauth.rs:201:25
[INFO] [stderr]     |
[INFO] [stderr] 201 |                         oauth_token_secret: oauth_token_secret,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oauth_token_secret`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/oauth.rs:202:25
[INFO] [stderr]     |
[INFO] [stderr] 202 |                         user_id: user_id,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `user_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/oauth.rs:203:25
[INFO] [stderr]     |
[INFO] [stderr] 203 |                         screen_name: screen_name
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/oauth2.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             consumer_key: consumer_key,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consumer_key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/oauth2.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             consumer_secret: consumer_secret,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consumer_secret`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/conn/mod.rs:95:22
[INFO] [stderr]    |
[INFO] [stderr] 95 |         Ok(Request { method: method, url: request_url, content: content })
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^ help: replace it with: `method`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/conn/mod.rs:95:56
[INFO] [stderr]    |
[INFO] [stderr] 95 |         Ok(Request { method: method, url: request_url, content: content })
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^ help: replace it with: `content`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/conn/mod.rs:124:13
[INFO] [stderr]     |
[INFO] [stderr] 124 |             connector: connector,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connector`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/conn/mod.rs:255:13
[INFO] [stderr]     |
[INFO] [stderr] 255 |             rate_limit: rate_limit,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rate_limit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/conn/mod.rs:263:17
[INFO] [stderr]     |
[INFO] [stderr] 263 |                 errors: errors,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `errors`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/conn/mod.rs:265:17
[INFO] [stderr]     |
[INFO] [stderr] 265 |                 rate_limit: rate_limit,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rate_limit`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/oauth.rs:98:25
[INFO] [stderr]    |
[INFO] [stderr] 98 |                         oauth_token: oauth_token,
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oauth_token`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/oauth.rs:99:25
[INFO] [stderr]    |
[INFO] [stderr] 99 |                         oauth_token_secret: oauth_token_secret,
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oauth_token_secret`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/oauth.rs:200:25
[INFO] [stderr]     |
[INFO] [stderr] 200 |                         oauth_token: oauth_token,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oauth_token`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/oauth.rs:201:25
[INFO] [stderr]     |
[INFO] [stderr] 201 |                         oauth_token_secret: oauth_token_secret,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oauth_token_secret`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/oauth.rs:202:25
[INFO] [stderr]     |
[INFO] [stderr] 202 |                         user_id: user_id,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^ help: replace it with: `user_id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/oauth.rs:203:25
[INFO] [stderr]     |
[INFO] [stderr] 203 |                         screen_name: screen_name
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/oauth2.rs:36:13
[INFO] [stderr]    |
[INFO] [stderr] 36 |             consumer_key: consumer_key,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consumer_key`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/oauth2.rs:37:13
[INFO] [stderr]    |
[INFO] [stderr] 37 |             consumer_secret: consumer_secret,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `consumer_secret`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/clients/impls.rs:18:26
[INFO] [stderr]    |
[INFO] [stderr] 18 | const MEDIA_UPLOAD_URL: &'static str = "https://upload.twitter.com/1.1/media/upload.json";
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/clients/impls.rs:18:26
[INFO] [stderr]    |
[INFO] [stderr] 18 | const MEDIA_UPLOAD_URL: &'static str = "https://upload.twitter.com/1.1/media/upload.json";
[INFO] [stderr]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/clients/helper.rs:19:29
[INFO] [stderr]    |
[INFO] [stderr] 19 |         while let Some(v) = iter.next() {
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: try: `for v in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/clients/helper.rs:36:29
[INFO] [stderr]    |
[INFO] [stderr] 36 |         while let Some(v) = iter.next() {
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: try: `for v in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]     --> /opt/crater/target/debug/build/tweetust-d370481dbcdd2d3c/out/clients.rs:2429:40
[INFO] [stderr]      |
[INFO] [stderr] 2429 |     pub fn new<T1: Into<Cow<'a, str>>>(&self, text: T1) -> DirectMessagesNewRequestBuilder<'a, A, H> {
[INFO] [stderr]      |                                        ^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]     --> /opt/crater/target/debug/build/tweetust-d370481dbcdd2d3c/out/clients.rs:2429:5
[INFO] [stderr]      |
[INFO] [stderr] 2429 | /     pub fn new<T1: Into<Cow<'a, str>>>(&self, text: T1) -> DirectMessagesNewRequestBuilder<'a, A, H> {
[INFO] [stderr] 2430 | |         DirectMessagesNewRequestBuilder {
[INFO] [stderr] 2431 | |             _client: self.client,
[INFO] [stderr] 2432 | |             text: text.into(),
[INFO] [stderr] ...    |
[INFO] [stderr] 2435 | |         }
[INFO] [stderr] 2436 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/conn/mod.rs:210:12
[INFO] [stderr]     |
[INFO] [stderr] 210 |         if s.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/models/error.rs:25:21
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 let ref e = x[0];
[INFO] [stderr]    |                 ----^^^^^-------- help: try: `let e = &x[0];`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/clients/helper.rs:19:29
[INFO] [stderr]    |
[INFO] [stderr] 19 |         while let Some(v) = iter.next() {
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: try: `for v in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/clients/helper.rs:36:29
[INFO] [stderr]    |
[INFO] [stderr] 36 |         while let Some(v) = iter.next() {
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: try: `for v in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually take no self; consider choosing a less ambiguous name
[INFO] [stderr]     --> /opt/crater/target/debug/build/tweetust-d370481dbcdd2d3c/out/clients.rs:2429:40
[INFO] [stderr]      |
[INFO] [stderr] 2429 |     pub fn new<T1: Into<Cow<'a, str>>>(&self, text: T1) -> DirectMessagesNewRequestBuilder<'a, A, H> {
[INFO] [stderr]      |                                        ^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `new` usually return `Self`
[INFO] [stderr]     --> /opt/crater/target/debug/build/tweetust-d370481dbcdd2d3c/out/clients.rs:2429:5
[INFO] [stderr]      |
[INFO] [stderr] 2429 | /     pub fn new<T1: Into<Cow<'a, str>>>(&self, text: T1) -> DirectMessagesNewRequestBuilder<'a, A, H> {
[INFO] [stderr] 2430 | |         DirectMessagesNewRequestBuilder {
[INFO] [stderr] 2431 | |             _client: self.client,
[INFO] [stderr] 2432 | |             text: text.into(),
[INFO] [stderr] ...    |
[INFO] [stderr] 2435 | |         }
[INFO] [stderr] 2436 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::new_ret_no_self)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/conn/mod.rs:210:12
[INFO] [stderr]     |
[INFO] [stderr] 210 |         if s.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/models/error.rs:25:21
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 let ref e = x[0];
[INFO] [stderr]    |                 ----^^^^^-------- help: try: `let e = &x[0];`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/oauth.rs:132:33
[INFO] [stderr]     |
[INFO] [stderr] 132 |     pub fn to_authenticator<'a>(self) -> OAuthAuthenticator<'a> {
[INFO] [stderr]     |                                 ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/oauth2.rs:23:33
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn to_authenticator<'a>(self) -> ApplicationOnlyAuthenticator<'a> {
[INFO] [stderr]    |                                 ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/oauth.rs:132:33
[INFO] [stderr]     |
[INFO] [stderr] 132 |     pub fn to_authenticator<'a>(self) -> OAuthAuthenticator<'a> {
[INFO] [stderr]     |                                 ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
[INFO] [stderr]   --> src/oauth2.rs:23:33
[INFO] [stderr]    |
[INFO] [stderr] 23 |     pub fn to_authenticator<'a>(self) -> ApplicationOnlyAuthenticator<'a> {
[INFO] [stderr]    |                                 ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> examples/cli.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 |         print!("\n");
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> examples/cli.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 | const CONFIG_FILE: &'static str = "test_client_config.txt";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> examples/cli.rs:52:22
[INFO] [stderr]    |
[INFO] [stderr] 52 | const CONSUMER_KEY: &'static str = "wDvwfgeq3mJO6GKTNXnOQvIf3";
[INFO] [stderr]    |                     -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> examples/cli.rs:53:25
[INFO] [stderr]    |
[INFO] [stderr] 53 | const CONSUMER_SECRET: &'static str = "om5lZdHf9dbyQUEIdwtiz0HqeC83O5JQUV3Dc9Amk0HO7FB7Rs";
[INFO] [stderr]    |                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> examples/cli.rs:318:71
[INFO] [stderr]     |
[INFO] [stderr] 318 |                     std::thread::sleep(std::time::Duration::from_secs(x as u64));
[INFO] [stderr]     |                                                                       ^^^^^^^^ help: try: `u64::from(x)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 25.73s
[INFO] running `"docker" "inspect" "5efe680d3def66eef6b5401a671bd3b841e56dcd8f331fa7257cfda65f3f4c5b"`
[INFO] running `"docker" "rm" "-f" "5efe680d3def66eef6b5401a671bd3b841e56dcd8f331fa7257cfda65f3f4c5b"`
[INFO] [stdout] 5efe680d3def66eef6b5401a671bd3b841e56dcd8f331fa7257cfda65f3f4c5b