[INFO] crate twapi 0.4.1 is already in cache [INFO] extracting crate twapi 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/twapi/0.4.1 [INFO] extracting crate twapi 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/twapi/0.4.1 [INFO] validating manifest of twapi-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of twapi-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing twapi-0.4.1 [INFO] finished frobbing twapi-0.4.1 [INFO] frobbed toml for twapi-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/twapi/0.4.1/Cargo.toml [INFO] started frobbing twapi-0.4.1 [INFO] finished frobbing twapi-0.4.1 [INFO] frobbed toml for twapi-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/twapi/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting twapi-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/twapi/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a0e0de2ad3dbda6b509634546c8be210b5ec6ba2575a612ae2bc9b04149594ec [INFO] running `"docker" "start" "-a" "a0e0de2ad3dbda6b509634546c8be210b5ec6ba2575a612ae2bc9b04149594ec"` [INFO] [stderr] Checking twapi v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:398:31 [INFO] [stderr] | [INFO] [stderr] 398 | while segment_index * 5000000 < file_size { [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:399:61 [INFO] [stderr] | [INFO] [stderr] 399 | let read_size: usize = if (segment_index + 1) * 5000000 < file_size { [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:400:17 [INFO] [stderr] | [INFO] [stderr] 400 | 5000000 [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:402:46 [INFO] [stderr] | [INFO] [stderr] 402 | (file_size - segment_index * 5000000) as usize [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:398:31 [INFO] [stderr] | [INFO] [stderr] 398 | while segment_index * 5000000 < file_size { [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:399:61 [INFO] [stderr] | [INFO] [stderr] 399 | let read_size: usize = if (segment_index + 1) * 5000000 < file_size { [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:400:17 [INFO] [stderr] | [INFO] [stderr] 400 | 5000000 [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:402:46 [INFO] [stderr] | [INFO] [stderr] 402 | (file_size - segment_index * 5000000) as usize [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/oauth1.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | fn make_query(list: &Vec<(&str, String)>, separator: &str) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/oauth1.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | header_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/oauth1.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | options: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:116:23 [INFO] [stderr] | [INFO] [stderr] 116 | let oauth_token = hash_query.get("oauth_token").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["oauth_token"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | hash_query.get("oauth_token_secret").unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["oauth_token_secret"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | Ok((hash_query.get("oauth_token").unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["oauth_token"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | hash_query.get("oauth_token_secret").unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["oauth_token_secret"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | hash_query.get("user_id").unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["user_id"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | hash_query.get("screen_name").unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["screen_name"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:99:18 [INFO] [stderr] | [INFO] [stderr] 99 | options: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:105:24 [INFO] [stderr] | [INFO] [stderr] 105 | query_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:121:24 [INFO] [stderr] | [INFO] [stderr] 121 | query_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 121 | query_options: &[(&str, &str)], [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `query_options.clone()` to [INFO] [stderr] | [INFO] [stderr] 124 | let mut merged_options = query_options.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | form_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | query_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:161:24 [INFO] [stderr] | [INFO] [stderr] 161 | query_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:177:24 [INFO] [stderr] | [INFO] [stderr] 177 | query_options: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:193:24 [INFO] [stderr] | [INFO] [stderr] 193 | query_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | params: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | params: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | params: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/oauth1.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | fn make_query(list: &Vec<(&str, String)>, separator: &str) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/oauth1.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | header_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/oauth1.rs:54:14 [INFO] [stderr] | [INFO] [stderr] 54 | options: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | reader.read(cursor.get_mut())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:417:13 [INFO] [stderr] | [INFO] [stderr] 417 | segment_index = segment_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:116:23 [INFO] [stderr] | [INFO] [stderr] 116 | let oauth_token = hash_query.get("oauth_token").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["oauth_token"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | hash_query.get("oauth_token_secret").unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["oauth_token_secret"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | Ok((hash_query.get("oauth_token").unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["oauth_token"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | hash_query.get("oauth_token_secret").unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["oauth_token_secret"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | hash_query.get("user_id").unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["user_id"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/oauth1.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | hash_query.get("screen_name").unwrap().clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hash_query["screen_name"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:99:18 [INFO] [stderr] | [INFO] [stderr] 99 | options: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:105:24 [INFO] [stderr] | [INFO] [stderr] 105 | query_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:121:24 [INFO] [stderr] | [INFO] [stderr] 121 | query_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 121 | query_options: &[(&str, &str)], [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `query_options.clone()` to [INFO] [stderr] | [INFO] [stderr] 124 | let mut merged_options = query_options.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | form_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: Could not compile `twapi`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:143:24 [INFO] [stderr] | [INFO] [stderr] 143 | query_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:161:24 [INFO] [stderr] | [INFO] [stderr] 161 | query_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:177:24 [INFO] [stderr] | [INFO] [stderr] 177 | query_options: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:193:24 [INFO] [stderr] | [INFO] [stderr] 193 | query_options: &Vec<(&str, &str)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:210:17 [INFO] [stderr] | [INFO] [stderr] 210 | params: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:221:17 [INFO] [stderr] | [INFO] [stderr] 221 | params: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | params: &Vec<(&str, &str)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str, &str)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/lib.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | reader.read(cursor.get_mut())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:417:13 [INFO] [stderr] | [INFO] [stderr] 417 | segment_index = segment_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `segment_index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `twapi`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a0e0de2ad3dbda6b509634546c8be210b5ec6ba2575a612ae2bc9b04149594ec"` [INFO] running `"docker" "rm" "-f" "a0e0de2ad3dbda6b509634546c8be210b5ec6ba2575a612ae2bc9b04149594ec"` [INFO] [stdout] a0e0de2ad3dbda6b509634546c8be210b5ec6ba2575a612ae2bc9b04149594ec