[INFO] crate tvis 0.15.3 is already in cache [INFO] extracting crate tvis 0.15.3 into work/ex/clippy-test-run/sources/stable/reg/tvis/0.15.3 [INFO] extracting crate tvis 0.15.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tvis/0.15.3 [INFO] validating manifest of tvis-0.15.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tvis-0.15.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tvis-0.15.3 [INFO] finished frobbing tvis-0.15.3 [INFO] frobbed toml for tvis-0.15.3 written to work/ex/clippy-test-run/sources/stable/reg/tvis/0.15.3/Cargo.toml [INFO] started frobbing tvis-0.15.3 [INFO] finished frobbing tvis-0.15.3 [INFO] frobbed toml for tvis-0.15.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tvis/0.15.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tvis-0.15.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tvis/0.15.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 91bdabbcf938e0b1a0e73018df917fba98a1156353bd5dffdb52b4a5fd1b5963 [INFO] running `"docker" "start" "-a" "91bdabbcf938e0b1a0e73018df917fba98a1156353bd5dffdb52b4a5fd1b5963"` [INFO] [stderr] Compiling tvis v0.15.3 (/opt/crater/workdir) [INFO] [stderr] Checking dlx v0.1.0 [INFO] [stderr] Checking tinf v0.14.0 [INFO] [stderr] Checking tvis_util v0.5.2 [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/term/unix.rs:212:29 [INFO] [stderr] | [INFO] [stderr] 212 | let s = &self.setftc; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/term/unix.rs:227:29 [INFO] [stderr] | [INFO] [stderr] 227 | let s = &self.setbtc; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/term/unix.rs:212:29 [INFO] [stderr] | [INFO] [stderr] 212 | let s = &self.setftc; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/term/unix.rs:227:29 [INFO] [stderr] | [INFO] [stderr] 227 | let s = &self.setbtc; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: lint name `if_same_then_else` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/input/unix/mod.rs:463:48 [INFO] [stderr] | [INFO] [stderr] 463 | #[cfg_attr(feature = "cargo-clippy", allow(if_same_then_else))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::if_same_then_else` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/input/unix/mod.rs:573:55 [INFO] [stderr] | [INFO] [stderr] 573 | let u = (((self.bytes[0] as u32) << 18) & 0x1fffff) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `if_same_then_else` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/input/unix/mod.rs:463:48 [INFO] [stderr] | [INFO] [stderr] 463 | #[cfg_attr(feature = "cargo-clippy", allow(if_same_then_else))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::if_same_then_else` [INFO] [stderr] [INFO] [stderr] warning: lint name `if_same_then_else` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/input/unix/mod.rs:463:48 [INFO] [stderr] | [INFO] [stderr] 463 | #[cfg_attr(feature = "cargo-clippy", allow(if_same_then_else))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::if_same_then_else` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/input/unix/mod.rs:573:55 [INFO] [stderr] | [INFO] [stderr] 573 | let u = (((self.bytes[0] as u32) << 18) & 0x1fffff) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x001f_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: lint name `if_same_then_else` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/input/unix/mod.rs:463:48 [INFO] [stderr] | [INFO] [stderr] 463 | #[cfg_attr(feature = "cargo-clippy", allow(if_same_then_else))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::if_same_then_else` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/term/mod.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | fn count(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input/unix/esckey.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | fn is_shifted_key(scap: &cap::String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `cap::String` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/input/unix/mod.rs:145:16 [INFO] [stderr] | [INFO] [stderr] 145 | if len < 1 || !reader.parse_signal(buf).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `len < 1 || reader.parse_signal(buf).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/input/unix/mod.rs:152:41 [INFO] [stderr] | [INFO] [stderr] 152 | let elapsed = i64::from(tstart.elapsed().subsec_nanos() / 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tstart.elapsed().subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:523:25 [INFO] [stderr] | [INFO] [stderr] 523 | let u = self.bytes[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:539:26 [INFO] [stderr] | [INFO] [stderr] 539 | let u = ((self.bytes[0] as u32) << 6) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:540:24 [INFO] [stderr] | [INFO] [stderr] 540 | | ((self.bytes[1] as u32) & 0x3f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:556:27 [INFO] [stderr] | [INFO] [stderr] 556 | let u = (((self.bytes[0] as u32) << 12) & 0xffff) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:557:25 [INFO] [stderr] | [INFO] [stderr] 557 | | (((self.bytes[1] as u32) << 6) & 0xfff) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:558:24 [INFO] [stderr] | [INFO] [stderr] 558 | | ((self.bytes[2] as u32) & 0x3f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:573:23 [INFO] [stderr] | [INFO] [stderr] 573 | let u = (((self.bytes[0] as u32) << 18) & 0x1fffff) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:574:21 [INFO] [stderr] | [INFO] [stderr] 574 | | (((self.bytes[1] as u32) << 12) & 0x3ffff) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:575:21 [INFO] [stderr] | [INFO] [stderr] 575 | | (((self.bytes[2] as u32) << 6) & 0xfff) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:576:20 [INFO] [stderr] | [INFO] [stderr] 576 | | ((self.bytes[3] as u32) & 0x3f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/mod.rs:57:54 [INFO] [stderr] | [INFO] [stderr] 57 | unsafe { ::std::char::from_u32_unchecked(byte as u32) }, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/term/mod.rs:32:14 [INFO] [stderr] | [INFO] [stderr] 32 | fn count(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input/unix/esckey.rs:134:29 [INFO] [stderr] | [INFO] [stderr] 134 | fn is_shifted_key(scap: &cap::String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `cap::String` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/input/unix/mod.rs:145:16 [INFO] [stderr] | [INFO] [stderr] 145 | if len < 1 || !reader.parse_signal(buf).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `len < 1 || reader.parse_signal(buf).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_micros()` is more concise than this calculation [INFO] [stderr] --> src/input/unix/mod.rs:152:41 [INFO] [stderr] | [INFO] [stderr] 152 | let elapsed = i64::from(tstart.elapsed().subsec_nanos() / 1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tstart.elapsed().subsec_micros()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:523:25 [INFO] [stderr] | [INFO] [stderr] 523 | let u = self.bytes[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:539:26 [INFO] [stderr] | [INFO] [stderr] 539 | let u = ((self.bytes[0] as u32) << 6) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:540:24 [INFO] [stderr] | [INFO] [stderr] 540 | | ((self.bytes[1] as u32) & 0x3f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:556:27 [INFO] [stderr] | [INFO] [stderr] 556 | let u = (((self.bytes[0] as u32) << 12) & 0xffff) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:557:25 [INFO] [stderr] | [INFO] [stderr] 557 | | (((self.bytes[1] as u32) << 6) & 0xfff) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:558:24 [INFO] [stderr] | [INFO] [stderr] 558 | | ((self.bytes[2] as u32) & 0x3f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:573:23 [INFO] [stderr] | [INFO] [stderr] 573 | let u = (((self.bytes[0] as u32) << 18) & 0x1fffff) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:574:21 [INFO] [stderr] | [INFO] [stderr] 574 | | (((self.bytes[1] as u32) << 12) & 0x3ffff) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:575:21 [INFO] [stderr] | [INFO] [stderr] 575 | | (((self.bytes[2] as u32) << 6) & 0xfff) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/unix/mod.rs:576:20 [INFO] [stderr] | [INFO] [stderr] 576 | | ((self.bytes[3] as u32) & 0x3f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.bytes[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/input/mod.rs:57:54 [INFO] [stderr] | [INFO] [stderr] 57 | unsafe { ::std::char::from_u32_unchecked(byte as u32) }, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> examples/colors.rs:238:15 [INFO] [stderr] | [INFO] [stderr] 238 | fn to_p16(&mut self) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> examples/colors.rs:245:16 [INFO] [stderr] | [INFO] [stderr] 245 | fn to_p256(&mut self) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> examples/colors.rs:252:16 [INFO] [stderr] | [INFO] [stderr] 252 | fn to_true(&mut self) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> examples/colors.rs:285:20 [INFO] [stderr] | [INFO] [stderr] 285 | if let Some(_) = evt.as_any().downcast_ref::() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 286 | | self.offset += 1; [INFO] [stderr] 287 | | self.paint(); [INFO] [stderr] 288 | | } [INFO] [stderr] | |_____________- help: try this: `if evt.as_any().downcast_ref::().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/pentominoes.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/pentominoes.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/pentominoes.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> examples/pentominoes.rs:65:30 [INFO] [stderr] | [INFO] [stderr] 65 | fn paint(&mut self, sol: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> examples/pentominoes.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | / if (x == self.hole_x || x == self.hole_x + 1) [INFO] [stderr] 151 | | && (y == self.hole_y || y == self.hole_y + 1) [INFO] [stderr] 152 | | { [INFO] [stderr] 153 | | return false; [INFO] [stderr] 154 | | } else { [INFO] [stderr] 155 | | return true; [INFO] [stderr] 156 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 150 | return !((x == self.hole_x || x == self.hole_x + 1) [INFO] [stderr] 151 | && (y == self.hole_y || y == self.hole_y + 1)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.33s [INFO] running `"docker" "inspect" "91bdabbcf938e0b1a0e73018df917fba98a1156353bd5dffdb52b4a5fd1b5963"` [INFO] running `"docker" "rm" "-f" "91bdabbcf938e0b1a0e73018df917fba98a1156353bd5dffdb52b4a5fd1b5963"` [INFO] [stdout] 91bdabbcf938e0b1a0e73018df917fba98a1156353bd5dffdb52b4a5fd1b5963