[INFO] crate tvdb 0.5.1 is already in cache
[INFO] extracting crate tvdb 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/tvdb/0.5.1
[INFO] extracting crate tvdb 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tvdb/0.5.1
[INFO] validating manifest of tvdb-0.5.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tvdb-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tvdb-0.5.1
[INFO] removed 3 missing examples
[INFO] finished frobbing tvdb-0.5.1
[INFO] frobbed toml for tvdb-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/tvdb/0.5.1/Cargo.toml
[INFO] started frobbing tvdb-0.5.1
[INFO] removed 3 missing examples
[INFO] finished frobbing tvdb-0.5.1
[INFO] frobbed toml for tvdb-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tvdb/0.5.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tvdb-0.5.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tvdb/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ff54444e3265d2d762568dcd855882ec62f1336663ff0b9a4f8dc4ad5d7078a9
[INFO] running `"docker" "start" "-a" "ff54444e3265d2d762568dcd855882ec62f1336663ff0b9a4f8dc4ad5d7078a9"`
[INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently
[INFO] [stderr] disables Cargo from automatically inferring other example targets.
[INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following
[INFO] [stderr] files will be included as a example target:
[INFO] [stderr] 
[INFO] [stderr] * /opt/crater/workdir/examples/tvdb-lookup.rs
[INFO] [stderr] * /opt/crater/workdir/examples/tvdb-random.rs
[INFO] [stderr] * /opt/crater/workdir/examples/tvdb-basic.rs
[INFO] [stderr] 
[INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be
[INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself
[INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package]
[INFO] [stderr] section. You may also move the files to a location where Cargo would not
[INFO] [stderr] automatically infer them to be a target, such as in subfolders.
[INFO] [stderr] 
[INFO] [stderr] For more information on this warning you can consult
[INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330
[INFO] [stderr]     Checking tvdb v0.5.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             seriesid: seriesid,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `seriesid`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/data.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             seriesid: seriesid,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `seriesid`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/raw.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return Ok(result);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/raw.rs:178:9
[INFO] [stderr]     |
[INFO] [stderr] 178 |         return Ok(result);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/raw.rs:204:9
[INFO] [stderr]     |
[INFO] [stderr] 204 |         return Ok(result?);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result?)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/raw.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return Ok(result);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/raw.rs:178:9
[INFO] [stderr]     |
[INFO] [stderr] 178 |         return Ok(result);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/raw.rs:204:9
[INFO] [stderr]     |
[INFO] [stderr] 204 |         return Ok(result?);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result?)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/raw.rs:100:33
[INFO] [stderr]     |
[INFO] [stderr] 100 |             Some(ref t) => Some(format!("{}", *t)),
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `*t.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/raw.rs:100:33
[INFO] [stderr]     |
[INFO] [stderr] 100 |             Some(ref t) => Some(format!("{}", *t)),
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `*t.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> tests/lib.rs:8:16
[INFO] [stderr]   |
[INFO] [stderr] 8 | const APIKEY: &'static str = "0629B785CE550C8D";
[INFO] [stderr]   |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/lib.rs:30:41
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let ep = api.episode(EpisodeId::new(184603, "en"));
[INFO] [stderr]    |                                         ^^^^^^ help: consider: `184_603`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/lib.rs:39:26
[INFO] [stderr]    |
[INFO] [stderr] 39 |     let ep = api.episode(184603);
[INFO] [stderr]    |                          ^^^^^^ help: consider: `184_603`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/lib.rs:68:9
[INFO] [stderr]    |
[INFO] [stderr] 68 |         return DummyRequestClient {};
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DummyRequestClient {}`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> tests/lib.rs:74:9
[INFO] [stderr]    |
[INFO] [stderr] 74 | /         return Err(TvdbError::CommunicationError {
[INFO] [stderr] 75 | |             reason: format!(
[INFO] [stderr] 76 | |                 "Fake error while doing fake request for: {:?} with JWT {:?}",
[INFO] [stderr] 77 | |                 url, jwt_token,
[INFO] [stderr] 78 | |             ),
[INFO] [stderr] 79 | |         });
[INFO] [stderr]    | |___________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 74 |         Err(TvdbError::CommunicationError {
[INFO] [stderr] 75 |             reason: format!(
[INFO] [stderr] 76 |                 "Fake error while doing fake request for: {:?} with JWT {:?}",
[INFO] [stderr] 77 |                 url, jwt_token,
[INFO] [stderr] 78 |             ),
[INFO] [stderr] 79 |         })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`.
[INFO] [stderr]   --> tests/lib.rs:97:17
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 TvdbError::CommunicationError { reason: _ } => (),
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: Try with `CommunicationError { .. }` instead
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 15.74s
[INFO] running `"docker" "inspect" "ff54444e3265d2d762568dcd855882ec62f1336663ff0b9a4f8dc4ad5d7078a9"`
[INFO] running `"docker" "rm" "-f" "ff54444e3265d2d762568dcd855882ec62f1336663ff0b9a4f8dc4ad5d7078a9"`
[INFO] [stdout] ff54444e3265d2d762568dcd855882ec62f1336663ff0b9a4f8dc4ad5d7078a9