[INFO] crate tv1d 0.1.0 is already in cache [INFO] extracting crate tv1d 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/tv1d/0.1.0 [INFO] extracting crate tv1d 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tv1d/0.1.0 [INFO] validating manifest of tv1d-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tv1d-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tv1d-0.1.0 [INFO] finished frobbing tv1d-0.1.0 [INFO] frobbed toml for tv1d-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/tv1d/0.1.0/Cargo.toml [INFO] started frobbing tv1d-0.1.0 [INFO] finished frobbing tv1d-0.1.0 [INFO] frobbed toml for tv1d-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tv1d/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tv1d-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tv1d/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2deb8846ef3a7240a8a1f460826860fe3c44b72f1e44fa951369881899badd9c [INFO] running `"docker" "start" "-a" "2deb8846ef3a7240a8a1f460826860fe3c44b72f1e44fa951369881899badd9c"` [INFO] [stderr] Checking tv1d v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/utils.rs:2:68 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn sync_values(anchor_value: usize, values: &mut [&mut usize]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/utils.rs:2:68 [INFO] [stderr] | [INFO] [stderr] 2 | pub fn sync_values(anchor_value: usize, values: &mut [&mut usize]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:467:43 [INFO] [stderr] | [INFO] [stderr] 467 | let output_expected = vec![116.0, 412.100006, 155.199997, 248.199997, 861.400024, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `412.100_006` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:467:55 [INFO] [stderr] | [INFO] [stderr] 467 | let output_expected = vec![116.0, 412.100006, 155.199997, 248.199997, 861.400024, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `155.199_997` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:467:67 [INFO] [stderr] | [INFO] [stderr] 467 | let output_expected = vec![116.0, 412.100006, 155.199997, 248.199997, 861.400024, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `248.199_997` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:467:79 [INFO] [stderr] | [INFO] [stderr] 467 | let output_expected = vec![116.0, 412.100006, 155.199997, 248.199997, 861.400024, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `861.400_024` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:468:36 [INFO] [stderr] | [INFO] [stderr] 468 | 675.200012, 436.200012, 315.100006]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `675.200_012` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:468:48 [INFO] [stderr] | [INFO] [stderr] 468 | 675.200012, 436.200012, 315.100006]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `436.200_012` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:468:60 [INFO] [stderr] | [INFO] [stderr] 468 | 675.200012, 436.200012, 315.100006]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `315.100_006` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:511:36 [INFO] [stderr] | [INFO] [stderr] 511 | let output_expected = vec![402.425049, 402.425049, 402.425049, 402.425049, 402.425049, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `402.425_049` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:511:48 [INFO] [stderr] | [INFO] [stderr] 511 | let output_expected = vec![402.425049, 402.425049, 402.425049, 402.425049, 402.425049, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `402.425_049` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:511:60 [INFO] [stderr] | [INFO] [stderr] 511 | let output_expected = vec![402.425049, 402.425049, 402.425049, 402.425049, 402.425049, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `402.425_049` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:511:72 [INFO] [stderr] | [INFO] [stderr] 511 | let output_expected = vec![402.425049, 402.425049, 402.425049, 402.425049, 402.425049, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `402.425_049` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:511:84 [INFO] [stderr] | [INFO] [stderr] 511 | let output_expected = vec![402.425049, 402.425049, 402.425049, 402.425049, 402.425049, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `402.425_049` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:512:36 [INFO] [stderr] | [INFO] [stderr] 512 | 402.425049, 402.425049, 402.425049]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `402.425_049` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:512:48 [INFO] [stderr] | [INFO] [stderr] 512 | 402.425049, 402.425049, 402.425049]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `402.425_049` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:512:60 [INFO] [stderr] | [INFO] [stderr] 512 | 402.425049, 402.425049, 402.425049]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `402.425_049` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:527:36 [INFO] [stderr] | [INFO] [stderr] 527 | let output_expected = vec![3.050000, 3.050000, 4.933333, 4.933333, 4.933333, 5.200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `3.050_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:527:46 [INFO] [stderr] | [INFO] [stderr] 527 | let output_expected = vec![3.050000, 3.050000, 4.933333, 4.933333, 4.933333, 5.200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `3.050_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:527:56 [INFO] [stderr] | [INFO] [stderr] 527 | let output_expected = vec![3.050000, 3.050000, 4.933333, 4.933333, 4.933333, 5.200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `4.933_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:527:66 [INFO] [stderr] | [INFO] [stderr] 527 | let output_expected = vec![3.050000, 3.050000, 4.933333, 4.933333, 4.933333, 5.200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `4.933_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:527:76 [INFO] [stderr] | [INFO] [stderr] 527 | let output_expected = vec![3.050000, 3.050000, 4.933333, 4.933333, 4.933333, 5.200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `4.933_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:527:86 [INFO] [stderr] | [INFO] [stderr] 527 | let output_expected = vec![3.050000, 3.050000, 4.933333, 4.933333, 4.933333, 5.200000, [INFO] [stderr] | ^^^^^^^^ help: consider: `5.200_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:528:36 [INFO] [stderr] | [INFO] [stderr] 528 | 6.200000, 7.100000]; [INFO] [stderr] | ^^^^^^^^ help: consider: `6.200_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:528:46 [INFO] [stderr] | [INFO] [stderr] 528 | 6.200000, 7.100000]; [INFO] [stderr] | ^^^^^^^^ help: consider: `7.100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:532:60 [INFO] [stderr] | [INFO] [stderr] 532 | assert!((output_data - expected_data).abs() <= 0.000001); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | assert!(input.len() > 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:205:14 [INFO] [stderr] | [INFO] [stderr] 205 | for i in 1..(c_low - s_low + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=c_low - s_low` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | assert!(input.len() > 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | assert!(input.len() > 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:205:14 [INFO] [stderr] | [INFO] [stderr] 205 | for i in 1..(c_low - s_low + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=c_low - s_low` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:288:13 [INFO] [stderr] | [INFO] [stderr] 288 | assert!(input.len() > 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.60s [INFO] running `"docker" "inspect" "2deb8846ef3a7240a8a1f460826860fe3c44b72f1e44fa951369881899badd9c"` [INFO] running `"docker" "rm" "-f" "2deb8846ef3a7240a8a1f460826860fe3c44b72f1e44fa951369881899badd9c"` [INFO] [stdout] 2deb8846ef3a7240a8a1f460826860fe3c44b72f1e44fa951369881899badd9c