[INFO] crate tuple_storage 0.1.1 is already in cache [INFO] extracting crate tuple_storage 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/tuple_storage/0.1.1 [INFO] extracting crate tuple_storage 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tuple_storage/0.1.1 [INFO] validating manifest of tuple_storage-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tuple_storage-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tuple_storage-0.1.1 [INFO] finished frobbing tuple_storage-0.1.1 [INFO] frobbed toml for tuple_storage-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/tuple_storage/0.1.1/Cargo.toml [INFO] started frobbing tuple_storage-0.1.1 [INFO] finished frobbing tuple_storage-0.1.1 [INFO] frobbed toml for tuple_storage-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tuple_storage/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tuple_storage-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tuple_storage/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50960391abd2125cd9f5d18f5cab775dc22e5aef8423db8608e5e3188a234f95 [INFO] running `"docker" "start" "-a" "50960391abd2125cd9f5d18f5cab775dc22e5aef8423db8608e5e3188a234f95"` [INFO] [stderr] Checking tuple_storage v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/mmap_util.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn get_slice<'b : 'a, T: Sized + Copy>(&mut self, n_elements: usize) -> &[T] { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/mmap_util.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn get_str_slice<'b : 'a>(&mut self, n_elements: usize) -> &str { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | Self::base_size() as u64 + self.schema.serialized_size() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(Self::base_size())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:365:32 [INFO] [stderr] | [INFO] [stderr] 365 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:476:13 [INFO] [stderr] | [INFO] [stderr] 476 | let ref schema = storage.header.schema; [INFO] [stderr] | ----^^^^^^^^^^------------------------- help: try: `let schema = &storage.header.schema;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:482:32 [INFO] [stderr] | [INFO] [stderr] 482 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/bin/tuple_storage.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/bin/tuple_storage.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/mmap_util.rs:93:22 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn get_slice<'b : 'a, T: Sized + Copy>(&mut self, n_elements: usize) -> &[T] { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/mmap_util.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn get_str_slice<'b : 'a>(&mut self, n_elements: usize) -> &str { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | Self::base_size() as u64 + self.schema.serialized_size() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(Self::base_size())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:365:32 [INFO] [stderr] | [INFO] [stderr] 365 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:476:13 [INFO] [stderr] | [INFO] [stderr] 476 | let ref schema = storage.header.schema; [INFO] [stderr] | ----^^^^^^^^^^------------------------- help: try: `let schema = &storage.header.schema;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:482:32 [INFO] [stderr] | [INFO] [stderr] 482 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/tuple_storage.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:57:6 [INFO] [stderr] | [INFO] [stderr] 57 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 58 | | [INFO] [stderr] 59 | | if args.get_bool("show") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:62:6 [INFO] [stderr] | [INFO] [stderr] 62 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 63 | | [INFO] [stderr] 64 | | if args.get_bool("info") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:67:6 [INFO] [stderr] | [INFO] [stderr] 67 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 68 | | [INFO] [stderr] 69 | | if args.get_bool("insert") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:73:6 [INFO] [stderr] | [INFO] [stderr] 73 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 74 | | [INFO] [stderr] 75 | | if args.get_bool("append") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:79:6 [INFO] [stderr] | [INFO] [stderr] 79 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 80 | | [INFO] [stderr] 81 | | if args.get_bool("update") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:85:6 [INFO] [stderr] | [INFO] [stderr] 85 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | if args.get_bool("search") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:104:6 [INFO] [stderr] | [INFO] [stderr] 104 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 105 | | [INFO] [stderr] 106 | | if args.get_bool("remove") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:111:6 [INFO] [stderr] | [INFO] [stderr] 111 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 112 | | [INFO] [stderr] 113 | | if args.get_bool("remove_all") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/tuple_storage.rs:7:15 [INFO] [stderr] | [INFO] [stderr] 7 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:57:6 [INFO] [stderr] | [INFO] [stderr] 57 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 58 | | [INFO] [stderr] 59 | | if args.get_bool("show") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:62:6 [INFO] [stderr] | [INFO] [stderr] 62 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 63 | | [INFO] [stderr] 64 | | if args.get_bool("info") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:67:6 [INFO] [stderr] | [INFO] [stderr] 67 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 68 | | [INFO] [stderr] 69 | | if args.get_bool("insert") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:73:6 [INFO] [stderr] | [INFO] [stderr] 73 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 74 | | [INFO] [stderr] 75 | | if args.get_bool("append") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:79:6 [INFO] [stderr] | [INFO] [stderr] 79 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 80 | | [INFO] [stderr] 81 | | if args.get_bool("update") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:85:6 [INFO] [stderr] | [INFO] [stderr] 85 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | if args.get_bool("search") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:104:6 [INFO] [stderr] | [INFO] [stderr] 104 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 105 | | [INFO] [stderr] 106 | | if args.get_bool("remove") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/bin/tuple_storage.rs:111:6 [INFO] [stderr] | [INFO] [stderr] 111 | } else [INFO] [stderr] | ______^ [INFO] [stderr] 112 | | [INFO] [stderr] 113 | | if args.get_bool("remove_all") { [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.79s [INFO] running `"docker" "inspect" "50960391abd2125cd9f5d18f5cab775dc22e5aef8423db8608e5e3188a234f95"` [INFO] running `"docker" "rm" "-f" "50960391abd2125cd9f5d18f5cab775dc22e5aef8423db8608e5e3188a234f95"` [INFO] [stdout] 50960391abd2125cd9f5d18f5cab775dc22e5aef8423db8608e5e3188a234f95