[INFO] crate tun 0.4.2 is already in cache [INFO] extracting crate tun 0.4.2 into work/ex/clippy-test-run/sources/stable/reg/tun/0.4.2 [INFO] extracting crate tun 0.4.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tun/0.4.2 [INFO] validating manifest of tun-0.4.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tun-0.4.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tun-0.4.2 [INFO] finished frobbing tun-0.4.2 [INFO] frobbed toml for tun-0.4.2 written to work/ex/clippy-test-run/sources/stable/reg/tun/0.4.2/Cargo.toml [INFO] started frobbing tun-0.4.2 [INFO] finished frobbing tun-0.4.2 [INFO] frobbed toml for tun-0.4.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tun/0.4.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tun-0.4.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tun/0.4.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 107bcef50e64217b5ce4c191292fcbc4c5c49f4da15c321714b16c04a3fdb138 [INFO] running `"docker" "start" "-a" "107bcef50e64217b5ce4c191292fcbc4c5c49f4da15c321714b16c04a3fdb138"` [INFO] [stderr] Checking ioctl-sys v0.5.2 [INFO] [stderr] Checking tun v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux/device.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | tun: tun, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `tun` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux/device.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | ctl: ctl, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `ctl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux/device.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | tun: tun, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `tun` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform/linux/device.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | ctl: ctl, [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `ctl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/platform/posix/sockaddr.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | ((parts[0] as c_uint)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/platform/posix/sockaddr.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | ((parts[0] as c_uint)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/address.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/address.rs:88:8 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(value.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/address.rs:104:6 [INFO] [stderr] | [INFO] [stderr] 104 | Ok(self.ip().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.ip()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/address.rs:118:8 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(value.ip().clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*value.ip()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const libc::sockaddr_in`) [INFO] [stderr] --> src/platform/posix/sockaddr.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(SockAddr(ptr::read(value as *const _ as *const _))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/platform/posix/sockaddr.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | ((parts[3] as c_uint) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/platform/posix/sockaddr.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | ((parts[2] as c_uint) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/platform/posix/sockaddr.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | ((parts[1] as c_uint) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/platform/posix/sockaddr.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | ((parts[0] as c_uint)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/platform/posix/fd.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | return Err(io::Error::last_os_error().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::last_os_error()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/platform/posix/fd.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | return Err(io::Error::last_os_error().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::last_os_error()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/platform/posix/split.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | return Err(io::Error::last_os_error().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::last_os_error()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/platform/posix/split.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | return Err(io::Error::last_os_error().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::last_os_error()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: The function/method `siocsifflags` doesn't need a mutable reference [INFO] [stderr] --> src/platform/linux/device.rs:198:42 [INFO] [stderr] | [INFO] [stderr] 198 | if siocsifflags(self.ctl.as_raw_fd(), &mut req) < 0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tun`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/address.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | Ok(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/address.rs:88:8 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(value.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/address.rs:104:6 [INFO] [stderr] | [INFO] [stderr] 104 | Ok(self.ip().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.ip()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/address.rs:118:8 [INFO] [stderr] | [INFO] [stderr] 118 | Ok(value.ip().clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*value.ip()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: casting from `*const libc::sockaddr` to a more-strictly-aligned pointer (`*const libc::sockaddr_in`) [INFO] [stderr] --> src/platform/posix/sockaddr.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(SockAddr(ptr::read(value as *const _ as *const _))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/platform/posix/sockaddr.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | ((parts[3] as c_uint) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/platform/posix/sockaddr.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | ((parts[2] as c_uint) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/platform/posix/sockaddr.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | ((parts[1] as c_uint) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/platform/posix/sockaddr.rs:71:4 [INFO] [stderr] | [INFO] [stderr] 71 | ((parts[0] as c_uint)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parts[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/platform/posix/fd.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | return Err(io::Error::last_os_error().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::last_os_error()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/platform/posix/fd.rs:54:16 [INFO] [stderr] | [INFO] [stderr] 54 | return Err(io::Error::last_os_error().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::last_os_error()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/platform/posix/split.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | return Err(io::Error::last_os_error().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::last_os_error()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/platform/posix/split.rs:48:16 [INFO] [stderr] | [INFO] [stderr] 48 | return Err(io::Error::last_os_error().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::last_os_error()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: The function/method `siocsifflags` doesn't need a mutable reference [INFO] [stderr] --> src/platform/linux/device.rs:198:42 [INFO] [stderr] | [INFO] [stderr] 198 | if siocsifflags(self.ctl.as_raw_fd(), &mut req) < 0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `tun`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "107bcef50e64217b5ce4c191292fcbc4c5c49f4da15c321714b16c04a3fdb138"` [INFO] running `"docker" "rm" "-f" "107bcef50e64217b5ce4c191292fcbc4c5c49f4da15c321714b16c04a3fdb138"` [INFO] [stdout] 107bcef50e64217b5ce4c191292fcbc4c5c49f4da15c321714b16c04a3fdb138