[INFO] crate ttl_cache 0.5.1 is already in cache [INFO] extracting crate ttl_cache 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/ttl_cache/0.5.1 [INFO] extracting crate ttl_cache 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ttl_cache/0.5.1 [INFO] validating manifest of ttl_cache-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ttl_cache-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ttl_cache-0.5.1 [INFO] finished frobbing ttl_cache-0.5.1 [INFO] frobbed toml for ttl_cache-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/ttl_cache/0.5.1/Cargo.toml [INFO] started frobbing ttl_cache-0.5.1 [INFO] finished frobbing ttl_cache-0.5.1 [INFO] frobbed toml for ttl_cache-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ttl_cache/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ttl_cache-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ttl_cache/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 007b55f448841743dfbfd335a6d51c2bb49ed1664ebfbfeea6a4ec9203563785 [INFO] running `"docker" "start" "-a" "007b55f448841743dfbfd335a6d51c2bb49ed1664ebfbfeea6a4ec9203563785"` [INFO] [stderr] Checking ttl_cache v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | to_ret [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:249:22 [INFO] [stderr] | [INFO] [stderr] 249 | let to_ret = self.map [INFO] [stderr] | ______________________^ [INFO] [stderr] 250 | | .get(k) [INFO] [stderr] 251 | | .and_then(|x| if x.is_expired() { None } else { Some(&x.value) }); [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | to_ret [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:288:22 [INFO] [stderr] | [INFO] [stderr] 288 | let to_ret = self.map.get_mut(k).and_then(|x| { [INFO] [stderr] | ______________________^ [INFO] [stderr] 289 | | if x.is_expired() { [INFO] [stderr] 290 | | None [INFO] [stderr] 291 | | } else { [INFO] [stderr] 292 | | Some(&mut x.value) [INFO] [stderr] 293 | | } [INFO] [stderr] 294 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | to_ret [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:249:22 [INFO] [stderr] | [INFO] [stderr] 249 | let to_ret = self.map [INFO] [stderr] | ______________________^ [INFO] [stderr] 250 | | .get(k) [INFO] [stderr] 251 | | .and_then(|x| if x.is_expired() { None } else { Some(&x.value) }); [INFO] [stderr] | |_____________________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:303:9 [INFO] [stderr] | [INFO] [stderr] 303 | to_ret [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:288:22 [INFO] [stderr] | [INFO] [stderr] 288 | let to_ret = self.map.get_mut(k).and_then(|x| { [INFO] [stderr] | ______________________^ [INFO] [stderr] 289 | | if x.is_expired() { [INFO] [stderr] 290 | | None [INFO] [stderr] 291 | | } else { [INFO] [stderr] 292 | | Some(&mut x.value) [INFO] [stderr] 293 | | } [INFO] [stderr] 294 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> tests/test.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | cache.get_mut(&1).map(|v| *v = 20); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = cache.get_mut(&1) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.88s [INFO] running `"docker" "inspect" "007b55f448841743dfbfd335a6d51c2bb49ed1664ebfbfeea6a4ec9203563785"` [INFO] running `"docker" "rm" "-f" "007b55f448841743dfbfd335a6d51c2bb49ed1664ebfbfeea6a4ec9203563785"` [INFO] [stdout] 007b55f448841743dfbfd335a6d51c2bb49ed1664ebfbfeea6a4ec9203563785