[INFO] crate tsv 0.1.1 is already in cache [INFO] extracting crate tsv 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/tsv/0.1.1 [INFO] extracting crate tsv 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsv/0.1.1 [INFO] validating manifest of tsv-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tsv-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tsv-0.1.1 [INFO] finished frobbing tsv-0.1.1 [INFO] frobbed toml for tsv-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/tsv/0.1.1/Cargo.toml [INFO] started frobbing tsv-0.1.1 [INFO] finished frobbing tsv-0.1.1 [INFO] frobbed toml for tsv-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsv/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tsv-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tsv/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7cbe224136b0da161a5c68cb29c4e053be4997c239416468667d8a0baa7e6f0 [INFO] running `"docker" "start" "-a" "d7cbe224136b0da161a5c68cb29c4e053be4997c239416468667d8a0baa7e6f0"` [INFO] [stderr] Checking indexed v0.1.1 [INFO] [stderr] Compiling serde_derive_internals v0.21.0 [INFO] [stderr] Checking trees v0.2.1 [INFO] [stderr] Compiling reflection_derive v0.1.1 [INFO] [stderr] Checking reflection v0.1.3 [INFO] [stderr] Checking tsv v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de.rs:202:16 [INFO] [stderr] | [INFO] [stderr] 202 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 203 | | if let Some( visit ) = self.columns.get() { [INFO] [stderr] 204 | | return Some( visit.node().data.range.clone() ); [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 202 | } else if let Some( visit ) = self.columns.get() { [INFO] [stderr] 203 | return Some( visit.node().data.range.clone() ); [INFO] [stderr] 204 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/de.rs:202:16 [INFO] [stderr] | [INFO] [stderr] 202 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 203 | | if let Some( visit ) = self.columns.get() { [INFO] [stderr] 204 | | return Some( visit.node().data.range.clone() ); [INFO] [stderr] 205 | | } [INFO] [stderr] 206 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 202 | } else if let Some( visit ) = self.columns.get() { [INFO] [stderr] 203 | return Some( visit.node().data.range.clone() ); [INFO] [stderr] 204 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ser.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | enum_col_end.map( |end| self.col = end ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(end) = enum_col_end { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ser.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | for _ in row.len() .. self.col+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `row.len()..=self.col` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ser.rs:79:18 [INFO] [stderr] | [INFO] [stderr] 79 | for _ in self.grids.len() .. self.row+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.grids.len()..=self.row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ser.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | for _ in self.grids.len() .. self.row+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.grids.len()..=self.row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ser.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | range.map( |range| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 139 | || let start = self.grids[ self.row ].len(); [INFO] [stderr] 140 | || for _ in start..range.end { [INFO] [stderr] 141 | || self.grids[ self.row ].push( String::new() ); [INFO] [stderr] 142 | || } [INFO] [stderr] 143 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(range) = range { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ser.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | fn row_to_string( row: &Vec ) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ser.rs:184:27 [INFO] [stderr] | [INFO] [stderr] 184 | fn table_to_string( rows: &Vec> ) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:218:74 [INFO] [stderr] | [INFO] [stderr] 218 | fn serialize_i8 ( self, v: i8 ) -> Result<()> { self.serialize_i64( v as i64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:219:74 [INFO] [stderr] | [INFO] [stderr] 219 | fn serialize_i16( self, v: i16 ) -> Result<()> { self.serialize_i64( v as i64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:220:74 [INFO] [stderr] | [INFO] [stderr] 220 | fn serialize_i32( self, v: i32 ) -> Result<()> { self.serialize_i64( v as i64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:223:74 [INFO] [stderr] | [INFO] [stderr] 223 | fn serialize_u8 ( self, v: u8 ) -> Result<()> { self.serialize_u64( v as u64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:224:74 [INFO] [stderr] | [INFO] [stderr] 224 | fn serialize_u16( self, v: u16 ) -> Result<()> { self.serialize_u64( v as u64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:225:74 [INFO] [stderr] | [INFO] [stderr] 225 | fn serialize_u32( self, v: u32 ) -> Result<()> { self.serialize_u64( v as u64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:228:74 [INFO] [stderr] | [INFO] [stderr] 228 | fn serialize_f32( self, v: f32 ) -> Result<()> { self.serialize_f64( v as f64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/de.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | fn to_parent_column( &mut self ) -> Option> { self.columns.to_parent() } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/table.rs:37:49 [INFO] [stderr] | [INFO] [stderr] 37 | tr( Column::new( node.data.clone(), start..start+1 )) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `start..=start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/table.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | nodes.last_mut().map( |last| last.next = 0 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(last) = nodes.last_mut() { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/table.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | fn row_to_string( row: &Vec ) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[Id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/table.rs:150:16 [INFO] [stderr] | [INFO] [stderr] 150 | return output + &"\n"; [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `RESERVED_CHAR`. [INFO] [stderr] --> src/lib.rs:102:22 [INFO] [stderr] | [INFO] [stderr] 102 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 102 | for in &RESERVED_CHAR { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ser.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | enum_col_end.map( |end| self.col = end ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(end) = enum_col_end { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ser.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | for _ in row.len() .. self.col+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `row.len()..=self.col` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ser.rs:79:18 [INFO] [stderr] | [INFO] [stderr] 79 | for _ in self.grids.len() .. self.row+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.grids.len()..=self.row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/ser.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | for _ in self.grids.len() .. self.row+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `self.grids.len()..=self.row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ser.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | range.map( |range| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 139 | || let start = self.grids[ self.row ].len(); [INFO] [stderr] 140 | || for _ in start..range.end { [INFO] [stderr] 141 | || self.grids[ self.row ].push( String::new() ); [INFO] [stderr] 142 | || } [INFO] [stderr] 143 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(range) = range { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/ser.rs:166:36 [INFO] [stderr] | [INFO] [stderr] 166 | fn print_column( &mut self ) { self.columns.get().map( |visit| eprintln!( "next_column: {:?}", visit )); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(visit) = self.columns.get() { $ crate :: io :: _eprint ( format_args_nl ! ( $ ( $ arg ) * ) ) ; }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ser.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | fn row_to_string( row: &Vec ) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ser.rs:184:27 [INFO] [stderr] | [INFO] [stderr] 184 | fn table_to_string( rows: &Vec> ) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:218:74 [INFO] [stderr] | [INFO] [stderr] 218 | fn serialize_i8 ( self, v: i8 ) -> Result<()> { self.serialize_i64( v as i64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:219:74 [INFO] [stderr] | [INFO] [stderr] 219 | fn serialize_i16( self, v: i16 ) -> Result<()> { self.serialize_i64( v as i64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:220:74 [INFO] [stderr] | [INFO] [stderr] 220 | fn serialize_i32( self, v: i32 ) -> Result<()> { self.serialize_i64( v as i64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:223:74 [INFO] [stderr] | [INFO] [stderr] 223 | fn serialize_u8 ( self, v: u8 ) -> Result<()> { self.serialize_u64( v as u64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:224:74 [INFO] [stderr] | [INFO] [stderr] 224 | fn serialize_u16( self, v: u16 ) -> Result<()> { self.serialize_u64( v as u64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:225:74 [INFO] [stderr] | [INFO] [stderr] 225 | fn serialize_u32( self, v: u32 ) -> Result<()> { self.serialize_u64( v as u64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ser.rs:228:74 [INFO] [stderr] | [INFO] [stderr] 228 | fn serialize_f32( self, v: f32 ) -> Result<()> { self.serialize_f64( v as f64 )} [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/de.rs:145:26 [INFO] [stderr] | [INFO] [stderr] 145 | fn to_parent_column( &mut self ) -> Option> { self.columns.to_parent().map( |visit| { eprintln!( "to_parent: {:?}", visit ); visit })} [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let expected =` [INFO] [stderr] --> src/de.rs:633:9 [INFO] [stderr] | [INFO] [stderr] 633 | let expected = (); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let result =` [INFO] [stderr] --> src/de.rs:635:9 [INFO] [stderr] | [INFO] [stderr] 635 | let result: () = from_str( input, <()>::schemata(), &mut env ).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/table.rs:37:49 [INFO] [stderr] | [INFO] [stderr] 37 | tr( Column::new( node.data.clone(), start..start+1 )) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `start..=start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/table.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | nodes.last_mut().map( |last| last.next = 0 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(last) = nodes.last_mut() { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/table.rs:134:28 [INFO] [stderr] | [INFO] [stderr] 134 | fn row_to_string( row: &Vec ) -> String { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[Id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/table.rs:150:16 [INFO] [stderr] | [INFO] [stderr] 150 | return output + &"\n"; [INFO] [stderr] | ^^^^^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"\n"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `RESERVED_CHAR`. [INFO] [stderr] --> src/lib.rs:102:22 [INFO] [stderr] | [INFO] [stderr] 102 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 102 | for in &RESERVED_CHAR { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.03s [INFO] running `"docker" "inspect" "d7cbe224136b0da161a5c68cb29c4e053be4997c239416468667d8a0baa7e6f0"` [INFO] running `"docker" "rm" "-f" "d7cbe224136b0da161a5c68cb29c4e053be4997c239416468667d8a0baa7e6f0"` [INFO] [stdout] d7cbe224136b0da161a5c68cb29c4e053be4997c239416468667d8a0baa7e6f0