[INFO] crate tsunami 0.7.2 is already in cache [INFO] extracting crate tsunami 0.7.2 into work/ex/clippy-test-run/sources/stable/reg/tsunami/0.7.2 [INFO] extracting crate tsunami 0.7.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsunami/0.7.2 [INFO] validating manifest of tsunami-0.7.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tsunami-0.7.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tsunami-0.7.2 [INFO] finished frobbing tsunami-0.7.2 [INFO] frobbed toml for tsunami-0.7.2 written to work/ex/clippy-test-run/sources/stable/reg/tsunami/0.7.2/Cargo.toml [INFO] started frobbing tsunami-0.7.2 [INFO] finished frobbing tsunami-0.7.2 [INFO] frobbed toml for tsunami-0.7.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsunami/0.7.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tsunami-0.7.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tsunami/0.7.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 652d102652f6ff2e6cf3ac8b377856ca59236865e2cedd797eda798801d56b86 [INFO] running `"docker" "start" "-a" "652d102652f6ff2e6cf3ac8b377856ca59236865e2cedd797eda798801d56b86"` [INFO] [stderr] Compiling slog v2.4.1 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Compiling rusoto_core v0.34.0 [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking isatty v0.1.9 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking crossbeam v0.6.0 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking ssh2 v0.3.3 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking hyper v0.12.23 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking rusoto_credential v0.13.0 [INFO] [stderr] Checking rusoto_ec2 v0.34.0 [INFO] [stderr] Checking rusoto_sts v0.34.0 [INFO] [stderr] Checking tsunami v0.7.2 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ssh.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 44 | | if start.elapsed() > Duration::from_secs(30) { [INFO] [stderr] 45 | | warn!(log, "still can't ssh to {}: {:?}", addr, e); [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 43 | } else if start.elapsed() > Duration::from_secs(30) { [INFO] [stderr] 44 | warn!(log, "still can't ssh to {}: {:?}", addr, e); [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ssh.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 44 | | if start.elapsed() > Duration::from_secs(30) { [INFO] [stderr] 45 | | warn!(log, "still can't ssh to {}: {:?}", addr, e); [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 43 | } else if start.elapsed() > Duration::from_secs(30) { [INFO] [stderr] 44 | warn!(log, "still can't ssh to {}: {:?}", addr, e); [INFO] [stderr] 45 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ssh.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | let mut sess = ssh2::Session::new().ok_or(Context::new("libssh2 not available"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Context::new("libssh2 not available"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn as_user(mut self, username: &str) -> Self { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:260:29 [INFO] [stderr] | [INFO] [stderr] 260 | self.max_duration = hours as i64 * 60; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/lib.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | / pub fn run_as(self, provider: P, f: F) -> Result [INFO] [stderr] 347 | | where [INFO] [stderr] 348 | | P: ProvideAwsCredentials + Send + Sync + 'static, [INFO] [stderr] 349 | |

::Future: Send, [INFO] [stderr] ... | [INFO] [stderr] 807 | | }) [INFO] [stderr] 808 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:389:9 [INFO] [stderr] | [INFO] [stderr] 389 | / let _ = ec2 [INFO] [stderr] 390 | | .authorize_security_group_ingress(req.clone()) [INFO] [stderr] 391 | | .sync() [INFO] [stderr] 392 | | .context("failed to fill in security group for new machines")?; [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | / let _ = ec2 [INFO] [stderr] 400 | | .authorize_security_group_ingress(req) [INFO] [stderr] 401 | | .sync() [INFO] [stderr] 402 | | .context("failed to fill in security group for new machines")?; [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:519:34 [INFO] [stderr] | [INFO] [stderr] 519 | .context(format!("failed to describe spot instances")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"failed to describe spot instances".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:804:18 [INFO] [stderr] | [INFO] [stderr] 804 | .map(|e| Err(e)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `Err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/ssh.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | let mut sess = ssh2::Session::new().ok_or(Context::new("libssh2 not available"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Context::new("libssh2 not available"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn as_user(mut self, username: &str) -> Self { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:260:29 [INFO] [stderr] | [INFO] [stderr] 260 | self.max_duration = hours as i64 * 60; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i64::from(hours)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/lib.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | / pub fn run_as(self, provider: P, f: F) -> Result [INFO] [stderr] 347 | | where [INFO] [stderr] 348 | | P: ProvideAwsCredentials + Send + Sync + 'static, [INFO] [stderr] 349 | |

::Future: Send, [INFO] [stderr] ... | [INFO] [stderr] 807 | | }) [INFO] [stderr] 808 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:389:9 [INFO] [stderr] | [INFO] [stderr] 389 | / let _ = ec2 [INFO] [stderr] 390 | | .authorize_security_group_ingress(req.clone()) [INFO] [stderr] 391 | | .sync() [INFO] [stderr] 392 | | .context("failed to fill in security group for new machines")?; [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/lib.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | / let _ = ec2 [INFO] [stderr] 400 | | .authorize_security_group_ingress(req) [INFO] [stderr] 401 | | .sync() [INFO] [stderr] 402 | | .context("failed to fill in security group for new machines")?; [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:519:34 [INFO] [stderr] | [INFO] [stderr] 519 | .context(format!("failed to describe spot instances")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"failed to describe spot instances".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:804:18 [INFO] [stderr] | [INFO] [stderr] 804 | .map(|e| Err(e)) [INFO] [stderr] | ^^^^^^^^^^ help: remove closure as shown: `Err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 02s [INFO] running `"docker" "inspect" "652d102652f6ff2e6cf3ac8b377856ca59236865e2cedd797eda798801d56b86"` [INFO] running `"docker" "rm" "-f" "652d102652f6ff2e6cf3ac8b377856ca59236865e2cedd797eda798801d56b86"` [INFO] [stdout] 652d102652f6ff2e6cf3ac8b377856ca59236865e2cedd797eda798801d56b86