[INFO] crate tsukurou 0.2.0 is already in cache [INFO] extracting crate tsukurou 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/tsukurou/0.2.0 [INFO] extracting crate tsukurou 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsukurou/0.2.0 [INFO] validating manifest of tsukurou-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tsukurou-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tsukurou-0.2.0 [INFO] finished frobbing tsukurou-0.2.0 [INFO] frobbed toml for tsukurou-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/tsukurou/0.2.0/Cargo.toml [INFO] started frobbing tsukurou-0.2.0 [INFO] finished frobbing tsukurou-0.2.0 [INFO] frobbed toml for tsukurou-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsukurou/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tsukurou-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tsukurou/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bc0c17fea0dfe87c74c27c4d668457cdc100806faec9cbe94b9d96b7f0cb59e6 [INFO] running `"docker" "start" "-a" "bc0c17fea0dfe87c74c27c4d668457cdc100806faec9cbe94b9d96b7f0cb59e6"` [INFO] [stderr] Checking tsukurou v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | / if let &Property::Boolean(x) = property { [INFO] [stderr] 197 | | Some(x) [INFO] [stderr] 198 | | } else { [INFO] [stderr] 199 | | None [INFO] [stderr] 200 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 196 | if let Property::Boolean(x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / if let &Property::Integer(x) = property { [INFO] [stderr] 213 | | Some(x) [INFO] [stderr] 214 | | } else { [INFO] [stderr] 215 | | None [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 212 | if let Property::Integer(x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | / if let &Property::Number(x) = property { [INFO] [stderr] 229 | | Some(x) [INFO] [stderr] 230 | | } else { [INFO] [stderr] 231 | | None [INFO] [stderr] 232 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 228 | if let Property::Number(x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | / if let &Property::Text(ref x) = property { [INFO] [stderr] 245 | | Some(x.clone()) [INFO] [stderr] 246 | | } else { [INFO] [stderr] 247 | | None [INFO] [stderr] 248 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 244 | if let Property::Text(ref x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | / if let &Property::Text(ref x) = property { [INFO] [stderr] 261 | | Some(x) [INFO] [stderr] 262 | | } else { [INFO] [stderr] 263 | | None [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 260 | if let Property::Text(ref x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / if let &Property::Properties(ref x) = property { [INFO] [stderr] 277 | | Some(x) [INFO] [stderr] 278 | | } else { [INFO] [stderr] 279 | | None [INFO] [stderr] 280 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 276 | if let Property::Properties(ref x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | / if let &mut Property::Properties(ref mut x) = property { [INFO] [stderr] 289 | | Some(x) [INFO] [stderr] 290 | | } else { [INFO] [stderr] 291 | | None [INFO] [stderr] 292 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 288 | if let Property::Properties(ref mut x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `f64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 329 | transitive_property!(f64 as f32); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/world/mod.rs:687:9 [INFO] [stderr] | [INFO] [stderr] 687 | / if self.chunks.contains_key(&location) { [INFO] [stderr] 688 | | Err(chunk) [INFO] [stderr] 689 | | } else { [INFO] [stderr] 690 | | self.chunks.insert(location, chunk); [INFO] [stderr] 691 | | Ok(()) [INFO] [stderr] 692 | | } [INFO] [stderr] | |_________^ help: consider using: `self.chunks.entry(location)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | / if let &Property::Boolean(x) = property { [INFO] [stderr] 197 | | Some(x) [INFO] [stderr] 198 | | } else { [INFO] [stderr] 199 | | None [INFO] [stderr] 200 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 196 | if let Property::Boolean(x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | / if let &Property::Integer(x) = property { [INFO] [stderr] 213 | | Some(x) [INFO] [stderr] 214 | | } else { [INFO] [stderr] 215 | | None [INFO] [stderr] 216 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 212 | if let Property::Integer(x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | / if let &Property::Number(x) = property { [INFO] [stderr] 229 | | Some(x) [INFO] [stderr] 230 | | } else { [INFO] [stderr] 231 | | None [INFO] [stderr] 232 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 228 | if let Property::Number(x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | / if let &Property::Text(ref x) = property { [INFO] [stderr] 245 | | Some(x.clone()) [INFO] [stderr] 246 | | } else { [INFO] [stderr] 247 | | None [INFO] [stderr] 248 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 244 | if let Property::Text(ref x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | / if let &Property::Text(ref x) = property { [INFO] [stderr] 261 | | Some(x) [INFO] [stderr] 262 | | } else { [INFO] [stderr] 263 | | None [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 260 | if let Property::Text(ref x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / if let &Property::Properties(ref x) = property { [INFO] [stderr] 277 | | Some(x) [INFO] [stderr] 278 | | } else { [INFO] [stderr] 279 | | None [INFO] [stderr] 280 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 276 | if let Property::Properties(ref x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/properties.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | / if let &mut Property::Properties(ref mut x) = property { [INFO] [stderr] 289 | | Some(x) [INFO] [stderr] 290 | | } else { [INFO] [stderr] 291 | | None [INFO] [stderr] 292 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 288 | if let Property::Properties(ref mut x) = *property { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `i64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 328 | transitive_property!(i64 as u64, i32, u32, i16, u16, i8, u8, isize, usize); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/properties.rs:321:36 [INFO] [stderr] | [INFO] [stderr] 321 | Property::from(y as $x) [INFO] [stderr] | ^ help: try: `f64::from(y)` [INFO] [stderr] ... [INFO] [stderr] 329 | transitive_property!(f64 as f32); [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/world/mod.rs:687:9 [INFO] [stderr] | [INFO] [stderr] 687 | / if self.chunks.contains_key(&location) { [INFO] [stderr] 688 | | Err(chunk) [INFO] [stderr] 689 | | } else { [INFO] [stderr] 690 | | self.chunks.insert(location, chunk); [INFO] [stderr] 691 | | Ok(()) [INFO] [stderr] 692 | | } [INFO] [stderr] | |_________^ help: consider using: `self.chunks.entry(location)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.35s [INFO] running `"docker" "inspect" "bc0c17fea0dfe87c74c27c4d668457cdc100806faec9cbe94b9d96b7f0cb59e6"` [INFO] running `"docker" "rm" "-f" "bc0c17fea0dfe87c74c27c4d668457cdc100806faec9cbe94b9d96b7f0cb59e6"` [INFO] [stdout] bc0c17fea0dfe87c74c27c4d668457cdc100806faec9cbe94b9d96b7f0cb59e6