[INFO] crate tsp 0.2.3 is already in cache
[INFO] extracting crate tsp 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/tsp/0.2.3
[INFO] extracting crate tsp 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsp/0.2.3
[INFO] validating manifest of tsp-0.2.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tsp-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tsp-0.2.3
[INFO] finished frobbing tsp-0.2.3
[INFO] frobbed toml for tsp-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/tsp/0.2.3/Cargo.toml
[INFO] started frobbing tsp-0.2.3
[INFO] finished frobbing tsp-0.2.3
[INFO] frobbed toml for tsp-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsp/0.2.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tsp-0.2.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tsp/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3012db0e4278ef7a8e7574e3ee2650cdbc8983c8bf1188eb16b31b74beb6e93c
[INFO] running `"docker" "start" "-a" "3012db0e4278ef7a8e7574e3ee2650cdbc8983c8bf1188eb16b31b74beb6e93c"`
[INFO] [stderr]    Compiling protobuf v1.7.4
[INFO] [stderr]     Checking tls-api v0.1.20
[INFO] [stderr]     Checking tsp v0.2.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server.rs:31:39
[INFO] [stderr]    |
[INFO] [stderr] 31 |     server.serve(move|| Ok(TSPService{app: app}));
[INFO] [stderr]    |                                       ^^^^^^^^ help: replace it with: `app`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/types.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server.rs:31:39
[INFO] [stderr]    |
[INFO] [stderr] 31 |     server.serve(move|| Ok(TSPService{app: app}));
[INFO] [stderr]    |                                       ^^^^^^^^ help: replace it with: `app`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/types.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/server.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         return Ok(message.ok());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(message.ok())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/types.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228
[INFO] [stderr]   --> src/server.rs:15:15
[INFO] [stderr]    |
[INFO] [stderr] 15 | use futures::{BoxFuture, Future};
[INFO] [stderr]    |               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec
[INFO] [stderr]   --> src/server.rs:21:41
[INFO] [stderr]    |
[INFO] [stderr] 21 | use tokio_io::codec::{Decoder, Encoder, Framed};
[INFO] [stderr]    |                                         ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec
[INFO] [stderr]    --> src/server.rs:106:22
[INFO] [stderr]     |
[INFO] [stderr] 106 |     type Transport = Framed<T, TSPCodec>;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228
[INFO] [stderr]    --> src/server.rs:123:19
[INFO] [stderr]     |
[INFO] [stderr] 123 |     type Future = BoxFuture<Self::Response, Self::Error>;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/server.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         return Ok(message.ok());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(message.ok())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/types.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead
[INFO] [stderr]    --> src/server.rs:110:15
[INFO] [stderr]     |
[INFO] [stderr] 110 |         Ok(io.framed(TSPCodec))
[INFO] [stderr]     |               ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'futures::Future::boxed': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228
[INFO] [stderr]    --> src/server.rs:127:30
[INFO] [stderr]     |
[INFO] [stderr] 127 |         future::ok(response).boxed()
[INFO] [stderr]     |                              ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228
[INFO] [stderr]   --> src/server.rs:15:15
[INFO] [stderr]    |
[INFO] [stderr] 15 | use futures::{BoxFuture, Future};
[INFO] [stderr]    |               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec
[INFO] [stderr]   --> src/server.rs:21:41
[INFO] [stderr]    |
[INFO] [stderr] 21 | use tokio_io::codec::{Decoder, Encoder, Framed};
[INFO] [stderr]    |                                         ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'tokio_io::codec::Framed': Moved to tokio-codec
[INFO] [stderr]    --> src/server.rs:106:22
[INFO] [stderr]     |
[INFO] [stderr] 106 |     type Transport = Framed<T, TSPCodec>;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'futures::BoxFuture': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228
[INFO] [stderr]    --> src/server.rs:123:19
[INFO] [stderr]     |
[INFO] [stderr] 123 |     type Future = BoxFuture<Self::Response, Self::Error>;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'tokio_io::AsyncRead::framed': Use tokio_codec::Decoder::framed instead
[INFO] [stderr]    --> src/server.rs:110:15
[INFO] [stderr]     |
[INFO] [stderr] 110 |         Ok(io.framed(TSPCodec))
[INFO] [stderr]     |               ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'futures::Future::boxed': removed without replacement, recommended to use a local extension trait or function if needed, more details in https://github.com/rust-lang-nursery/futures-rs/issues/228
[INFO] [stderr]    --> src/server.rs:127:30
[INFO] [stderr]     |
[INFO] [stderr] 127 |         future::ok(response).boxed()
[INFO] [stderr]     |                              ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/server.rs:58:52
[INFO] [stderr]    |
[INFO] [stderr] 58 |         let msg_nbytes = BigEndian::read_uint(&buf[1 .. (varint_len + 1)], varint_len) as usize;
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=varint_len`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/server.rs:79:40
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let varint_len = cmp::max(8 - ((msg_len as u64).leading_zeros() >> 3), 1);
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^ help: try: `u64::from(msg_len)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/server.rs:88:44
[INFO] [stderr]    |
[INFO] [stderr] 88 |             BigEndian::write_u64(&mut buf, msg_len as u64);
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^ help: try: `u64::from(msg_len)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/server.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         writer.write(&msg_len_bytes[(8 - varint_len as usize) ..])?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/server.rs:58:52
[INFO] [stderr]    |
[INFO] [stderr] 58 |         let msg_nbytes = BigEndian::read_uint(&buf[1 .. (varint_len + 1)], varint_len) as usize;
[INFO] [stderr]    |                                                    ^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=varint_len`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/server.rs:79:40
[INFO] [stderr]    |
[INFO] [stderr] 79 |         let varint_len = cmp::max(8 - ((msg_len as u64).leading_zeros() >> 3), 1);
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^ help: try: `u64::from(msg_len)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/server.rs:88:44
[INFO] [stderr]    |
[INFO] [stderr] 88 |             BigEndian::write_u64(&mut buf, msg_len as u64);
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^ help: try: `u64::from(msg_len)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/server.rs:93:9
[INFO] [stderr]    |
[INFO] [stderr] 93 |         writer.write(&msg_len_bytes[(8 - varint_len as usize) ..])?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tsp`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tsp`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "3012db0e4278ef7a8e7574e3ee2650cdbc8983c8bf1188eb16b31b74beb6e93c"`
[INFO] running `"docker" "rm" "-f" "3012db0e4278ef7a8e7574e3ee2650cdbc8983c8bf1188eb16b31b74beb6e93c"`
[INFO] [stdout] 3012db0e4278ef7a8e7574e3ee2650cdbc8983c8bf1188eb16b31b74beb6e93c