[INFO] crate tsk_lib 0.0.0 is already in cache [INFO] extracting crate tsk_lib 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/tsk_lib/0.0.0 [INFO] extracting crate tsk_lib 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsk_lib/0.0.0 [INFO] validating manifest of tsk_lib-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tsk_lib-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tsk_lib-0.0.0 [INFO] finished frobbing tsk_lib-0.0.0 [INFO] frobbed toml for tsk_lib-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/tsk_lib/0.0.0/Cargo.toml [INFO] started frobbing tsk_lib-0.0.0 [INFO] finished frobbing tsk_lib-0.0.0 [INFO] frobbed toml for tsk_lib-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsk_lib/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tsk_lib-0.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tsk_lib/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13a2c5a0baf25397f3d6c66d4804c2f855fec44aaf3ca8b50391a28a0e24b4b6 [INFO] running `"docker" "start" "-a" "13a2c5a0baf25397f3d6c66d4804c2f855fec44aaf3ca8b50391a28a0e24b4b6"` [INFO] [stderr] Checking tsk_lib v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | let mut list = List { tasks: tasks }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tasks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | let mut list = List { tasks: tasks }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tasks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `InfixExpression` [INFO] [stderr] --> src/list.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | use query::ast::{Expression, InfixExpression, AST}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `InfixExpression` [INFO] [stderr] --> src/list.rs:23:30 [INFO] [stderr] | [INFO] [stderr] 23 | use query::ast::{Expression, InfixExpression, AST}; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `exp` [INFO] [stderr] --> src/list.rs:142:31 [INFO] [stderr] | [INFO] [stderr] 142 | fn eval<'a>(&'a mut self, exp: Expression) -> Vec<&'a Task> { [INFO] [stderr] | ^^^ help: consider using `_exp` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backends::file::Backend` [INFO] [stderr] --> src/backends/file.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Backend { [INFO] [stderr] 31 | | Backend {} [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/list.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn current<'a>(&'a mut self) -> Option<&'a mut Task> { [INFO] [stderr] 60 | | let mut ind = 0; [INFO] [stderr] 61 | | for (task_id, task) in self.enumerate() { [INFO] [stderr] 62 | | if !task.completed() { [INFO] [stderr] ... | [INFO] [stderr] 68 | | self.find_by_ind(ind) [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/list.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | / self.tasks [INFO] [stderr] 122 | | .iter() [INFO] [stderr] 123 | | .filter(|x| &x.context == context) [INFO] [stderr] 124 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 121 | self.tasks [INFO] [stderr] 122 | .iter() [INFO] [stderr] 123 | .filter(|x| &x.context == context).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/list.rs:123:29 [INFO] [stderr] | [INFO] [stderr] 123 | .filter(|x| &x.context == context) [INFO] [stderr] | ----------^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `x.context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/query/lexer.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | if s.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tasks/task.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / match self.completed_date { [INFO] [stderr] 81 | | Some(_) => true, [INFO] [stderr] 82 | | None => false, [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ help: try this: `self.completed_date.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unused variable: `exp` [INFO] [stderr] --> src/list.rs:142:31 [INFO] [stderr] | [INFO] [stderr] 142 | fn eval<'a>(&'a mut self, exp: Expression) -> Vec<&'a Task> { [INFO] [stderr] | ^^^ help: consider using `_exp` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backends::file::Backend` [INFO] [stderr] --> src/backends/file.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / pub fn new() -> Backend { [INFO] [stderr] 31 | | Backend {} [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/list.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn current<'a>(&'a mut self) -> Option<&'a mut Task> { [INFO] [stderr] 60 | | let mut ind = 0; [INFO] [stderr] 61 | | for (task_id, task) in self.enumerate() { [INFO] [stderr] 62 | | if !task.completed() { [INFO] [stderr] ... | [INFO] [stderr] 68 | | self.find_by_ind(ind) [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/list.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | / self.tasks [INFO] [stderr] 122 | | .iter() [INFO] [stderr] 123 | | .filter(|x| &x.context == context) [INFO] [stderr] 124 | | .map(|x| x.clone()) [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 121 | self.tasks [INFO] [stderr] 122 | .iter() [INFO] [stderr] 123 | .filter(|x| &x.context == context).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/list.rs:123:29 [INFO] [stderr] | [INFO] [stderr] 123 | .filter(|x| &x.context == context) [INFO] [stderr] | ----------^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `x.context` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/list.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | priority = priority - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `priority -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/query/lexer.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | if s.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/query/parser.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | / match Validator::validate(&exp) { [INFO] [stderr] 358 | | Ok(()) => { [INFO] [stderr] 359 | | println!("{:?}", exp); [INFO] [stderr] 360 | | assert!(false) [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | Err(_) => (), [INFO] [stderr] 363 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 357 | if let Ok(()) = Validator::validate(&exp) { [INFO] [stderr] 358 | println!("{:?}", exp); [INFO] [stderr] 359 | assert!(false) [INFO] [stderr] 360 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/query/parser.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | / match Parser::from(input).parse() { [INFO] [stderr] 370 | | Ok(_) => assert!(false), [INFO] [stderr] 371 | | Err(_) => (), [INFO] [stderr] 372 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = Parser::from(input).parse() { assert!(false) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/tasks/task.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / match self.completed_date { [INFO] [stderr] 81 | | Some(_) => true, [INFO] [stderr] 82 | | None => false, [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ help: try this: `self.completed_date.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/tasks/task.rs:129:31 [INFO] [stderr] | [INFO] [stderr] 129 | assert!(task.title == "Some title".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"Some title"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.78s [INFO] running `"docker" "inspect" "13a2c5a0baf25397f3d6c66d4804c2f855fec44aaf3ca8b50391a28a0e24b4b6"` [INFO] running `"docker" "rm" "-f" "13a2c5a0baf25397f3d6c66d4804c2f855fec44aaf3ca8b50391a28a0e24b4b6"` [INFO] [stdout] 13a2c5a0baf25397f3d6c66d4804c2f855fec44aaf3ca8b50391a28a0e24b4b6