[INFO] crate tsk 0.0.0 is already in cache [INFO] extracting crate tsk 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/tsk/0.0.0 [INFO] extracting crate tsk 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsk/0.0.0 [INFO] validating manifest of tsk-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tsk-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tsk-0.0.0 [INFO] finished frobbing tsk-0.0.0 [INFO] frobbed toml for tsk-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/tsk/0.0.0/Cargo.toml [INFO] started frobbing tsk-0.0.0 [INFO] finished frobbing tsk-0.0.0 [INFO] frobbed toml for tsk-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tsk/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tsk-0.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tsk/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc469383b1e500fbee46e836514326d69e7fb671c12f3d4917ca759913f6513d [INFO] running `"docker" "start" "-a" "fc469383b1e500fbee46e836514326d69e7fb671c12f3d4917ca759913f6513d"` [INFO] [stderr] Checking tsk_lib v0.0.0 [INFO] [stderr] Checking tsk v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/error.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands/error.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | Err(_) => match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | Err(_) => match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/complete.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | config.save().map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/new.rs:89:27 [INFO] [stderr] | [INFO] [stderr] 89 | config.save().map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/query.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | .map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/show.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | ).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/show.rs:52:36 [INFO] [stderr] | [INFO] [stderr] 52 | task.to_json().map_err(|e| Error::from(e))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/show.rs:58:63 [INFO] [stderr] | [INFO] [stderr] 58 | writeln!(&mut io::stdout(), "{}", task.title).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/show.rs:83:8 [INFO] [stderr] | [INFO] [stderr] 83 | if task.notes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!task.notes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/show.rs:94:55 [INFO] [stderr] | [INFO] [stderr] 94 | writeln!(&mut io::stdout(), "{}", pretty).map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/commands/show.rs:109:14 [INFO] [stderr] | [INFO] [stderr] 109 | .ok_or(Error::new( [INFO] [stderr] | ______________^ [INFO] [stderr] 110 | | ErrorKind::InvalidArg("".to_string()), [INFO] [stderr] 111 | | "Could not find a task with that ID", [INFO] [stderr] 112 | | ))?, [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | .ok_or_else(|| Error::new( [INFO] [stderr] 110 | ErrorKind::InvalidArg("".to_string()), [INFO] [stderr] 111 | "Could not find a task with that ID", [INFO] [stderr] 112 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/commands/show.rs:113:40 [INFO] [stderr] | [INFO] [stderr] 113 | None => config.state.current().ok_or(Error::new( [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 114 | | ErrorKind::InvalidArg("".to_string()), [INFO] [stderr] 115 | | "No current task to show. Provide an index to show a completed task.", [INFO] [stderr] 116 | | ))?, [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | None => config.state.current().ok_or_else(|| Error::new( [INFO] [stderr] 114 | ErrorKind::InvalidArg("".to_string()), [INFO] [stderr] 115 | "No current task to show. Provide an index to show a completed task.", [INFO] [stderr] 116 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/config.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if let None = self.config.get("dir") { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 50 | | self.config.insert( [INFO] [stderr] 51 | | "dir".to_string(), [INFO] [stderr] 52 | | Config::dir().unwrap().to_string_lossy().to_string(), [INFO] [stderr] 53 | | ); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________- help: try this: `if self.config.get("dir").is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `config::Config` [INFO] [stderr] --> src/config.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / pub fn new() -> Config { [INFO] [stderr] 108 | | Config { [INFO] [stderr] 109 | | backend: BackendConfig::new(), [INFO] [stderr] 110 | | state: List::new(Vec::new()), [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | impl Default for config::Config { [INFO] [stderr] 82 | fn default() -> Self { [INFO] [stderr] 83 | Self::new() [INFO] [stderr] 84 | } [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/complete.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | config.save().map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/new.rs:89:27 [INFO] [stderr] | [INFO] [stderr] 89 | config.save().map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/query.rs:72:22 [INFO] [stderr] | [INFO] [stderr] 72 | .map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/show.rs:53:19 [INFO] [stderr] | [INFO] [stderr] 53 | ).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/show.rs:52:36 [INFO] [stderr] | [INFO] [stderr] 52 | task.to_json().map_err(|e| Error::from(e))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/show.rs:58:63 [INFO] [stderr] | [INFO] [stderr] 58 | writeln!(&mut io::stdout(), "{}", task.title).map_err(|e| Error::from(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/show.rs:83:8 [INFO] [stderr] | [INFO] [stderr] 83 | if task.notes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!task.notes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/commands/show.rs:94:55 [INFO] [stderr] | [INFO] [stderr] 94 | writeln!(&mut io::stdout(), "{}", pretty).map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/commands/show.rs:109:14 [INFO] [stderr] | [INFO] [stderr] 109 | .ok_or(Error::new( [INFO] [stderr] | ______________^ [INFO] [stderr] 110 | | ErrorKind::InvalidArg("".to_string()), [INFO] [stderr] 111 | | "Could not find a task with that ID", [INFO] [stderr] 112 | | ))?, [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | .ok_or_else(|| Error::new( [INFO] [stderr] 110 | ErrorKind::InvalidArg("".to_string()), [INFO] [stderr] 111 | "Could not find a task with that ID", [INFO] [stderr] 112 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/commands/show.rs:113:40 [INFO] [stderr] | [INFO] [stderr] 113 | None => config.state.current().ok_or(Error::new( [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 114 | | ErrorKind::InvalidArg("".to_string()), [INFO] [stderr] 115 | | "No current task to show. Provide an index to show a completed task.", [INFO] [stderr] 116 | | ))?, [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | None => config.state.current().ok_or_else(|| Error::new( [INFO] [stderr] 114 | ErrorKind::InvalidArg("".to_string()), [INFO] [stderr] 115 | "No current task to show. Provide an index to show a completed task.", [INFO] [stderr] 116 | ))?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/config.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | if let None = self.config.get("dir") { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 50 | | self.config.insert( [INFO] [stderr] 51 | | "dir".to_string(), [INFO] [stderr] 52 | | Config::dir().unwrap().to_string_lossy().to_string(), [INFO] [stderr] 53 | | ); [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________- help: try this: `if self.config.get("dir").is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `config::Config` [INFO] [stderr] --> src/config.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / pub fn new() -> Config { [INFO] [stderr] 108 | | Config { [INFO] [stderr] 109 | | backend: BackendConfig::new(), [INFO] [stderr] 110 | | state: List::new(Vec::new()), [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | impl Default for config::Config { [INFO] [stderr] 82 | fn default() -> Self { [INFO] [stderr] 83 | Self::new() [INFO] [stderr] 84 | } [INFO] [stderr] 85 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.17s [INFO] running `"docker" "inspect" "fc469383b1e500fbee46e836514326d69e7fb671c12f3d4917ca759913f6513d"` [INFO] running `"docker" "rm" "-f" "fc469383b1e500fbee46e836514326d69e7fb671c12f3d4917ca759913f6513d"` [INFO] [stdout] fc469383b1e500fbee46e836514326d69e7fb671c12f3d4917ca759913f6513d