[INFO] crate tshell 0.2.2 is already in cache [INFO] extracting crate tshell 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/tshell/0.2.2 [INFO] extracting crate tshell 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tshell/0.2.2 [INFO] validating manifest of tshell-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tshell-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tshell-0.2.2 [INFO] finished frobbing tshell-0.2.2 [INFO] frobbed toml for tshell-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/tshell/0.2.2/Cargo.toml [INFO] started frobbing tshell-0.2.2 [INFO] finished frobbing tshell-0.2.2 [INFO] frobbed toml for tshell-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tshell/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tshell-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tshell/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5da9112a038545504b04b5374897e01afda0028e68b338024f271be77ed82500 [INFO] running `"docker" "start" "-a" "5da9112a038545504b04b5374897e01afda0028e68b338024f271be77ed82500"` [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking tshell v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | hidden: hidden, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hidden` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | callback: callback [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/commands.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/completion.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/completion.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | sub_node: sub_node [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sub_node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | hidden: hidden, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `hidden` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | callback: callback [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `callback` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/commands.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/completion.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/completion.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | sub_node: sub_node [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sub_node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/commands.rs:312:42 [INFO] [stderr] | [INFO] [stderr] 312 | context: Arc::new(Mutex::new((context))) [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/commands.rs:312:42 [INFO] [stderr] | [INFO] [stderr] 312 | context: Arc::new(Mutex::new((context))) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/commands.rs:525:22 [INFO] [stderr] | [INFO] [stderr] 525 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 526 | | if !entry.is_empty() { [INFO] [stderr] 527 | | levels.push(entry); [INFO] [stderr] 528 | | } [INFO] [stderr] 529 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 525 | else if !entry.is_empty() { [INFO] [stderr] 526 | levels.push(entry); [INFO] [stderr] 527 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/commands.rs:394:24 [INFO] [stderr] | [INFO] [stderr] 394 | let home_dir = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/commands.rs:312:42 [INFO] [stderr] | [INFO] [stderr] 312 | context: Arc::new(Mutex::new((context))) [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/commands.rs:312:42 [INFO] [stderr] | [INFO] [stderr] 312 | context: Arc::new(Mutex::new((context))) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/commands.rs:525:22 [INFO] [stderr] | [INFO] [stderr] 525 | else { [INFO] [stderr] | ______________________^ [INFO] [stderr] 526 | | if !entry.is_empty() { [INFO] [stderr] 527 | | levels.push(entry); [INFO] [stderr] 528 | | } [INFO] [stderr] 529 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 525 | else if !entry.is_empty() { [INFO] [stderr] 526 | levels.push(entry); [INFO] [stderr] 527 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/commands.rs:394:24 [INFO] [stderr] | [INFO] [stderr] 394 | let home_dir = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/commands.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match env::var(&c){ [INFO] [stderr] 26 | | Ok(_) => false, [INFO] [stderr] 27 | | Err(_) => true [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ help: try this: `env::var(&c).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands.rs:145:20 [INFO] [stderr] | [INFO] [stderr] 145 | if required.len() > 0 || optional.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!required.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands.rs:145:42 [INFO] [stderr] | [INFO] [stderr] 145 | if required.len() > 0 || optional.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!optional.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/commands.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | / match env::var(&c){ [INFO] [stderr] 26 | | Ok(_) => false, [INFO] [stderr] 27 | | Err(_) => true [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ help: try this: `env::var(&c).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/commands.rs:349:36 [INFO] [stderr] | [INFO] [stderr] 349 | if let None = levels.get(i + 1) { [INFO] [stderr] | _____________________________- ^^^^ [INFO] [stderr] 350 | | println!("'{}' missing fields: {:?}", current_node.cmd, required[x..].to_vec()); [INFO] [stderr] 351 | | return None; [INFO] [stderr] 352 | | } [INFO] [stderr] | |_____________________________- help: try this: `if levels.get(i + 1).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/commands.rs:371:35 [INFO] [stderr] | [INFO] [stderr] 371 | let mut temp_prompt = format!("{}", self.name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> src/commands.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | / pub fn run(&mut self) { [INFO] [stderr] 384 | | println!("Welcome to {} v{}", self.name, self.version); [INFO] [stderr] 385 | | // let config = Config::builder() [INFO] [stderr] 386 | | // .history_ignore_space(true) [INFO] [stderr] ... | [INFO] [stderr] 685 | | } [INFO] [stderr] 686 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands.rs:145:20 [INFO] [stderr] | [INFO] [stderr] 145 | if required.len() > 0 || optional.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!required.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands.rs:145:42 [INFO] [stderr] | [INFO] [stderr] 145 | if required.len() > 0 || optional.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!optional.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/commands.rs:349:36 [INFO] [stderr] | [INFO] [stderr] 349 | if let None = levels.get(i + 1) { [INFO] [stderr] | _____________________________- ^^^^ [INFO] [stderr] 350 | | println!("'{}' missing fields: {:?}", current_node.cmd, required[x..].to_vec()); [INFO] [stderr] 351 | | return None; [INFO] [stderr] 352 | | } [INFO] [stderr] | |_____________________________- help: try this: `if levels.get(i + 1).is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/commands.rs:371:35 [INFO] [stderr] | [INFO] [stderr] 371 | let mut temp_prompt = format!("{}", self.name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.name.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> src/commands.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | / pub fn run(&mut self) { [INFO] [stderr] 384 | | println!("Welcome to {} v{}", self.name, self.version); [INFO] [stderr] 385 | | // let config = Config::builder() [INFO] [stderr] 386 | | // .history_ignore_space(true) [INFO] [stderr] ... | [INFO] [stderr] 685 | | } [INFO] [stderr] 686 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands.rs:665:51 [INFO] [stderr] | [INFO] [stderr] 665 | if !levels[i].starts_with("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/commands.rs:689:27 [INFO] [stderr] | [INFO] [stderr] 689 | pub fn exit_cli(_args: HashMap, _: &mut Option, _: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 689 | pub fn exit_cli(_args: HashMap, _: &mut Option, _: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/commands.rs:689:73 [INFO] [stderr] | [INFO] [stderr] 689 | pub fn exit_cli(_args: HashMap, _: &mut Option, _: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 689 | pub fn exit_cli(_args: HashMap, _: &mut Option, _: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/completion.rs:31:40 [INFO] [stderr] | [INFO] [stderr] 31 | let suggestions: Vec = self.tree.get_suggestions(line, self.sub_node) [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 32 | | .and_then(|mut entries| { [INFO] [stderr] 33 | | Some(entries.drain(..).map(|entry| entry.to_owned()).collect()) [INFO] [stderr] 34 | | }) [INFO] [stderr] 35 | | .unwrap_or(Vec::new()); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | let suggestions: Vec = self.tree.get_suggestions(line, self.sub_node) [INFO] [stderr] 32 | .and_then(|mut entries| { [INFO] [stderr] 33 | Some(entries.drain(..).map(|entry| entry.to_owned()).collect()) [INFO] [stderr] 34 | }).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/commands.rs:665:51 [INFO] [stderr] | [INFO] [stderr] 665 | if !levels[i].starts_with("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/commands.rs:689:27 [INFO] [stderr] | [INFO] [stderr] 689 | pub fn exit_cli(_args: HashMap, _: &mut Option, _: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 689 | pub fn exit_cli(_args: HashMap, _: &mut Option, _: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/commands.rs:689:73 [INFO] [stderr] | [INFO] [stderr] 689 | pub fn exit_cli(_args: HashMap, _: &mut Option, _: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 689 | pub fn exit_cli(_args: HashMap, _: &mut Option, _: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/completion.rs:31:40 [INFO] [stderr] | [INFO] [stderr] 31 | let suggestions: Vec = self.tree.get_suggestions(line, self.sub_node) [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 32 | | .and_then(|mut entries| { [INFO] [stderr] 33 | | Some(entries.drain(..).map(|entry| entry.to_owned()).collect()) [INFO] [stderr] 34 | | }) [INFO] [stderr] 35 | | .unwrap_or(Vec::new()); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 31 | let suggestions: Vec = self.tree.get_suggestions(line, self.sub_node) [INFO] [stderr] 32 | .and_then(|mut entries| { [INFO] [stderr] 33 | Some(entries.drain(..).map(|entry| entry.to_owned()).collect()) [INFO] [stderr] 34 | }).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> examples/example.rs:12:10 [INFO] [stderr] | [INFO] [stderr] 12 | fn world(args: HashMap, o_context: &mut Option, history: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `o_context` [INFO] [stderr] --> examples/example.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | fn world(args: HashMap, o_context: &mut Option, history: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_o_context` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `o_context` [INFO] [stderr] --> examples/example.rs:20:42 [INFO] [stderr] | [INFO] [stderr] 20 | fn darkness(args: HashMap, o_context: &mut Option, history: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_o_context` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `history` [INFO] [stderr] --> examples/example.rs:20:75 [INFO] [stderr] | [INFO] [stderr] 20 | fn darkness(args: HashMap, o_context: &mut Option, history: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^ help: consider using `_history` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `o_context` [INFO] [stderr] --> examples/example.rs:30:45 [INFO] [stderr] | [INFO] [stderr] 30 | fn new_context(args: HashMap, o_context: &mut Option, history: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_o_context` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `history` [INFO] [stderr] --> examples/example.rs:30:78 [INFO] [stderr] | [INFO] [stderr] 30 | fn new_context(args: HashMap, o_context: &mut Option, history: &HashMap) -> CommandResult> { [INFO] [stderr] | ^^^^^^^ help: consider using `_history` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> examples/example.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | let mut context = Context::default(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> examples/example.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | let mut o_context = Some(context); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.14s [INFO] running `"docker" "inspect" "5da9112a038545504b04b5374897e01afda0028e68b338024f271be77ed82500"` [INFO] running `"docker" "rm" "-f" "5da9112a038545504b04b5374897e01afda0028e68b338024f271be77ed82500"` [INFO] [stdout] 5da9112a038545504b04b5374897e01afda0028e68b338024f271be77ed82500