[INFO] crate try-mutex 0.1.1 is already in cache [INFO] extracting crate try-mutex 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/try-mutex/0.1.1 [INFO] extracting crate try-mutex 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/try-mutex/0.1.1 [INFO] validating manifest of try-mutex-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of try-mutex-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing try-mutex-0.1.1 [INFO] finished frobbing try-mutex-0.1.1 [INFO] frobbed toml for try-mutex-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/try-mutex/0.1.1/Cargo.toml [INFO] started frobbing try-mutex-0.1.1 [INFO] finished frobbing try-mutex-0.1.1 [INFO] frobbed toml for try-mutex-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/try-mutex/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting try-mutex-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/try-mutex/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a8cf55c7027dfe9457166bcebee63ae3a9d23bbc169e2fd72066b2d739f49909 [INFO] running `"docker" "start" "-a" "a8cf55c7027dfe9457166bcebee63ae3a9d23bbc169e2fd72066b2d739f49909"` [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling compiletest_rs v0.3.18 [INFO] [stderr] Checking try-mutex v0.1.1 (/opt/crater/workdir) [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking tester v0.5.0 [INFO] [stderr] Checking csv-core v0.1.5 [INFO] [stderr] Checking tinytemplate v1.0.1 [INFO] [stderr] Checking rustfix v0.4.4 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking rand_os v0.1.1 [INFO] [stderr] Checking csv v1.0.5 [INFO] [stderr] Checking criterion-plot v0.3.0 [INFO] [stderr] Checking criterion v0.2.9 [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> benches/bench.rs:9:17 [INFO] [stderr] | [INFO] [stderr] 9 | for _ in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> benches/bench.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | for _ in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> benches/bench.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | for _ in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> benches/bench.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | for _ in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> benches/bench.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | for _ in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> benches/bench.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | for _ in 0..100000 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> benches/bench.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | black_box(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> benches/bench.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | black_box(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> benches/bench.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | let m = Mutex::new(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> benches/bench.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | let mut g = m.try_lock().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> benches/bench.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | let m = Mutex::new(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> benches/bench.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | let mut g = m.try_lock().unwrap(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> benches/bench.rs:49:34 [INFO] [stderr] | [INFO] [stderr] 49 | std::mem::drop(black_box(m.try_lock())); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> tests/tests.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | assert!(*b.try_lock().unwrap() == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*b.try_lock().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> tests/tests.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | assert!(*m.try_lock().unwrap() == true) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*m.try_lock().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.28s [INFO] running `"docker" "inspect" "a8cf55c7027dfe9457166bcebee63ae3a9d23bbc169e2fd72066b2d739f49909"` [INFO] running `"docker" "rm" "-f" "a8cf55c7027dfe9457166bcebee63ae3a9d23bbc169e2fd72066b2d739f49909"` [INFO] [stdout] a8cf55c7027dfe9457166bcebee63ae3a9d23bbc169e2fd72066b2d739f49909