[INFO] crate trust-dns-rustls 0.4.0 is already in cache [INFO] extracting crate trust-dns-rustls 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/trust-dns-rustls/0.4.0 [INFO] extracting crate trust-dns-rustls 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trust-dns-rustls/0.4.0 [INFO] validating manifest of trust-dns-rustls-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trust-dns-rustls-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trust-dns-rustls-0.4.0 [INFO] finished frobbing trust-dns-rustls-0.4.0 [INFO] frobbed toml for trust-dns-rustls-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/trust-dns-rustls/0.4.0/Cargo.toml [INFO] started frobbing trust-dns-rustls-0.4.0 [INFO] finished frobbing trust-dns-rustls-0.4.0 [INFO] frobbed toml for trust-dns-rustls-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trust-dns-rustls/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trust-dns-rustls-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/trust-dns-rustls/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 04e4765767eb0adda17f53e931dcb450f18cc6edbf3c3c3c302ced1b27fa7230 [INFO] running `"docker" "start" "-a" "04e4765767eb0adda17f53e931dcb450f18cc6edbf3c3c3c302ced1b27fa7230"` [INFO] [stderr] Compiling openssl v0.10.16 [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking trust-dns-rustls v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tls_client_stream::TlsClientStreamBuilder` [INFO] [stderr] --> src/tls_client_stream.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Self { [INFO] [stderr] 29 | | TlsClientStreamBuilder(TlsStreamBuilder::new()) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for tls_client_stream::TlsClientStreamBuilder { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tls_client_stream.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | .map(move |tls_stream| TcpClientStream::from_stream(tls_stream)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TcpClientStream::from_stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tls_stream::TlsStreamBuilder` [INFO] [stderr] --> src/tls_stream.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> Self { [INFO] [stderr] 47 | | TlsStreamBuilder { [INFO] [stderr] 48 | | client_config: ClientConfig::new(), [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | impl Default for tls_stream::TlsStreamBuilder { [INFO] [stderr] 45 | fn default() -> Self { [INFO] [stderr] 46 | Self::new() [INFO] [stderr] 47 | } [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tls_stream.rs:121:73 [INFO] [stderr] | [INFO] [stderr] 121 | io::Error::new(io::ErrorKind::InvalidInput, format!("bad dns_name")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bad dns_name".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | const TEST_BYTES: &'static [u8; 8] = b"DEADBEEF"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tls_client_stream::TlsClientStreamBuilder` [INFO] [stderr] --> src/tls_client_stream.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Self { [INFO] [stderr] 29 | | TlsClientStreamBuilder(TlsStreamBuilder::new()) [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for tls_client_stream::TlsClientStreamBuilder { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tls_client_stream.rs:68:22 [INFO] [stderr] | [INFO] [stderr] 68 | .map(move |tls_stream| TcpClientStream::from_stream(tls_stream)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TcpClientStream::from_stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tls_stream::TlsStreamBuilder` [INFO] [stderr] --> src/tls_stream.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> Self { [INFO] [stderr] 47 | | TlsStreamBuilder { [INFO] [stderr] 48 | | client_config: ClientConfig::new(), [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 44 | impl Default for tls_stream::TlsStreamBuilder { [INFO] [stderr] 45 | fn default() -> Self { [INFO] [stderr] 46 | Self::new() [INFO] [stderr] 47 | } [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tls_stream.rs:121:73 [INFO] [stderr] | [INFO] [stderr] 121 | io::Error::new(io::ErrorKind::InvalidInput, format!("bad dns_name")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bad dns_name".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tests.rs:64:37 [INFO] [stderr] | [INFO] [stderr] 64 | let mut file = File::open(path).expect(&format!("failed to open file: {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to open file: {}", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tests.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | .expect(&format!("failed to read file: {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to read file: {}", path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tests.rs:89:56 [INFO] [stderr] | [INFO] [stderr] 89 | let server_path = env::var("TDNS_SERVER_SRC_ROOT").unwrap_or("../server".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "../server".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tests.rs:169:30 [INFO] [stderr] | [INFO] [stderr] 169 | let length = (len_bytes[0] as u16) << 8 & 0xFF00 | len_bytes[1] as u16 & 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(len_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tests.rs:169:68 [INFO] [stderr] | [INFO] [stderr] 169 | let length = (len_bytes[0] as u16) << 8 & 0xFF00 | len_bytes[1] as u16 & 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(len_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/tests.rs:215:22 [INFO] [stderr] | [INFO] [stderr] 215 | let mut stream = io_loop [INFO] [stderr] | ______________________^ [INFO] [stderr] 216 | | .block_on(stream) [INFO] [stderr] 217 | | .ok() [INFO] [stderr] 218 | | .expect("run failed to get stream"); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.25s [INFO] running `"docker" "inspect" "04e4765767eb0adda17f53e931dcb450f18cc6edbf3c3c3c302ced1b27fa7230"` [INFO] running `"docker" "rm" "-f" "04e4765767eb0adda17f53e931dcb450f18cc6edbf3c3c3c302ced1b27fa7230"` [INFO] [stdout] 04e4765767eb0adda17f53e931dcb450f18cc6edbf3c3c3c302ced1b27fa7230