[INFO] crate trust-dns-resolver 0.10.0 is already in cache [INFO] extracting crate trust-dns-resolver 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/trust-dns-resolver/0.10.0 [INFO] extracting crate trust-dns-resolver 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trust-dns-resolver/0.10.0 [INFO] validating manifest of trust-dns-resolver-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trust-dns-resolver-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trust-dns-resolver-0.10.0 [INFO] finished frobbing trust-dns-resolver-0.10.0 [INFO] frobbed toml for trust-dns-resolver-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/trust-dns-resolver/0.10.0/Cargo.toml [INFO] started frobbing trust-dns-resolver-0.10.0 [INFO] finished frobbing trust-dns-resolver-0.10.0 [INFO] frobbed toml for trust-dns-resolver-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trust-dns-resolver/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trust-dns-resolver-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/trust-dns-resolver/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b75297d24d22a059dcd0131ce4773d3643fd1cbe01a387b5288c78576eece08 [INFO] running `"docker" "start" "-a" "4b75297d24d22a059dcd0131ce4773d3643fd1cbe01a387b5288c78576eece08"` [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking trust-dns-resolver v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/async_resolver/background.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | hosts: hosts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hosts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | client_cache: client_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup_state.rs:475:25 [INFO] [stderr] | [INFO] [stderr] 475 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup_state.rs:928:13 [INFO] [stderr] | [INFO] [stderr] 928 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup_state.rs:973:13 [INFO] [stderr] | [INFO] [stderr] 973 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup_state.rs:1063:13 [INFO] [stderr] | [INFO] [stderr] 1063 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup_state.rs:1095:13 [INFO] [stderr] | [INFO] [stderr] 1095 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name_server_pool.rs:767:13 [INFO] [stderr] | [INFO] [stderr] 767 | mdns_conns: mdns_conns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mdns_conns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/async_resolver/background.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | hosts: hosts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `hosts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | client_cache: client_cache, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `client_cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup_state.rs:475:25 [INFO] [stderr] | [INFO] [stderr] 475 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup_state.rs:928:13 [INFO] [stderr] | [INFO] [stderr] 928 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup_state.rs:973:13 [INFO] [stderr] | [INFO] [stderr] 973 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup_state.rs:1063:13 [INFO] [stderr] | [INFO] [stderr] 1063 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup_state.rs:1095:13 [INFO] [stderr] | [INFO] [stderr] 1095 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/name_server_pool.rs:767:13 [INFO] [stderr] | [INFO] [stderr] 767 | mdns_conns: mdns_conns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mdns_conns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:172:1 [INFO] [stderr] | [INFO] [stderr] 172 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_ip.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / return LookupIpFuture { [INFO] [stderr] 179 | | // errors on names don't need to be cheap... i.e. this clone is unfortunate in this case. [INFO] [stderr] 180 | | client_cache, [INFO] [stderr] 181 | | names: vec![], [INFO] [stderr] ... | [INFO] [stderr] 188 | | finally_ip_addr: None, [INFO] [stderr] 189 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 178 | LookupIpFuture { [INFO] [stderr] 179 | // errors on names don't need to be cheap... i.e. this clone is unfortunate in this case. [INFO] [stderr] 180 | client_cache, [INFO] [stderr] 181 | names: vec![], [INFO] [stderr] 182 | strategy: LookupIpStrategy::default(), [INFO] [stderr] 183 | options: DnsRequestOptions::default(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_ip.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | / return LookupIpFuture { [INFO] [stderr] 194 | | client_cache, [INFO] [stderr] 195 | | names: vec![], [INFO] [stderr] 196 | | strategy: LookupIpStrategy::default(), [INFO] [stderr] ... | [INFO] [stderr] 200 | | finally_ip_addr: None, [INFO] [stderr] 201 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 193 | LookupIpFuture { [INFO] [stderr] 194 | client_cache, [INFO] [stderr] 195 | names: vec![], [INFO] [stderr] 196 | strategy: LookupIpStrategy::default(), [INFO] [stderr] 197 | options: DnsRequestOptions::default(), [INFO] [stderr] 198 | query: Box::new(future::ok(lp)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_state.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_state.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | return Ok(Async::Ready(lru.get(&self.query, Instant::now()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(lru.get(&self.query, Instant::now())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/lookup_state.rs:269:26 [INFO] [stderr] | [INFO] [stderr] 269 | } else [INFO] [stderr] | __________________________^ [INFO] [stderr] 270 | | // srv evaluation, it's an srv lookup and the srv_search_name/target matches this name [INFO] [stderr] 271 | | // and it's an IP [INFO] [stderr] 272 | | if self.query.query_type().is_srv() && r.rr_type().is_ip_addr() && search_name.as_ref() == r.name() { [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_state.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:494:17 [INFO] [stderr] | [INFO] [stderr] 494 | message_future: _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | dnssec: _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:498:17 [INFO] [stderr] | [INFO] [stderr] 498 | options: _, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:499:17 [INFO] [stderr] | [INFO] [stderr] 499 | client: _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `QueryFuture { query, cache, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:516:17 [INFO] [stderr] | [INFO] [stderr] 516 | message_future: _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:519:17 [INFO] [stderr] | [INFO] [stderr] 519 | dnssec: _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:520:17 [INFO] [stderr] | [INFO] [stderr] 520 | options: _, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:521:17 [INFO] [stderr] | [INFO] [stderr] 521 | client: _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `QueryFuture { query, cache, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_state.rs:640:9 [INFO] [stderr] | [INFO] [stderr] 640 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/name_server_pool.rs:403:17 [INFO] [stderr] | [INFO] [stderr] 403 | return ConnectionHandleResponseInner::UdpOrTcp(conn.send(request)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConnectionHandleResponseInner::UdpOrTcp(conn.send(request))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:172:1 [INFO] [stderr] | [INFO] [stderr] 172 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_ip.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / return LookupIpFuture { [INFO] [stderr] 179 | | // errors on names don't need to be cheap... i.e. this clone is unfortunate in this case. [INFO] [stderr] 180 | | client_cache, [INFO] [stderr] 181 | | names: vec![], [INFO] [stderr] ... | [INFO] [stderr] 188 | | finally_ip_addr: None, [INFO] [stderr] 189 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 178 | LookupIpFuture { [INFO] [stderr] 179 | // errors on names don't need to be cheap... i.e. this clone is unfortunate in this case. [INFO] [stderr] 180 | client_cache, [INFO] [stderr] 181 | names: vec![], [INFO] [stderr] 182 | strategy: LookupIpStrategy::default(), [INFO] [stderr] 183 | options: DnsRequestOptions::default(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_ip.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | / return LookupIpFuture { [INFO] [stderr] 194 | | client_cache, [INFO] [stderr] 195 | | names: vec![], [INFO] [stderr] 196 | | strategy: LookupIpStrategy::default(), [INFO] [stderr] ... | [INFO] [stderr] 200 | | finally_ip_addr: None, [INFO] [stderr] 201 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 193 | LookupIpFuture { [INFO] [stderr] 194 | client_cache, [INFO] [stderr] 195 | names: vec![], [INFO] [stderr] 196 | strategy: LookupIpStrategy::default(), [INFO] [stderr] 197 | options: DnsRequestOptions::default(), [INFO] [stderr] 198 | query: Box::new(future::ok(lp)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_state.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_state.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | return Ok(Async::Ready(lru.get(&self.query, Instant::now()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::Ready(lru.get(&self.query, Instant::now())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this is an `else if` but the formatting might hide it [INFO] [stderr] --> src/lookup_state.rs:269:26 [INFO] [stderr] | [INFO] [stderr] 269 | } else [INFO] [stderr] | __________________________^ [INFO] [stderr] 270 | | // srv evaluation, it's an srv lookup and the srv_search_name/target matches this name [INFO] [stderr] 271 | | // and it's an IP [INFO] [stderr] 272 | | if self.query.query_type().is_srv() && r.rr_type().is_ip_addr() && search_name.as_ref() == r.name() { [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, remove the `else` or remove the new line between `else` and `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_state.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:494:17 [INFO] [stderr] | [INFO] [stderr] 494 | message_future: _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | dnssec: _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:498:17 [INFO] [stderr] | [INFO] [stderr] 498 | options: _, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:499:17 [INFO] [stderr] | [INFO] [stderr] 499 | client: _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `QueryFuture { query, cache, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:516:17 [INFO] [stderr] | [INFO] [stderr] 516 | message_future: _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:519:17 [INFO] [stderr] | [INFO] [stderr] 519 | dnssec: _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:520:17 [INFO] [stderr] | [INFO] [stderr] 520 | options: _, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lookup_state.rs:521:17 [INFO] [stderr] | [INFO] [stderr] 521 | client: _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `QueryFuture { query, cache, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup_state.rs:640:9 [INFO] [stderr] | [INFO] [stderr] 640 | return Ok(Async::NotReady); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Async::NotReady)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/name_server_pool.rs:403:17 [INFO] [stderr] | [INFO] [stderr] 403 | return ConnectionHandleResponseInner::UdpOrTcp(conn.send(request)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ConnectionHandleResponseInner::UdpOrTcp(conn.send(request))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/async_resolver/mod.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / Ip { [INFO] [stderr] 103 | | maybe_name: ProtoResult, [INFO] [stderr] 104 | | maybe_ip: Option, [INFO] [stderr] 105 | | tx: oneshot::Sender, [INFO] [stderr] 106 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/async_resolver/mod.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / Ip { [INFO] [stderr] 103 | | maybe_name: ProtoResult, [INFO] [stderr] 104 | | maybe_ip: Option, [INFO] [stderr] 105 | | tx: oneshot::Sender, [INFO] [stderr] 106 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/async_resolver/mod.rs:242:16 [INFO] [stderr] | [INFO] [stderr] 242 | if let Err(_) = self.request_tx.unbounded_send(request) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 243 | | return ResolveErrorKind::Message("background resolver gone, this is a bug").into(); [INFO] [stderr] 244 | | } [INFO] [stderr] | |_________- help: try this: `if self.request_tx.unbounded_send(request).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/async_resolver/mod.rs:266:16 [INFO] [stderr] | [INFO] [stderr] 266 | if let Err(_) = self.request_tx.unbounded_send(request) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 267 | | // Note: this shouldn't happen. We return a ResolveError here, but it would [INFO] [stderr] 268 | | // probably be okay to just `expect` the unbounded send to be successful. [INFO] [stderr] 269 | | return ResolveErrorKind::Message("background resolver gone, this is a bug").into(); [INFO] [stderr] 270 | | } [INFO] [stderr] | |_________- help: try this: `if self.request_tx.unbounded_send(request).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:211:24 [INFO] [stderr] | [INFO] [stderr] 211 | pub fn is_datagram(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn is_stream(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn is_encrypted(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `config::NameServerConfigGroup` [INFO] [stderr] --> src/config.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | / pub fn new() -> Self { [INFO] [stderr] 264 | | // this might be a nice oportunity for SmallVec [INFO] [stderr] 265 | | // most name_server configs will be 2. [INFO] [stderr] 266 | | Self::with_capacity(2) [INFO] [stderr] 267 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 259 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config.rs:282:46 [INFO] [stderr] | [INFO] [stderr] 282 | socket_addr: SocketAddr::new(ip.clone(), port), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*ip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config.rs:287:46 [INFO] [stderr] | [INFO] [stderr] 287 | socket_addr: SocketAddr::new(ip.clone(), port), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dns_lru.rs:137:56 [INFO] [stderr] | [INFO] [stderr] 137 | .unwrap_or_else(|| Duration::from_secs(MAX_TTL as u64)), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(MAX_TTL)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dns_lru.rs:139:56 [INFO] [stderr] | [INFO] [stderr] 139 | .unwrap_or_else(|| Duration::from_secs(MAX_TTL as u64)), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(MAX_TTL)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dns_lru.rs:155:47 [INFO] [stderr] | [INFO] [stderr] 155 | let ttl = Duration::from_secs(ttl as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(ttl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dns_lru.rs:187:39 [INFO] [stderr] | [INFO] [stderr] 187 | let ttl = Duration::from_secs(ttl as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(ttl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dns_lru.rs:209:39 [INFO] [stderr] | [INFO] [stderr] 209 | let ttl = Duration::from_secs(ttl as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(ttl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hosts.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | .or_insert_with(|| LookupType::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `LookupType::default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/hosts.rs:63:34 [INFO] [stderr] | [INFO] [stderr] 63 | let mut old_lookup = match &record_type { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 64 | | &RecordType::A => lookup_type [INFO] [stderr] 65 | | .a [INFO] [stderr] 66 | | .get_or_insert_with(|| Lookup::new_with_max_ttl(Arc::new(vec![]))), [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | let mut old_lookup = match record_type { [INFO] [stderr] 64 | RecordType::A => lookup_type [INFO] [stderr] 65 | .a [INFO] [stderr] 66 | .get_or_insert_with(|| Lookup::new_with_max_ttl(Arc::new(vec![]))), [INFO] [stderr] 67 | RecordType::AAAA => lookup_type [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/hosts.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / match &record_type { [INFO] [stderr] 81 | | &RecordType::A => lookup_type.a = Some(new_lookup), [INFO] [stderr] 82 | | &RecordType::AAAA => lookup_type.aaaa = Some(new_lookup), [INFO] [stderr] 83 | | _ => warn!("unsupported IP type from Hosts file"), [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 80 | match record_type { [INFO] [stderr] 81 | RecordType::A => lookup_type.a = Some(new_lookup), [INFO] [stderr] 82 | RecordType::AAAA => lookup_type.aaaa = Some(new_lookup), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/hosts.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | / match &addr { [INFO] [stderr] 134 | | &RData::A(..) => hosts.insert(name.clone(), RecordType::A, lookup), [INFO] [stderr] 135 | | &RData::AAAA(..) => hosts.insert(name.clone(), RecordType::AAAA, lookup), [INFO] [stderr] 136 | | _ => { [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | match addr { [INFO] [stderr] 134 | RData::A(..) => hosts.insert(name.clone(), RecordType::A, lookup), [INFO] [stderr] 135 | RData::AAAA(..) => hosts.insert(name.clone(), RecordType::AAAA, lookup), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lookup.rs:45:64 [INFO] [stderr] | [INFO] [stderr] 45 | let valid_until = Instant::now() + Duration::from_secs(MAX_TTL as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(MAX_TTL)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/lookup_state.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | n @ _ if LOCALHOST_usage.zone_of(n) => &*LOCALHOST_usage, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/lookup_state.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | n @ _ if IN_ADDR_ARPA_127.zone_of(n) => &*LOCALHOST_usage, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/lookup_state.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | n @ _ if IP6_ARPA_1.zone_of(n) => &*LOCALHOST_usage, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/lookup_state.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | n @ _ if INVALID.zone_of(n) => &*INVALID, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/lookup_state.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | n @ _ if LOCAL.zone_of(n) => &*LOCAL, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lookup_state.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | / match r.rdata() { [INFO] [stderr] 219 | | &RData::CNAME(ref cname) => { [INFO] [stderr] 220 | | // take the minimum TTL of the cname_ttl and the next record in the chain [INFO] [stderr] 221 | | let ttl = cname_ttl.min(r.ttl()); [INFO] [stderr] ... | [INFO] [stderr] 235 | | _ => (), [INFO] [stderr] 236 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 218 | match *r.rdata() { [INFO] [stderr] 219 | RData::CNAME(ref cname) => { [INFO] [stderr] 220 | // take the minimum TTL of the cname_ttl and the next record in the chain [INFO] [stderr] 221 | let ttl = cname_ttl.min(r.ttl()); [INFO] [stderr] 222 | debug_assert_eq!(r.rr_type(), RecordType::CNAME); [INFO] [stderr] 223 | if search_name.as_ref() == r.name() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lookup_state.rs:272:125 [INFO] [stderr] | [INFO] [stderr] 272 | if self.query.query_type().is_srv() && r.rr_type().is_ip_addr() && search_name.as_ref() == r.name() { [INFO] [stderr] | _____________________________________________________________________________________________________________________________^ [INFO] [stderr] 273 | | Some((r.unwrap_rdata(), ttl)) [INFO] [stderr] 274 | | } else { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lookup_state.rs:267:97 [INFO] [stderr] | [INFO] [stderr] 267 | (search_name.as_ref() == r.name() || self.query.name() == r.name()) { [INFO] [stderr] | _________________________________________________________________________________________________^ [INFO] [stderr] 268 | | Some((r.unwrap_rdata(), ttl)) [INFO] [stderr] 269 | | } else [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/lookup_state.rs:357:21 [INFO] [stderr] | [INFO] [stderr] 357 | r @ _ => Err(ResolveErrorKind::Msg(format!("DNS Error: {}", r)).into()), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rdatas @ _` pattern can be written as just `rdatas` [INFO] [stderr] --> src/lookup_state.rs:528:21 [INFO] [stderr] | [INFO] [stderr] 528 | rdatas @ _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rdatas @ _` pattern can be written as just `rdatas` [INFO] [stderr] --> src/lookup_state.rs:546:21 [INFO] [stderr] | [INFO] [stderr] 546 | rdatas @ _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lookup_state.rs:583:53 [INFO] [stderr] | [INFO] [stderr] 583 | let poll = query.poll().map_err(|e| e.into()); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `o @ _` pattern can be written as just `o` [INFO] [stderr] --> src/name_server_pool.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | o @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/name_server_pool.rs:525:5 [INFO] [stderr] | [INFO] [stderr] 525 | / pub fn new( [INFO] [stderr] 526 | | config: NameServerConfig, [INFO] [stderr] 527 | | options: ResolverOpts, [INFO] [stderr] 528 | | ) -> NameServer { [INFO] [stderr] ... | [INFO] [stderr] 538 | | } [INFO] [stderr] 539 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/name_server_pool.rs:720:77 [INFO] [stderr] | [INFO] [stderr] 720 | NameServer::<_, StandardConnection>::new(ns_config.clone(), options.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/name_server_pool.rs:728:77 [INFO] [stderr] | [INFO] [stderr] 728 | NameServer::<_, StandardConnection>::new(ns_config.clone(), options.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/name_server_pool.rs:736:22 [INFO] [stderr] | [INFO] [stderr] 736 | options: options.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/name_server_pool.rs:751:22 [INFO] [stderr] | [INFO] [stderr] 751 | options: options.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: replacing an `Option` with `None` [INFO] [stderr] --> src/name_server_pool.rs:879:39 [INFO] [stderr] | [INFO] [stderr] 879 | let request = mem::replace(request, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `request.take()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mem_replace_option_with_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/resolver.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | self.options.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/system_conf/unix.rs:93:43 [INFO] [stderr] | [INFO] [stderr] 93 | options.timeout = Duration::from_secs(parsed_config.timeout as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(parsed_config.timeout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `trust-dns-resolver`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/async_resolver/mod.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / Ip { [INFO] [stderr] 103 | | maybe_name: ProtoResult, [INFO] [stderr] 104 | | maybe_ip: Option, [INFO] [stderr] 105 | | tx: oneshot::Sender, [INFO] [stderr] 106 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/async_resolver/mod.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / Ip { [INFO] [stderr] 103 | | maybe_name: ProtoResult, [INFO] [stderr] 104 | | maybe_ip: Option, [INFO] [stderr] 105 | | tx: oneshot::Sender, [INFO] [stderr] 106 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/async_resolver/mod.rs:242:16 [INFO] [stderr] | [INFO] [stderr] 242 | if let Err(_) = self.request_tx.unbounded_send(request) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 243 | | return ResolveErrorKind::Message("background resolver gone, this is a bug").into(); [INFO] [stderr] 244 | | } [INFO] [stderr] | |_________- help: try this: `if self.request_tx.unbounded_send(request).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/async_resolver/mod.rs:266:16 [INFO] [stderr] | [INFO] [stderr] 266 | if let Err(_) = self.request_tx.unbounded_send(request) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 267 | | // Note: this shouldn't happen. We return a ResolveError here, but it would [INFO] [stderr] 268 | | // probably be okay to just `expect` the unbounded send to be successful. [INFO] [stderr] 269 | | return ResolveErrorKind::Message("background resolver gone, this is a bug").into(); [INFO] [stderr] 270 | | } [INFO] [stderr] | |_________- help: try this: `if self.request_tx.unbounded_send(request).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:211:24 [INFO] [stderr] | [INFO] [stderr] 211 | pub fn is_datagram(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | pub fn is_stream(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | pub fn is_encrypted(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `config::NameServerConfigGroup` [INFO] [stderr] --> src/config.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | / pub fn new() -> Self { [INFO] [stderr] 264 | | // this might be a nice oportunity for SmallVec [INFO] [stderr] 265 | | // most name_server configs will be 2. [INFO] [stderr] 266 | | Self::with_capacity(2) [INFO] [stderr] 267 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 259 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config.rs:282:46 [INFO] [stderr] | [INFO] [stderr] 282 | socket_addr: SocketAddr::new(ip.clone(), port), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*ip` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config.rs:287:46 [INFO] [stderr] | [INFO] [stderr] 287 | socket_addr: SocketAddr::new(ip.clone(), port), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dns_lru.rs:137:56 [INFO] [stderr] | [INFO] [stderr] 137 | .unwrap_or_else(|| Duration::from_secs(MAX_TTL as u64)), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(MAX_TTL)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dns_lru.rs:139:56 [INFO] [stderr] | [INFO] [stderr] 139 | .unwrap_or_else(|| Duration::from_secs(MAX_TTL as u64)), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(MAX_TTL)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dns_lru.rs:155:47 [INFO] [stderr] | [INFO] [stderr] 155 | let ttl = Duration::from_secs(ttl as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(ttl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dns_lru.rs:187:39 [INFO] [stderr] | [INFO] [stderr] 187 | let ttl = Duration::from_secs(ttl as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(ttl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/dns_lru.rs:209:39 [INFO] [stderr] | [INFO] [stderr] 209 | let ttl = Duration::from_secs(ttl as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(ttl)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/hosts.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | .or_insert_with(|| LookupType::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `LookupType::default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/hosts.rs:63:34 [INFO] [stderr] | [INFO] [stderr] 63 | let mut old_lookup = match &record_type { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 64 | | &RecordType::A => lookup_type [INFO] [stderr] 65 | | .a [INFO] [stderr] 66 | | .get_or_insert_with(|| Lookup::new_with_max_ttl(Arc::new(vec![]))), [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | let mut old_lookup = match record_type { [INFO] [stderr] 64 | RecordType::A => lookup_type [INFO] [stderr] 65 | .a [INFO] [stderr] 66 | .get_or_insert_with(|| Lookup::new_with_max_ttl(Arc::new(vec![]))), [INFO] [stderr] 67 | RecordType::AAAA => lookup_type [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/hosts.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / match &record_type { [INFO] [stderr] 81 | | &RecordType::A => lookup_type.a = Some(new_lookup), [INFO] [stderr] 82 | | &RecordType::AAAA => lookup_type.aaaa = Some(new_lookup), [INFO] [stderr] 83 | | _ => warn!("unsupported IP type from Hosts file"), [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 80 | match record_type { [INFO] [stderr] 81 | RecordType::A => lookup_type.a = Some(new_lookup), [INFO] [stderr] 82 | RecordType::AAAA => lookup_type.aaaa = Some(new_lookup), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/hosts.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | / match &addr { [INFO] [stderr] 134 | | &RData::A(..) => hosts.insert(name.clone(), RecordType::A, lookup), [INFO] [stderr] 135 | | &RData::AAAA(..) => hosts.insert(name.clone(), RecordType::AAAA, lookup), [INFO] [stderr] 136 | | _ => { [INFO] [stderr] ... | [INFO] [stderr] 139 | | } [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | match addr { [INFO] [stderr] 134 | RData::A(..) => hosts.insert(name.clone(), RecordType::A, lookup), [INFO] [stderr] 135 | RData::AAAA(..) => hosts.insert(name.clone(), RecordType::AAAA, lookup), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hosts.rs:166:60 [INFO] [stderr] | [INFO] [stderr] 166 | let server_path = env::var("TDNS_SERVER_SRC_ROOT").unwrap_or(".".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| ".".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lookup.rs:45:64 [INFO] [stderr] | [INFO] [stderr] 45 | let valid_until = Instant::now() + Duration::from_secs(MAX_TTL as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(MAX_TTL)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lookup.rs:407:53 [INFO] [stderr] | [INFO] [stderr] 407 | self.messages.lock().unwrap().pop().unwrap_or(empty()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lookup_ip.rs:404:53 [INFO] [stderr] | [INFO] [stderr] 404 | self.messages.lock().unwrap().pop().unwrap_or(empty()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(empty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/lookup_state.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | n @ _ if LOCALHOST_usage.zone_of(n) => &*LOCALHOST_usage, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/lookup_state.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | n @ _ if IN_ADDR_ARPA_127.zone_of(n) => &*LOCALHOST_usage, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/lookup_state.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | n @ _ if IP6_ARPA_1.zone_of(n) => &*LOCALHOST_usage, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/lookup_state.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | n @ _ if INVALID.zone_of(n) => &*INVALID, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `n @ _` pattern can be written as just `n` [INFO] [stderr] --> src/lookup_state.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | n @ _ if LOCAL.zone_of(n) => &*LOCAL, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lookup_state.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | / match r.rdata() { [INFO] [stderr] 219 | | &RData::CNAME(ref cname) => { [INFO] [stderr] 220 | | // take the minimum TTL of the cname_ttl and the next record in the chain [INFO] [stderr] 221 | | let ttl = cname_ttl.min(r.ttl()); [INFO] [stderr] ... | [INFO] [stderr] 235 | | _ => (), [INFO] [stderr] 236 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 218 | match *r.rdata() { [INFO] [stderr] 219 | RData::CNAME(ref cname) => { [INFO] [stderr] 220 | // take the minimum TTL of the cname_ttl and the next record in the chain [INFO] [stderr] 221 | let ttl = cname_ttl.min(r.ttl()); [INFO] [stderr] 222 | debug_assert_eq!(r.rr_type(), RecordType::CNAME); [INFO] [stderr] 223 | if search_name.as_ref() == r.name() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lookup_state.rs:272:125 [INFO] [stderr] | [INFO] [stderr] 272 | if self.query.query_type().is_srv() && r.rr_type().is_ip_addr() && search_name.as_ref() == r.name() { [INFO] [stderr] | _____________________________________________________________________________________________________________________________^ [INFO] [stderr] 273 | | Some((r.unwrap_rdata(), ttl)) [INFO] [stderr] 274 | | } else { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lookup_state.rs:267:97 [INFO] [stderr] | [INFO] [stderr] 267 | (search_name.as_ref() == r.name() || self.query.name() == r.name()) { [INFO] [stderr] | _________________________________________________________________________________________________^ [INFO] [stderr] 268 | | Some((r.unwrap_rdata(), ttl)) [INFO] [stderr] 269 | | } else [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the `r @ _` pattern can be written as just `r` [INFO] [stderr] --> src/lookup_state.rs:357:21 [INFO] [stderr] | [INFO] [stderr] 357 | r @ _ => Err(ResolveErrorKind::Msg(format!("DNS Error: {}", r)).into()), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rdatas @ _` pattern can be written as just `rdatas` [INFO] [stderr] --> src/lookup_state.rs:528:21 [INFO] [stderr] | [INFO] [stderr] 528 | rdatas @ _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `rdatas @ _` pattern can be written as just `rdatas` [INFO] [stderr] --> src/lookup_state.rs:546:21 [INFO] [stderr] | [INFO] [stderr] 546 | rdatas @ _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lookup_state.rs:583:53 [INFO] [stderr] | [INFO] [stderr] 583 | let poll = query.poll().map_err(|e| e.into()); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the `o @ _` pattern can be written as just `o` [INFO] [stderr] --> src/name_server_pool.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | o @ _ => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/name_server_pool.rs:525:5 [INFO] [stderr] | [INFO] [stderr] 525 | / pub fn new( [INFO] [stderr] 526 | | config: NameServerConfig, [INFO] [stderr] 527 | | options: ResolverOpts, [INFO] [stderr] 528 | | ) -> NameServer { [INFO] [stderr] ... | [INFO] [stderr] 538 | | } [INFO] [stderr] 539 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/name_server_pool.rs:720:77 [INFO] [stderr] | [INFO] [stderr] 720 | NameServer::<_, StandardConnection>::new(ns_config.clone(), options.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/name_server_pool.rs:728:77 [INFO] [stderr] | [INFO] [stderr] 728 | NameServer::<_, StandardConnection>::new(ns_config.clone(), options.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/name_server_pool.rs:736:22 [INFO] [stderr] | [INFO] [stderr] 736 | options: options.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/name_server_pool.rs:751:22 [INFO] [stderr] | [INFO] [stderr] 751 | options: options.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: replacing an `Option` with `None` [INFO] [stderr] --> src/name_server_pool.rs:879:39 [INFO] [stderr] | [INFO] [stderr] 879 | let request = mem::replace(request, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::take()` instead: `request.take()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mem_replace_option_with_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_none [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/resolver.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | self.options.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/system_conf/unix.rs:93:43 [INFO] [stderr] | [INFO] [stderr] 93 | options.timeout = Duration::from_secs(parsed_config.timeout as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(parsed_config.timeout)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/system_conf/unix.rs:128:60 [INFO] [stderr] | [INFO] [stderr] 128 | let server_path = env::var("TDNS_SERVER_SRC_ROOT").unwrap_or(".".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| ".".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `trust-dns-resolver`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4b75297d24d22a059dcd0131ce4773d3643fd1cbe01a387b5288c78576eece08"` [INFO] running `"docker" "rm" "-f" "4b75297d24d22a059dcd0131ce4773d3643fd1cbe01a387b5288c78576eece08"` [INFO] [stdout] 4b75297d24d22a059dcd0131ce4773d3643fd1cbe01a387b5288c78576eece08