[INFO] crate trust-dns-proto 0.5.0 is already in cache [INFO] extracting crate trust-dns-proto 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/trust-dns-proto/0.5.0 [INFO] extracting crate trust-dns-proto 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trust-dns-proto/0.5.0 [INFO] validating manifest of trust-dns-proto-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trust-dns-proto-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trust-dns-proto-0.5.0 [INFO] finished frobbing trust-dns-proto-0.5.0 [INFO] frobbed toml for trust-dns-proto-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/trust-dns-proto/0.5.0/Cargo.toml [INFO] started frobbing trust-dns-proto-0.5.0 [INFO] finished frobbing trust-dns-proto-0.5.0 [INFO] frobbed toml for trust-dns-proto-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trust-dns-proto/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trust-dns-proto-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/trust-dns-proto/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa879b89e4f64f0292f1ed21908e68b1312e2fcdde2363382582aaaa4cb5b95e [INFO] running `"docker" "start" "-a" "fa879b89e4f64f0292f1ed21908e68b1312e2fcdde2363382582aaaa4cb5b95e"` [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking trust-dns-proto v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/edns.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | rcode_high: rcode_high, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rcode_high` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/edns.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/edns.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | dnssec_ok: dnssec_ok, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dnssec_ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/edns.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | max_payload: max_payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/edns.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:814:13 [INFO] [stderr] | [INFO] [stderr] 814 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:815:13 [INFO] [stderr] | [INFO] [stderr] 815 | queries: queries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `queries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:816:13 [INFO] [stderr] | [INFO] [stderr] 816 | answers: answers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `answers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:817:13 [INFO] [stderr] | [INFO] [stderr] 817 | name_servers: name_servers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_servers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:818:13 [INFO] [stderr] | [INFO] [stderr] 818 | additionals: additionals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additionals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | sig0: sig0, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sig0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:820:13 [INFO] [stderr] | [INFO] [stderr] 820 | edns: edns, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/op/message.rs:897:1 [INFO] [stderr] | [INFO] [stderr] 897 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/query.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/query.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | query_type: query_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `query_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/query.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | query_class: query_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `query_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/op/response_code.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/domain/name.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | labels: labels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/domain/name.rs:1021:9 [INFO] [stderr] | [INFO] [stderr] 1021 | labels: labels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rr/rdata/aaaa.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | let e: u16 = decoder.read_u16()?.unverified(/*valid as any u16*/); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/rr/rdata/aaaa.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let f: u16 = decoder.read_u16()?.unverified(/*valid as any u16*/); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/rr/rdata/aaaa.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | let g: u16 = decoder.read_u16()?.unverified(/*valid as any u16*/); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/rr/rdata/aaaa.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | let h: u16 = decoder.read_u16()?.unverified(/*valid as any u16*/); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/mx.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | preference: preference, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `preference` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/mx.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | exchange: exchange, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `exchange` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:179:15 [INFO] [stderr] | [INFO] [stderr] 179 | OPT { options: options } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:240:25 [INFO] [stderr] | [INFO] [stderr] 240 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:241:25 [INFO] [stderr] | [INFO] [stderr] 241 | collected: collected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | mname: mname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | rname: rname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | refresh: refresh, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `refresh` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | retry: retry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | expire: expire, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `expire` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | minimum: minimum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minimum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/srv.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/srv.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/srv.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/srv.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | rr_type: rr_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `rr_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | ttl: ttl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | ttl: ttl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | rdata: rdata, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rdata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:322:13 [INFO] [stderr] | [INFO] [stderr] 322 | name_labels: name_labels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | ttl: ttl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | rdata: rdata, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rdata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rr_set.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | record_type: record_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rr_set.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rr_set.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rr_set.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | record_type: record_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rr_set.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | ttl: ttl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize/binary/decoder.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize/binary/encoder.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_client_stream.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | tcp_stream: tcp_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tcp_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_client_stream.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | tcp_stream: tcp_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tcp_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | peer_addr: peer_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:230:37 [INFO] [stderr] | [INFO] [stderr] 230 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:231:37 [INFO] [stderr] | [INFO] [stderr] 231 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:232:37 [INFO] [stderr] | [INFO] [stderr] 232 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:240:37 [INFO] [stderr] | [INFO] [stderr] 240 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:250:37 [INFO] [stderr] | [INFO] [stderr] 250 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:251:37 [INFO] [stderr] | [INFO] [stderr] 251 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:358:29 [INFO] [stderr] | [INFO] [stderr] 358 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/udp_client_stream.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | name_server: name_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/udp_client_stream.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | udp_stream: udp_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `udp_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/udp_stream.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/udp_stream.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/udp_stream.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfer/dns_multiplexer.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | signer: signer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `signer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfer/retry_dns_handle.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfer/retry_dns_handle.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | future: future, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `future` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfer/mod.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | name_server: name_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfer/mod.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/edns.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | rcode_high: rcode_high, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rcode_high` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/edns.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | version: version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/edns.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | dnssec_ok: dnssec_ok, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dnssec_ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/edns.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | max_payload: max_payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/edns.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | options: options, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:814:13 [INFO] [stderr] | [INFO] [stderr] 814 | header: header, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:815:13 [INFO] [stderr] | [INFO] [stderr] 815 | queries: queries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `queries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:816:13 [INFO] [stderr] | [INFO] [stderr] 816 | answers: answers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `answers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:817:13 [INFO] [stderr] | [INFO] [stderr] 817 | name_servers: name_servers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_servers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:818:13 [INFO] [stderr] | [INFO] [stderr] 818 | additionals: additionals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `additionals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | sig0: sig0, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sig0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/message.rs:820:13 [INFO] [stderr] | [INFO] [stderr] 820 | edns: edns, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `edns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/op/message.rs:897:1 [INFO] [stderr] | [INFO] [stderr] 897 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/query.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/query.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | query_type: query_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `query_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/op/query.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | query_class: query_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `query_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/op/response_code.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/domain/name.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | labels: labels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/domain/name.rs:1021:9 [INFO] [stderr] | [INFO] [stderr] 1021 | labels: labels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/rr/rdata/aaaa.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | let e: u16 = decoder.read_u16()?.unverified(/*valid as any u16*/); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/rr/rdata/aaaa.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let f: u16 = decoder.read_u16()?.unverified(/*valid as any u16*/); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/rr/rdata/aaaa.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | let g: u16 = decoder.read_u16()?.unverified(/*valid as any u16*/); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/rr/rdata/aaaa.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | let h: u16 = decoder.read_u16()?.unverified(/*valid as any u16*/); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/mx.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | preference: preference, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `preference` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/mx.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | exchange: exchange, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `exchange` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:179:15 [INFO] [stderr] | [INFO] [stderr] 179 | OPT { options: options } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `options` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:221:21 [INFO] [stderr] | [INFO] [stderr] 221 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:240:25 [INFO] [stderr] | [INFO] [stderr] 240 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/opt.rs:241:25 [INFO] [stderr] | [INFO] [stderr] 241 | collected: collected, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | mname: mname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | rname: rname, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | refresh: refresh, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `refresh` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | retry: retry, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `retry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | expire: expire, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `expire` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/soa.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | minimum: minimum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `minimum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/srv.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | priority: priority, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `priority` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/srv.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/srv.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rdata/srv.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | target: target, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | rr_type: rr_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `rr_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | ttl: ttl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | ttl: ttl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | rdata: rdata, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rdata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:322:13 [INFO] [stderr] | [INFO] [stderr] 322 | name_labels: name_labels, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_labels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | ttl: ttl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/resource.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | rdata: rdata, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rdata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rr_set.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | record_type: record_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rr_set.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | serial: serial, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `serial` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rr_set.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rr_set.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | record_type: record_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `record_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rr/rr_set.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | ttl: ttl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ttl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize/binary/decoder.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serialize/binary/encoder.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_client_stream.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | tcp_stream: tcp_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tcp_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_client_stream.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | tcp_stream: tcp_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tcp_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:181:13 [INFO] [stderr] | [INFO] [stderr] 181 | peer_addr: peer_addr, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:230:37 [INFO] [stderr] | [INFO] [stderr] 230 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:231:37 [INFO] [stderr] | [INFO] [stderr] 231 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:232:37 [INFO] [stderr] | [INFO] [stderr] 232 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:240:37 [INFO] [stderr] | [INFO] [stderr] 240 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:250:37 [INFO] [stderr] | [INFO] [stderr] 250 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:251:37 [INFO] [stderr] | [INFO] [stderr] 251 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:358:29 [INFO] [stderr] | [INFO] [stderr] 358 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/udp_client_stream.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | name_server: name_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/udp_client_stream.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | udp_stream: udp_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `udp_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/udp_stream.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/udp_stream.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/udp/udp_stream.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfer/dns_multiplexer.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | signer: signer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `signer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfer/retry_dns_handle.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | request: request, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `request` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfer/retry_dns_handle.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | future: future, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `future` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfer/mod.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | name_server: name_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/xfer/mod.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | sender: sender, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rr/domain/name.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/rr/record_data.rs:407:17 [INFO] [stderr] | [INFO] [stderr] 407 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/xfer/dns_exchange.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/rr/domain/label.rs:450:41 [INFO] [stderr] | [INFO] [stderr] 450 | Label::from_raw_bytes(&[001]).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 450 | Label::from_raw_bytes(&[1]).unwrap(), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 450 | Label::from_raw_bytes(&[0o1]).unwrap(), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rr/domain/name.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/rr/domain/name.rs:1388:23 [INFO] [stderr] | [INFO] [stderr] 1388 | &[001u8] as &[u8], [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1388 | &[1u8] as &[u8], [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1388 | &[0o1u8] as &[u8], [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/rr/domain/name.rs:1395:23 [INFO] [stderr] | [INFO] [stderr] 1395 | &[001u8] as &[u8], [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 1395 | &[1u8] as &[u8], [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 1395 | &[0o1u8] as &[u8], [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/rr/record_data.rs:407:17 [INFO] [stderr] | [INFO] [stderr] 407 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rr/rr_set.rs:616:17 [INFO] [stderr] | [INFO] [stderr] 616 | 2015082403, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_015_082_403` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rr/rr_set.rs:619:17 [INFO] [stderr] | [INFO] [stderr] 619 | 1209600, [INFO] [stderr] | ^^^^^^^ help: consider: `1_209_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rr/rr_set.rs:631:17 [INFO] [stderr] | [INFO] [stderr] 631 | 2015082403, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_015_082_403` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rr/rr_set.rs:634:17 [INFO] [stderr] | [INFO] [stderr] 634 | 1209600, [INFO] [stderr] | ^^^^^^^ help: consider: `1_209_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rr/rr_set.rs:646:17 [INFO] [stderr] | [INFO] [stderr] 646 | 2015082404, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_015_082_404` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rr/rr_set.rs:649:17 [INFO] [stderr] | [INFO] [stderr] 649 | 1209600, [INFO] [stderr] | ^^^^^^^ help: consider: `1_209_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rr/rr_set.rs:792:17 [INFO] [stderr] | [INFO] [stderr] 792 | 2015082403, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_015_082_403` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rr/rr_set.rs:795:17 [INFO] [stderr] | [INFO] [stderr] 795 | 1209600, [INFO] [stderr] | ^^^^^^^ help: consider: `1_209_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/serialize/binary/bin_tests.rs:96:10 [INFO] [stderr] | [INFO] [stderr] 96 | (2147483648, vec![0x80, 0x00, 0x00, 0x00]), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tcp/tcp_client_stream.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | const TEST_BYTES: &'static [u8; 8] = b"DEADBEEF"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tcp/tcp_stream.rs:444:20 [INFO] [stderr] | [INFO] [stderr] 444 | const TEST_BYTES: &'static [u8; 8] = b"DEADBEEF"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/xfer/dns_exchange.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/xfer/retry_dns_handle.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | return Box::new(failed(ProtoError::from("last retry set to fail").into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(failed(ProtoError::from("last retry set to fail").into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/xfer/retry_dns_handle.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | / if i > self.retries || self.retries - i == 0 { [INFO] [stderr] 116 | | if self.last_succeed { [INFO] [stderr] 117 | | let mut message = Message::new(); [INFO] [stderr] 118 | | message.set_id(i); [INFO] [stderr] 119 | | return Box::new(finished(message.into())); [INFO] [stderr] 120 | | } [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 115 | if (i > self.retries || self.retries - i == 0) && self.last_succeed { [INFO] [stderr] 116 | let mut message = Message::new(); [INFO] [stderr] 117 | message.set_id(i); [INFO] [stderr] 118 | return Box::new(finished(message.into())); [INFO] [stderr] 119 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/op/edns.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn option(&self, code: &EdnsCode) -> Option<&EdnsOption> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `EdnsCode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/op/message.rs:719:1 [INFO] [stderr] | [INFO] [stderr] 719 | / pub fn emit_message_parts( [INFO] [stderr] 720 | | header: &Header, [INFO] [stderr] 721 | | queries: &mut Q, [INFO] [stderr] 722 | | answers: &mut A, [INFO] [stderr] ... | [INFO] [stderr] 772 | | Ok(()) [INFO] [stderr] 773 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/op/response_code.rs:134:16 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn low(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/op/response_code.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn high(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/op/response_code.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/rr/domain/label.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: item `rr::domain::label::Label` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/rr/domain/label.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / impl Label { [INFO] [stderr] 33 | | /// These must only be ASCII, with unicode encoded to PunyCode, or other such transformation. [INFO] [stderr] 34 | | /// [INFO] [stderr] 35 | | /// This uses the bytes as raw ascii values, with nothing escaped on the wire. [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rr/domain/label.rs:51:26 [INFO] [stderr] | [INFO] [stderr] 51 | if s.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/rr/domain/name.rs:27:37 [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Clone, Default, Debug, Eq, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/rr/domain/name.rs:882:1 [INFO] [stderr] | [INFO] [stderr] 882| / impl PartialEq for Name { [INFO] [stderr] 883| | fn eq(&self, other: &Self) -> bool { [INFO] [stderr] 884| | self.cmp_with_f::(other) == Ordering::Equal [INFO] [stderr] 885| | } [INFO] [stderr] 886| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:813:13 [INFO] [stderr] | [INFO] [stderr] 813 | / "in-addr" [INFO] [stderr] 814 | | .as_bytes() [INFO] [stderr] | |___________________________^ help: consider using a byte string literal instead: `b"in-addr"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | / "arpa" [INFO] [stderr] 820 | | .as_bytes() [INFO] [stderr] | |___________________________^ help: consider using a byte string literal instead: `b"arpa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:866:13 [INFO] [stderr] | [INFO] [stderr] 866 | / "ip6" [INFO] [stderr] 867 | | .as_bytes() [INFO] [stderr] | |___________________________^ help: consider using a byte string literal instead: `b"ip6"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:872:13 [INFO] [stderr] | [INFO] [stderr] 872 | / "arpa" [INFO] [stderr] 873 | | .as_bytes() [INFO] [stderr] | |___________________________^ help: consider using a byte string literal instead: `b"arpa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/rr/domain/usage.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | / pub fn new(name: Name, user: UserUsage, app: AppUsage, resolver: ResolverUsage, cache: CacheUsage, auth: AuthUsage, op: OpUsage, registry: RegistryUsage) -> Self { [INFO] [stderr] 397 | | ZoneUsage {name, user, app, resolver, cache, auth, op, registry} [INFO] [stderr] 398 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/rdata/a.rs:59:48 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn emit(encoder: &mut BinEncoder, address: &Ipv4Addr) -> ProtoResult<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/rdata/opt.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | pub fn get(&self, code: &EdnsCode) -> Option<&EdnsOption> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `EdnsCode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/record_type.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn is_any(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/record_type.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn is_cname(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/record_type.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn is_srv(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/record_type.rs:124:23 [INFO] [stderr] | [INFO] [stderr] 124 | pub fn is_ip_addr(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rr/rr_set.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | / pub fn records_without_rrsigs<'s>(&'s self) -> RrsetRecords<'s> { [INFO] [stderr] 194 | | if self.records.is_empty() { [INFO] [stderr] 195 | | RrsetRecords::Empty [INFO] [stderr] 196 | | } else { [INFO] [stderr] 197 | | RrsetRecords::RecordsOnly(self.records.iter()) [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rr/rr_set.rs:203:5 [INFO] [stderr] | [INFO] [stderr] 203 | / pub fn iter<'s>(&'s self) -> Iter<'s, Record> { [INFO] [stderr] 204 | | self.records.iter() [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/serialize/binary/encoder.rs:371:24 [INFO] [stderr] | [INFO] [stderr] 371 | let mut iter = iter.map(|i| *i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/tcp/tcp_client_stream.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new(name_server: SocketAddr) -> (TcpClientConnect, Box) { [INFO] [stderr] 39 | | Self::with_timeout(name_server, Duration::from_secs(5)) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:353:25 [INFO] [stderr] | [INFO] [stderr] 352 | let mut bytes = Vec::with_capacity(length as usize); [INFO] [stderr] | ----------------------------------- help: consider replace allocation with: `vec![0; length as usize]` [INFO] [stderr] 353 | bytes.resize(length as usize, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/udp/udp_client_stream.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new(name_server: SocketAddr) -> (UdpClientConnect, Box) { [INFO] [stderr] 36 | | let (stream_future, sender) = UdpStream::new(name_server); [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | let new_future = Box::new( [INFO] [stderr] ... | [INFO] [stderr] 50 | | (new_future, sender) [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/xfer/dns_multiplexer.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new( [INFO] [stderr] 142 | | stream: F, [INFO] [stderr] 143 | | stream_handle: Box, [INFO] [stderr] 144 | | signer: Option>, [INFO] [stderr] ... | [INFO] [stderr] 149 | | Self::with_timeout(stream, stream_handle, Duration::from_secs(5), signer) [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/xfer/dns_multiplexer.rs:348:72 [INFO] [stderr] | [INFO] [stderr] 348 | return DnsMultiplexerSerialResponseInner::Err(Some(e.into())).into(); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/xfer/dns_multiplexer.rs:373:76 [INFO] [stderr] | [INFO] [stderr] 373 | return DnsMultiplexerSerialResponseInner::Err(Some(err.into())).into() [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: item `xfer::dns_response::DnsResponse` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/xfer/dns_response.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / impl DnsResponse { [INFO] [stderr] 27 | | /// Get all the messages in the Response [INFO] [stderr] 28 | | pub fn messages(&self) -> Iter { [INFO] [stderr] 29 | | self.0.as_slice().iter() [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/xfer/mod.rs:232:30 [INFO] [stderr] | [INFO] [stderr] 232 | ProtoError::from(format!("could not send request")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"could not send request".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `trust-dns-proto`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/op/edns.rs:82:32 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn option(&self, code: &EdnsCode) -> Option<&EdnsOption> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `EdnsCode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/op/message.rs:719:1 [INFO] [stderr] | [INFO] [stderr] 719 | / pub fn emit_message_parts( [INFO] [stderr] 720 | | header: &Header, [INFO] [stderr] 721 | | queries: &mut Q, [INFO] [stderr] 722 | | answers: &mut A, [INFO] [stderr] ... | [INFO] [stderr] 772 | | Ok(()) [INFO] [stderr] 773 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/op/response_code.rs:134:16 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn low(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/op/response_code.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | pub fn high(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/op/response_code.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/rr/domain/label.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: item `rr::domain::label::Label` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/rr/domain/label.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / impl Label { [INFO] [stderr] 33 | | /// These must only be ASCII, with unicode encoded to PunyCode, or other such transformation. [INFO] [stderr] 34 | | /// [INFO] [stderr] 35 | | /// This uses the bytes as raw ascii values, with nothing escaped on the wire. [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rr/domain/label.rs:51:26 [INFO] [stderr] | [INFO] [stderr] 51 | if s.starts_with("_") { [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/rr/domain/name.rs:27:37 [INFO] [stderr] | [INFO] [stderr] 27 | #[derive(Clone, Default, Debug, Eq, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/rr/domain/name.rs:882:1 [INFO] [stderr] | [INFO] [stderr] 882| / impl PartialEq for Name { [INFO] [stderr] 883| | fn eq(&self, other: &Self) -> bool { [INFO] [stderr] 884| | self.cmp_with_f::(other) == Ordering::Equal [INFO] [stderr] 885| | } [INFO] [stderr] 886| | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:813:13 [INFO] [stderr] | [INFO] [stderr] 813 | / "in-addr" [INFO] [stderr] 814 | | .as_bytes() [INFO] [stderr] | |___________________________^ help: consider using a byte string literal instead: `b"in-addr"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | / "arpa" [INFO] [stderr] 820 | | .as_bytes() [INFO] [stderr] | |___________________________^ help: consider using a byte string literal instead: `b"arpa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:866:13 [INFO] [stderr] | [INFO] [stderr] 866 | / "ip6" [INFO] [stderr] 867 | | .as_bytes() [INFO] [stderr] | |___________________________^ help: consider using a byte string literal instead: `b"ip6"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:872:13 [INFO] [stderr] | [INFO] [stderr] 872 | / "arpa" [INFO] [stderr] 873 | | .as_bytes() [INFO] [stderr] | |___________________________^ help: consider using a byte string literal instead: `b"arpa"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/rr/domain/name.rs:1169:1 [INFO] [stderr] | [INFO] [stderr] 1169 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rr/domain/name.rs:1287:18 [INFO] [stderr] | [INFO] [stderr] 1287 | for b in (0..n).into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1389:21 [INFO] [stderr] | [INFO] [stderr] 1389 | "z".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"z"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1390:21 [INFO] [stderr] | [INFO] [stderr] 1390 | "example".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"example"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1396:21 [INFO] [stderr] | [INFO] [stderr] 1396 | "z".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"z"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1397:21 [INFO] [stderr] | [INFO] [stderr] 1397 | "example".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"example"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1405:21 [INFO] [stderr] | [INFO] [stderr] 1405 | "z".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"z"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1406:21 [INFO] [stderr] | [INFO] [stderr] 1406 | "example".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"example"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1459:17 [INFO] [stderr] | [INFO] [stderr] 1459 | "www".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"www"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1460:17 [INFO] [stderr] | [INFO] [stderr] 1460 | "example".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"example"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1461:17 [INFO] [stderr] | [INFO] [stderr] 1461 | "com".as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"com"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1477:17 [INFO] [stderr] | [INFO] [stderr] 1477 | "www".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"www"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1478:17 [INFO] [stderr] | [INFO] [stderr] 1478 | "example".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"example"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1479:17 [INFO] [stderr] | [INFO] [stderr] 1479 | "com".as_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"com"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1505:13 [INFO] [stderr] | [INFO] [stderr] 1505 | "WWW".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"WWW"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1506:13 [INFO] [stderr] | [INFO] [stderr] 1506 | "example".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"example"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1507:13 [INFO] [stderr] | [INFO] [stderr] 1507 | "COM".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"COM"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1519:13 [INFO] [stderr] | [INFO] [stderr] 1519 | "WWW".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"WWW"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1520:13 [INFO] [stderr] | [INFO] [stderr] 1520 | "example".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"example"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/rr/domain/name.rs:1521:13 [INFO] [stderr] | [INFO] [stderr] 1521 | "COM".as_bytes(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"COM"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/rr/domain/usage.rs:396:5 [INFO] [stderr] | [INFO] [stderr] 396 | / pub fn new(name: Name, user: UserUsage, app: AppUsage, resolver: ResolverUsage, cache: CacheUsage, auth: AuthUsage, op: OpUsage, registry: RegistryUsage) -> Self { [INFO] [stderr] 397 | | ZoneUsage {name, user, app, resolver, cache, auth, op, registry} [INFO] [stderr] 398 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/rdata/a.rs:59:48 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn emit(encoder: &mut BinEncoder, address: &Ipv4Addr) -> ProtoResult<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Ipv4Addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/rr/rdata/caa.rs:1026:32 [INFO] [stderr] | [INFO] [stderr] 1026 | let encoded: Vec = header [INFO] [stderr] | ________________________________^ [INFO] [stderr] 1027 | | .into_iter() [INFO] [stderr] 1028 | | .chain(name_bytes.iter()) [INFO] [stderr] 1029 | | .map(|b| *b) [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 1026 | let encoded: Vec = header [INFO] [stderr] 1027 | .into_iter() [INFO] [stderr] 1028 | .chain(name_bytes.iter()).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/rr/rdata/caa.rs:1027:14 [INFO] [stderr] | [INFO] [stderr] 1027 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/rr/rdata/caa.rs:1046:32 [INFO] [stderr] | [INFO] [stderr] 1046 | let encoded: Vec = header.iter().chain(name_bytes.iter()).map(|b| *b).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `header.iter().chain(name_bytes.iter()).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/rdata/opt.rs:188:29 [INFO] [stderr] | [INFO] [stderr] 188 | pub fn get(&self, code: &EdnsCode) -> Option<&EdnsOption> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `EdnsCode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/rr/record_data.rs:623:1 [INFO] [stderr] | [INFO] [stderr] 623 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: the variable `test_pass` is used as a loop counter. Consider using `for (test_pass, item) in get_data().enumerate()` or similar iterators [INFO] [stderr] --> src/rr/record_data.rs:773:33 [INFO] [stderr] | [INFO] [stderr] 773 | for (expect, binary) in get_data() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/record_type.rs:106:19 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn is_any(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/record_type.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn is_cname(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/record_type.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn is_srv(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rr/record_type.rs:124:23 [INFO] [stderr] | [INFO] [stderr] 124 | pub fn is_ip_addr(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/rr/resource.rs:421:1 [INFO] [stderr] | [INFO] [stderr] 421 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rr/rr_set.rs:193:5 [INFO] [stderr] | [INFO] [stderr] 193 | / pub fn records_without_rrsigs<'s>(&'s self) -> RrsetRecords<'s> { [INFO] [stderr] 194 | | if self.records.is_empty() { [INFO] [stderr] 195 | | RrsetRecords::Empty [INFO] [stderr] 196 | | } else { [INFO] [stderr] 197 | | RrsetRecords::RecordsOnly(self.records.iter()) [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rr/rr_set.rs:203:5 [INFO] [stderr] | [INFO] [stderr] 203 | / pub fn iter<'s>(&'s self) -> Iter<'s, Record> { [INFO] [stderr] 204 | | self.records.iter() [INFO] [stderr] 205 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:564:17 [INFO] [stderr] | [INFO] [stderr] 564 | / .collect::>() [INFO] [stderr] 565 | | .contains(&&insert) [INFO] [stderr] | |___________________________________^ help: replace with: `.any(|&x| x == &insert)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:574:17 [INFO] [stderr] | [INFO] [stderr] 574 | / .collect::>() [INFO] [stderr] 575 | | .contains(&&insert) [INFO] [stderr] | |___________________________________^ help: replace with: `.any(|&x| x == &insert)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:591:17 [INFO] [stderr] | [INFO] [stderr] 591 | / .collect::>() [INFO] [stderr] 592 | | .contains(&&insert) [INFO] [stderr] | |___________________________________^ help: replace with: `.any(|&x| x == &insert)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:597:17 [INFO] [stderr] | [INFO] [stderr] 597 | / .collect::>() [INFO] [stderr] 598 | | .contains(&&insert1) [INFO] [stderr] | |____________________________________^ help: replace with: `.any(|&x| x == &insert1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:658:17 [INFO] [stderr] | [INFO] [stderr] 658 | / .collect::>() [INFO] [stderr] 659 | | .contains(&&insert) [INFO] [stderr] | |___________________________________^ help: replace with: `.any(|&x| x == &insert)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:666:17 [INFO] [stderr] | [INFO] [stderr] 666 | / .collect::>() [INFO] [stderr] 667 | | .contains(&&insert) [INFO] [stderr] | |___________________________________^ help: replace with: `.any(|&x| x == &insert)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:672:17 [INFO] [stderr] | [INFO] [stderr] 672 | / .collect::>() [INFO] [stderr] 673 | | .contains(&&same_serial,) [INFO] [stderr] | |_________________________________________^ help: replace with: `.any(|&x| x == &same_serial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:683:17 [INFO] [stderr] | [INFO] [stderr] 683 | / .collect::>() [INFO] [stderr] 684 | | .contains(&&new_serial) [INFO] [stderr] | |_______________________________________^ help: replace with: `.any(|&x| x == &new_serial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:689:17 [INFO] [stderr] | [INFO] [stderr] 689 | / .collect::>() [INFO] [stderr] 690 | | .contains(&&insert) [INFO] [stderr] | |___________________________________^ help: replace with: `.any(|&x| x == &insert)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:695:17 [INFO] [stderr] | [INFO] [stderr] 695 | / .collect::>() [INFO] [stderr] 696 | | .contains(&&same_serial) [INFO] [stderr] | |________________________________________^ help: replace with: `.any(|&x| x == &same_serial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:728:17 [INFO] [stderr] | [INFO] [stderr] 728 | / .collect::>() [INFO] [stderr] 729 | | .contains(&&insert) [INFO] [stderr] | |___________________________________^ help: replace with: `.any(|&x| x == &insert)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:737:17 [INFO] [stderr] | [INFO] [stderr] 737 | / .collect::>() [INFO] [stderr] 738 | | .contains(&&insert) [INFO] [stderr] | |___________________________________^ help: replace with: `.any(|&x| x == &insert)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:743:17 [INFO] [stderr] | [INFO] [stderr] 743 | / .collect::>() [INFO] [stderr] 744 | | .contains(&&new_record) [INFO] [stderr] | |_______________________________________^ help: replace with: `.any(|&x| x == &new_record)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/rr/rr_set.rs:805:17 [INFO] [stderr] | [INFO] [stderr] 805 | / .collect::>() [INFO] [stderr] 806 | | .contains(&&insert) [INFO] [stderr] | |___________________________________^ help: replace with: `.any(|&x| x == &insert)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/serialize/binary/encoder.rs:371:24 [INFO] [stderr] | [INFO] [stderr] 371 | let mut iter = iter.map(|i| *i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `iter.cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: the variable `test_pass` is used as a loop counter. Consider using `for (test_pass, item) in data_set.enumerate()` or similar iterators [INFO] [stderr] --> src/serialize/binary/bin_tests.rs:118:29 [INFO] [stderr] | [INFO] [stderr] 118 | for (expect, binary) in data_set { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `test_pass` is used as a loop counter. Consider using `for (test_pass, item) in data_set.enumerate()` or similar iterators [INFO] [stderr] --> src/serialize/binary/bin_tests.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | for (data, expect) in data_set { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/tcp/tcp_client_stream.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new(name_server: SocketAddr) -> (TcpClientConnect, Box) { [INFO] [stderr] 39 | | Self::with_timeout(name_server, Duration::from_secs(5)) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tcp/tcp_client_stream.rs:199:30 [INFO] [stderr] | [INFO] [stderr] 199 | let length = (len_bytes[0] as u16) << 8 & 0xFF00 | len_bytes[1] as u16 & 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(len_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tcp/tcp_client_stream.rs:199:68 [INFO] [stderr] | [INFO] [stderr] 199 | let length = (len_bytes[0] as u16) << 8 & 0xFF00 | len_bytes[1] as u16 & 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(len_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/tcp/tcp_stream.rs:353:25 [INFO] [stderr] | [INFO] [stderr] 352 | let mut bytes = Vec::with_capacity(length as usize); [INFO] [stderr] | ----------------------------------- help: consider replace allocation with: `vec![0; length as usize]` [INFO] [stderr] 353 | bytes.resize(length as usize, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tcp/tcp_stream.rs:496:30 [INFO] [stderr] | [INFO] [stderr] 496 | let length = (len_bytes[0] as u16) << 8 & 0xFF00 | len_bytes[1] as u16 & 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(len_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tcp/tcp_stream.rs:496:68 [INFO] [stderr] | [INFO] [stderr] 496 | let length = (len_bytes[0] as u16) << 8 & 0xFF00 | len_bytes[1] as u16 & 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(len_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/tcp/tcp_stream.rs:526:22 [INFO] [stderr] | [INFO] [stderr] 526 | let mut stream = io_loop [INFO] [stderr] | ______________________^ [INFO] [stderr] 527 | | .block_on(stream) [INFO] [stderr] 528 | | .ok() [INFO] [stderr] 529 | | .expect("run failed to get stream"); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/udp/udp_client_stream.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new(name_server: SocketAddr) -> (UdpClientConnect, Box) { [INFO] [stderr] 36 | | let (stream_future, sender) = UdpStream::new(name_server); [INFO] [stderr] 37 | | [INFO] [stderr] 38 | | let new_future = Box::new( [INFO] [stderr] ... | [INFO] [stderr] 50 | | (new_future, sender) [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/udp/udp_stream.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | / io_loop [INFO] [stderr] 201 | | .block_on(stream) [INFO] [stderr] 202 | | .ok() [INFO] [stderr] 203 | | .expect("failed to get next socket address"), [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/xfer/dns_multiplexer.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new( [INFO] [stderr] 142 | | stream: F, [INFO] [stderr] 143 | | stream_handle: Box, [INFO] [stderr] 144 | | signer: Option>, [INFO] [stderr] ... | [INFO] [stderr] 149 | | Self::with_timeout(stream, stream_handle, Duration::from_secs(5), signer) [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/xfer/dns_multiplexer.rs:348:72 [INFO] [stderr] | [INFO] [stderr] 348 | return DnsMultiplexerSerialResponseInner::Err(Some(e.into())).into(); [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/xfer/dns_multiplexer.rs:373:76 [INFO] [stderr] | [INFO] [stderr] 373 | return DnsMultiplexerSerialResponseInner::Err(Some(err.into())).into() [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: item `xfer::dns_response::DnsResponse` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/xfer/dns_response.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | / impl DnsResponse { [INFO] [stderr] 27 | | /// Get all the messages in the Response [INFO] [stderr] 28 | | pub fn messages(&self) -> Iter { [INFO] [stderr] 29 | | self.0.as_slice().iter() [INFO] [stderr] ... | [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/xfer/retry_dns_handle.rs:124:36 [INFO] [stderr] | [INFO] [stderr] 124 | return Box::new(failed(ProtoError::from("last retry set to fail").into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ProtoError::from("last retry set to fail")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/xfer/retry_dns_handle.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | let result = handle [INFO] [stderr] | ______________________^ [INFO] [stderr] 140 | | .send(test1) [INFO] [stderr] 141 | | .wait() [INFO] [stderr] 142 | | .ok() [INFO] [stderr] 143 | | .expect("should have succeeded"); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/xfer/mod.rs:232:30 [INFO] [stderr] | [INFO] [stderr] 232 | ProtoError::from(format!("could not send request")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"could not send request".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `trust-dns-proto`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fa879b89e4f64f0292f1ed21908e68b1312e2fcdde2363382582aaaa4cb5b95e"` [INFO] running `"docker" "rm" "-f" "fa879b89e4f64f0292f1ed21908e68b1312e2fcdde2363382582aaaa4cb5b95e"` [INFO] [stdout] fa879b89e4f64f0292f1ed21908e68b1312e2fcdde2363382582aaaa4cb5b95e