[INFO] crate trust-dns-native-tls 0.4.0 is already in cache [INFO] extracting crate trust-dns-native-tls 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/trust-dns-native-tls/0.4.0 [INFO] extracting crate trust-dns-native-tls 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trust-dns-native-tls/0.4.0 [INFO] validating manifest of trust-dns-native-tls-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trust-dns-native-tls-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trust-dns-native-tls-0.4.0 [INFO] finished frobbing trust-dns-native-tls-0.4.0 [INFO] frobbed toml for trust-dns-native-tls-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/trust-dns-native-tls/0.4.0/Cargo.toml [INFO] started frobbing trust-dns-native-tls-0.4.0 [INFO] finished frobbing trust-dns-native-tls-0.4.0 [INFO] frobbed toml for trust-dns-native-tls-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trust-dns-native-tls/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trust-dns-native-tls-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/trust-dns-native-tls/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 454fca0703f75171d4737060a3fd4021cc7b8cf580bb15e78132468017568a85 [INFO] running `"docker" "start" "-a" "454fca0703f75171d4737060a3fd4021cc7b8cf580bb15e78132468017568a85"` [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Checking trust-dns-native-tls v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tls_client_stream::TlsClientStreamBuilder` [INFO] [stderr] --> src/tls_client_stream.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> TlsClientStreamBuilder { [INFO] [stderr] 36 | | TlsClientStreamBuilder(TlsStreamBuilder::new()) [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for tls_client_stream::TlsClientStreamBuilder { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tls_client_stream.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | .map(move |tls_stream| TcpClientStream::from_stream(tls_stream)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TcpClientStream::from_stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tls_stream::TlsStreamBuilder` [INFO] [stderr] --> src/tls_stream.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn new() -> TlsStreamBuilder { [INFO] [stderr] 69 | | TlsStreamBuilder { [INFO] [stderr] 70 | | ca_chain: vec![], [INFO] [stderr] 71 | | identity: None, [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tests.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | const TEST_BYTES: &'static [u8; 8] = b"DEADBEEF"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tls_client_stream::TlsClientStreamBuilder` [INFO] [stderr] --> src/tls_client_stream.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> TlsClientStreamBuilder { [INFO] [stderr] 36 | | TlsClientStreamBuilder(TlsStreamBuilder::new()) [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | impl Default for tls_client_stream::TlsClientStreamBuilder { [INFO] [stderr] 34 | fn default() -> Self { [INFO] [stderr] 35 | Self::new() [INFO] [stderr] 36 | } [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tls_client_stream.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | .map(move |tls_stream| TcpClientStream::from_stream(tls_stream)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TcpClientStream::from_stream` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tls_stream::TlsStreamBuilder` [INFO] [stderr] --> src/tls_stream.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn new() -> TlsStreamBuilder { [INFO] [stderr] 69 | | TlsStreamBuilder { [INFO] [stderr] 70 | | ca_chain: vec![], [INFO] [stderr] 71 | | identity: None, [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/tests.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/tests.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tests.rs:59:37 [INFO] [stderr] | [INFO] [stderr] 59 | let mut file = File::open(path).expect(&format!("failed to open file: {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to open file: {}", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tests.rs:61:10 [INFO] [stderr] | [INFO] [stderr] 61 | .expect(&format!("failed to read file: {}", path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to read file: {}", path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tests.rs:83:56 [INFO] [stderr] | [INFO] [stderr] 83 | let server_path = env::var("TDNS_SERVER_SRC_ROOT").unwrap_or("../server".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "../server".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tests.rs:148:30 [INFO] [stderr] | [INFO] [stderr] 148 | let length = (len_bytes[0] as u16) << 8 & 0xFF00 | len_bytes[1] as u16 & 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(len_bytes[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/tests.rs:148:68 [INFO] [stderr] | [INFO] [stderr] 148 | let length = (len_bytes[0] as u16) << 8 & 0xFF00 | len_bytes[1] as u16 & 0x00FF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(len_bytes[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/tests.rs:193:22 [INFO] [stderr] | [INFO] [stderr] 193 | let mut stream = io_loop [INFO] [stderr] | ______________________^ [INFO] [stderr] 194 | | .block_on(stream) [INFO] [stderr] 195 | | .ok() [INFO] [stderr] 196 | | .expect("run failed to get stream"); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `trust-dns-native-tls`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "454fca0703f75171d4737060a3fd4021cc7b8cf580bb15e78132468017568a85"` [INFO] running `"docker" "rm" "-f" "454fca0703f75171d4737060a3fd4021cc7b8cf580bb15e78132468017568a85"` [INFO] [stdout] 454fca0703f75171d4737060a3fd4021cc7b8cf580bb15e78132468017568a85