[INFO] crate triehash 0.3.0 is already in cache [INFO] extracting crate triehash 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/triehash/0.3.0 [INFO] extracting crate triehash 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/triehash/0.3.0 [INFO] validating manifest of triehash-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of triehash-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing triehash-0.3.0 [INFO] finished frobbing triehash-0.3.0 [INFO] frobbed toml for triehash-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/triehash/0.3.0/Cargo.toml [INFO] started frobbing triehash-0.3.0 [INFO] finished frobbing triehash-0.3.0 [INFO] frobbed toml for triehash-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/triehash/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting triehash-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/triehash/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f7e9287ca491797785419302aafea1fd115f50500f899d256200afc2760d069e [INFO] running `"docker" "start" "-a" "f7e9287ca491797785419302aafea1fd115f50500f899d256200afc2760d069e"` [INFO] [stderr] Checking parity-bytes v0.1.0 [INFO] [stderr] Checking hashdb v0.3.0 [INFO] [stderr] Checking elastic-array v0.10.0 [INFO] [stderr] Checking plain_hasher v0.2.0 [INFO] [stderr] Checking ethereum-types-serialize v0.2.1 [INFO] [stderr] Checking uint v0.4.1 [INFO] [stderr] Checking rlp v0.3.0 [INFO] [stderr] Checking fixed-hash v0.2.5 [INFO] [stderr] Checking triehash v0.3.0 (/opt/crater/workdir) [INFO] [stderr] Checking ethbloom v0.5.0 [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:231:18 [INFO] [stderr] | [INFO] [stderr] 231 | let mut begin = match pre_len == key.len() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 232 | | true => 1, [INFO] [stderr] 233 | | false => 0 [INFO] [stderr] 234 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if pre_len == key.len() { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:239:13 [INFO] [stderr] | [INFO] [stderr] 239 | let len = match begin < input.len() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 240 | | true => input[begin..].iter() [INFO] [stderr] 241 | | .take_while(| pair | pair.0.as_ref()[pre_len] == i ) [INFO] [stderr] 242 | | .count(), [INFO] [stderr] 243 | | false => 0 [INFO] [stderr] 244 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 239 | let len = if begin < input.len() { input[begin..].iter() [INFO] [stderr] 240 | .take_while(| pair | pair.0.as_ref()[pre_len] == i ) [INFO] [stderr] 241 | .count() } else { 0 }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:256:2 [INFO] [stderr] | [INFO] [stderr] 256 | match pre_len == key.len() { [INFO] [stderr] | _____^ [INFO] [stderr] 257 | | true => { stream.append(&value); }, [INFO] [stderr] 258 | | false => { stream.append_empty_data(); } [INFO] [stderr] 259 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if pre_len == key.len() { stream.append(&value); } else { stream.append_empty_data(); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Checking hashdb v0.2.1 [INFO] [stderr] Checking ethereum-types v0.4.0 [INFO] [stderr] Checking keccak-hash v0.1.2 [INFO] [stderr] Checking rlp v0.2.4 [INFO] [stderr] Checking keccak-hasher v0.1.1 [INFO] [stderr] Checking trie-standardmap v0.1.1 [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/triehash.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `triehash`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0277]: the trait bound `keccak_hasher::KeccakHasher: hashdb::Hasher` is not satisfied [INFO] [stderr] --> src/lib.rs:318:14 [INFO] [stderr] | [INFO] [stderr] 318 | assert_eq!(trie_root::(vec![ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `hashdb::Hasher` is not implemented for `keccak_hasher::KeccakHasher` [INFO] [stderr] [INFO] [stderr] error[E0277]: the trait bound `keccak_hasher::KeccakHasher: hashdb::Hasher` is not satisfied [INFO] [stderr] --> src/lib.rs:318:14 [INFO] [stderr] | [INFO] [stderr] 318 | assert_eq!(trie_root::(vec![ [INFO] [stderr] | ____________________^ [INFO] [stderr] 319 | | (b"A", b"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" as &[u8]) [INFO] [stderr] 320 | | ]), "d23786fb4a010da3ce639d66d5e904a11dbc02746d1ce25029e53290cabf28ab".into()); [INFO] [stderr] | |__________^ the trait `hashdb::Hasher` is not implemented for `keccak_hasher::KeccakHasher` [INFO] [stderr] [INFO] [stderr] error[E0277]: the trait bound `keccak_hasher::KeccakHasher: hashdb::Hasher` is not satisfied [INFO] [stderr] --> src/lib.rs:325:11 [INFO] [stderr] | [INFO] [stderr] 325 | assert!(trie_root::(vec![ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `hashdb::Hasher` is not implemented for `keccak_hasher::KeccakHasher` [INFO] [stderr] [INFO] [stderr] error[E0277]: the trait bound `keccak_hasher::KeccakHasher: hashdb::Hasher` is not satisfied [INFO] [stderr] --> src/lib.rs:325:11 [INFO] [stderr] | [INFO] [stderr] 325 | assert!(trie_root::(vec![ [INFO] [stderr] | _________________^ [INFO] [stderr] 326 | | (vec![0x01u8, 0x23], vec![0x01u8, 0x23]), [INFO] [stderr] 327 | | (vec![0x81u8, 0x23], vec![0x81u8, 0x23]), [INFO] [stderr] 328 | | (vec![0xf1u8, 0x23], vec![0xf1u8, 0x23]), [INFO] [stderr] 329 | | ]) == [INFO] [stderr] | |__________^ the trait `hashdb::Hasher` is not implemented for `keccak_hasher::KeccakHasher` [INFO] [stderr] [INFO] [stderr] error[E0277]: the trait bound `keccak_hasher::KeccakHasher: hashdb::Hasher` is not satisfied [INFO] [stderr] --> src/lib.rs:330:3 [INFO] [stderr] | [INFO] [stderr] 330 | trie_root::(vec![ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `hashdb::Hasher` is not implemented for `keccak_hasher::KeccakHasher` [INFO] [stderr] [INFO] [stderr] error[E0277]: the trait bound `keccak_hasher::KeccakHasher: hashdb::Hasher` is not satisfied [INFO] [stderr] --> src/lib.rs:330:3 [INFO] [stderr] | [INFO] [stderr] 330 | trie_root::(vec![ [INFO] [stderr] | _________^ [INFO] [stderr] 331 | | (vec![0x01u8, 0x23], vec![0x01u8, 0x23]), [INFO] [stderr] 332 | | (vec![0xf1u8, 0x23], vec![0xf1u8, 0x23]), // last two tuples are swapped [INFO] [stderr] 333 | | (vec![0x81u8, 0x23], vec![0x81u8, 0x23]), [INFO] [stderr] 334 | | ])); [INFO] [stderr] | |__________^ the trait `hashdb::Hasher` is not implemented for `keccak_hasher::KeccakHasher` [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0277`. [INFO] [stderr] error: Could not compile `triehash`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f7e9287ca491797785419302aafea1fd115f50500f899d256200afc2760d069e"` [INFO] running `"docker" "rm" "-f" "f7e9287ca491797785419302aafea1fd115f50500f899d256200afc2760d069e"` [INFO] [stdout] f7e9287ca491797785419302aafea1fd115f50500f899d256200afc2760d069e