[INFO] crate trek 0.3.1 is already in cache [INFO] extracting crate trek 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/trek/0.3.1 [INFO] extracting crate trek 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trek/0.3.1 [INFO] validating manifest of trek-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of trek-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing trek-0.3.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished frobbing trek-0.3.1 [INFO] frobbed toml for trek-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/trek/0.3.1/Cargo.toml [INFO] started frobbing trek-0.3.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished frobbing trek-0.3.1 [INFO] frobbed toml for trek-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/trek/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting trek-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/trek/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e6f7a12a96b0b127c2ad62a90a8e1869477a1336b5b179c6c7c50e778e62a66d [INFO] running `"docker" "start" "-a" "e6f7a12a96b0b127c2ad62a90a8e1869477a1336b5b179c6c7c50e778e62a66d"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/migration_index.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking fallible-iterator v0.1.6 [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking postgres-shared v0.4.2 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking trek v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | cause: cause [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/migration_index.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | migrations: migrations [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `migrations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | cause: cause [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/migration_index.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | migrations: migrations [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `migrations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/migration_index.rs:154:29 [INFO] [stderr] | [INFO] [stderr] 154 | let old_migration = self.migrations.get(old_migration_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.migrations[old_migration_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/migration_index.rs:184:37 [INFO] [stderr] | [INFO] [stderr] 184 | let new_migration = self.migrations.get(old_migration_index - 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.migrations[old_migration_index - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/migration_index.rs:154:29 [INFO] [stderr] | [INFO] [stderr] 154 | let old_migration = self.migrations.get(old_migration_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.migrations[old_migration_index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/migration_index.rs:184:37 [INFO] [stderr] | [INFO] [stderr] 184 | let new_migration = self.migrations.get(old_migration_index - 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.migrations[old_migration_index - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> tests/test.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | let db_params = env::var("TREK_TEST_DB_PARAMS") [INFO] [stderr] | _____________________^ [INFO] [stderr] 22 | | .ok().expect( [INFO] [stderr] 23 | | "TREK_TEST_DB_PARAMS environment variable is unset. This environment variable should \ [INFO] [stderr] 24 | | contain a database connection string for a PostgreSQL database to use when testing. \ [INFO] [stderr] ... | [INFO] [stderr] 28 | | https://sfackler.github.io/rust-postgres/doc/postgres/struct.Connection.html#method.connect\n" [INFO] [stderr] 29 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/example.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> examples/example.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let db_params = env::var("TREK_TEST_DB_PARAMS") [INFO] [stderr] | _____________________^ [INFO] [stderr] 58 | | .ok().expect( [INFO] [stderr] 59 | | "TREK_TEST_DB_PARAMS environment variable is unset. This environment variable should \ [INFO] [stderr] 60 | | contain a database connection string for a PostgreSQL database to use when testing. \ [INFO] [stderr] ... | [INFO] [stderr] 64 | | https://sfackler.github.io/rust-postgres/doc/postgres/struct.Connection.html#method.connect\n" [INFO] [stderr] 65 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.36s [INFO] running `"docker" "inspect" "e6f7a12a96b0b127c2ad62a90a8e1869477a1336b5b179c6c7c50e778e62a66d"` [INFO] running `"docker" "rm" "-f" "e6f7a12a96b0b127c2ad62a90a8e1869477a1336b5b179c6c7c50e778e62a66d"` [INFO] [stdout] e6f7a12a96b0b127c2ad62a90a8e1869477a1336b5b179c6c7c50e778e62a66d