[INFO] crate treeflection 0.1.31 is already in cache [INFO] extracting crate treeflection 0.1.31 into work/ex/clippy-test-run/sources/stable/reg/treeflection/0.1.31 [INFO] extracting crate treeflection 0.1.31 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/treeflection/0.1.31 [INFO] validating manifest of treeflection-0.1.31 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of treeflection-0.1.31 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing treeflection-0.1.31 [INFO] finished frobbing treeflection-0.1.31 [INFO] frobbed toml for treeflection-0.1.31 written to work/ex/clippy-test-run/sources/stable/reg/treeflection/0.1.31/Cargo.toml [INFO] started frobbing treeflection-0.1.31 [INFO] finished frobbing treeflection-0.1.31 [INFO] frobbed toml for treeflection-0.1.31 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/treeflection/0.1.31/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting treeflection-0.1.31 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/treeflection/0.1.31:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34fc2832be2fef12a4bd92eccad26e3ec4837e196f009f30c2a2fc1a151c53fa [INFO] running `"docker" "start" "-a" "34fc2832be2fef12a4bd92eccad26e3ec4837e196f009f30c2a2fc1a151c53fa"` [INFO] [stderr] Checking itertools v0.6.5 [INFO] [stderr] Checking treeflection v0.1.31 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node_runner.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | tokens: tokens [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context_vec.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | vector: vector, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `vector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keyed_context_vec.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | vector: vector, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `vector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keyed_context_vec.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | keys: keys, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `keys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node_runner.rs:137:21 [INFO] [stderr] | [INFO] [stderr] 137 | tokens: tokens [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/context_vec.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | vector: vector, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `vector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keyed_context_vec.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | vector: vector, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `vector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/keyed_context_vec.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | keys: keys, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `keys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | / return match length { [INFO] [stderr] 23 | | 0 => format!("Used index {} on an empty vector", index), [INFO] [stderr] 24 | | 1 => format!("Used index {} on a vector of size 1 (try 0)", index), [INFO] [stderr] 25 | | _ => format!("Used index {} on a vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | match length { [INFO] [stderr] 23 | 0 => format!("Used index {} on an empty vector", index), [INFO] [stderr] 24 | 1 => format!("Used index {} on a vector of size 1 (try 0)", index), [INFO] [stderr] 25 | _ => format!("Used index {} on a vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/context_vec.rs:208:25 [INFO] [stderr] | [INFO] [stderr] 208 | / return match length { [INFO] [stderr] 209 | | 0 => format!("Used index {} on an empty vector", index), [INFO] [stderr] 210 | | 1 => format!("Used index {} on a vector of size 1 (try 0)", index), [INFO] [stderr] 211 | | _ => format!("Used index {} on a vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 212 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 208 | match length { [INFO] [stderr] 209 | 0 => format!("Used index {} on an empty vector", index), [INFO] [stderr] 210 | 1 => format!("Used index {} on a vector of size 1 (try 0)", index), [INFO] [stderr] 211 | _ => format!("Used index {} on a vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 212 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/keyed_context_vec.rs:412:25 [INFO] [stderr] | [INFO] [stderr] 412 | / return match length { [INFO] [stderr] 413 | | 0 => format!("Used index {} on an empty keyed context vector", index), [INFO] [stderr] 414 | | 1 => format!("Used index {} on a keyed context vector of size 1 (try 0)", index), [INFO] [stderr] 415 | | _ => format!("Used index {} on a keyed context vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 416 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 412 | match length { [INFO] [stderr] 413 | 0 => format!("Used index {} on an empty keyed context vector", index), [INFO] [stderr] 414 | 1 => format!("Used index {} on a keyed context vector of size 1 (try 0)", index), [INFO] [stderr] 415 | _ => format!("Used index {} on a keyed context vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 416 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | / return match length { [INFO] [stderr] 23 | | 0 => format!("Used index {} on an empty vector", index), [INFO] [stderr] 24 | | 1 => format!("Used index {} on a vector of size 1 (try 0)", index), [INFO] [stderr] 25 | | _ => format!("Used index {} on a vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 22 | match length { [INFO] [stderr] 23 | 0 => format!("Used index {} on an empty vector", index), [INFO] [stderr] 24 | 1 => format!("Used index {} on a vector of size 1 (try 0)", index), [INFO] [stderr] 25 | _ => format!("Used index {} on a vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/context_vec.rs:208:25 [INFO] [stderr] | [INFO] [stderr] 208 | / return match length { [INFO] [stderr] 209 | | 0 => format!("Used index {} on an empty vector", index), [INFO] [stderr] 210 | | 1 => format!("Used index {} on a vector of size 1 (try 0)", index), [INFO] [stderr] 211 | | _ => format!("Used index {} on a vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 212 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 208 | match length { [INFO] [stderr] 209 | 0 => format!("Used index {} on an empty vector", index), [INFO] [stderr] 210 | 1 => format!("Used index {} on a vector of size 1 (try 0)", index), [INFO] [stderr] 211 | _ => format!("Used index {} on a vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 212 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/keyed_context_vec.rs:412:25 [INFO] [stderr] | [INFO] [stderr] 412 | / return match length { [INFO] [stderr] 413 | | 0 => format!("Used index {} on an empty keyed context vector", index), [INFO] [stderr] 414 | | 1 => format!("Used index {} on a keyed context vector of size 1 (try 0)", index), [INFO] [stderr] 415 | | _ => format!("Used index {} on a keyed context vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 416 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 412 | match length { [INFO] [stderr] 413 | 0 => format!("Used index {} on an empty keyed context vector", index), [INFO] [stderr] 414 | 1 => format!("Used index {} on a keyed context vector of size 1 (try 0)", index), [INFO] [stderr] 415 | _ => format!("Used index {} on a keyed context vector of size {} (try a value between 0-{})", index, length, length-1) [INFO] [stderr] 416 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/node.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | impl Node for HashMap where T: Node + Serialize + DeserializeOwned + Default { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 98 | impl Node for HashMap where T: Node + Serialize + DeserializeOwned + Default { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 162| *self = HashMap::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | / match self.get_mut(&key) { [INFO] [stderr] 104 | | Some (item) => { return item.node_step(runner) } [INFO] [stderr] 105 | | None => { } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some (item) = self.get_mut(&key) { return item.node_step(runner) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/node.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | / if self.contains_key(&key) { [INFO] [stderr] 146 | | format!("Tried to insert key '{}' on a map that already contains it. Current keys: {}", key, format_keys(self)) [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | else { [INFO] [stderr] 149 | | self.insert(key, T::default()); [INFO] [stderr] 150 | | String::new() [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________________^ help: consider using: `self.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/node.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | if let None = self.remove(&key) { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 155 | | format!("Tried to remove key '{}' on a map that doesnt contain it. Current keys: {}", key, format_keys(self)) [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | else { [INFO] [stderr] 158 | | String::new() [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________________- help: try this: `if self.remove(&key).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/node.rs:334:17 [INFO] [stderr] | [INFO] [stderr] 334 | / if let &mut Some(ref mut value) = self { [INFO] [stderr] 335 | | value.node_step(runner) [INFO] [stderr] 336 | | } [INFO] [stderr] 337 | | else { [INFO] [stderr] 338 | | String::from("Option contains no value") [INFO] [stderr] 339 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 334 | if let Some(ref mut value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 652 | int_node!(i32, "A number from –2,147,483,648 to 2,147,483,647"); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/node.rs:98:18 [INFO] [stderr] | [INFO] [stderr] 98 | impl Node for HashMap where T: Node + Serialize + DeserializeOwned + Default { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 98 | impl Node for HashMap where T: Node + Serialize + DeserializeOwned + Default { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 162| *self = HashMap::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/node.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | / match self.get_mut(&key) { [INFO] [stderr] 104 | | Some (item) => { return item.node_step(runner) } [INFO] [stderr] 105 | | None => { } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some (item) = self.get_mut(&key) { return item.node_step(runner) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/node.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | / if self.contains_key(&key) { [INFO] [stderr] 146 | | format!("Tried to insert key '{}' on a map that already contains it. Current keys: {}", key, format_keys(self)) [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | else { [INFO] [stderr] 149 | | self.insert(key, T::default()); [INFO] [stderr] 150 | | String::new() [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________________^ help: consider using: `self.entry(key)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/node.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | if let None = self.remove(&key) { [INFO] [stderr] | _________________- ^^^^ [INFO] [stderr] 155 | | format!("Tried to remove key '{}' on a map that doesnt contain it. Current keys: {}", key, format_keys(self)) [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | else { [INFO] [stderr] 158 | | String::new() [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________________- help: try this: `if self.remove(&key).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 653 | int_node!(u32, "A number from 0 to 4,294,967,295"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:427:63 [INFO] [stderr] | [INFO] [stderr] 427 | _ => NumStore::Int (*self as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 653 | int_node!(u32, "A number from 0 to 4,294,967,295"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 654 | int_node!(i16, "A number from –32,768 to –32,767"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 655 | int_node!(u16, "A number from 0 to 65,535"); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:427:63 [INFO] [stderr] | [INFO] [stderr] 427 | _ => NumStore::Int (*self as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 655 | int_node!(u16, "A number from 0 to 65,535"); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 656 | int_node!(i8, "A number from -128 to 127"); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 657 | int_node!(u8, "A number from 0 to 255"); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:427:63 [INFO] [stderr] | [INFO] [stderr] 427 | _ => NumStore::Int (*self as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 657 | int_node!(u8, "A number from 0 to 255"); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:555:63 [INFO] [stderr] | [INFO] [stderr] 555 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 662 | float_node!(f32, "A number with a decimal point"); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/node.rs:334:17 [INFO] [stderr] | [INFO] [stderr] 334 | / if let &mut Some(ref mut value) = self { [INFO] [stderr] 335 | | value.node_step(runner) [INFO] [stderr] 336 | | } [INFO] [stderr] 337 | | else { [INFO] [stderr] 338 | | String::from("Option contains no value") [INFO] [stderr] 339 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 334 | if let Some(ref mut value) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node_runner.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if command.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node_runner.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | if prop_string.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prop_string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node_runner.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | if index_string.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `index_string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node_runner.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | if current.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node_runner.rs:188:12 [INFO] [stderr] | [INFO] [stderr] 188 | if current.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 652 | int_node!(i32, "A number from –2,147,483,648 to 2,147,483,647"); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `serde_json::to_string_pretty` doesn't need a mutable reference [INFO] [stderr] --> src/context_vec.rs:242:46 [INFO] [stderr] | [INFO] [stderr] 242 | serde_json::to_string_pretty(&mut self.vector).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/context_vec.rs:260:24 [INFO] [stderr] | [INFO] [stderr] 260 | if let Some(_) = self.pop() { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 261 | | String::new() [INFO] [stderr] 262 | | } else { [INFO] [stderr] 263 | | String::from("Tried to remove from an empty vector.") [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________________- help: try this: `if self.pop().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 653 | int_node!(u32, "A number from 0 to 4,294,967,295"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:427:63 [INFO] [stderr] | [INFO] [stderr] 427 | _ => NumStore::Int (*self as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 653 | int_node!(u32, "A number from 0 to 4,294,967,295"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 654 | int_node!(i16, "A number from –32,768 to –32,767"); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 655 | int_node!(u16, "A number from 0 to 65,535"); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:427:63 [INFO] [stderr] | [INFO] [stderr] 427 | _ => NumStore::Int (*self as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 655 | int_node!(u16, "A number from 0 to 65,535"); [INFO] [stderr] | -------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 656 | int_node!(i8, "A number from -128 to 127"); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/keyed_context_vec.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | self.keys.get(i).map(|x| x.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.keys.get(i).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/keyed_context_vec.rs:279:37 [INFO] [stderr] | [INFO] [stderr] 279 | pub fn contains_key(&self, key: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:426:63 [INFO] [stderr] | [INFO] [stderr] 426 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 657 | int_node!(u8, "A number from 0 to 255"); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:427:63 [INFO] [stderr] | [INFO] [stderr] 427 | _ => NumStore::Int (*self as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 657 | int_node!(u8, "A number from 0 to 255"); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/keyed_context_vec.rs:422:17 [INFO] [stderr] | [INFO] [stderr] 422 | / match self.key_to_value_mut(&key) { [INFO] [stderr] 423 | | Some (item) => { return item.node_step(runner) } [INFO] [stderr] 424 | | None => { } [INFO] [stderr] 425 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some (item) = self.key_to_value_mut(&key) { return item.node_step(runner) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: The function/method `serde_json::to_string_pretty` doesn't need a mutable reference [INFO] [stderr] --> src/keyed_context_vec.rs:464:46 [INFO] [stderr] | [INFO] [stderr] 464 | serde_json::to_string_pretty(&mut self.vector).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/node.rs:555:63 [INFO] [stderr] | [INFO] [stderr] 555 | "f32" | "f64" => NumStore::Float (*self as f64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(*self)` [INFO] [stderr] ... [INFO] [stderr] 662 | float_node!(f32, "A number with a decimal point"); [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node_runner.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if command.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node_runner.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | if prop_string.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `prop_string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node_runner.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | if index_string.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `index_string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node_runner.rs:171:20 [INFO] [stderr] | [INFO] [stderr] 171 | if current.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/node_runner.rs:188:12 [INFO] [stderr] | [INFO] [stderr] 188 | if current.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `serde_json::to_string_pretty` doesn't need a mutable reference [INFO] [stderr] --> src/context_vec.rs:242:46 [INFO] [stderr] | [INFO] [stderr] 242 | serde_json::to_string_pretty(&mut self.vector).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/context_vec.rs:260:24 [INFO] [stderr] | [INFO] [stderr] 260 | if let Some(_) = self.pop() { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 261 | | String::new() [INFO] [stderr] 262 | | } else { [INFO] [stderr] 263 | | String::from("Tried to remove from an empty vector.") [INFO] [stderr] 264 | | } [INFO] [stderr] | |_________________- help: try this: `if self.pop().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/keyed_context_vec.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | self.keys.get(i).map(|x| x.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.keys.get(i).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/keyed_context_vec.rs:279:37 [INFO] [stderr] | [INFO] [stderr] 279 | pub fn contains_key(&self, key: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/keyed_context_vec.rs:422:17 [INFO] [stderr] | [INFO] [stderr] 422 | / match self.key_to_value_mut(&key) { [INFO] [stderr] 423 | | Some (item) => { return item.node_step(runner) } [INFO] [stderr] 424 | | None => { } [INFO] [stderr] 425 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some (item) = self.key_to_value_mut(&key) { return item.node_step(runner) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: The function/method `serde_json::to_string_pretty` doesn't need a mutable reference [INFO] [stderr] --> src/keyed_context_vec.rs:464:46 [INFO] [stderr] | [INFO] [stderr] 464 | serde_json::to_string_pretty(&mut self.vector).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/unittest_primitive.rs:14:46 [INFO] [stderr] | [INFO] [stderr] 14 | let result = node.node_step(NodeRunner { tokens: tokens }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/unittest_numeric.rs:21:46 [INFO] [stderr] | [INFO] [stderr] 21 | let result = node.node_step(NodeRunner { tokens: tokens }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_map.rs:9:37 [INFO] [stderr] | [INFO] [stderr] 9 | map.insert(String::from("foo"), 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_map.rs:79:47 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(*some_map.get("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_map.rs:87:47 [INFO] [stderr] | [INFO] [stderr] 87 | assert_eq!(*some_map.get("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_map.rs:95:47 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(*some_map.get("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_map.rs:107:47 [INFO] [stderr] | [INFO] [stderr] 107 | assert_eq!(*some_map.get("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_map.rs:115:47 [INFO] [stderr] | [INFO] [stderr] 115 | assert_eq!(*some_map.get("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_context_vec.rs:7:31 [INFO] [stderr] | [INFO] [stderr] 7 | ContextVec::from_vec(vec!(100000, 13, -358, 42)) [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_context_vec.rs:433:29 [INFO] [stderr] | [INFO] [stderr] 433 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_context_vec.rs:441:29 [INFO] [stderr] | [INFO] [stderr] 441 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_context_vec.rs:450:29 [INFO] [stderr] | [INFO] [stderr] 450 | assert_eq!(some_vec[1], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_context_vec.rs:459:29 [INFO] [stderr] | [INFO] [stderr] 459 | assert_eq!(some_vec[1], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_context_vec.rs:493:29 [INFO] [stderr] | [INFO] [stderr] 493 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_context_vec.rs:501:29 [INFO] [stderr] | [INFO] [stderr] 501 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | assert_eq!(*some_map.get("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["foo"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:80:17 [INFO] [stderr] | [INFO] [stderr] 80 | assert_eq!(*some_map.get("bar").unwrap(), 13); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["bar"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:81:17 [INFO] [stderr] | [INFO] [stderr] 81 | assert_eq!(*some_map.get("baz").unwrap(), -358); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["baz"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | assert_eq!(*some_map.get("qux").unwrap(), 42); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["qux"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | assert_eq!(*some_map.get("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["foo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | assert_eq!(*some_map.get("bar").unwrap(), 13); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["bar"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | assert_eq!(*some_map.get("baz").unwrap(), -358); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["baz"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | assert_eq!(*some_map.get("qux").unwrap(), 42); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["qux"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | assert_eq!(*some_map.get("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["foo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | assert_eq!(*some_map.get("bar").unwrap(), 13); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["bar"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | assert_eq!(*some_map.get("baz").unwrap(), -358); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["baz"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(*some_map.get("qux").unwrap(), 42); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["qux"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | assert_eq!(*some_map.get("quux").unwrap(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["quux"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | assert_eq!(*some_map.get("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["foo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | assert_eq!(*some_map.get("bar").unwrap(), 13); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["bar"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | assert_eq!(*some_map.get("baz").unwrap(), -358); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["baz"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | assert_eq!(*some_map.get("qux").unwrap(), 42); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["qux"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | assert_eq!(*some_map.get("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["foo"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | assert_eq!(*some_map.get("bar").unwrap(), 13); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["bar"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!(*some_map.get("baz").unwrap(), -358); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["baz"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | assert_eq!(*some_map.get("qux").unwrap(), 42); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["qux"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:123:17 [INFO] [stderr] | [INFO] [stderr] 123 | assert_eq!(*some_map.get("bar").unwrap(), 13); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["bar"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | assert_eq!(*some_map.get("baz").unwrap(), -358); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["baz"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | assert_eq!(*some_map.get("qux").unwrap(), 42); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["qux"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:156:22 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(1, *some_map.get("value").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["value"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | assert_eq!(99, *some_map.get("string").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["string"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/unittest_map.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(100, *some_map.get("a somewhat unusual string").unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&some_map["a somewhat unusual string"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/unittest_primitive.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | assert_eq!(expected, String::from(result)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_collections.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | vec!(100000, 13, -358, 42) [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_collections.rs:84:29 [INFO] [stderr] | [INFO] [stderr] 84 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_collections.rs:92:29 [INFO] [stderr] | [INFO] [stderr] 92 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_collections.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | assert_eq!(some_vec[1], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_collections.rs:110:29 [INFO] [stderr] | [INFO] [stderr] 110 | assert_eq!(some_vec[1], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_collections.rs:122:29 [INFO] [stderr] | [INFO] [stderr] 122 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_collections.rs:130:29 [INFO] [stderr] | [INFO] [stderr] 130 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_numeric.rs:451:57 [INFO] [stderr] | [INFO] [stderr] 451 | assert_set::(49992.12345, "3.141592653589793", 3.141592653589793); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `3.141_592_653_589_793` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_numeric.rs:452:57 [INFO] [stderr] | [INFO] [stderr] 452 | assert_set::(49992.12345, "3.141592653589793", 3.141592653589793); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `3.141_592_653_589_793` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_numeric.rs:460:23 [INFO] [stderr] | [INFO] [stderr] 460 | assert_get::(6.283185307179586, "6.2831855"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `6.283_185_307_179_586` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_numeric.rs:461:23 [INFO] [stderr] | [INFO] [stderr] 461 | assert_get::(6.283185307179586, "6.283185307179586"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `6.283_185_307_179_586` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:7:58 [INFO] [stderr] | [INFO] [stderr] 7 | KeyedContextVec::from_vec(vec!((String::from("foo"), 100000), (String::from("bar"), 13), (String::from("baz"), -358), (String::from("qux"), 42))) [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:264:56 [INFO] [stderr] | [INFO] [stderr] 264 | assert_eq!(*some_vec.key_to_value("foo").unwrap(), 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:344:29 [INFO] [stderr] | [INFO] [stderr] 344 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:350:33 [INFO] [stderr] | [INFO] [stderr] 350 | assert_eq!(some_vec["foo"], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:541:29 [INFO] [stderr] | [INFO] [stderr] 541 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:549:29 [INFO] [stderr] | [INFO] [stderr] 549 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:557:29 [INFO] [stderr] | [INFO] [stderr] 557 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:566:29 [INFO] [stderr] | [INFO] [stderr] 566 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:579:29 [INFO] [stderr] | [INFO] [stderr] 579 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:587:29 [INFO] [stderr] | [INFO] [stderr] 587 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:595:29 [INFO] [stderr] | [INFO] [stderr] 595 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:603:29 [INFO] [stderr] | [INFO] [stderr] 603 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:612:29 [INFO] [stderr] | [INFO] [stderr] 612 | assert_eq!(some_vec[1], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:621:29 [INFO] [stderr] | [INFO] [stderr] 621 | assert_eq!(some_vec[1], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:655:29 [INFO] [stderr] | [INFO] [stderr] 655 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:663:29 [INFO] [stderr] | [INFO] [stderr] 663 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:687:29 [INFO] [stderr] | [INFO] [stderr] 687 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:695:29 [INFO] [stderr] | [INFO] [stderr] 695 | assert_eq!(some_vec[0], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> tests/unittest_collections.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | fn test_tuple16() -> (u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8, u8) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> tests/unittest_collections.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | / fn vec_insert() { [INFO] [stderr] 81 | | let mut some_vec = test_vec4(); [INFO] [stderr] 82 | | [INFO] [stderr] 83 | | assert_eq!(some_vec.len(), 4); [INFO] [stderr] ... | [INFO] [stderr] 114 | | assert_eq!(some_vec[5], 42); [INFO] [stderr] 115 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> tests/unittest_context_vec.rs:293:5 [INFO] [stderr] | [INFO] [stderr] 293 | context_vec[3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> tests/unittest_context_vec.rs:429:1 [INFO] [stderr] | [INFO] [stderr] 429 | / fn node_step_insert_index() { [INFO] [stderr] 430 | | let mut some_vec = test_vec4(); [INFO] [stderr] 431 | | [INFO] [stderr] 432 | | assert_eq!(some_vec.len(), 4); [INFO] [stderr] ... | [INFO] [stderr] 463 | | assert_eq!(some_vec[5], 42); [INFO] [stderr] 464 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> tests/unittest_numeric.rs:22:26 [INFO] [stderr] | [INFO] [stderr] 22 | assert_eq!(expected, String::from(result)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | assert_eq!(e, 250.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | assert_eq!(e, 250.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!(b, 99.9999); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!(b, 99.9999); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!(a, 13.37); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | assert_eq!(a, 13.37); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(b, 13.37); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(b, 13.37); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | assert_eq!(d, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:141:5 [INFO] [stderr] | [INFO] [stderr] 141 | assert_eq!(d, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | assert_eq!(e, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | assert_eq!(e, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | assert_eq!(d, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | assert_eq!(d, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(e, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | assert_eq!(e, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | assert_eq!(d, 17.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | assert_eq!(d, 17.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | assert_eq!(e, 17.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | assert_eq!(e, 17.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | assert_eq!(d, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:198:5 [INFO] [stderr] | [INFO] [stderr] 198 | assert_eq!(d, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(e, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(e, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:209:5 [INFO] [stderr] | [INFO] [stderr] 209 | assert_eq!(d, 9.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:209:5 [INFO] [stderr] | [INFO] [stderr] 209 | assert_eq!(d, 9.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(e, 9.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:211:5 [INFO] [stderr] | [INFO] [stderr] 211 | assert_eq!(e, 9.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(d, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:232:5 [INFO] [stderr] | [INFO] [stderr] 232 | assert_eq!(d, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | assert_eq!(e, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | assert_eq!(e, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | assert_eq!(d, 52.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | assert_eq!(d, 52.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | assert_eq!(e, 52.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | assert_eq!(e, 52.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> tests/unittest_numeric.rs:249:1 [INFO] [stderr] | [INFO] [stderr] 249 | / fn numeric_divide() { [INFO] [stderr] 250 | | let runner = NodeRunner { tokens: vec!(NodeToken::Custom(String::from("divide"), vec!(String::from("4")))) }; [INFO] [stderr] 251 | | let runner_fail = NodeRunner { tokens: vec!(NodeToken::Custom(String::from("divide"), vec!(String::from("4a")))) }; [INFO] [stderr] 252 | | let runner_0 = NodeRunner { tokens: vec!(NodeToken::Custom(String::from("divide"), vec!(String::from("0")))) }; [INFO] [stderr] ... | [INFO] [stderr] 297 | | assert_eq!(e, 3.25); [INFO] [stderr] 298 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | assert_eq!(d, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | assert_eq!(d, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | assert_eq!(e, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:269:5 [INFO] [stderr] | [INFO] [stderr] 269 | assert_eq!(e, 13.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | assert_eq!(d, f32::INFINITY); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:278:5 [INFO] [stderr] | [INFO] [stderr] 278 | assert_eq!(d, f32::INFINITY); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | assert_eq!(e, f64::INFINITY); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | assert_eq!(e, f64::INFINITY); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | assert_eq!(d, 3.25); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | assert_eq!(d, 3.25); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/unittest_numeric.rs:297:5 [INFO] [stderr] | [INFO] [stderr] 297 | assert_eq!(e, 3.25); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/unittest_numeric.rs:297:5 [INFO] [stderr] | [INFO] [stderr] 297 | assert_eq!(e, 3.25); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/unittest_numeric.rs:451:23 [INFO] [stderr] | [INFO] [stderr] 451 | assert_set::(49992.12345, "3.141592653589793", 3.141592653589793); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `49_992.125` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/unittest_numeric.rs:451:57 [INFO] [stderr] | [INFO] [stderr] 451 | assert_set::(49992.12345, "3.141592653589793", 3.141592653589793); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.141_592_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/unittest_numeric.rs:451:57 [INFO] [stderr] | [INFO] [stderr] 451 | assert_set::(49992.12345, "3.141592653589793", 3.141592653589793); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/unittest_numeric.rs:452:57 [INFO] [stderr] | [INFO] [stderr] 452 | assert_set::(49992.12345, "3.141592653589793", 3.141592653589793); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/unittest_numeric.rs:454:30 [INFO] [stderr] | [INFO] [stderr] 454 | assert_set_output::(49992.12345, "invalid", 49992.12345, "Invalid value for f32 (needs to be: A number with a decimal point)"); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `49_992.125` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/unittest_numeric.rs:454:54 [INFO] [stderr] | [INFO] [stderr] 454 | assert_set_output::(49992.12345, "invalid", 49992.12345, "Invalid value for f32 (needs to be: A number with a decimal point)"); [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `49_992.125` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/unittest_numeric.rs:460:23 [INFO] [stderr] | [INFO] [stderr] 460 | assert_get::(6.283185307179586, "6.2831855"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `6.283_185_5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: aborting due to 26 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `treeflection`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | context_vec[3]; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | context_vec["glub"]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:537:1 [INFO] [stderr] | [INFO] [stderr] 537 | / fn node_step_insert_key() { [INFO] [stderr] 538 | | let mut some_vec = test_vec4(); [INFO] [stderr] 539 | | [INFO] [stderr] 540 | | assert_eq!(some_vec.len(), 4); [INFO] [stderr] ... | [INFO] [stderr] 571 | | assert_eq!(some_vec[5], 0); [INFO] [stderr] 572 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> tests/unittest_keyed_context_vec.rs:575:1 [INFO] [stderr] | [INFO] [stderr] 575 | / fn node_step_insert_index_key() { [INFO] [stderr] 576 | | let mut some_vec = test_vec4(); [INFO] [stderr] 577 | | [INFO] [stderr] 578 | | assert_eq!(some_vec.len(), 4); [INFO] [stderr] ... | [INFO] [stderr] 625 | | assert_eq!(some_vec[5], 42); [INFO] [stderr] 626 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "34fc2832be2fef12a4bd92eccad26e3ec4837e196f009f30c2a2fc1a151c53fa"` [INFO] running `"docker" "rm" "-f" "34fc2832be2fef12a4bd92eccad26e3ec4837e196f009f30c2a2fc1a151c53fa"` [INFO] [stdout] 34fc2832be2fef12a4bd92eccad26e3ec4837e196f009f30c2a2fc1a151c53fa