[INFO] crate treediff 3.0.1 is already in cache
[INFO] extracting crate treediff 3.0.1 into work/ex/clippy-test-run/sources/stable/reg/treediff/3.0.1
[INFO] extracting crate treediff 3.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/treediff/3.0.1
[INFO] validating manifest of treediff-3.0.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of treediff-3.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing treediff-3.0.1
[INFO] finished frobbing treediff-3.0.1
[INFO] frobbed toml for treediff-3.0.1 written to work/ex/clippy-test-run/sources/stable/reg/treediff/3.0.1/Cargo.toml
[INFO] started frobbing treediff-3.0.1
[INFO] finished frobbing treediff-3.0.1
[INFO] frobbed toml for treediff-3.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/treediff/3.0.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting treediff-3.0.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/treediff/3.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 458d3ac27d053a22f5cb6caf953ae06df27bcd7f5ce3fd1b5abe781e62c96306
[INFO] running `"docker" "start" "-a" "458d3ac27d053a22f5cb6caf953ae06df27bcd7f5ce3fd1b5abe781e62c96306"`
[INFO] [stderr]     Checking treediff v3.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: `self` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult
[INFO] [stderr]   --> src/tools/merge.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |         &mut self,
[INFO] [stderr]    |         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::duplicate_underscore_argument)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_underscore_argument
[INFO] [stderr] 
[INFO] [stderr] warning: `self` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult
[INFO] [stderr]   --> src/tools/merge.rs:62:9
[INFO] [stderr]    |
[INFO] [stderr] 62 |         &mut self,
[INFO] [stderr]    |         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_underscore_argument
[INFO] [stderr] 
[INFO] [stderr] warning: `self` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult
[INFO] [stderr]   --> src/tools/merge.rs:49:9
[INFO] [stderr]    |
[INFO] [stderr] 49 |         &mut self,
[INFO] [stderr]    |         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::duplicate_underscore_argument)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_underscore_argument
[INFO] [stderr] 
[INFO] [stderr] warning: `self` already exists, having another argument having almost the same name makes code comprehension and documentation more difficult
[INFO] [stderr]   --> src/tools/merge.rs:62:9
[INFO] [stderr]    |
[INFO] [stderr] 62 |         &mut self,
[INFO] [stderr]    |         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_underscore_argument
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]  --> src/traitdef.rs:9:31
[INFO] [stderr]   |
[INFO] [stderr] 9 |     fn items<'a>(&'a self) -> Option<Box<Iterator<Item = (Self::Key, &'a Self::Item)> + 'a>>;
[INFO] [stderr]   |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/traitdef.rs:38:18
[INFO] [stderr]    |
[INFO] [stderr] 38 |     fn unchanged<'b>(&mut self, _v: &'a V) {}
[INFO] [stderr]    |                  ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/traitdef.rs:41:17
[INFO] [stderr]    |
[INFO] [stderr] 41 |     fn modified<'b>(&mut self, _old: &'a V, _new: &'a V) {}
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/tools/merge.rs:26:26
[INFO] [stderr]    |
[INFO] [stderr] 26 | fn appended<'b, K>(keys: &Vec<K>, k: Option<&'b K>) -> Vec<K>
[INFO] [stderr]    |                          ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 26 | fn appended<'b, K>(keys: &[K], k: Option<&'b K>) -> Vec<K>
[INFO] [stderr]    |                          ^^^^
[INFO] [stderr] help: change `keys.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let mut keys = keys.to_owned();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/tools/merge.rs:103:18
[INFO] [stderr]     |
[INFO] [stderr] 103 |     fn unchanged<'b>(&mut self, v: &'a V) {
[INFO] [stderr]     |                  ^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/tools/merge.rs:106:17
[INFO] [stderr]     |
[INFO] [stderr] 106 |     fn modified<'b>(&mut self, old: &'a V, new: &'a V) {
[INFO] [stderr]     |                 ^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/tools/record.rs:42:17
[INFO] [stderr]    |
[INFO] [stderr] 42 | fn mk<'b, K>(c: &Vec<K>, k: Option<&'b K>) -> Vec<K>
[INFO] [stderr]    |                 ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 42 | fn mk<'b, K>(c: &[K], k: Option<&'b K>) -> Vec<K>
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr] help: change `c.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 46 |     let mut c = c.to_owned();
[INFO] [stderr]    |                 ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/tools/record.rs:74:18
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn unchanged<'b>(&mut self, v: &'a V) {
[INFO] [stderr]    |                  ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/tools/record.rs:78:17
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn modified<'b>(&mut self, v1: &'a V, v2: &'a V) {
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]  --> src/traitdef.rs:9:31
[INFO] [stderr]   |
[INFO] [stderr] 9 |     fn items<'a>(&'a self) -> Option<Box<Iterator<Item = (Self::Key, &'a Self::Item)> + 'a>>;
[INFO] [stderr]   |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/traitdef.rs:38:18
[INFO] [stderr]    |
[INFO] [stderr] 38 |     fn unchanged<'b>(&mut self, _v: &'a V) {}
[INFO] [stderr]    |                  ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/traitdef.rs:41:17
[INFO] [stderr]    |
[INFO] [stderr] 41 |     fn modified<'b>(&mut self, _old: &'a V, _new: &'a V) {}
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/tools/merge.rs:26:26
[INFO] [stderr]    |
[INFO] [stderr] 26 | fn appended<'b, K>(keys: &Vec<K>, k: Option<&'b K>) -> Vec<K>
[INFO] [stderr]    |                          ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 26 | fn appended<'b, K>(keys: &[K], k: Option<&'b K>) -> Vec<K>
[INFO] [stderr]    |                          ^^^^
[INFO] [stderr] help: change `keys.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 30 |     let mut keys = keys.to_owned();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/tools/merge.rs:103:18
[INFO] [stderr]     |
[INFO] [stderr] 103 |     fn unchanged<'b>(&mut self, v: &'a V) {
[INFO] [stderr]     |                  ^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]    --> src/tools/merge.rs:106:17
[INFO] [stderr]     |
[INFO] [stderr] 106 |     fn modified<'b>(&mut self, old: &'a V, new: &'a V) {
[INFO] [stderr]     |                 ^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/tools/record.rs:42:17
[INFO] [stderr]    |
[INFO] [stderr] 42 | fn mk<'b, K>(c: &Vec<K>, k: Option<&'b K>) -> Vec<K>
[INFO] [stderr]    |                 ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 42 | fn mk<'b, K>(c: &[K], k: Option<&'b K>) -> Vec<K>
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr] help: change `c.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 46 |     let mut c = c.to_owned();
[INFO] [stderr]    |                 ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/tools/record.rs:74:18
[INFO] [stderr]    |
[INFO] [stderr] 74 |     fn unchanged<'b>(&mut self, v: &'a V) {
[INFO] [stderr]    |                  ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/tools/record.rs:78:17
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn modified<'b>(&mut self, v1: &'a V, v2: &'a V) {
[INFO] [stderr]    |                 ^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: unused macro definition
[INFO] [stderr]    --> tests/merge.rs:3:1
[INFO] [stderr]     |
[INFO] [stderr] 3   | / macro_rules! make_suite {
[INFO] [stderr] 4   | | () => {
[INFO] [stderr] 5   | |     use treediff::diff;
[INFO] [stderr] 6   | |     use treediff::tools::{MutableFilter, Merger};
[INFO] [stderr] ...   |
[INFO] [stderr] 166 | | }
[INFO] [stderr] 167 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_macros)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused macro definition
[INFO] [stderr]   --> tests/json_value.rs:3:1
[INFO] [stderr]    |
[INFO] [stderr] 3  | / macro_rules! make_suite {
[INFO] [stderr] 4  | | ($bool:expr) => {
[INFO] [stderr] 5  | |     use treediff::Value;
[INFO] [stderr] 6  | |     use treediff::value::Key;
[INFO] [stderr] ...  |
[INFO] [stderr] 37 | | };
[INFO] [stderr] 38 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_macros)] on by default
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.38s
[INFO] running `"docker" "inspect" "458d3ac27d053a22f5cb6caf953ae06df27bcd7f5ce3fd1b5abe781e62c96306"`
[INFO] running `"docker" "rm" "-f" "458d3ac27d053a22f5cb6caf953ae06df27bcd7f5ce3fd1b5abe781e62c96306"`
[INFO] [stdout] 458d3ac27d053a22f5cb6caf953ae06df27bcd7f5ce3fd1b5abe781e62c96306