[INFO] crate tree-rs 0.6.5 is already in cache [INFO] extracting crate tree-rs 0.6.5 into work/ex/clippy-test-run/sources/stable/reg/tree-rs/0.6.5 [INFO] extracting crate tree-rs 0.6.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tree-rs/0.6.5 [INFO] validating manifest of tree-rs-0.6.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tree-rs-0.6.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tree-rs-0.6.5 [INFO] finished frobbing tree-rs-0.6.5 [INFO] frobbed toml for tree-rs-0.6.5 written to work/ex/clippy-test-run/sources/stable/reg/tree-rs/0.6.5/Cargo.toml [INFO] started frobbing tree-rs-0.6.5 [INFO] finished frobbing tree-rs-0.6.5 [INFO] frobbed toml for tree-rs-0.6.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tree-rs/0.6.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tree-rs-0.6.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tree-rs/0.6.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5aaa4ccc89b68ea83ba2bfdbe68a4c2074870b7a0f90ec749a6311a2de6da5b8 [INFO] running `"docker" "start" "-a" "5aaa4ccc89b68ea83ba2bfdbe68a4c2074870b7a0f90ec749a6311a2de6da5b8"` [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking tree-rs v0.6.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathiterator.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathiterator.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathiterator.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | is_last: is_last, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_last` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathiterator.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathiterator.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | use_color: use_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `use_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | max_level: max_level, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathiterator.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathiterator.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathiterator.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | is_last: is_last, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `is_last` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathiterator.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | queue: queue, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathiterator.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | use_color: use_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `use_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | max_level: max_level, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:283:18 [INFO] [stderr] | [INFO] [stderr] 283 | const PATH: &'static str = "target/release/tree-rs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | stdout_str [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:291:26 [INFO] [stderr] | [INFO] [stderr] 291 | let stdout_str = String::from_utf8(stdout).expect("Bad parsing"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/filter.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / loop { [INFO] [stderr] 30 | | if let Some(last) = self.cache.pop_back() { [INFO] [stderr] 31 | | if last.level < item.level { [INFO] [stderr] 32 | | self.cache.push_back(last); [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(last) = self.cache.pop_back() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/filter.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / loop { [INFO] [stderr] 59 | | if let Some(item) = self.source.next() { [INFO] [stderr] 60 | | self.remove_empty_directories_from_cache(&item); [INFO] [stderr] 61 | | [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(item) = self.source.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/filter.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / loop { [INFO] [stderr] 30 | | if let Some(last) = self.cache.pop_back() { [INFO] [stderr] 31 | | if last.level < item.level { [INFO] [stderr] 32 | | self.cache.push_back(last); [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(last) = self.cache.pop_back() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/filter.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / loop { [INFO] [stderr] 59 | | if let Some(item) = self.source.next() { [INFO] [stderr] 60 | | self.remove_empty_directories_from_cache(&item); [INFO] [stderr] 61 | | [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(item) = self.source.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.52s [INFO] running `"docker" "inspect" "5aaa4ccc89b68ea83ba2bfdbe68a4c2074870b7a0f90ec749a6311a2de6da5b8"` [INFO] running `"docker" "rm" "-f" "5aaa4ccc89b68ea83ba2bfdbe68a4c2074870b7a0f90ec749a6311a2de6da5b8"` [INFO] [stdout] 5aaa4ccc89b68ea83ba2bfdbe68a4c2074870b7a0f90ec749a6311a2de6da5b8