[INFO] crate tree-cursor 0.3.0 is already in cache [INFO] extracting crate tree-cursor 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/tree-cursor/0.3.0 [INFO] extracting crate tree-cursor 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tree-cursor/0.3.0 [INFO] validating manifest of tree-cursor-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tree-cursor-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tree-cursor-0.3.0 [INFO] finished frobbing tree-cursor-0.3.0 [INFO] frobbed toml for tree-cursor-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/tree-cursor/0.3.0/Cargo.toml [INFO] started frobbing tree-cursor-0.3.0 [INFO] finished frobbing tree-cursor-0.3.0 [INFO] frobbed toml for tree-cursor-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tree-cursor/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tree-cursor-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tree-cursor/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 942cfadd62b428c6e4363d8a998e34f9a1473cb59b75c0ee14e42fce028c8bd7 [INFO] running `"docker" "start" "-a" "942cfadd62b428c6e4363d8a998e34f9a1473cb59b75c0ee14e42fce028c8bd7"` [INFO] [stderr] Checking tree-cursor v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/cursor.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / if let &Some(new_ptr) = &maybe_new_ptr { [INFO] [stderr] 54 | | self.stack.push((new_ptr, 0)); [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(new_ptr) = maybe_new_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/cursor.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / if let &Some(new_ptr) = &maybe_new_ptr { [INFO] [stderr] 136 | | self.stack.push((new_ptr, 0)); [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 135 | if let Some(new_ptr) = maybe_new_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/cursor.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | / if let &Some(new_ptr) = &maybe_new_ptr { [INFO] [stderr] 218 | | self.stack.push((new_ptr, 0)); [INFO] [stderr] 219 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 217 | if let Some(new_ptr) = maybe_new_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/cursor.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | / if let &Some(new_ptr) = &maybe_new_ptr { [INFO] [stderr] 351 | | self.stack.push((new_ptr, 0)); [INFO] [stderr] 352 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 350 | if let Some(new_ptr) = maybe_new_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/cursor.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / if let &Some(new_ptr) = &maybe_new_ptr { [INFO] [stderr] 54 | | self.stack.push((new_ptr, 0)); [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | if let Some(new_ptr) = maybe_new_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/cursor.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / if let &Some(new_ptr) = &maybe_new_ptr { [INFO] [stderr] 136 | | self.stack.push((new_ptr, 0)); [INFO] [stderr] 137 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 135 | if let Some(new_ptr) = maybe_new_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/cursor.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | / if let &Some(new_ptr) = &maybe_new_ptr { [INFO] [stderr] 218 | | self.stack.push((new_ptr, 0)); [INFO] [stderr] 219 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 217 | if let Some(new_ptr) = maybe_new_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/cursor.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | / if let &Some(new_ptr) = &maybe_new_ptr { [INFO] [stderr] 351 | | self.stack.push((new_ptr, 0)); [INFO] [stderr] 352 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 350 | if let Some(new_ptr) = maybe_new_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/tests/hashmap_tree.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / fn down_map() { [INFO] [stderr] 24 | | let t = nn(0, vec![ [INFO] [stderr] 25 | | ("foo", n(1)), [INFO] [stderr] 26 | | ("bar", nn(2, vec![ [INFO] [stderr] ... | [INFO] [stderr] 75 | | assert_eq!(cm.get().x, 1); [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 59 [INFO] [stderr] --> src/tests/link_tree.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / fn link_tree() { [INFO] [stderr] 35 | | let root = n("foo"); [INFO] [stderr] 36 | | let nn = vec![ [INFO] [stderr] 37 | | ("foo", n("bar")), [INFO] [stderr] ... | [INFO] [stderr] 131 | | assert_eq!(&cm.get().target, "bar"); [INFO] [stderr] 132 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 120 [INFO] [stderr] --> src/tests/standard_tree.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / fn get() { [INFO] [stderr] 116 | | let t = xx(vec![ [INFO] [stderr] 117 | | xx(vec![ [INFO] [stderr] 118 | | x(), [INFO] [stderr] ... | [INFO] [stderr] 275 | | assert_eq!(cm.get().v.len(), 2); [INFO] [stderr] 276 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/tests/standard_tree.rs:279:1 [INFO] [stderr] | [INFO] [stderr] 279 | / fn scoped_down() { [INFO] [stderr] 280 | | let t = xx(vec![ [INFO] [stderr] 281 | | xx(vec![ [INFO] [stderr] 282 | | x(), [INFO] [stderr] ... | [INFO] [stderr] 349 | | assert!(cm.down()); [INFO] [stderr] 350 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 47 [INFO] [stderr] --> src/tests/standard_tree.rs:353:1 [INFO] [stderr] | [INFO] [stderr] 353 | / fn take() { [INFO] [stderr] 354 | | let t = xx(vec![ [INFO] [stderr] 355 | | xx(vec![ [INFO] [stderr] 356 | | x(), [INFO] [stderr] ... | [INFO] [stderr] 433 | | assert!(cm.down()); [INFO] [stderr] 434 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.74s [INFO] running `"docker" "inspect" "942cfadd62b428c6e4363d8a998e34f9a1473cb59b75c0ee14e42fce028c8bd7"` [INFO] running `"docker" "rm" "-f" "942cfadd62b428c6e4363d8a998e34f9a1473cb59b75c0ee14e42fce028c8bd7"` [INFO] [stdout] 942cfadd62b428c6e4363d8a998e34f9a1473cb59b75c0ee14e42fce028c8bd7