[INFO] crate tre 0.1.1 is already in cache [INFO] extracting crate tre 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/tre/0.1.1 [INFO] extracting crate tre 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tre/0.1.1 [INFO] validating manifest of tre-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tre-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tre-0.1.1 [INFO] finished frobbing tre-0.1.1 [INFO] frobbed toml for tre-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/tre/0.1.1/Cargo.toml [INFO] started frobbing tre-0.1.1 [INFO] finished frobbing tre-0.1.1 [INFO] frobbed toml for tre-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/tre/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tre-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/tre/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b553214be78479a6995d22ef072c04d93befb38121170c332a5c39106baa5f54 [INFO] running `"docker" "start" "-a" "b553214be78479a6995d22ef072c04d93befb38121170c332a5c39106baa5f54"` [INFO] [stderr] Checking colored v1.7.0 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking ignore v0.4.6 [INFO] [stderr] Checking tre v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/streamer.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | collector: collector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/streamer.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | collector: collector, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/config.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new( [INFO] [stderr] 18 | | root: Option, [INFO] [stderr] 19 | | max_depth: Option, [INFO] [stderr] 20 | | follow_sym_links: bool, [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/display.rs:14:14 [INFO] [stderr] | [INFO] [stderr] 14 | parents: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/display.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | parents: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `stats_collector::StatsCollector` [INFO] [stderr] --> src/stats_collector.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> StatsCollector { [INFO] [stderr] 30 | | StatsCollector { [INFO] [stderr] 31 | | stats: Stats { [INFO] [stderr] 32 | | files: 0, [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for stats_collector::StatsCollector { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/streamer.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | for dir in walker.into_iter().filter_map(|e| e.ok()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `walker` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/streamer.rs:84:46 [INFO] [stderr] | [INFO] [stderr] 84 | let mut shallow_walker = build_shallow(parent_path, &self.options)? [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 85 | | .into_iter() [INFO] [stderr] | |____________________________________^ help: consider removing `.into_iter()`: `build_shallow(parent_path, &self.options)?` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/streamer.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | if let Some(_) = shallow_walker.next() { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 91 | | self.parent_depths.push(self.prev_depth); [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | is_last = true; [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________- help: try this: `if shallow_walker.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/walker.rs:8:56 [INFO] [stderr] | [INFO] [stderr] 8 | let mut walker = WalkBuilder::new(opt.root.clone().unwrap_or(String::from("."))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/config.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new( [INFO] [stderr] 18 | | root: Option, [INFO] [stderr] 19 | | max_depth: Option, [INFO] [stderr] 20 | | follow_sym_links: bool, [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/display.rs:14:14 [INFO] [stderr] | [INFO] [stderr] 14 | parents: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/display.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | parents: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `stats_collector::StatsCollector` [INFO] [stderr] --> src/stats_collector.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> StatsCollector { [INFO] [stderr] 30 | | StatsCollector { [INFO] [stderr] 31 | | stats: Stats { [INFO] [stderr] 32 | | files: 0, [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for stats_collector::StatsCollector { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/streamer.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | for dir in walker.into_iter().filter_map(|e| e.ok()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `walker` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/streamer.rs:84:46 [INFO] [stderr] | [INFO] [stderr] 84 | let mut shallow_walker = build_shallow(parent_path, &self.options)? [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 85 | | .into_iter() [INFO] [stderr] | |____________________________________^ help: consider removing `.into_iter()`: `build_shallow(parent_path, &self.options)?` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/streamer.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | if let Some(_) = shallow_walker.next() { [INFO] [stderr] | _____________________- ^^^^^^^ [INFO] [stderr] 91 | | self.parent_depths.push(self.prev_depth); [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | is_last = true; [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________- help: try this: `if shallow_walker.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/walker.rs:8:56 [INFO] [stderr] | [INFO] [stderr] 8 | let mut walker = WalkBuilder::new(opt.root.clone().unwrap_or(String::from("."))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.22s [INFO] running `"docker" "inspect" "b553214be78479a6995d22ef072c04d93befb38121170c332a5c39106baa5f54"` [INFO] running `"docker" "rm" "-f" "b553214be78479a6995d22ef072c04d93befb38121170c332a5c39106baa5f54"` [INFO] [stdout] b553214be78479a6995d22ef072c04d93befb38121170c332a5c39106baa5f54